relaton-bsi 1.9.2 → 1.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0e35dcda4191d7eeb80cff93c299c6d7b629af7fa7534d8c08edf740573d98bd
-  data.tar.gz: 7a1b3a52177f1ef5ad36d530c1c2cc2a71f69c5dfe3232d5619b3429a86849b4
+  metadata.gz: 575d3bddb3ae25f1eb02722c22b2828078dcfbdda026f1880cb9267f7063fe02
+  data.tar.gz: 9acb554596e76d303396f3ee3ca363a90debaf796e056d30a7a7cec1666c35d8
 SHA512:
-  metadata.gz: 915df61335547d25559ddf97c92b0c7029cf679eb3f09131de86698797912c687be3af9dea159fdb46c43a73915bc1976338925116636b02d2832abe30f06f21
-  data.tar.gz: 70b54bc05430c5a983fca9d4b894eaa770d212a662f0741fd08275fcbf2005cb971c883523a590b261c7bda697e7a40d7e30dc59e5c87482bc4a8d488fce5cab
+  metadata.gz: 97419068d0508756a60da761bfb2caa436959ccfc4939052149ee951d781ee74b1b5a401796e591ec54a94974365a1b2560ce77fd91f0e0704f903ef21d0dd67
+  data.tar.gz: 016d70fee73a215b58cc53b8101fa4c70b21e30a6229f727524a3604eaa838b9a2dc1c88493ec1f2a1992a45a8161ebcdf4a5e7103822ca3f44ed21a0549b5fb

data/.rubocop.yml

@@ -2,6 +2,8 @@
 # https://github.com/riboseinc/oss-guides
 # All project-specific additions and overrides should be specified in this file.
 
+require: rubocop-rails
+
 inherit_from:
   - https://raw.githubusercontent.com/riboseinc/oss-guides/master/ci/rubocop.yml
 AllCops:

data/lib/relaton_bsi/bsi_bibliography.rb

@@ -24,17 +24,21 @@ module RelatonBsi
         raise RelatonBib::RequestError, e.message
       end
 
+      #
       # @param code [String] the BSI standard Code to look up
       # @param year [String] the year the standard was published (optional)
-      # @param opts [Hash] options; restricted to :all_parts if all-parts reference is required
+      # @param opts [Hash] options
+      # @option opts [Boolean] :all_parts if all-parts reference is required
+      # @option opts [Boolean] :no_year if last published document is required
+      #
       # @return [String] Relaton XML serialisation of reference
-      def get(code, year = nil, opts = {}) # rubocop:disable Metrics/CyclomaticComplexity,Metrics/MethodLength,Metrics/PerceivedComplexity
-        c, y = code.split ':'
+      def get(code, year = nil, opts = {})
+        c, y = code.split ":"
         year ||= y
         ret = bib_get1(c, year, opts)
         return nil if ret.nil?
 
-        # ret = ret.to_most_recent_reference unless year || opts[:keep_year]
+        ret = ret.to_most_recent_reference unless year || opts[:keep_year]
         # ret = ret.to_all_parts if opts[:all_parts]
         ret
       end
@@ -44,18 +48,19 @@ module RelatonBsi
       def fetch_ref_err(code, year, missed_years) # rubocop:disable Metrics/MethodLength
         id = year ? "#{code}:#{year}" : code
         warn "[relaton-bsi] WARNING: no match found online for #{id}. "\
-          "The code must be exactly like it is on the standards website."
+             "The code must be exactly like it is on the standards website."
         unless missed_years.empty?
-          warn "[relaton-bsi] (There was no match for #{year}, though there were matches "\
-            "found for #{missed_years.join(', ')}.)"
+          warn "[relaton-bsi] (There was no match for #{year}, though there "\
+               "were matches found for #{missed_years.join(', ')}.)"
         end
         # if /\d-\d/.match? code
-        #   warn "[relaton-bsi] The provided document part may not exist, or the document "\
-        #     "may no longer be published in parts."
+        #   warn "[relaton-bsi] The provided document part may not exist, or "\
+        #     "the document may no longer be published in parts."
         # else
-        #   warn "[relaton-bsi] If you wanted to cite all document parts for the reference, "\
-        #     "use \"#{code} (all parts)\".\nIf the document is not a standard, "\
-        #     "use its document type abbreviation (TS, TR, PAS, Guide)."
+        #   warn "[relaton-bsi] If you wanted to cite all document parts for "\
+        #     "the reference, use \"#{code} (all parts)\".\nIf the document "\
+        #     "is not a standard, use its document type abbreviation (TS, TR, "\
+        #     "PAS, Guide)."
         # end
         nil
       end

data/lib/relaton_bsi/hit_collection.rb

@@ -8,8 +8,6 @@ module RelatonBsi
   class HitCollection < RelatonBib::HitCollection
     DOMAIN = "https://shop.bsigroup.com"
 
-    # @return [Mechanize]
-    # attr_reader :agent
 
     # @param ref [String]
     # @param year [String]
@@ -28,11 +26,12 @@ module RelatonBsi
 
     # @param hits [Array<Hash>]
     # @return [Array<RelatonBsi::Hit>]
-    def hits(hits) # rubocop:disable Metrics/MethodLength
+    def hits(hits) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
       hits.map do |h|
+        code = h[:meta][:global][:primaryDesignator].sub(/\sLOOSELEAF|\s\(A5 LAMINATED\)/, "")
         Hit.new(
           {
-            code: h[:meta][:global][:primaryDesignator],
+            code: code,
             title: h[:title],
             url: h[:handle],
             date: h[:meta][:global][:publishedDate],
@@ -42,7 +41,7 @@ module RelatonBsi
             doctype: h[:product_type],
           }, self
         )
-      end
+      end.sort_by { |h| h.hit[:date] }.reverse
     end
   end
 end

data/lib/relaton_bsi/scrapper.rb

@@ -118,7 +118,7 @@ module RelatonBsi
       # @param docid [String]
       # @param data [Hash]
       # @return [Array<RelatonBib::DocumentIdentifier>]
-      def fetch_docid(docid, data)
+      def fetch_docid(docid, data) # rubocop:disable Metrics/AbcSize
         ids = [{ type: "BSI", id: docid }]
         if data.any? && data["variants"]["edges"][0]["node"]["isbn"]
           isbn = data["variants"]["edges"][0]["node"]["isbn"]["value"]

data/lib/relaton_bsi/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RelatonBsi
-  VERSION = "1.9.2"
+  VERSION = "1.9.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: relaton-bsi
 version: !ruby/object:Gem::Version
-  version: 1.9.2
+  version: 1.9.3
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-04 00:00:00.000000000 Z
+date: 2021-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: equivalent-xml