regressor 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b6976e039d3e3cb93759a984eadcdc617f2bcf9
-  data.tar.gz: 6c20bbc08b4f80b0aa6662d1fb782183aa094e13
+  metadata.gz: 3da20145433fc7502546a3a4789311489eebbab9
+  data.tar.gz: c5a5810e0089934d2dd1fc783215d646b0112d1e
 SHA512:
-  metadata.gz: 13219132e9fdf9aca87ebf8c431bc2f6525318adde7ab469a5c64476bd6efa9dc57d4228715d8856fd426fe9076f9cab50660340833e2a7c43eb8431200db9b9
-  data.tar.gz: 29575ffc4aeb4067035cd0947ff68096497caf6519c1e5cac4dcee3a4c32aade857a364804c973677f1dd4b8419dbecba0ee89e003a9e1a6d522765f01138897
+  metadata.gz: d7f3221de3e0db9fe5486582c051ed2dbb38330df05517b24542484ee3c981acd7537fdb7cee724b28bc89471d2fd93d246279e60eb2f3b233e91756d9d6d241
+  data.tar.gz: 5ac2a8e062369acd1e7c239dbdd7cbc2c5174f3281420b88dcce947cf522a47f5055f54460f04d31e791260edb1e213670a70e43d1bd8018a7ec4f8646b625e2

data/lib/generators/regressor/model/validation/length.rb

@@ -3,23 +3,27 @@ module Regressor
     module Validation
       module Length
         def length_validators
+          extract_length_validators.inject([]) do |result, validator|
+            result << generate_validator_examples(validator, validator.options[:minimum]-1, validator.options[:minimum]) if validator.options[:minimum]
+            result << generate_validator_examples(validator, validator.options[:maximum] + 1, validator.options[:maximum]) if validator.options[:maximum]
+            result
+          end.flatten.compact.uniq.join("\n\t")
+        end
+
+        private
+
+        def extract_length_validators
           @model.constantize.validators.select do |validator|
             validator.class.to_s == ActiveModel::Validations::LengthValidator.to_s
-          end.inject([]) do |result, validator|
-            if validator.options[:minimum]
-              validator.attributes.each do |attribute|
-                result << "it { is_expected.to allow_value(Faker::Lorem.characters(#{validator.options[:minimum]})).for :#{attribute} }"
-                result << "it { is_expected.not_to allow_value(Faker::Lorem.characters(#{validator.options[:minimum] - 1})).for :#{attribute} }"
-              end
-            end
-            if validator.options[:maximum]
-              validator.attributes.each do |attribute|
-                result << "it { is_expected.to allow_value(Faker::Lorem.characters(#{validator.options[:maximum]})).for :#{attribute} }"
-                result << "it { is_expected.not_to allow_value(Faker::Lorem.characters(#{validator.options[:maximum] + 1})).for :#{attribute} }"
-              end
-            end
+          end
+        end
+
+        def generate_validator_examples(validator, upper_bound, lower_bound)
+          validator.attributes.inject([]) do |result, attribute|
+            result << "it { is_expected.to allow_value(Faker::Lorem.characters(#{lower_bound})).for :#{attribute} }"
+            result << "it { is_expected.not_to allow_value(Faker::Lorem.characters(#{upper_bound})).for :#{attribute} }"
             result
-          end.flatten.compact.uniq.join("\n\t")
+          end
         end
       end
     end

data/lib/regressor/version.rb

@@ -1,3 +1,3 @@
 module Regressor
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: regressor
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Erwin Schens