refworks 0.0.6 → 0.0.7

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NTQ0MGNjZmEyNDI0MzAzNmE5NDg5YjIxNzQzZDI5MGNlOWM1YTQ3Ng==
+    YzU5NzhjZDUyNzFkMmQ4ZDFkNGYyNTM1N2IwNjM3MzEzMjE3OTExNg==
   data.tar.gz: !binary |-
-    NDI0YTljYzU3YTYzYzViY2IwNzk2MGNmODcwZTMyZTYzMzE0M2Y1Nw==
+    ZGQyODU2NWVjOTlmM2Y2N2UxYTViZTA1MzY5ZGE0NzIyMjgxZDg0Ng==
 SHA512:
   metadata.gz: !binary |-
-    YjNjYTUwYWQ4YjQyMWJiMmI4NGM0ZDM0M2Q5ZmQ2YmMzYWNhNjc2Y2IzNTlk
-    NTI3YjRmM2U0ZDNmYzdiYjVjYTRlMzllNzg1MWIyYzNlZDcxODU1ODE1ODk4
-    OTk3YWJhZTFmMmZmYTVhMDU2NTNhMDE2OTBkOTE4ODYwNjliOGE=
+    NzcxNDE0ZDM3YTk5YWI5ZWM4YTdiNzA1NTVmYzczNWUyNjQxODgyNjY3MGM3
+    N2ZhNWQyODhlMThjNGNiNjA5MGI0Y2FkYjdjMmYyZDc5YTBlYWIxN2IzNjNj
+    ZWQ2MGFmZWVmNDg3ZDM2NjIyNjRkNjI0MGVjODJkMTBiYTNiNTA=
   data.tar.gz: !binary |-
-    MDcyMmEzMDYxZDRmYjI2NzU3MWYwYTcwOWYyODBhYzg4ZGRhMTMwZGZiMTNh
-    ZmYzODY3M2IyNjIyYmVjMGI3M2UwZDNhM2NiNDJmNWE0NTA3N2ZkZDhkZTI2
-    NjI4MmIzYTM4ZDIyM2E2MzgxMDRiOWYyYTQ0NjY3ZTE4MzM0MWM=
+    YWVlMDk5NWU0ZDJlOTVkYWY0OGU5MWYwNDllZjQzMmIzOTZmODMwMGFjZGQ1
+    MzUyZmU1NDRlOWViYjMzNzUzMWFkNzljODg0ZWM2ZWYyZDlmYmI4MTYxMmE0
+    MjJjOWU0NzcyYThkNWMyNmIyN2Q1Y2ZlYWUyYWVhOGI5ZWI3MzQ=

data/lib/refworks/response.rb

@@ -3,17 +3,6 @@ class Response
   attr_reader :body, :parsed_response, :result_code, :result_msg, :process_time
 
   def initialize(raw_response)
-    # The RefWorks API emits invalid XML.  Specifically, when the session is invalid, the ResultMsg field
-    # which comes back contains some illegal raw characters.  This is the only set of transformations I
-    # could find which completely eliminate the junk characters.
-
-    p raw_response.body
-
-    raw_response.body.encode!('UTF-8', 'binary', :invalid => :replace, :undef => :replace, :replace => '?')
-    raw_response.body.gsub!(/[\u0001-\u0019]/,'?')
-
-    p raw_response.body
-
     @body = raw_response.body
     @parsed_response = raw_response.parsed_response
     @result_code = parsed_response["refworks"]["RWResult"]["result"]

data/lib/refworks/version.rb

@@ -1,3 +1,3 @@
 class Refworks
-  VERSION = '0.0.6'
+  VERSION = '0.0.7'
 end

data/lib/refworks.rb

@@ -18,7 +18,6 @@ class Refworks
   include HTTParty
 
   attr_reader :api_url, :access_key, :secret_key, :login_name, :password, :group_code, :id, :sess
-  attr_writer :sess
 
   # Create a new Refworks client instance.
   # @example
@@ -56,33 +55,29 @@ class Refworks
 
     # probably should check here that I have the minimal set of required attributes to continue
 
-    # Can't do much without a session, so get one now if one wasn't passed in
-    if params[:sess]
-      @sess = params[:sess]
+    # Can't do much without a session, so get one now
+    # May need to refactor this - there are parts of the API that don't strictly need a session
+    if (@group_code)
+      response = request('authentication', 'newsess',
+                         {
+                            :login_name => @login_name,
+                            :group_code => @group_code,
+                            :password => @password,
+                         }
+      )
     else
-      # May need to refactor this - there are parts of the API that don't strictly need a session
-      if (@group_code)
-        response = request('authentication', 'newsess',
-                           {
-                              :login_name => @login_name,
-                              :group_code => @group_code,
-                              :password => @password,
-                           }
-        )
-      else
-        response = request('authentication', 'newsess',
-                           {
-                               :login_name => @login_name,
-                               :id => @id,
-                               :password => @password,
-                           }
-        )
-      end
-
-      # Grab the session string.
-      @sess = response.sess
+      response = request('authentication', 'newsess',
+                         {
+                             :login_name => @login_name,
+                             :id => @id,
+                             :password => @password,
+                         }
+      )
     end
 
+    # Grab the session string.
+    @sess = response.sess
+
     # Need some error checking here
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: refworks
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Fran Fabrizio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-19 00:00:00.000000000 Z
+date: 2014-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty