reform 2.0.0.rc2 → 2.0.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a87860e43b6e321c13ae641903aa1a6b098c2ec1
-  data.tar.gz: 50d863fbf7d3e5ba9ea7eb0ea2d46a073e7cf458
+  metadata.gz: 1656561190a1c9784f1e2463e6c4e2c558bb78d0
+  data.tar.gz: 236cc4811f68a6e6e6e7a9e0a31d11a4afbe955d
 SHA512:
-  metadata.gz: 6a3171c4d74d852e77a88d817b886515fbe2c0f469e9f54abb3e53efd7b237013010d4b1c404b382c5e068294bd5747c9bd61061fdc511c18db8507bfff5630c
-  data.tar.gz: 12f688ec7d485fafd29924d91c5dd59862ff3fb6f23c463a3b4e6be2aaddaa6d7381e706f318029841509bfd52571d4b462d6eead389c976a3437085b6053f84
+  metadata.gz: 2aa18198338829e843a002d940dfb60d0f4d318662637d064f01a668f30fd59bf20fa3fe11dd25b7a5534e93b986aabc54d19cf2f01e3e42f02c81273fe7601a
+  data.tar.gz: 4d9cea3a1c22769400c48164b2a907e0b8f713a82b2cb9e11fb0fb97bbc963f3a5445da828b4b899b2dd4b420416fb7b7d94f1f6c400378e47210c64028d99f5

data/CHANGES.md

@@ -17,6 +17,10 @@ you don't need to know about forms anymore, the twin handles that using #insert.
 * Forms do not `include ActiveModel::Validations` anymore. This has polluted the entire gem and is not encapsulated in `Validator`. Consider using Lotus Validations instead.
 * Validation inheritance with `ActiveModel::Validations` is broken with Rails 3.2 and 4.0. Update Rails or use the `Lotus` validations.
 
+## 2.0.0.rc3
+
+* Fix an annoying bug coming from Rails autoloader with validations and `model_name`.
+
 ## 1.2.6
 
 * Added `:prepopulate` to fill out form properties for presentation. Note that you need to call `Form#prepopulate!` to trigger the prepopulation.

data/lib/reform/form/active_model/validations.rb

@@ -31,6 +31,7 @@ module Reform::Form::ActiveModel
     # on instance, it exposes #valid?.
     class Validator
       include ActiveModel::Validations
+      # extend ActiveModel::Naming
 
       def initialize(form)
         @form = form
@@ -40,9 +41,13 @@ module Reform::Form::ActiveModel
         @form.send(method_name, *args, &block)
       end
 
-      def self.name # FIXME: this is only needed for i18n, it seems.
-        "ba"
+      # def self.model_name # FIXME: this is only needed for i18n, it seems.
+      #   "Reform::Form"
+      # end
+      def self.model_name
+        ActiveModel::Name.new(Reform::Form)
       end
+      # we can also do self.name and return "reform/form" but then run into "wrong constant name reform/form" from the autoloader. wtf?
 
       def self.clone
         Class.new(self)

data/lib/reform/version.rb

@@ -1,3 +1,3 @@
 module Reform
-  VERSION = "2.0.0.rc2"
+  VERSION = "2.0.0.rc3"
 end

data/test/lotus/Gemfile

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gem "reform", path: "../../"
+gem "lotus-validations"
+gem "minitest"

data/test/lotus/lotus_test.rb

@@ -0,0 +1,27 @@
+require "reform"
+require "reform/form/lotus"
+require "minitest/autorun"
+
+Reform::Contract.class_eval do
+  include Reform::Contract::Validate
+  include Reform::Form::Lotus
+end
+
+class LotusTest < Minitest::Spec
+  Album = Struct.new(:title, :songs, :artist)
+
+  class AlbumForm < Reform::Form
+
+
+    property :title
+    validates :title, presence: true
+  end
+
+  it do
+    form = AlbumForm.new(Album.new("Show Completo"))
+
+    form.validate(title: "").must_equal false
+
+    form.errors.to_s.must_equal ""
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reform
 version: !ruby/object:Gem::Version
-  version: 2.0.0.rc2
+  version: 2.0.0.rc3
 platform: ruby
 authors:
 - Nick Sutterer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-07 00:00:00.000000000 Z
+date: 2015-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: disposable
@@ -273,6 +273,8 @@ files:
 - test/form_test.rb
 - test/from_test.rb
 - test/inherit_test.rb
+- test/lotus/Gemfile
+- test/lotus/lotus_test.rb
 - test/lotus_test.rb
 - test/model_reflections_test.rb
 - test/model_validations_test.rb
@@ -360,6 +362,8 @@ test_files:
 - test/form_test.rb
 - test/from_test.rb
 - test/inherit_test.rb
+- test/lotus/Gemfile
+- test/lotus/lotus_test.rb
 - test/lotus_test.rb
 - test/model_reflections_test.rb
 - test/model_validations_test.rb