reform 2.0.0.beta2 → 2.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4b89a50eb51cda0fe932efa6b7e67eb03658fdba
-  data.tar.gz: 019bfd72b5e2c966dde1a35bc22ce4dc0c2bd934
+  metadata.gz: 981ddfe5d276177430c4441c81e38f8d1bc89166
+  data.tar.gz: 269eeca94c1c7636e4ff8fd73df5e2c6bccc459c
 SHA512:
-  metadata.gz: adb468e4594747b200c08ac1e23dcefab0730e801698f4fd2e675a04366f75fdd156a4bc3f49fd571f0346ae7283397e5b7cf7ab536243abbd2e6e70883248a2
-  data.tar.gz: 20aab2ce543b0619ee7e064e11c993d58792cb030af05513361b358ba9b324aaf0d24bf500edadaa1dbb1f08cac18aae20d6bfe0e68b1ce86cbbe43fc1a02fb4
+  metadata.gz: 165337839adaf02e97f805f05974a2ce9b8b1950f848493a1feabbb5ce708c3877e7bb6f59c7d0f5ab088f36ddfc10c3b4069cbed2ada2ba95909a360c0d705d
+  data.tar.gz: c7cf74f86eebc98c0810299fbaa179715b2bf92ba02d666f8658a116323d8b3b637fb9cf36361612f673abe1e5aa9541d04b1606d674f758fcc264d165d0f23c

data/CHANGES.md

@@ -1,6 +1,7 @@
 ## 2.0.0
 
 * The `::reform_2_0!` is no longer there. Guess why.
+* Again: `:empty` doesn't exist anymore. You can choose from `:readable`, `:writeable` and `:virtual`.
 * :populator => lambda { |fragment, index, args|
 #           songs[index] or songs[index] = args.binding[:form].new(Song.new)
 #         }

data/Gemfile

@@ -3,5 +3,5 @@ source 'https://rubygems.org'
 gemspec
 
 #gem 'representable', path: "../representable"
-# gem "disposable", path: "../disposable"
+ # gem "disposable", path: "../disposable"
 # gem "disposable", github: "apotonick/disposable"

data/README.md

@@ -10,6 +10,7 @@ Although reform can be used in any Ruby framework, it comes with [Rails support]
 
 Temporary note: This is the README and API for Reform 2. On the public API, only a few tiny things have changed. When in trouble, join us on the IRC (Freenode) #trailblazer channel.
 
+[Full documentation for Reform](http://trailblazerb.org/gems/reform) is available online, or support us and grab the [Trailblazer book](https://leanpub.com/trailblazer).
 
 ## Disposable
 
@@ -527,6 +528,8 @@ end
 
 Note that you can also override properties [using inheritance](#inheritance) in Reform.
 
+When using coercion, make sure the including form already contains the `Coercion` module.
+
 
 ## Inheritance
 

data/Rakefile

@@ -6,31 +6,32 @@ Rake::TestTask.new(:test) do |test|
   test.libs << 'test'
   test.test_files = FileList['test/*_test.rb']
 
-  test.test_files = ["test/changed_test.rb",
-  "test/coercion_test.rb",
-  "test/feature_test.rb",
+#   test.test_files = ["test/changed_test.rb",
+#   "test/coercion_test.rb",
+#   "test/feature_test.rb",
 
-  "test/contract_test.rb",
+#   "test/contract_test.rb",
 
-  "test/populate_test.rb", "test/prepopulator_test.rb",
+#   "test/populate_test.rb", "test/prepopulator_test.rb",
 
-  "test/readable_test.rb","test/setup_test.rb","test/skip_if_test.rb",
+#   "test/readable_test.rb","test/setup_test.rb","test/skip_if_test.rb",
 
-  "test/validate_test.rb", "test/save_test.rb",
+#   "test/validate_test.rb", "test/save_test.rb",
 
-  "test/writeable_test.rb","test/virtual_test.rb",
+#   "test/writeable_test.rb","test/virtual_test.rb",
 
-  "test/form_builder_test.rb", "test/active_model_test.rb",
+#   "test/form_builder_test.rb", "test/active_model_test.rb",
 
-  "test/readonly_test.rb",
-  "test/inherit_test.rb",
-  "test/uniqueness_test.rb",
-  "test/from_test.rb",
-  "test/composition_test.rb",
-  "test/form_option_test.rb",
-  "test/form_test.rb",
-  "test/deserialize_test.rb"
-]
+#   "test/readonly_test.rb",
+#   "test/inherit_test.rb",
+#   "test/uniqueness_test.rb",
+#   "test/from_test.rb",
+#   "test/composition_test.rb",
+#   "test/form_option_test.rb",
+#   "test/form_test.rb",
+#   "test/deserialize_test.rb",
+#   "test/module_test.rb"
+# ]
 
 
 

data/lib/reform/contract.rb

@@ -91,22 +91,6 @@ module Reform
     require "reform/schema"
     extend Reform::Schema
   end
-
-  class Contract_ # DISCUSS: make class?
-    # allows including representers from Representable, Roar or disposable.
-    def self.inherit_module!(representer) # called from Representable::included.
-      # representer_class.inherit_module!(representer)
-      representer.representable_attrs.each do |dfn|
-        next if dfn.name == "links" # wait a second # FIXME what is that?
-
-        # TODO: remove manifesting and do that in representable, too!
-        args = [dfn.name, dfn.instance_variable_get(:@options)] # TODO: dfn.to_args (inluding &block)
-
-        property(*args) and next unless dfn.representer_module
-        property(*args) { include dfn.representer_module } # nested.
-      end
-    end
-  end
 end
 
 require 'reform/contract/errors'

data/lib/reform/form.rb

@@ -16,10 +16,6 @@ module Reform
     module Property
       # add macro logic, e.g. for :populator.
       def property(name, options={}, &block)
-        if options.delete(:virtual)
-          options[:writeable] = options[:readable] = false # DISCUSS: isn't that like an #option in Twin?
-        end
-
         if deserializer = options[:deserializer] # this means someone is explicitly specifying :deserializer.
           options[:deserializer] = Representable::Cloneable::Hash[deserializer]
         end

data/lib/reform/form/active_record.rb

@@ -39,7 +39,7 @@ module Reform::Form::ActiveRecord
   def model_for_property(name)
     return model unless is_a?(Reform::Form::Composition) # i am too lazy for proper inheritance. there should be a ActiveRecord::Composition that handles this.
 
-    model_name = mapper.representable_attrs.get(name)[:on]
+    model_name = schema.representable_attrs.get(name)[:on]
     model[model_name]
   end
 end

data/lib/reform/form/model_reflections.rb

@@ -30,7 +30,7 @@ module Reform::Form::ModelReflections
   def defined_enums
     return model.defined_enums unless is_a?(Reform::Form::Composition)
 
-    model.each.with_object({}) { |m,h| h.merge! m.defined_enums }
+    mapper.each.with_object({}) { |m,h| h.merge! m.defined_enums }
   end
 
   # this should also contain to_param and friends as this is used by the form helpers.

data/lib/reform/form/module.rb

@@ -1,5 +1,6 @@
 # Include this in every module that gets further included.
-module Reform::Form::Module # Schema
+# TODO: this could be implemented in Declarable, as we can use that everywhere.
+module Reform::Form::Module
   def self.included(base)
     base.extend ClassMethods
     base.extend Included

data/lib/reform/version.rb

@@ -1,3 +1,3 @@
 module Reform
-  VERSION = "2.0.0.beta2"
+  VERSION = "2.0.0.rc1"
 end

data/reform.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency             "representable",  ">= 2.2.2"
-  spec.add_dependency             "disposable",     "~> 0.1.4"
+  spec.add_dependency             "disposable",     "~> 0.1.5"
   spec.add_dependency             "uber",           "~> 0.0.11"
   spec.add_dependency             "activemodel"
 

data/test/active_record_test.rb

@@ -205,7 +205,7 @@ class PopulateWithActiveRecordTest < MiniTest::Spec
       let (:album) { Album.create(:title => 'Greatest Hits') }
       let (:form) { ActiveModelAlbumForm.new(album) }
 
-      it do
+      it "xxx"do
         form.validate('songs_attributes' => {'0' => {'title' => 'Tango'}})
 
         # form populated.
@@ -229,6 +229,8 @@ class PopulateWithActiveRecordTest < MiniTest::Spec
         album.songs.size.must_equal 1
         album.songs[0].title.must_equal 'Tango'
 
+        # DISCUSS: IfEmpty uses twin.original[index] for syncing. in our case, this is empty, so it will add Tango again.
+        form = ActiveModelAlbumForm.new(album)
         form.validate('songs_attributes' => {'0' => {'id' => first_song.id, 'title' => 'Tango nuevo'}, '1' => {'title' => 'Waltz'}})
 
         # form populated.
@@ -257,42 +259,6 @@ class PopulateWithActiveRecordTest < MiniTest::Spec
       end
     end
   end
-
-  # it do
-  #   a=Album.new
-  #   a.songs << Song.new(title: "Old What's His Name") # Song does not get persisted.
-
-  #   a.songs[1] = Song.new(title: "Permanent Rust")
-
-  #   puts "@@@"
-  #   puts a.songs.inspect
-
-  #   puts "---"
-  #   a.save
-  #   puts a.songs.inspect
-
-  #   b = a.songs.first
-
-  #   a.songs = [Song.new(title:"Biomag")]
-  #   puts "\\\\"
-  #   a.save
-  #   a.reload
-  #   puts a.songs.inspect
-
-  #   b.reload
-  #   puts "#{b.inspect}, #{b.persisted?}"
-
-
-  #   a.songs = [a.songs.first, Song.new(title: "Count Down")]
-  #   b = a.songs.first
-  #   puts ":::::"
-  #   a.save
-  #   a.reload
-  #   puts a.songs.inspect
-
-  #   b.reload
-  #   puts "#{b.inspect}, #{b.persisted?}"
-  # end
 end
 
 

data/test/inherit_test.rb

@@ -104,133 +104,4 @@ require "pp"
     AlbumForm.new(OpenStruct.new(artist: OpenStruct.new)).artist.artist_id.must_equal 1
     CompilationForm.new(OpenStruct.new(artist: OpenStruct.new)).artist.artist_id.must_equal 1
   end
-end
-
-
-# require 'reform/form/coercion'
-# class ModuleInclusionTest < MiniTest::Spec
-#   module BandPropertyForm
-#     include Reform::Form::Module
-
-#     property :band do
-#       property :title
-
-#       validates :title, :presence => true
-
-#       def id # gets mixed into Form, too.
-#         2
-#       end
-#     end
-
-#     def id # gets mixed into Form, too.
-#       1
-#     end
-
-#     validates :band, :presence => true
-
-#     property :cool, type: Virtus::Attribute::Boolean # test coercion.
-#   end
-
-#   # TODO: test if works, move stuff into inherit_schema!
-#   module AirplaysPropertyForm
-#     include Reform::Form::Module
-
-#     collection :airplays do
-#       property :station
-#       validates :station, :presence => true
-#     end
-#     validates :airplays, :presence => true
-#   end
-
-
-#   # test:
-#   # by including BandPropertyForm into multiple classes we assure that options hashes don't get messed up by AM:V.
-#   class HitForm < Reform::Form
-#     include BandPropertyForm
-#   end
-
-#   class SongForm < Reform::Form
-#     property :title
-
-#     include BandPropertyForm
-#   end
-
-
-#   let (:song) { OpenStruct.new(:band => OpenStruct.new(:title => "Time Again")) }
-
-#   # nested form from module is present and creates accessor.
-#   it { SongForm.new(song).band.title.must_equal "Time Again" }
-
-#   # methods from module get included.
-#   it { SongForm.new(song).id.must_equal 1 }
-#   it { SongForm.new(song).band.id.must_equal 2 }
-
-#   # validators get inherited.
-#   it do
-#     form = SongForm.new(OpenStruct.new)
-#     form.validate({})
-#     form.errors.messages.must_equal({:band=>["can't be blank"]})
-#   end
-
-#   # coercion works
-#   it do
-#     form = SongForm.new(OpenStruct.new)
-#     form.validate({:cool => "1"})
-#     form.cool.must_equal true
-#   end
-
-
-#   # include a module into a module into a class :)
-#   module AlbumFormModule
-#     include Reform::Form::Module
-#     include BandPropertyForm
-
-#     property :name
-#     validates :name, :presence => true
-#   end
-
-#   class AlbumForm < Reform::Form
-#     include AlbumFormModule
-
-#     property :band, :inherit => true do
-#       property :label
-#       validates :label, :presence => true
-#     end
-#   end
-#   # puts "......"+ AlbumForm.representer_class.representable_attrs.get(:band).inspect
-
-#   it do
-#     form = AlbumForm.new(OpenStruct.new(:band => OpenStruct.new))
-#     form.validate({"band" => {}})
-#     form.errors.messages.must_equal({:"band.title"=>["can't be blank"], :"band.label"=>["can't be blank"], :name=>["can't be blank"]})
-#   end
-
-
-#   # including representer into form
-#   module GenericRepresenter
-#     include Representable
-
-#     property :title
-#     property :manager do
-#       property :title
-#     end
-#   end
-
-#   class LabelForm < Reform::Form
-#     property :location
-
-#     include GenericRepresenter
-#     validates :title, :presence => true
-#     property :manager, :inherit => true do
-#       validates :title, :presence => true
-#     end
-#   end
-#     puts "......"+ LabelForm.representer_class.representable_attrs.get(:title).inspect
-
-
-#   it do
-#     form = LabelForm.new(OpenStruct.new(:manager => OpenStruct.new))
-#     form.validate({"manager" => {}, "title"=>""}) # it's important to pass both nested and scalar here!
-#     form.errors.messages.must_equal(:title=>["can't be blank"], :"manager.title"=>["can't be blank"], )
-#   end
-# end
+end

data/test/module_test.rb

@@ -0,0 +1,130 @@
+require "test_helper"
+require 'reform/form/coercion'
+
+class ModuleInclusionTest < MiniTest::Spec
+  module BandPropertyForm
+    include Reform::Form::Module
+
+    property :band do
+      property :title
+
+      validates :title, presence: true
+
+      def id # gets mixed into Form, too.
+        2
+      end
+    end
+
+    def id # gets mixed into Form, too.
+      1
+    end
+
+    validates :band, presence: true
+
+    property :cool, type: Virtus::Attribute::Boolean # test coercion.
+  end
+
+  # TODO: test if works, move stuff into inherit_schema!
+  module AirplaysPropertyForm
+    include Reform::Form::Module
+
+    collection :airplays do
+      property :station
+      validates :station, presence: true
+    end
+    validates :airplays, presence: true
+  end
+
+
+  # test:
+  # by including BandPropertyForm into multiple classes we assure that options hashes don't get messed up by AM:V.
+  class HitForm < Reform::Form
+    include BandPropertyForm
+  end
+
+  class SongForm < Reform::Form
+    include Coercion
+    property :title
+
+    include BandPropertyForm
+  end
+
+
+  let (:song) { OpenStruct.new(:band => OpenStruct.new(:title => "Time Again")) }
+
+  # nested form from module is present and creates accessor.
+  it { SongForm.new(song).band.title.must_equal "Time Again" }
+
+  # methods from module get included.
+  it { SongForm.new(song).id.must_equal 1 }
+  it { SongForm.new(song).band.id.must_equal 2 }
+
+  # validators get inherited.
+  it do
+    form = SongForm.new(OpenStruct.new)
+    form.validate({})
+    form.errors.messages.must_equal({:band=>["can't be blank"]})
+  end
+
+  # coercion works
+  it do
+    form = SongForm.new(OpenStruct.new)
+    form.validate({cool: "1"})
+    form.cool.must_equal true
+  end
+
+
+  # include a module into a module into a class :)
+  module AlbumFormModule
+    include Reform::Form::Module
+    include BandPropertyForm
+
+    property :name
+    validates :name, :presence => true
+  end
+
+  class AlbumForm < Reform::Form
+    include AlbumFormModule
+
+    property :band, :inherit => true do
+      property :label
+      validates :label, :presence => true
+    end
+  end
+  # puts "......"+ AlbumForm.representer_class.representable_attrs.get(:band).inspect
+
+  it do
+    form = AlbumForm.new(OpenStruct.new(:band => OpenStruct.new))
+    form.validate({"band" => {}})
+    form.errors.messages.must_equal({:"band.title"=>["can't be blank"], :"band.label"=>["can't be blank"], :name=>["can't be blank"]})
+  end
+
+
+#   # including representer into form
+#   module GenericRepresenter
+#     include Representable
+
+#     property :title
+#     property :manager do
+#       property :title
+#     end
+#   end
+
+#   class LabelForm < Reform::Form
+#     property :location
+
+#     include GenericRepresenter
+#     validates :title, :presence => true
+#     property :manager, :inherit => true do
+#       validates :title, :presence => true
+#     end
+#   end
+#     puts "......"+ LabelForm.representer_class.representable_attrs.get(:title).inspect
+
+
+#   it do
+#     form = LabelForm.new(OpenStruct.new(:manager => OpenStruct.new))
+#     form.validate({"manager" => {}, "title"=>""}) # it's important to pass both nested and scalar here!
+#     form.errors.messages.must_equal(:title=>["can't be blank"], :"manager.title"=>["can't be blank"], )
+#   end
+end

data/test/populate_test.rb

@@ -138,6 +138,8 @@ class PopulateIfEmptyTest < MiniTest::Spec
   let (:form) { AlbumForm.new(album) }
 
   it do
+    form.songs.size.must_equal 2
+
     form.validate(
       "songs"  => [{"title" => "Fallout"}, {"title" => "Roxanne"},
         {"title" => "Rime Of The Ancient Mariner"}, # new song.
@@ -181,7 +183,6 @@ class PopulateIfEmptyTest < MiniTest::Spec
 
     album.artist.must_equal nil
   end
-
 end
 
 

data/test/reform_test.rb

@@ -1,40 +1,11 @@
 require 'test_helper'
 
+# TODO: this test should be removed.
 class ReformTest < ReformSpec
   let (:comp) { OpenStruct.new(:name => "Duran Duran", :title => "Rio") }
 
   let (:form) { SongForm.new(comp) }
 
-
-  describe "::property" do
-    it "doesn't allow reserved names" do
-      assert_raises RuntimeError do
-        Class.new(Reform::Form) do
-          property :model
-        end
-      end
-    end
-  end
-
-
-  describe "::properties" do
-    let (:options) { {:type => String} }
-
-    subject do
-      opts = options
-      Class.new(Reform::Form) do
-        properties :name, :title, opts
-        properties :created_at
-      end.new(comp)
-    end
-
-    it { subject.name.must_equal       "Duran Duran" }
-    it { subject.title.must_equal      "Rio" }
-    it { subject.created_at.must_equal nil }
-    # don't overwrite options.
-    it { subject; options.must_equal({:type => String}) }
-  end
-
   class SongForm < Reform::Form
     property :name
     property :title

data/test/twin_test.rb

@@ -3,21 +3,36 @@ require 'test_helper'
 require 'test_helper'
 require 'reform/twin'
 
+# class TwinTest < MiniTest::Spec
+#   class SongForm < Reform::Form
+#     class Twin < Disposable::Twin
+#       property :title
+#       option :is_online # TODO: this should make it read-only in reform!
+#     end
+
+#     # include Reform::Twin
+#     # twin Twin
+#   end
+
+#   let (:model) { OpenStruct.new(title: "Kenny") }
+
+#   let (:form) { SongForm.new(model, is_online: true) }
+
+#   it { form.title.must_equal "Kenny" }
+#   it { form.is_online.must_equal true }
+# end
 class TwinTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    class Twin < Disposable::Twin
-      property :title
-      option :is_online # TODO: this should make it read-only in reform!
-    end
+  Song = Struct.new(:name)
 
-    include Reform::Twin
-    twin Twin
+  class SongForm < Reform::Form
+    property :name
+    property :is_online, virtual: true
   end
 
-  let (:model) { OpenStruct.new(title: "Kenny") }
+  let (:form) { SongForm.new(Song.new("Kenny"), is_online: true) }
 
-  let (:form) { SongForm.new(model, is_online: true) }
-
-  it { form.title.must_equal "Kenny" }
-  it { form.is_online.must_equal true }
-end
+  it do
+    form.name.must_equal "Kenny"
+    form.is_online.must_equal true
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reform
 version: !ruby/object:Gem::Version
-  version: 2.0.0.beta2
+  version: 2.0.0.rc1
 platform: ruby
 authors:
 - Nick Sutterer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-30 00:00:00.000000000 Z
+date: 2015-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: representable
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.4
+        version: 0.1.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.4
+        version: 0.1.5
 - !ruby/object:Gem::Dependency
   name: uber
   requirement: !ruby/object:Gem::Requirement
@@ -261,7 +261,6 @@ files:
 - test/dummy/log/server.log
 - test/errors_test.rb
 - test/feature_test.rb
-- test/fields_test.rb
 - test/form_builder_test.rb
 - test/form_option_test.rb
 - test/form_test.rb
@@ -269,6 +268,7 @@ files:
 - test/inherit_test.rb
 - test/model_reflections_test.rb
 - test/model_validations_test.rb
+- test/module_test.rb
 - test/populate_test.rb
 - test/prepopulator_test.rb
 - test/rails/integration_test.rb
@@ -276,13 +276,10 @@ files:
 - test/readable_test.rb
 - test/readonly_test.rb
 - test/reform_test.rb
-- test/representer_test.rb
 - test/save_test.rb
-- test/scalar_test.rb
 - test/setup_test.rb
 - test/skip_if_test.rb
 - test/skip_setter_and_getter_test.rb
-- test/skip_unchanged_test.rb
 - test/test_helper.rb
 - test/twin_test.rb
 - test/uniqueness_test.rb
@@ -349,7 +346,6 @@ test_files:
 - test/dummy/log/server.log
 - test/errors_test.rb
 - test/feature_test.rb
-- test/fields_test.rb
 - test/form_builder_test.rb
 - test/form_option_test.rb
 - test/form_test.rb
@@ -357,6 +353,7 @@ test_files:
 - test/inherit_test.rb
 - test/model_reflections_test.rb
 - test/model_validations_test.rb
+- test/module_test.rb
 - test/populate_test.rb
 - test/prepopulator_test.rb
 - test/rails/integration_test.rb
@@ -364,13 +361,10 @@ test_files:
 - test/readable_test.rb
 - test/readonly_test.rb
 - test/reform_test.rb
-- test/representer_test.rb
 - test/save_test.rb
-- test/scalar_test.rb
 - test/setup_test.rb
 - test/skip_if_test.rb
 - test/skip_setter_and_getter_test.rb
-- test/skip_unchanged_test.rb
 - test/test_helper.rb
 - test/twin_test.rb
 - test/uniqueness_test.rb

data/test/fields_test.rb

@@ -1,14 +0,0 @@
-require 'test_helper'
-
-class FieldsTest < MiniTest::Spec
-  describe "#new" do
-    it "accepts list of properties" do
-      fields = Reform::Contract::Fields.new([:name, :title])
-      fields.name.must_equal  nil
-      fields.title.must_equal nil
-
-      fields.title= "Planet X"
-      fields.title.must_equal "Planet X"
-    end
-  end
-end

data/test/representer_test.rb

@@ -1,47 +0,0 @@
-require 'test_helper'
-
-class RepresenterOptionsTest < MiniTest::Spec
-  subject { Reform::Representer::Options[] }
-
-  # don't maintain empty excludes until fixed in representable.
-  it { subject.exclude!([]).must_equal({:exclude=>[]}) }
-  it { subject.include!([]).must_equal({:include=>[]}) }
-
-  it { subject.exclude!([:title, :id]).must_equal({exclude: [:title, :id]}) }
-  it { subject.include!([:title, :id]).must_equal({include: [:title, :id]}) }
-
-
-  module Representer
-    include Representable::Hash
-    property :title
-    property :genre
-    property :id
-  end
-
-  it "representable" do
-    song = OpenStruct.new(title: "Title", genre: "Punk", id: 1)
-    puts Representer.prepare(song).to_hash(include: [:genre, :id], exclude: [:id]).inspect
-  end
-end
-
-
-class RepresenterTest < MiniTest::Spec
-  class SongRepresenter < Reform::Representer
-    property :title
-    property :name
-    property :genre
-  end
-
-  subject { SongRepresenter.new(Object.new) }
-
-  describe "#fields" do
-    it "returns all properties as strings" do
-      SongRepresenter.fields.must_equal(["title", "name", "genre"])
-    end
-
-    # allows block.
-    it do
-      SongRepresenter.fields { |dfn| dfn.name =~ /n/ }.must_equal ["name", "genre"]
-    end
-  end
-end

data/test/scalar_test.rb

@@ -1,167 +0,0 @@
-require 'test_helper'
-
-
-class SelfNestedTest < BaseTest
-  class Form < Reform::Form
-    property :title  do
-
-     end
-  end
-
-  let (:song) { Song.new("Crash And Burn") }
-  it do
-    Form.new(song)
-
-  end
-
-  it do
-    form = Form.new(song)
-
-    form.title = Class.new(Reform::Form) do
-      @form_name = "ficken"
-      def self.name # needed by ActiveModel::Validation and I18N.
-          @form_name
-        end
-
-      validates :model, :length => {:minimum => 10}
-
-
-      def update!(object)
-        model.replace(object)
-      end
-
-    end.new("Crash And Burn") # gets initialized with string (or image object, or whatever).
-
-    form.validate({"title" => "Teaser"})
-
-    form.errors.messages.must_equal({:"title.model"=>["is too short (minimum is 10 characters)"]})
-
-
-    # validation only kicks in when value present
-    form = Form.new(song)
-    form.validate({})
-    form.errors.messages.must_equal({})
-  end
-
-
-  class ImageForm < Reform::Form
-    # property :image, populate_if_empty: lambda { |object, args| object }  do
-    property :image, :scalar => true do
-      validates :size,  numericality: { less_than: 10 }
-      validates :length, numericality: { greater_than: 1 } # TODO: make better validators and remove AM::Validators at some point.
-
-      # FIXME: does that only work with representable 2.0?
-      # def size; model.size; end
-      # def type; model.class.to_s; end
-    end
-  end
-
-  AlbumCover = Struct.new(:image) do
-    include Saveable
-  end
-
-  # no image in params AND model.
-  it do
-    form = ImageForm.new(AlbumCover.new(nil))
-
-
-    form.validate({})
-    form.errors.messages.must_equal({})
-  end
-
-  # no image in params but in model.
-  it do
-    skip
-
-    # TODO: implement validations that only run when requested (only_validate_params: true)
-    form = ImageForm.new(AlbumCover.new("i don't know how i got here but i'm invalid"))
-
-
-    form.validate({})
-    form.errors.messages.must_equal({})
-  end
-
-  # image in params but NOT in model.
-  it do
-    form = ImageForm.new(AlbumCover.new(nil))
-
-    form.validate({"image" => "I'm OK!"})
-    puts form.inspect
-    form.errors.messages.must_equal({})
-    form.image.scalar.must_equal "I'm OK!"
-  end
-
-  # OK image, image existent.
-  it "hello" do
-    form = ImageForm.new(AlbumCover.new("nil"))
-
-    form.image.model.must_equal "nil"
-
-    form.validate({"image" => "I'm OK!"})
-    form.errors.messages.must_equal({})
-  end
-
-  # invalid image, image existent.
-  it "xx"do
-    form = ImageForm.new(AlbumCover.new("nil"))
-
-    form.validate({"image" => "I'm too long, is that a problem?"})
-    form.errors.messages.must_equal({:"image.size"=>["must be less than 10"]})
-  end
-
-
-
-  # validate string only if it's in params.
-  class StringForm < Reform::Form
-    property :image, :scalar => true do # creates "empty" form
-      validates :length => {:minimum => 10}
-    end
-  end
-
-
-  # validates when present.
-  # invalid
-  it do
-    form = StringForm.new(AlbumCover.new(nil))
-    form.validate("image" => "0x123").must_equal false
-    form.image.scalar.must_equal("0x123")
-    # TODO: errors, save
-
-    form.errors.messages.must_equal({:"image.scalar"=>["is too short (minimum is 10 characters)"]})
-  end
-
-  # valid
-  it "xxx" do
-    cover = AlbumCover.new(nil)
-
-    form = StringForm.new(cover)
-    form.validate("image" => "0x123456789").must_equal true
-
-    form.image.scalar.must_equal("0x123456789")
-    cover.image.must_equal nil
-
-    # errors
-    form.errors.messages.must_equal({})
-
-    # sync
-    form.sync
-    form.image.scalar.must_equal("0x123456789")
-    cover.image.must_equal "0x123456789" # that already writes it back.
-
-    # save
-    form.save
-    cover.image.must_equal "0x123456789" # #save writes back to model.
-
-    form.save do |hash|
-      hash.must_equal("image"=>"0x123456789")
-    end
-  end
-
-  # does not validate when absent (that's the whole point of this directive).
-  it do
-    form = StringForm.new(AlbumCover.new(nil))
-    form.validate({}).must_equal true
-  end
-
-  # DISCUSS: when AlbumCover.new("Hello").validate({}), does that fail?
-end

data/test/skip_unchanged_test.rb

@@ -1,86 +0,0 @@
-require 'test_helper'
-
-class SkipUnchangedTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    include Sync::SkipUnchanged
-    register_feature Sync::SkipUnchanged
-
-    property :id
-    property :title
-    property :image, sync: lambda { |value, *| model.image = "processed via :sync: #{value}" }#, virtual: true
-    property :band do
-      property :name, sync: lambda { |value, *| model.name = "band, processed: #{value}" }
-    end
-  end
-
-  Song = Struct.new(:id, :title, :image, :band) do
-    def id=(v); raise "never call me #{v.inspect}"; end
-  end
-  Band = Struct.new(:name)
-
-  let (:song) { Song.new(1, "Injection", Object, Band.new("Rise Against")) }
-
-  # skips when not present in hash + SkipUnchanged.
-  it("zhz") do
-    form = SongForm.new(song)
-
-    form.validate("title" => "Ready To Fall").must_equal true
-    form.sync
-
-    song.id.must_equal 1 # old
-    song.title.must_equal "Ready To Fall" # new!
-    song.image.must_equal Object # old
-    song.band.name.must_equal "Rise Against" # old
-  end
-
-  # uses :sync when present in params hash.
-  it do
-    form = SongForm.new(song)
-
-    form.validate("title" => "Ready To Fall", "image" => Module, "band" => {"name" => Class})
-    form.sync
-
-    song.id.must_equal 1
-    song.image.must_equal "processed via :sync: Module"
-    # nested works.
-    song.band.name.must_equal "band, processed: Class"
-  end
-end
-
-
-# :virtual is considered with SkipUnchanged
-class SkipUnchangedWithVirtualTest < MiniTest::Spec
-  Song = Struct.new(:title, :image, :band) do
-    def image=(v)
-      raise "i should not be called: #{v}"
-    end
-  end
-  Band = Struct.new(:name) do
-    def name=(v)
-      raise "i should not be called: #{v}"
-    end
-  end
-
-  let (:form) { HitForm.new(song) }
-  let (:song) { Song.new(nil, nil, Band.new) }
-
-  class HitForm < Reform::Form
-    include Sync::SkipUnchanged
-    register_feature Sync::SkipUnchanged
-
-    property :title
-    property :image, virtual: true
-    property :band do
-      property :name, virtual: true
-    end
-  end
-
-  it "hhy" do
-    form.validate("title" => "Full Throttle", "image" => "Funny photo of Steve Harris", "band" => {"name" => "Iron Maiden"}).must_equal true
-
-    form.sync
-    song.title.must_equal "Full Throttle"
-    song.image.must_equal nil
-    song.band.name.must_equal nil
-  end
-end