reform 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d8d0dc76658a132e15bea8612f35e7bfa77fb7b8
-  data.tar.gz: 31226f61d63c42b0a641b5592eb9714cb29bcff2
+  metadata.gz: 1a65ba4e715246d4be150394d9ee6fbcd34af3e8
+  data.tar.gz: 8c12fd32b88fd52a7c20cbe2cf84f5a6bbf01c8d
 SHA512:
-  metadata.gz: cde409c7fa9dc9054d05e2dafb7cf672abf8585d85b97f05f8f0d37b0d6c0de25e554775fb7a8a5eec57567977ba8ff03cdcb2276190c964e5f62c31259ce027
-  data.tar.gz: 70ac7b9421a13e0936ba9e149f611ad9f540b071f1f557d474a191c9c1d4a7e2a8fc126a9510a7fed65b1ef70078033ea4e8f34a6d9d2bc3dd9b74fbc61bd1c3
+  metadata.gz: 922aee7abf462ddcc510ffcce88f90a88d6450586df3c9eed27e174f5c6f73a8c6e43022147a6b730daa61fd61016bf3e97f620458546d5da5e5c6d30f134c68
+  data.tar.gz: b752b34d4a88ab8ac02f594635fc793ea3f7d0f39c139971d1d944d26109aa921196b46242febbd7b68ea478e87e8b12cd06b0fe1765391b427cbfd0c7216a39

data/CHANGES.md

@@ -1,3 +1,8 @@
+## 1.2.2
+
+* Use new `uber` to allow subclassing `reform_2_0!` forms.
+* Raise a better understandable deserialization error when the form is not populated properly. This error is so common that I overcame myself to add a dreaded `rescue` block in `Form#validate`.
+
 ## 1.2.1
 
 * Fixed a nasty bug where `ActiveModel` forms with form builder support wouldn't deserialize properly. A million Thanks to @karolsarnacki for finding this and providing an exemplary failing test. <3

data/README.md

@@ -4,6 +4,13 @@ Decouple your models from forms. Reform gives you a form object with validations
 
 Although reform can be used in any Ruby framework, it comes with [Rails support](#rails-integration), works with [simple_form and other form gems](#formbuilder-support), allows nesting forms to implement [has_one](#nesting-forms-1-1-relations) and [has_many](#nesting-forms-1-n-relations) relationships, can [compose a form](#compositions) from multiple objects and gives you [coercion](#coercion).
 
+<a href="https://leanpub.com/trailblazer">
+![](https://raw.githubusercontent.com/apotonick/trailblazer/master/doc/trb.jpg)
+</a>
+
+Reform is part of the [Trailblazer project](https://github.com/apotonick/trailblazer). Please [buy my book](https://leanpub.com/trailblazer) to support the development (and to learn all the cool stuff about Reform).
+
+
 ## Installation
 
 Add this line to your Gemfile:
@@ -664,7 +671,7 @@ When you want to show a value but skip processing it after submission the `:writ
 
 ```ruby
 class ProfileForm < Reform::Form
-  property :country, :writeable => false
+  property :country, writeable: false
 ```
 
 This time reform will query the model for the value by calling `model.country`.
@@ -683,7 +690,7 @@ form.save do |nested|
 A third alternative is to hide a field's value but write it to the database when syncing. This can be achieved using the `:readable` option.
 
 ```ruby
-property :credit_card_number, :readable => false
+property :credit_card_number, readable: false
 ```
 
 ## Validations From Models

data/lib/reform/contract/errors.rb

@@ -12,8 +12,6 @@ class Reform::Contract::Errors < ActiveModel::Errors
   # end
 
   def merge!(errors, prefix)
-    prefixes = prefix.join(".")
-
     # TODO: merge into AM.
     errors.messages.each do |field, msgs|
       unless field.to_sym == :base
@@ -36,4 +34,4 @@ class Reform::Contract::Errors < ActiveModel::Errors
   def to_s
     messages.inspect
   end
-end # Errors
+end # Errors

data/lib/reform/form/validate.rb

@@ -75,6 +75,9 @@ module Reform::Form::Validate
     update!(params)
 
     super() # run the actual validation on self.
+
+  rescue Representable::DeserializeError
+    raise DeserializeError.new("[Reform] Deserialize error: You probably called #validate without setting up your nested models. Check https://github.com/apotonick/reform#populating-forms-for-validation on how to use populators.")
   end
 
   # Some users use this method to pre-populate a form. Not saying this is right, but we'll keep
@@ -129,4 +132,7 @@ private
       dfn.merge!(:parse_filter => Changed.new) unless dfn[:form] # TODO: make changed? work for nested forms.
     end
   end
+
+  class DeserializeError < RuntimeError
+  end
 end

data/lib/reform/version.rb

@@ -1,3 +1,3 @@
 module Reform
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/reform.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency             "representable",  "~> 2.1.0"
   spec.add_dependency             "disposable",     "~> 0.0.5"
-  spec.add_dependency             "uber",           "~> 0.0.8"
+  spec.add_dependency             "uber",           "~> 0.0.11"
   spec.add_dependency             "activemodel"
   spec.add_development_dependency "bundler",        "~> 1.3"
   spec.add_development_dependency "rake"

data/test/validate_test.rb

@@ -37,6 +37,14 @@ class ValidateTest < BaseTest
     it { song2.title.must_equal nil }
   end
 
+  describe "not populated properly raises error" do
+    it do
+      assert_raises Reform::Form::Validate::DeserializeError do
+        AlbumForm.new(Album.new).validate("hit"   => {"title" => "Roxanne"})
+      end
+    end
+  end
+
   # TODO: the following tests go to populate_test.rb
   describe "manual setup with populator" do
     let (:form) {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reform
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Nick Sutterer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-07 00:00:00.000000000 Z
+date: 2014-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: representable
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.8
+        version: 0.0.11
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.8
+        version: 0.0.11
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement