reform-rails 0.2.0.rc2 → 0.2.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 9fbc01e9707fe8e853f1f6dfcae4bfeac3595a0d21cf06683a79cc013ef29fa0
-  data.tar.gz: 4b3ef3d982c952df0bee7d11af62bdf288f7b2253a743fd5a837421ce8bb38e7
+SHA1:
+  metadata.gz: 4f1ac1e0e188391ad063e8f61c6dafbc25554d8f
+  data.tar.gz: 6ddf5369a091079b68013c66c49bda0a4b7d1fe6
 SHA512:
-  metadata.gz: f9baab381f33d99fd9b798dba05de302e6fedb1d6c5348562ae6fd79232b8195f216c01b3b2499294c10abc4f88eb69035ba069012f798c0c594a3c70522e107
-  data.tar.gz: 7dc2393f4ad2a354e77031be6a4b1b4d4a99af95c6b6782ccec08ae6e3c70cc89393b727f74338c907027d8d990600025069022db0807c5212b1ce7c32e24cae
+  metadata.gz: 144fd8cb2e456c2af911bd69e7cacd9f198fd17626265cc2dd86296bcf098a03743de2f496b564bad73d4f92412c076290e113220a22398cdc4e03c8e38ac91d
+  data.tar.gz: 364f34a9e3ecfadd3fb4edd4e7489888b460f586fecc687fcb2ff75b2df35a74db6ac64818ad262c56641d24ccd1d520eb080299dec4a1d22a2f998b6d126c34

data/.gitignore

@@ -8,5 +8,7 @@
 /spec/reports/
 /tmp/
 *.gem
-
+*.sqlite3
+.byebug*
 *.log
+.rubocop-https*

data/.rubocop.yml

@@ -0,0 +1,3 @@
+inherit_from:
+    - https://raw.githubusercontent.com/trailblazer/meta/master/rubocop.yml
+    - .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,661 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-10-31 18:47:53 +1100 using RuboCop version 0.76.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 3
+# Configuration parameters: Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/DuplicatedGem:
+  Exclude:
+    - 'Gemfile'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/OrderedGems:
+  Exclude:
+    - 'Gemfile'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
+# Include: **/*.gemspec
+Gemspec/OrderedDependencies:
+  Exclude:
+    - 'reform-rails.gemspec'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: IndentationWidth.
+# SupportedStyles: outdent, indent
+Layout/AccessModifierIndentation:
+  EnforcedStyle: outdent
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/AlignHash:
+  Exclude:
+    - 'test/activemodel_validation_test.rb'
+    - 'test/form_builder_test.rb'
+    - 'test/test_helper.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith.
+# SupportedStylesAlignWith: either, start_of_block, start_of_line
+Layout/BlockAlignment:
+  Exclude:
+    - 'reform-rails.gemspec'
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/BlockEndNewline:
+  Exclude:
+    - 'test/active_model_custom_validation_translations_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/CommentIndentation:
+  Exclude:
+    - 'lib/reform/form/active_model/validations.rb'
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterGuardClause:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+    - 'lib/reform/form/active_model/model_validations.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterMagicComment:
+  Exclude:
+    - 'reform-rails.gemspec'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
+Layout/EmptyLineBetweenDefs:
+  Exclude:
+    - 'lib/reform/form/active_record.rb'
+    - 'lib/reform/form/mongoid.rb'
+
+# Offense count: 32
+# Cop supports --auto-correct.
+Layout/EmptyLines:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+    - 'lib/reform/form/active_model/validations.rb'
+    - 'test/active_model_custom_validation_translations_test.rb'
+    - 'test/active_model_test.rb'
+    - 'test/active_record_test.rb'
+    - 'test/activemodel_validation_test.rb'
+    - 'test/form_builder_test.rb'
+    - 'test/model_reflections_test.rb'
+    - 'test/mongoid_test.rb'
+    - 'test/multi_parameter_attributes_test.rb'
+    - 'test/test_helper.rb'
+    - 'test/unique_test.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: around, only_before
+Layout/EmptyLinesAroundAccessModifier:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+    - 'lib/reform/form/active_model/form_builder_methods.rb'
+    - 'lib/reform/form/multi_parameter_attributes.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, no_empty_lines
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+    - 'test/activemodel_validation_test.rb'
+    - 'test/custom_validation_test.rb'
+    - 'test/model_validations_test.rb'
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
+Layout/EmptyLinesAroundClassBody:
+  Exclude:
+    - 'lib/reform/form/active_model/model_validations.rb'
+    - 'test/active_record_test.rb'
+    - 'test/custom_validation_test.rb'
+    - 'test/model_validations_test.rb'
+    - 'test/mongoid_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
+Layout/EmptyLinesAroundModuleBody:
+  Exclude:
+    - 'lib/reform/form/active_model/model_validations.rb'
+    - 'lib/reform/form/active_model/validations.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: keyword, variable, start_of_line
+Layout/EndAlignment:
+  Exclude:
+    - 'test/active_model_test.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
+Layout/ExtraSpacing:
+  Exclude:
+    - 'test/active_model_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/FirstHashElementLineBreak:
+  Exclude:
+    - 'test/form_builder_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
+Layout/IndentFirstArgument:
+  Exclude:
+    - 'test/form_builder_test.rb'
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: normal, indented_internal_methods
+Layout/IndentationConsistency:
+  Exclude:
+    - 'test/active_model_test.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: Width, IgnoredPatterns.
+Layout/IndentationWidth:
+  Exclude:
+    - 'lib/reform/form/active_model/form_builder_methods.rb'
+    - 'test/active_model_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowDoxygenCommentStyle.
+Layout/LeadingCommentSpace:
+  Exclude:
+    - 'test/docs/**/*'
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/MultilineBlockLayout:
+  Exclude:
+    - 'test/active_model_custom_validation_translations_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: symmetrical, new_line, same_line
+Layout/MultilineMethodCallBraceLayout:
+  Exclude:
+    - 'test/form_builder_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/SpaceAfterColon:
+  Exclude:
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+Layout/SpaceAfterComma:
+  Exclude:
+    - 'lib/reform/form/active_model/model_reflections.rb'
+    - 'lib/reform/form/active_model/validations.rb'
+    - 'test/activemodel_validation_test.rb'
+    - 'test/test_helper.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/SpaceAfterNot:
+  Exclude:
+    - 'lib/reform/form/active_model/validations.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: space, no_space
+Layout/SpaceAroundEqualsInParameterDefault:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+    - 'lib/reform/form/active_model/form_builder_methods.rb'
+    - 'lib/reform/form/active_model/model_validations.rb'
+    - 'lib/reform/form/active_model/validations.rb'
+    - 'lib/reform/form/active_record.rb'
+    - 'lib/reform/form/mongoid.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/SpaceAroundKeyword:
+  Exclude:
+    - 'test/active_record_test.rb'
+
+# Offense count: 26
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Layout/SpaceAroundOperators:
+  Exclude:
+    - 'test/active_model_test.rb'
+    - 'test/active_record_test.rb'
+    - 'test/activemodel_validation_test.rb'
+    - 'test/form_builder_test.rb'
+    - 'test/form_test.rb'
+    - 'test/multi_parameter_attributes_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceBeforeBlockBraces:
+  Exclude:
+    - 'test/active_model_custom_validation_translations_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/SpaceBeforeComment:
+  Exclude:
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Layout/SpaceBeforeFirstArg:
+  Exclude:
+    - 'test/active_model_test.rb'
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 19
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideBlockBraces:
+  Exclude:
+    - 'test/activemodel_validation_test.rb'
+    - 'test/mongoid_test.rb'
+
+# Offense count: 34
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Exclude:
+    - 'test/active_model_validation_for_property_named_format_test.rb'
+    - 'test/activemodel_validation_test.rb'
+    - 'test/form_test.rb'
+    - 'test/model_validations_test.rb'
+    - 'test/multi_parameter_attributes_test.rb'
+    - 'test/unique_test.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: final_newline, final_blank_line
+Layout/TrailingBlankLines:
+  Exclude:
+    - 'lib/reform/form/active_model/form_builder_methods.rb'
+    - 'test/active_record_test.rb'
+    - 'test/model_validations_test.rb'
+
+# Offense count: 4
+Lint/AmbiguousOperator:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'lib/reform/form/multi_parameter_attributes.rb'
+
+# Offense count: 55
+Lint/ParenthesesAsGroupedExpression:
+  Exclude:
+    - 'test/active_model_test.rb'
+    - 'test/active_record_test.rb'
+    - 'test/activemodel_validation_test.rb'
+    - 'test/form_builder_test.rb'
+    - 'test/model_reflections_test.rb'
+    - 'test/mongoid_test.rb'
+    - 'test/multi_parameter_attributes_test.rb'
+    - 'test/test_helper.rb'
+    - 'test/unique_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/RedundantSplatExpansion:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowKeywordBlockArguments.
+Lint/UnderscorePrefixedVariableName:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'lib/reform/form/active_model/model_reflections.rb'
+    - 'lib/reform/form/orm.rb'
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/reform/form/active_model/validations.rb'
+
+# Offense count: 1
+Lint/UselessAssignment:
+  Exclude:
+    - 'test/unique_test.rb'
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 26
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 152
+
+# Offense count: 23
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 262
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'lib/reform/form/active_model/validations.rb'
+
+# Offense count: 2
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/reform/form/active_model/model_reflections.rb'
+    - 'test/model_reflections_test.rb'
+
+# Offense count: 6
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, normalcase, non_integer
+Naming/VariableNumber:
+  Exclude:
+    - 'test/unique_test.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'test/active_model_test.rb'
+    - 'test/active_record_test.rb'
+    - 'test/form_builder_test.rb'
+    - 'test/mongoid_test.rb'
+
+# Offense count: 21
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: braces, no_braces, context_dependent
+Style/BracesAroundHashParameters:
+  Exclude:
+    - 'lib/reform/form/active_model/model_validations.rb'
+    - 'test/active_model_validation_for_property_named_format_test.rb'
+    - 'test/active_record_test.rb'
+    - 'test/activemodel_validation_test.rb'
+    - 'test/form_test.rb'
+    - 'test/mongoid_test.rb'
+    - 'test/unique_test.rb'
+
+# Offense count: 8
+Style/CommentedKeyword:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+    - 'lib/reform/form/active_model/validations.rb'
+    - 'lib/reform/rails/railtie.rb'
+    - 'test/active_model_test.rb'
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+    - 'reform-rails.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Exclude:
+    - 'reform-rails.gemspec'
+
+# Offense count: 2
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/reform/form/active_model/model_validations.rb'
+    - 'test/custom_validation_test.rb'
+
+# Offense count: 2
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowIfModifier.
+Style/IfInsideElse:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/reform/form/active_model/model_validations.rb'
+    - 'lib/reform/form/multi_parameter_attributes.rb'
+    - 'lib/reform/form/validation/unique_validator.rb'
+    - 'test/activemodel_validation_test.rb'
+    - 'test/custom_validation_test.rb'
+
+# Offense count: 1
+Style/ImplicitRuntimeError:
+  Exclude:
+    - 'lib/reform/form/active_model/model_validations.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: line_count_dependent, lambda, literal
+Style/Lambda:
+  Exclude:
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 2
+Style/MethodCalledOnDoEndBlock:
+  Exclude:
+    - 'test/active_record_test.rb'
+    - 'test/mongoid_test.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
+Style/MethodDefParentheses:
+  Exclude:
+    - 'lib/reform/form/active_model/model_validations.rb'
+    - 'test/custom_validation_test.rb'
+
+# Offense count: 2
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/reform/form/active_model/validations.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: if, case, both
+Style/MissingElse:
+  Exclude:
+    - 'Gemfile'
+
+# Offense count: 2
+Style/MissingRespondToMissing:
+  Exclude:
+    - 'lib/reform/form/active_model/validations.rb'
+
+# Offense count: 1
+Style/MultilineTernaryOperator:
+  Exclude:
+    - 'lib/reform/form/multi_parameter_attributes.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'lib/reform/rails/version.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/reform/form/validation/unique_validator.rb'
+    - 'test/active_record_test.rb'
+    - 'test/mongoid_test.rb'
+
+# Offense count: 3
+# Configuration parameters: SuspiciousParamNames.
+# SuspiciousParamNames: options, opts, args, params, parameters
+Style/OptionHash:
+  Exclude:
+    - 'lib/reform/form/active_model.rb'
+    - 'lib/reform/form/active_record.rb'
+    - 'lib/reform/form/mongoid.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'reform-rails.gemspec'
+    - 'test/form_builder_test.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: short, verbose
+Style/PreferredHashMethods:
+  Exclude:
+    - 'lib/reform/form/active_model/form_builder_methods.rb'
+    - 'lib/reform/form/active_model/model_validations.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantInterpolation:
+  Exclude:
+    - 'test/active_model_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantPercentQ:
+  Exclude:
+    - 'reform-rails.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: return, return_nil
+Style/ReturnNil:
+  Exclude:
+    - 'lib/reform/form/multi_parameter_attributes.rb'
+
+# Offense count: 7
+Style/Send:
+  Exclude:
+    - 'lib/reform/form/active_model/model_reflections.rb'
+    - 'lib/reform/form/active_model/validations.rb'
+    - 'lib/reform/form/orm.rb'
+    - 'lib/reform/form/validation/unique_validator.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: only_raise, only_fail, semantic
+Style/SignalException:
+  Exclude:
+    - 'lib/reform/form/active_model/model_validations.rb'
+
+# Offense count: 133
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, MinSize, WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  Exclude:
+    - 'test/activemodel_validation_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/ZeroLengthPredicate:
+  Exclude:
+    - 'test/mongoid_test.rb'

data/.travis.yml

@@ -1,30 +1,38 @@
 language: ruby
 cache: bundler
-
+before_install:
+  - gem update --system
+  - gem install bundler
 rvm:
-  - 2.1.10
-  - 2.2.5
-  - 2.3.1
-  - 2.4.0
+    - 2.4.6
+    - 2.5.5
+    - 2.6.3
 services:
   - mongodb
 env:
-  - "RAILS_VERSION=3.2.0"
-  - "RAILS_VERSION=4.0.0"
-  - "RAILS_VERSION=4.1.0"
-  - "RAILS_VERSION=4.2.0"
-  - "RAILS_VERSION=5.0.0"
+  - "RAILS_VERSION=6.0.0"
+  - "RAILS_VERSION=5.2.0"
   - "RAILS_VERSION=5.1.0"
+  - "RAILS_VERSION=5.0.0"
+  - "RAILS_VERSION=4.2.0"
+  - "RAILS_VERSION=4.1.0"
+  - "RAILS_VERSION=4.0.0"
 matrix:
   fast_finish: true
   exclude:
-    - rvm: 2.1.10
-      env: "RAILS_VERSION=5.1.0"
-    - rvm: 2.1.10
-      env: "RAILS_VERSION=5.0.0"
-    - rvm: 2.4.0
-      env: "RAILS_VERSION=3.2.0"
-    - rvm: 2.4.0
+    - rvm: 2.4.6
+      env: "RAILS_VERSION=4.0.0"
+    - rvm: 2.4.6
+      env: "RAILS_VERSION=4.1.0"
+    - rvm: 2.4.6
+      env: "RAILS_VERSION=6.0.0"
+
+    - rvm: 2.5.5
+      env: "RAILS_VERSION=4.0.0"
+    - rvm: 2.5.5
+      env: "RAILS_VERSION=4.1.0"
+
+    - rvm: 2.6.3
       env: "RAILS_VERSION=4.0.0"
-    - rvm: 2.4.0
-      env: "RAILS_VERSION=4.1.0"
+    - rvm: 2.6.3
+      env: "RAILS_VERSION=4.1.0"

data/CHANGES.md

@@ -7,8 +7,13 @@
 * fix bug in uniqueness validation where form has different attribute name to column
 * improve handling of persisted records in uniqueness validator
 * remove params.merge! as it's deprecated in rails 5
-* update to support reform 2.3, the new API means that `errors.add` is delegated to ActiveModel::Errors so we have support for rails 5 :descriptions without having to do anything !Yey!
+* update to support reform 2.3, the new API means that `errors.add` is delegated to ActiveModel::Errors to support rails 5
 * Fix nested form validation (#53)
+* Errors supports symbol and string lookup (PR #77)
+* Implement respond_to that delegates to AMV errors (PR #78)
+
+# 0.1.8
+* Drop support to mongoid < 4.
 
 # 0.1.7 (0.1.6 Yanked)
 

data/Gemfile

@@ -1,17 +1,35 @@
-source 'https://rubygems.org'
+git_source(:github) do |repo_name|
+  repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/")
+  "https://github.com/#{repo_name}.git"
+end
 
-# Specify your gem's dependencies in reform-rails.gemspec
+source "https://rubygems.org"
 gemspec
 
-# gem "reform", github: "trailblazer/reform"
-# gem "reform", path: "../reform"
+gem 'pry-byebug'
+gem "minitest-line"
+
+case ENV["GEMS_SOURCE"]
+  when "local"
+    gem "reform", path: "../reform"
+  when "github"
+    gem "reform", github: "trailblazer/reform"
+end
 
-rails_version = ENV['RAILS_VERSION'] || '4.2'
+rails_version = ENV.fetch("RAILS_VERSION", "5.2.0")
 
 # bored of wrestling with rails...
-if rails_version == '4.0'
-  gem 'mongoid', '~> 4'
+if rails_version.include? "4.0"
+  gem "mongoid", "~> 4"
+else
+  gem("mongoid", "< 7.0") unless rails_version.include?('6.0')
 end
 
-gem "railties", "~> #{rails_version}"
 gem "activerecord", "~> #{rails_version}"
+gem "railties", "~> #{rails_version}"
+if rails_version.include?('6.0')
+  gem "sqlite3", "~> 1.4"
+else
+  gem "sqlite3", "~> 1.3", "< 1.4"
+end
+puts "Rails version #{rails_version}"

data/lib/reform/active_record.rb

@@ -1,4 +1,4 @@
-require "reform/form/active_model"
 require "reform/form/orm"
+require "reform/form/active_model"
 require "reform/form/active_record"
 require "reform/form/active_model/model_reflections" # only load this in AR context as simple_form currently is bound to AR.

data/lib/reform/form/active_model/validations.rb

@@ -52,12 +52,24 @@ module Reform
         @amv_errors
       end
 
+      def custom_errors
+        # required to keep update the ActiveModel::Errors#details used to test for
+        # added errors ActiveModel::Errors#added? and needs to be inside this block!
+        super.each do |custom_error|
+          errors = custom_error.errors
+          # CustomError build always the errors with an hash where the value is an array
+          errors.values.first.each do |value|
+            @amv_errors.add(errors.keys.first, value)
+          end
+        end
+      end
+
       def validate!(params, pointers=[])
         @amv_errors = ActiveModel::Errors.new(self)
 
         super.tap do
           # @fran: super ugly hack thanks to the shit architecture of AMV. let's drop it in 3.0 and move on!
-          all_errors = @result.instance_variable_get(:@results)
+          all_errors = @result.to_results
           nested_errors = @result.instance_variable_get(:@failure)
 
           @result = Reform::Contract::Result.new(all_errors, [nested_errors].compact)
@@ -121,7 +133,7 @@ module Reform
           end
 
           def [](k)
-            super || []
+            super(k.to_sym) || []
           end
 
           # rails expects this to return a stringified hash of the messages
@@ -129,9 +141,29 @@ module Reform
             messages.to_s
           end
 
+          def add(key, error_text)
+            # use rails magic to get the correct error_text and make sure we still update details and fields
+            text = @amv_errors.add(key, error_text)
+
+            # using error_text instead of text to either keep the symbol which will be
+            # magically replaced with the translate or directly the string - this is also
+            # required otherwise in the custom_errors method we will add the actual message in the
+            # ActiveModel::Errors#details which is not correct if a symbol was passed here
+            Reform::Contract::CustomError.new(key, error_text, @result.to_results)
+
+            # but since messages method is actually already defined in `Reform::Contract::Result::Errors
+            # we need to update the @dotted_errors instance variable to add or merge a new error
+            @dotted_errors.key?(key) ? @dotted_errors[key] |= text : @dotted_errors[key] = text
+            instance_variable_set(:@dotted_errors, @dotted_errors)
+          end
+
           def method_missing(m, *args, &block)
             @amv_errors.send(m, *args, &block) # send all methods to the AMV errors, even privates.
           end
+
+          def respond_to?(method)
+            @amv_errors.respond_to?(method) ? true : super
+          end
         end
       end
 

data/lib/reform/form/active_record.rb

@@ -1,5 +1,3 @@
-require "reform/form/orm"
-
 module Reform::Form::ActiveRecord
   def self.included(base)
     base.class_eval do

data/lib/reform/form/mongoid.rb

@@ -1,3 +1,5 @@
+gem 'mongoid', ">= 4.0"
+
 module Reform::Form::Mongoid
   def self.included(base)
     base.class_eval do
@@ -18,20 +20,7 @@ module Reform::Form::Mongoid
     end
   end
 
-
-  def self.mongoid_namespace
-    if mongoid_is_4_or_more?
-      'Validatable'
-    else
-      'Validations'
-    end
-  end
-
-  def self.mongoid_is_4_or_more?
-    Mongoid::VERSION.split('.').first.to_i >= 4
-  end
-
-  UniquenessValidator = Class.new("::Mongoid::#{mongoid_namespace}::UniquenessValidator".constantize) do
+  UniquenessValidator = Class.new("::Mongoid::Validatable::UniquenessValidator".constantize) do
     include Reform::Form::ORM::UniquenessValidator
   end
 end

data/lib/reform/form/orm.rb

@@ -19,7 +19,10 @@ module Reform::Form::ORM
 
       @klass = record.class # this is usually done in the super-sucky #setup method.
       super(record).tap do |res|
-        form.errors.add(property, record.errors.first.last) if record.errors.present?
+        if record.errors.present?
+          error = self.class.name.include?("Mongoid") ? record.errors.first.last : :taken
+          form.errors.add(property, error)
+        end
       end
     end
   end

data/lib/reform/mongoid.rb

@@ -1,4 +1,4 @@
-require 'reform/form/active_model'
 require 'reform/form/orm'
+require 'reform/form/active_model'
 require 'reform/form/mongoid'
 require 'reform/form/active_model/model_reflections' # only load this in AR context as simple_form currently is bound to AR.

data/lib/reform/rails.rb

@@ -1,4 +1,5 @@
 require "reform/rails/version"
+require 'reform'
 require "reform/rails/railtie"
 
 module Reform

data/lib/reform/rails/railtie.rb

@@ -6,7 +6,6 @@ module Reform
       initializer "reform.form_extensions", after: :load_config_initializers do
         validations = config.reform.validations || :active_model
 
-        require "reform"
         require "reform/form/multi_parameter_attributes"
 
         if validations == :active_model
@@ -27,14 +26,14 @@ module Reform
         require "reform/form/active_model/model_validations"
         require "reform/form/active_model/validations"
 
-        require "reform/active_record" if defined?(ActiveRecord)
-        require "reform/mongoid" if defined?(Mongoid)
+        require "reform/active_record" if defined?(::ActiveRecord)
+        require "reform/mongoid" if defined?(::Mongoid)
 
         Reform::Form.class_eval do
           include Reform::Form::ActiveModel
           include Reform::Form::ActiveModel::FormBuilderMethods
-          include Reform::Form::ActiveRecord if defined?(ActiveRecord)
-          include Reform::Form::Mongoid if defined?(Mongoid)
+          include Reform::Form::ActiveRecord if defined?(::ActiveRecord)
+          include Reform::Form::Mongoid if defined?(::Mongoid)
           include Reform::Form::ActiveModel::Validations
         end
       end

data/lib/reform/rails/version.rb

@@ -1,5 +1,5 @@
 module Reform
   module Rails
-    VERSION = "0.2.0.rc2"
+    VERSION = "0.2.0.rc3"
   end
 end

data/reform-rails.gemspec

@@ -14,19 +14,12 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/trailblazer/reform-rails"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+                         f.match(%r{^(test/|spec/|features/|database.sqlite3)})
+                       end
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_dependency "reform", ">= 2.3.0.rc1", "< 3.0.0"
   spec.add_dependency "activemodel", ">= 3.2"
-
-  spec.add_development_dependency "rails"
-  spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "minitest"
-  spec.add_development_dependency "actionpack"
-  spec.add_development_dependency "activerecord"
-  spec.add_development_dependency "mongoid"
-  spec.add_development_dependency "sqlite3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reform-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.0.rc2
+  version: 0.2.0.rc3
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-09 00:00:00.000000000 Z
+date: 2019-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: reform
@@ -44,118 +44,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
-- !ruby/object:Gem::Dependency
-  name: rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: actionpack
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: activerecord
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mongoid
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Automatically load and include all common Reform features for a standard
   Rails environment.
 email:
@@ -165,13 +53,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CHANGES.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- database.sqlite3
 - lib/reform/active_record.rb
 - lib/reform/form/active_model.rb
 - lib/reform/form/active_model/form_builder_methods.rb
@@ -208,7 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.6.14.3
 signing_key: 
 specification_version: 4
 summary: Automatically load and include all common Rails form features.