referral 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e9c718aeaa911a43d9f908ff6627f237b4d060d24c70ffe5266f997acc13e6d
-  data.tar.gz: 0e37e4bc4ea3b095ba44ba3a89398940e56e7672302ce1ee7b856a1312f59b63
+  metadata.gz: bbc3ccfe2fc13d49b4fe81db0b450452485ff2ee6a76d05c4ab04368df20f56b
+  data.tar.gz: ecdfede161422d2a90f199f718d80ade1eb644c520e5929c71643272295e0728
 SHA512:
-  metadata.gz: a5eeb557ef3127b448d868a292f0eca478c66c918d77abace17c0141a75795816a9ea3acc86db29ca82a6199cdc2cd86bc0cf1ddbcca088a4ed5c62b4d91f534
-  data.tar.gz: 011312e247b8aeca7acfe0a200c1c14e8eb799daac38d645ec30bef5a39659bd26e0760320fd82db64c6a35d8ded79dfc0f2e944a80f267745bd68a94236846e
+  metadata.gz: 10da1ed6a90542750ec6f77ed4258017432f782245fc159dc30ec24c5ac139e12f43ea273260650c810338fdeb4367c6dc1a42aff397d29105935584960d7242
+  data.tar.gz: 0b8e3682cd38e2acad49887aaddd026c0d85bbe686e39923163b8f87f4f65a132d3ef6086411d2c7959d2eb66475b8d7256f6724c9e09cc50977be22efefecee

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    referral (0.0.2)
+    referral (0.0.3)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -120,6 +120,8 @@ on there while you're at it:
 
 <img width="1272" alt="Screen Shot 2019-06-27 at 1 27 42 PM" src="https://user-images.githubusercontent.com/79303/60287234-64560a00-98df-11e9-9fed-46c68fdaac58.png">
 
+> It is important to note that Numbers, like earlier versions of Excel, uses an unsigned Integer for row numbering that limits the number of shown rows to ~65,000. On larger codebases, referral may create more references than this. LibreOffice and newer versions of Excel do not have this limitation on viewing.
+
 ### Recipe: detect references you forgot to update
 
 When working in a large codebase, it can be really tough to figure out if you
@@ -141,7 +143,7 @@ test/lib/splits_furigana_test.rb 56 634edc04 searls@gmail.com 2017-09-04T13:34:0
 ```
 
 [**Warning:** running `git-blame` on each file is, of course, a bit slow. Running
-this command on the [KameSame](https://kamesame.com) codebase took 3 seconds of
+this command on the [KameSame](https://www.kamesame.com/) codebase took 3 seconds of
 wall-time, compared to 0.7 seconds by default.]
 
 And it gets better! Since we're already running `blame`, why not sort every line

data/lib/referral/matches_token_names.rb

@@ -12,7 +12,7 @@ module Referral
     end
 
     def self.names_from_token(token)
-      token.fully_qualified.reject { |t| t.name.nil? }.map { |t| t.name.to_s }
+      token.full_name_tokens.reject { |t| t.name.nil? }.map { |t| t.name.to_s }
     end
 
     def self.names_from_query(query)

data/lib/referral/sorts_tokens.rb

@@ -8,9 +8,9 @@ module Referral
       }
     },
     scope: ->(tokens) {
-      max_length = tokens.map { |t| t.fully_qualified.size }.max
+      max_length = tokens.map { |t| t.scope_and_names.size }.max
       tokens.sort_by { |token|
-        names = token.fully_qualified.map { |fq| fq.name.to_s }
+        names = token.scope_and_names.map { |fq| fq.name.to_s }
         [
           *names.fill("", names.size...max_length),
           token.file, token.line, token.column, token.id,

data/lib/referral/value/token.rb

@@ -7,27 +7,38 @@ module Referral
       keyword_init: true
     )
 
-      def fully_qualified
+      def scope_and_names
         [
-          *parent&.fully_qualified,
-          *identity_components,
+          *parent&.scope_and_names,
+          *literal_name_tokens,
         ].compact
       end
 
-      def full_name
-        join_names(fully_qualified)
-      end
-
       def scope
         return "" unless parent
         parent.full_name
       end
 
+      def full_name
+        join_names(full_name_tokens)
+      end
+
+      def full_name_tokens
+        [
+          *(include_parents_in_full_name? ? parent&.scope_and_names : []),
+          *literal_name_tokens,
+        ].compact
+      end
+
       def literal_name
-        if identifiers.empty?
-          name.to_s
+        join_names(literal_name_tokens)
+      end
+
+      def literal_name_tokens
+        if identifiers && !identifiers.empty?
+          identifiers
         else
-          join_names(identifiers)
+          [self]
         end
       end
 
@@ -45,6 +56,10 @@ module Referral
 
       protected
 
+      def include_parents_in_full_name?
+        node_type.token_type == :definition && node_type.good_parent == true
+      end
+
       def join_names(tokens)
         tokens.reduce("") { |s, token|
           next s unless token.name
@@ -55,14 +70,6 @@ module Referral
           end
         }
       end
-
-      def identity_components
-        if identifiers && !identifiers.empty?
-          identifiers
-        else
-          [self]
-        end
-      end
     end
   end
 end

data/lib/referral/version.rb

@@ -1,3 +1,3 @@
 module Referral
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: referral
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Justin Searls
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-28 00:00:00.000000000 Z
+date: 2019-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler