reek 5.4.0 → 5.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c7a7193dd76b11cd88c3e3f031784a0bb54f3bcaa35a4e3b430dd550749facc
-  data.tar.gz: 0d2f96071b27301ebbd2b3ff82b8e1fbbde2aaf647125e3903d017074c4d061b
+  metadata.gz: 2cc4e5c07f939e121b14b1b9250411d0e83fce7e936271328731500cf8a93a8e
+  data.tar.gz: 167f4022f6d3120e9dffb9eb3828f756755790c13c1e70c09f46a20dd1dc23c7
 SHA512:
-  metadata.gz: cc75695b17d58bf820bf6b874e747c3a7f81c43b0e8c80a33144118b1dbbbb0e0cd294ae386026937ee0799d0a7fa7cd12c65470bfd217faaa9c66dcbd22a03c
-  data.tar.gz: cb9bfef6dd9f799c2f2733b020952909010f489b1cf621d64828a2982cc64ea912211a7bf0f9e21fc1246ce4068edb5bb1571acdd16445df6ddebca2c3c9a84b
+  metadata.gz: 540da16a41f3939e187389759bfb9893e56f0cdf9f9dee01b09e924ba412c6f42210584b07613122dfbaed26f75991ac2b411a7db78227e175b2aae2dc289db0
+  data.tar.gz: a354ce529e870797c32b2608f1e05facfbdeb52f8e4fe9de5280b42b769dd2ddbe740a0c374f2cbdc1cc32d5254eb51037861c9149cc4ef427545ea626137ea1

data/.rubocop.yml

@@ -2,6 +2,7 @@ inherit_from: .rubocop_todo.yml
 
 require:
   - rubocop-rspec
+  - rubocop-performance
 
 AllCops:
   Exclude:

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+## 5.4.1 (2019-11-12)
+
+* (Filipe Esperandio) Bump base image to a more recent ruby version
+* (Fernando Contreras) Add quotes inside directory configuration
+
 ## 5.4.0 (2019-04-24)
 
 * (Philippe Bernery) Enable regex for directory directives.

data/Dockerfile

@@ -3,7 +3,7 @@
 # Build and run via:
 #   docker build -t codeclimate/codeclimate-reek . && docker run codeclimate/codeclimate-reek
 
-FROM ruby:2.3.3-alpine
+FROM ruby:2.6.0-alpine
 
 MAINTAINER The Reek core team
 

data/Gemfile

@@ -7,19 +7,20 @@ ruby RUBY_VERSION
 group :development do
   gem 'aruba',               '~> 0.14.8'
   gem 'cucumber',            '~> 3.0'
-  gem 'factory_bot',         '~> 5.0'
+  gem 'factory_bot',         '~> 5.0', '!= 5.1.0'
   gem 'kramdown',            '~> 2.1'
   gem 'kramdown-parser-gfm', '~> 1.0'
-  gem 'rake',                '~> 12.0'
+  gem 'rake',                '~> 13.0'
   gem 'rspec',               '~> 3.0'
   gem 'rspec-benchmark',     '~> 0.5.0'
-  gem 'rubocop',             '~> 0.67.2'
-  gem 'rubocop-rspec',       '~> 1.32.0'
-  gem 'simplecov',           '~> 0.16.1'
+  gem 'rubocop',             '~> 0.75.0'
+  gem 'rubocop-performance', '~> 1.5.0'
+  gem 'rubocop-rspec',       '~> 1.36.0'
+  gem 'simplecov',           '~> 0.17.0'
   gem 'yard',                '~> 0.9.5'
 
   platforms :mri do
-    gem 'redcarpet', '~> 3.4.0'
+    gem 'redcarpet', '~> 3.4'
   end
 end
 

data/README.md

@@ -317,7 +317,7 @@ directories:
   "web_app/app/controllers":
     NestedIterators:
       enabled: false
-  "web_app/app/helpers**:
+  "web_app/app/helpers**":
     UtilityFunction:
       enabled: false
   "web_app/lib/**/test/**":

data/features/command_line_interface/options.feature

@@ -43,7 +43,7 @@ Feature: Reek can be controlled using command-line options
           -c, --config FILE                Read configuration options from FILE
               --smell SMELL                Only look for a specific smell.
                                            Call it like this: reek --smell MissingSafeMethod source.rb
-                                           Check out https://github.com/troessner/reek/blob/v5.4.0/docs/Code-Smells.md for a list of smells
+                                           Check out https://github.com/troessner/reek/blob/v5.4.1/docs/Code-Smells.md for a list of smells
               --stdin-filename FILE        When passing code in via pipe, assume this filename when checking file or directory rules in the config.
 
       Generate a todo list:
@@ -120,5 +120,5 @@ Feature: Reek can be controlled using command-line options
       UnusedPrivateMethod
       UtilityFunction
 
-      Check out https://github.com/troessner/reek/blob/v5.4.0/docs/Code-Smells.md for a details on each detector
+      Check out https://github.com/troessner/reek/blob/v5.4.1/docs/Code-Smells.md for a details on each detector
       """

data/features/reports/json.feature

@@ -24,7 +24,7 @@ Feature: Report smells using simple JSON layout
               "context": "Smelly#x",
               "lines": [ 4 ],
               "message": "has the name 'x'",
-              "documentation_link": "https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Method-Name.md",
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.4.1/docs/Uncommunicative-Method-Name.md",
               "name": "x"
           },
           {
@@ -33,7 +33,7 @@ Feature: Report smells using simple JSON layout
               "context": "Smelly#x",
               "lines": [ 5 ],
               "message": "has the variable name 'y'",
-              "documentation_link": "https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Variable-Name.md",
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.4.1/docs/Uncommunicative-Variable-Name.md",
               "name": "y"
           }
       ]
@@ -53,7 +53,7 @@ Feature: Report smells using simple JSON layout
                   1
               ],
               "message": "has no descriptive comment",
-              "documentation_link": "https://github.com/troessner/reek/blob/v5.4.0/docs/Irresponsible-Module.md"
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.4.1/docs/Irresponsible-Module.md"
           }
       ]
       """

data/features/reports/reports.feature

@@ -182,8 +182,8 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.4.1/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.4.1/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:
@@ -209,8 +209,8 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Method-Name.md]
-        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Variable-Name.md]
+        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.4.1/docs/Uncommunicative-Method-Name.md]
+        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.4.1/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:

data/features/reports/yaml.feature

@@ -25,7 +25,7 @@ Feature: Report smells using simple YAML layout
         smell_type: UncommunicativeMethodName
         source: smelly.rb
         name: x
-        documentation_link: https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Method-Name.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.4.1/docs/Uncommunicative-Method-Name.md
       - context: Smelly#x
         lines:
         - 5
@@ -33,7 +33,7 @@ Feature: Report smells using simple YAML layout
         smell_type: UncommunicativeVariableName
         source: smelly.rb
         name: y
-        documentation_link: https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Variable-Name.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.4.1/docs/Uncommunicative-Variable-Name.md
       """
 
   Scenario: Indicate smells and print them as yaml when using STDIN
@@ -48,5 +48,5 @@ Feature: Report smells using simple YAML layout
         lines:
         - 1
         message: has no descriptive comment
-        documentation_link: https://github.com/troessner/reek/blob/v5.4.0/docs/Irresponsible-Module.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.4.1/docs/Irresponsible-Module.md
       """

data/lib/reek/cli/command/todo_list_command.rb

@@ -40,13 +40,18 @@ module Reek
         def groups
           @groups ||=
             begin
-              todos = smells.group_by(&:smell_class).map do |smell_class, smells_for_class|
+              todos = DetectorRepository.smell_types.map do |smell_class|
+                smells_for_class = grouped_smells[smell_class.smell_type] or next
                 smell_class.todo_configuration_for(smells_for_class)
               end
-              todos.inject(&:merge)
+              todos.compact.inject(&:merge)
             end
         end
 
+        def grouped_smells
+          @grouped_smells ||= smells.group_by(&:smell_type)
+        end
+
         # :reek:FeatureEnvy
         def write_to_file
           File.open(DEFAULT_CONFIGURATION_FILE_NAME, 'w') do |configuration_file|

data/lib/reek/smell_detectors/base_detector.rb

@@ -79,7 +79,7 @@ module Reek
       end
 
       def smell_warning(**options)
-        SmellWarning.new(self,
+        SmellWarning.new(smell_type,
                          source: expression.source,
                          context: context.full_name,
                          lines: options.fetch(:lines),

data/lib/reek/smell_detectors/too_many_constants.rb

@@ -35,7 +35,7 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       def sniff
-        count = context.local_nodes(:casgn).reject(&:defines_module?).length
+        count = context.local_nodes(:casgn).count { |it| !it.defines_module? }
 
         return [] if count <= max_allowed_constants
 

data/lib/reek/smell_warning.rb

@@ -15,22 +15,30 @@ module Reek
     extend Forwardable
 
     # @public
-    attr_reader :context, :lines, :message, :parameters, :smell_detector, :source
-    def_delegators :smell_detector, :smell_type
-
+    attr_reader :context, :lines, :message, :parameters, :smell_type, :source
+
+    # @param smell_type [String] type of detected smell; corresponds to
+    #   detector#smell_type
+    # @param context [String] name of the context in which the smell occured
+    # @param lines [Array<Integer>] list of lines on which the smell occured
+    # @param message [String] text describing the smell in more detail
+    # @param source [String] name of the source (e.g., the file name) in which
+    #   the smell occured
+    # @param parameters [Hash] smell-specific parameters
+    #
     # @note When using Reek's public API, you should not create SmellWarning
     #   objects yourself. This is why the initializer is not part of the
     #   public API.
     #
     # @quality :reek:LongParameterList { max_params: 6 }
-    def initialize(smell_detector, context: '', lines:, message:,
+    def initialize(smell_type, context: '', lines:, message:,
                    source:, parameters: {})
-      @smell_detector = smell_detector
-      @source         = source
-      @context        = context.to_s
-      @lines          = lines
-      @message        = message
-      @parameters     = parameters
+      @smell_type = smell_type
+      @source     = source
+      @context    = context.to_s
+      @lines      = lines
+      @message    = message
+      @parameters = parameters
 
       freeze
     end
@@ -64,10 +72,6 @@ module Reek
       "#{smell_type}: #{context} #{message}"
     end
 
-    def smell_class
-      smell_detector.class
-    end
-
     def explanatory_link
       DocumentationLink.build(smell_type)
     end

data/lib/reek/version.rb

@@ -8,6 +8,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '5.4.0'
+    STRING = '5.4.1'
   end
 end

data/spec/factories/factories.rb

@@ -4,29 +4,18 @@ require_relative '../../lib/reek/smell_warning'
 require_relative '../../lib/reek/cli/options'
 
 FactoryBot.define do
-  factory :smell_detector, class: Reek::SmellDetectors::BaseDetector do
-    skip_create
-    transient do
-      smell_type { 'FeatureEnvy' }
-    end
-
-    initialize_with do
-      ::Reek::SmellDetectors.const_get(smell_type).new
-    end
-  end
-
   factory :smell_warning, class: Reek::SmellWarning do
     skip_create
-    smell_detector
-    context { 'self' }
 
+    smell_type { 'FeatureEnvy' }
     source { 'dummy_file' }
     lines { [42] }
     message { 'smell warning message' }
     parameters { {} }
+    context { 'self' }
 
     initialize_with do
-      new(smell_detector,
+      new(smell_type,
           source: source,
           context: context,
           lines: lines,

data/spec/reek/cli/application_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Reek::CLI::Application do
           described_class.new ['--foo']
         end
       end
-      expect(call).to raise_error(SystemExit) do |error|
+      expect(&call).to raise_error(SystemExit) do |error|
         expect(error.status).to eq Reek::CLI::Status::DEFAULT_ERROR_EXIT_CODE
       end
     end

data/spec/reek/examiner_spec.rb

@@ -6,6 +6,7 @@ RSpec.shared_examples_for 'no smells found' do
   it 'is not smelly' do
     expect(examiner).not_to be_smelly
   end
+
   it 'finds no smells' do
     expect(examiner.smells.length).to eq(0)
   end

data/spec/reek/report/code_climate/code_climate_fingerprint_spec.rb

@@ -9,11 +9,11 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
       let(:expected_fingerprint) { 'e68badd29db51c92363a7c6a2438d722' }
       let(:warning) do
         build(:smell_warning,
-              smell_detector: Reek::SmellDetectors::UtilityFunction.new,
-              context:        'alfa',
-              message:        "doesn't depend on instance state (maybe move it to another class?)",
-              lines:          lines,
-              source:         'a/ruby/source/file.rb')
+              smell_type: 'UtilityFunction',
+              context:    'alfa',
+              message:    "doesn't depend on instance state (maybe move it to another class?)",
+              lines:      lines,
+              source:     'a/ruby/source/file.rb')
       end
 
       context 'with code at a specific location' do
@@ -36,11 +36,11 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
     context 'when the fingerprint should not be computed' do
       let(:warning) do
         build(:smell_warning,
-              smell_detector: Reek::SmellDetectors::ManualDispatch.new,
-              context:        'Alfa#bravo',
-              message:        'manually dispatches method call',
-              lines:          [4],
-              source:         'a/ruby/source/file.rb')
+              smell_type: 'ManualDispatch',
+              context:    'Alfa#bravo',
+              message:    'manually dispatches method call',
+              lines:      [4],
+              source:     'a/ruby/source/file.rb')
       end
 
       it 'returns nil' do
@@ -51,12 +51,12 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
     context 'when the smell warning has only identifying parameters' do
       let(:warning) do
         build(:smell_warning,
-              smell_detector: Reek::SmellDetectors::ClassVariable.new,
-              context:        'Alfa',
-              message:        "declares the class variable '@@#{name}'",
-              lines:          [4],
-              parameters:     { name: "@@#{name}" },
-              source:         'a/ruby/source/file.rb')
+              smell_type: 'ClassVariable',
+              context:    'Alfa',
+              message:    "declares the class variable '@@#{name}'",
+              lines:      [4],
+              parameters: { name: "@@#{name}" },
+              source:     'a/ruby/source/file.rb')
       end
 
       context 'when the name is one thing' do
@@ -81,12 +81,12 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
     context 'when the smell warning has identifying and non-identifying parameters' do
       let(:warning) do
         build(:smell_warning,
-              smell_detector: Reek::SmellDetectors::DuplicateMethodCall.new,
-              context:        "Alfa##{name}",
-              message:        "calls '#{name}' #{count} times",
-              lines:          lines,
-              parameters:     { name: "@@#{name}", count: count },
-              source:         'a/ruby/source/file.rb')
+              smell_type: 'DuplicateMethodCall',
+              context:    "Alfa##{name}",
+              message:    "calls '#{name}' #{count} times",
+              lines:      lines,
+              parameters: { name: "@@#{name}", count: count },
+              source:     'a/ruby/source/file.rb')
       end
 
       context 'when the parameters are provided' do

data/spec/reek/report/code_climate/code_climate_formatter_spec.rb

@@ -5,11 +5,11 @@ RSpec.describe Reek::Report::CodeClimateFormatter do
   describe '#render' do
     let(:warning) do
       build(:smell_warning,
-            smell_detector: Reek::SmellDetectors::UtilityFunction.new,
-            context:        'context foo',
-            message:        'message bar',
-            lines:          [1, 2],
-            source:         'a/ruby/source/file.rb')
+            smell_type: 'UtilityFunction',
+            context:    'context foo',
+            message:    'message bar',
+            lines:      [1, 2],
+            source:     'a/ruby/source/file.rb')
     end
     let(:rendered) { described_class.new(warning).render }
     let(:json) { JSON.parse rendered.chop }

data/spec/reek/smell_configuration_spec.rb

@@ -18,10 +18,12 @@ RSpec.describe Reek::SmellConfiguration do
     it { expect(smell_config.merge('enabled' => true)).to eq(base_config) }
     it { expect(smell_config.merge('exclude' => [])).to eq(base_config) }
     it { expect(smell_config.merge('accept' => ['_'])).to eq(base_config) }
+
     it do
       updated = smell_config.merge('reject' => [/^.$/, /[0-9]$/, /[A-Z]/])
       expect(updated).to eq(base_config)
     end
+
     it do
       updated = smell_config.merge('accept' => ['_'], 'enabled' => true)
       expect(updated).to eq(base_config)

data/spec/reek/smell_detectors/base_detector_spec.rb

@@ -5,15 +5,13 @@ require_lib 'reek/smell_detectors/duplicate_method_call'
 RSpec.describe Reek::SmellDetectors::BaseDetector do
   describe '.todo_configuration_for' do
     it 'returns exclusion configuration for the given smells' do
-      detector = described_class.new
-      smell = create(:smell_warning, smell_detector: detector, context: 'Foo#bar')
+      smell = create(:smell_warning, smell_type: 'Foo', context: 'Foo#bar')
       result = described_class.todo_configuration_for([smell])
       expect(result).to eq('BaseDetector' => { 'exclude' => ['Foo#bar'] })
     end
 
     it 'merges identical contexts' do
-      detector = described_class.new
-      smell = create(:smell_warning, smell_detector: detector, context: 'Foo#bar')
+      smell = create(:smell_warning, smell_type: 'Foo', context: 'Foo#bar')
       result = described_class.todo_configuration_for([smell, smell])
       expect(result).to eq('BaseDetector' => { 'exclude' => ['Foo#bar'] })
     end
@@ -22,8 +20,7 @@ RSpec.describe Reek::SmellDetectors::BaseDetector do
       let(:subclass) { Reek::SmellDetectors::TooManyStatements }
 
       it 'includes default exclusions' do
-        detector = subclass.new
-        smell = create(:smell_warning, smell_detector: detector, context: 'Foo#bar')
+        smell = create(:smell_warning, smell_type: 'TooManyStatements', context: 'Foo#bar')
         result = subclass.todo_configuration_for([smell])
 
         aggregate_failures do

data/spec/reek/smell_warning_spec.rb

@@ -2,9 +2,6 @@ require_relative '../spec_helper'
 require_lib 'reek/smell_warning'
 
 RSpec.describe Reek::SmellWarning do
-  let(:duplication_detector)  { build(:smell_detector, smell_type: 'DuplicateMethodCall') }
-  let(:feature_envy_detector) { build(:smell_detector, smell_type: 'FeatureEnvy') }
-  let(:utility_function_detector) { build(:smell_detector, smell_type: 'UtilityFunction') }
   let(:uncommunicative_name_detector) { build(:smell_detector, smell_type: 'UncommunicativeVariableName') }
 
   describe 'sort order' do
@@ -27,23 +24,23 @@ RSpec.describe Reek::SmellWarning do
     end
 
     context 'when smells differ only by detector' do
-      let(:first) { build(:smell_warning, smell_detector: duplication_detector) }
-      let(:second) { build(:smell_warning, smell_detector: feature_envy_detector) }
+      let(:first) { build(:smell_warning, smell_type: 'DuplicateMethodCall') }
+      let(:second) { build(:smell_warning, smell_type: 'FeatureEnvy') }
 
       it_behaves_like 'first sorts ahead of second'
     end
 
     context 'when smells differ only by lines' do
-      let(:first) { build(:smell_warning, smell_detector: feature_envy_detector, lines: [2]) }
-      let(:second) { build(:smell_warning, smell_detector: feature_envy_detector, lines: [3]) }
+      let(:first) { build(:smell_warning, smell_type: 'FeatureEnvy', lines: [2]) }
+      let(:second) { build(:smell_warning, smell_type: 'FeatureEnvy', lines: [3]) }
 
       it_behaves_like 'first sorts ahead of second'
     end
 
     context 'when smells differ only by context' do
-      let(:first) { build(:smell_warning, smell_detector: duplication_detector, context: 'first') }
+      let(:first) { build(:smell_warning, smell_type: 'DuplicateMethodCall', context: 'first') }
       let(:second) do
-        build(:smell_warning, smell_detector: duplication_detector, context: 'second')
+        build(:smell_warning, smell_type: 'DuplicateMethodCall', context: 'second')
       end
 
       it_behaves_like 'first sorts ahead of second'
@@ -51,11 +48,11 @@ RSpec.describe Reek::SmellWarning do
 
     context 'when smells differ only by message' do
       let(:first) do
-        build(:smell_warning, smell_detector: duplication_detector,
+        build(:smell_warning, smell_type: 'DuplicateMethodCall',
                               context: 'ctx', message: 'first message')
       end
       let(:second) do
-        build(:smell_warning, smell_detector: duplication_detector,
+        build(:smell_warning, smell_type: 'DuplicateMethodCall',
                               context: 'ctx', message: 'second message')
       end
 
@@ -64,10 +61,10 @@ RSpec.describe Reek::SmellWarning do
 
     context 'when smells differ by name and message' do
       let(:first) do
-        build(:smell_warning, smell_detector: feature_envy_detector, message: 'second message')
+        build(:smell_warning, smell_type: 'FeatureEnvy', message: 'second message')
       end
       let(:second) do
-        build(:smell_warning, smell_detector: utility_function_detector, message: 'first message')
+        build(:smell_warning, smell_type: 'UtilityFunction', message: 'first message')
       end
 
       it_behaves_like 'first sorts ahead of second'
@@ -75,13 +72,13 @@ RSpec.describe Reek::SmellWarning do
 
     context 'when smells differ everywhere' do
       let(:first) do
-        build(:smell_warning, smell_detector: duplication_detector,
+        build(:smell_warning, smell_type: 'DuplicateMethodCall',
                               context: 'Dirty#a',
                               message: 'calls @s.title twice')
       end
 
       let(:second) do
-        build(:smell_warning, smell_detector: uncommunicative_name_detector,
+        build(:smell_warning, smell_type: 'UncommunicativeVariableName',
                               context: 'Dirty',
                               message: "has the variable name '@s'")
       end
@@ -90,28 +87,20 @@ RSpec.describe Reek::SmellWarning do
     end
   end
 
-  describe '#smell_class' do
-    it "returns the dectector's class" do
-      warning = build(:smell_warning, smell_detector: duplication_detector)
-      expect(warning.smell_class).to eq duplication_detector.class
-    end
-  end
-
   describe '#yaml_hash' do
     let(:context_name) { 'Module::Class#method/block' }
     let(:lines) { [24, 513] }
     let(:message) { 'test message' }
-    let(:detector) { Reek::SmellDetectors::FeatureEnvy.new }
     let(:parameters) { { 'one' => 34, 'two' => 'second' } }
     let(:smell_type) { 'FeatureEnvy' }
     let(:source) { 'a/ruby/source/file.rb' }
 
     let(:yaml) do
-      warning = described_class.new(detector, source: source,
-                                              context: context_name,
-                                              lines: lines,
-                                              message: message,
-                                              parameters: parameters)
+      warning = described_class.new(smell_type, source: source,
+                                    context: context_name,
+                                    lines: lines,
+                                    message: message,
+                                    parameters: parameters)
       warning.yaml_hash
     end
 

data/spec/reek/spec/should_reek_only_of_spec.rb

@@ -40,19 +40,16 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
   end
 
   context 'with 1 non-matching smell' do
-    let(:control_couple_detector) { build(:smell_detector, smell_type: 'ControlParameter') }
-    let(:smells) { [build(:smell_warning, smell_detector: control_couple_detector)] }
+    let(:smells) { [build(:smell_warning, smell_type: 'ControlParameter')] }
 
     it_behaves_like 'no match'
   end
 
   context 'with 2 non-matching smells' do
-    let(:control_couple_detector) { build(:smell_detector, smell_type: 'ControlParameter') }
-    let(:feature_envy_detector) { build(:smell_detector, smell_type: 'FeatureEnvy') }
     let(:smells) do
       [
-        build(:smell_warning, smell_detector: control_couple_detector),
-        build(:smell_warning, smell_detector: feature_envy_detector)
+        build(:smell_warning, smell_type: 'ControlParameter'),
+        build(:smell_warning, smell_type: 'FeatureEnvy')
       ]
     end
 
@@ -60,12 +57,10 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
   end
 
   context 'with 1 non-matching and 1 matching smell' do
-    let(:control_couple_detector) { build(:smell_detector, smell_type: 'ControlParameter') }
     let(:smells) do
-      detector = build(:smell_detector, smell_type: expected_smell_type.to_s)
       [
-        build(:smell_warning, smell_detector: control_couple_detector),
-        build(:smell_warning, smell_detector: detector,
+        build(:smell_warning, smell_type: 'ControlParameter'),
+        build(:smell_warning, smell_type: expected_smell_type.to_s,
                               message: "message mentioning #{expected_context_name}")
       ]
     end
@@ -75,9 +70,7 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
 
   context 'with 1 matching smell' do
     let(:smells) do
-      detector = build(:smell_detector, smell_type: expected_smell_type.to_s)
-
-      [build(:smell_warning, smell_detector: detector,
+      [build(:smell_warning, smell_type: expected_smell_type.to_s,
                              message: "message mentioning #{expected_context_name}")]
     end
 

data/spec/reek/spec/smell_matcher_spec.rb

@@ -2,9 +2,8 @@ require_relative '../../spec_helper'
 require_lib 'reek/spec/smell_matcher'
 
 RSpec.describe Reek::Spec::SmellMatcher do
-  let(:detector) { build(:smell_detector, smell_type: 'UncommunicativeVariableName') }
   let(:smell_warning) do
-    build(:smell_warning, smell_detector: detector,
+    build(:smell_warning, smell_type: 'UncommunicativeVariableName',
                           message: "has the variable name '@s'",
                           parameters: { test: 'something' })
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 5.4.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-24 00:00:00.000000000 Z
+date: 2019-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb