reek 4.2.0 → 4.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 300e8430e0cb4dcd0ca01529abb40921ed54f29f
-  data.tar.gz: c844e886e736762ddb4d61cdcf5bc5931aabc041
+  metadata.gz: 778582708b4cbc00f46fe28d606263595eaa2715
+  data.tar.gz: 59a7e7cb9fc8d1fe90053e822496c29102f99b6c
 SHA512:
-  metadata.gz: 287000e19154d5d0fff6a0996a175eeb4ff091506b19487dd126d3b858a2513d21afa284a2a603791b8c1e7a8e4538c0c3d75c213f3e04264e6e59deedcb3837
-  data.tar.gz: 7e67159cc8a61f025a1d36f25fba7fefd0b1abda631d7f590c44242292a179804c26604ae4c72dc2af012a9b4c7e359be169f1c29a3d88868a7470810eebe8db
+  metadata.gz: ef57fbf9e3451a8bc3ba904655e31e51cd3f1dbfec6ecc4a555ef90638804da2bfccd1389ee27e9ab204f5b224482164a50fb9ed5ccf52bb2b15cfff19eb9389
+  data.tar.gz: 52784f1ccba96fc6140d200c8bd256a6111f8439c77bdd465dec87dd38114648d7266c7677c919c87b8a34aee7785fe94da18f120cb4390cc69fbc2702fa176d

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 4.2.1 (2016-07-20)
+
+* (waldyr) Fix TooManyConstants for outer module when inner module suppress
+
 ## 4.2.0 (2016-07-16)
 
 * (waldyr) Add Too Many Constants smell detector

data/docs/Feature-Envy.md

@@ -25,7 +25,7 @@ end
 would report:
 
 ```Bash
-Warehouse#total_price refers to item more than self (FeatureEnvy)
+Warehouse#sale_price refers to item more than self (FeatureEnvy)
 ```
 
 since this:

data/lib/reek/smells/too_many_constants.rb

@@ -17,6 +17,7 @@ module Reek
       # of constants permitted in a class.
       MAX_ALLOWED_CONSTANTS_KEY = 'max_constants'.freeze
       DEFAULT_MAX_CONSTANTS = 5
+      IGNORED_NODES = [:module, :class].freeze
 
       def self.contexts
         [:class, :module]
@@ -36,7 +37,7 @@ module Reek
       def inspect(ctx)
         max_allowed_constants = value(MAX_ALLOWED_CONSTANTS_KEY, ctx)
 
-        count = ctx.each_node(:casgn, [:class]).delete_if(&:defines_module?).length
+        count = ctx.each_node(:casgn, IGNORED_NODES).delete_if(&:defines_module?).length
 
         return [] if count <= max_allowed_constants
 

data/lib/reek/version.rb

@@ -7,6 +7,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '4.2.0'.freeze
+    STRING = '4.2.1'.freeze
   end
 end

data/spec/reek/smells/too_many_constants_spec.rb

@@ -104,6 +104,24 @@ RSpec.describe Reek::Smells::TooManyConstants do
       expect(src).not_to reek_of(:TooManyConstants)
     end
 
+    it 'should not report outer module when inner module suppressed' do
+      src = <<-EOS
+        module Foo
+          # ignore :reek:TooManyConstants:
+          module Bar
+            A = 1
+            B = 2
+            C = 3
+            D = 4
+            E = 5
+            F = 6
+          end
+        end
+      EOS
+
+      expect(src).not_to reek_of(:TooManyConstants, context: 'Foo')
+    end
+
     it 'should count each constant only once for each namespace' do
       src = <<-EOS
         module Movie

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.2.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-16 00:00:00.000000000 Z
+date: 2016-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb