reek 4.0.4 → 4.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7c09dc83cbd7c49a57a5e0568479ccf87a8c284d
-  data.tar.gz: 7a9643ce33812488821abaabaf157eee3ba1f886
+  metadata.gz: ed3e33db32a0d7b3de163a1ac8d9f042d0123e00
+  data.tar.gz: 6316cc39b5ed860bbca0b4f47aca9f3547709eca
 SHA512:
-  metadata.gz: e85233445ea0535f360876d6f45398ff364aa895883b0175a60097839fbb5182b399496010c675253a9b79efdd15b1ca759db9253ea7febfc916efe2a3e3013f
-  data.tar.gz: cdc14223fc488191e56d3642c1bff7affeb9f4e97fc9f6030d1bd7988f7c75f133ad824724da58785c44556ab0a2483f7893f35c219eb666f22dfcb21f8b6082
+  metadata.gz: 5f81127feca9c714604fdb3e80cdb1a83e071359e953f902de08295b14ebf6942f345613b1f6b9b90e259364aa194a1704038c8a8e1f03c4beabab51b7e0319e
+  data.tar.gz: bbbbe01a9d539dd9b50a1c883fdbbe519d2258abedaaa16e59cb481a7576048be7743163f8bad3cabc867a9b4fb8353e07220e29b6cbae7f82f6cdf403fe3722

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 4.0.5 (2016-06-16)
+
+* (mvz) Handle new lambda syntax in NestedIterators
+
 ## 4.0.4 (2016-06-11)
 
 * (troessner) Bump parser

data/lib/reek/ast/sexp_extensions.rb

@@ -7,6 +7,7 @@ require_relative 'sexp_extensions/block'
 require_relative 'sexp_extensions/case'
 require_relative 'sexp_extensions/constant'
 require_relative 'sexp_extensions/if'
+require_relative 'sexp_extensions/lambda'
 require_relative 'sexp_extensions/literal'
 require_relative 'sexp_extensions/logical_operators'
 require_relative 'sexp_extensions/methods'

data/lib/reek/ast/sexp_extensions/lambda.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+module Reek
+  module AST
+    module SexpExtensions
+      # Utility methods for :lambda nodes.
+      module LambdaNode
+        def name
+          'lambda'
+        end
+      end
+    end
+  end
+end

data/lib/reek/version.rb

@@ -7,6 +7,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '4.0.4'.freeze
+    STRING = '4.0.5'.freeze
   end
 end

data/spec/reek/ast/sexp_extensions_spec.rb

@@ -332,6 +332,16 @@ RSpec.describe Reek::AST::SexpExtensions::BlockNode do
   end
 end
 
+RSpec.describe Reek::AST::SexpExtensions::LambdaNode do
+  let(:node) { sexp(:lambda) }
+
+  context '#name' do
+    it 'returns :lambda' do
+      expect(node.name).to eq 'lambda'
+    end
+  end
+end
+
 RSpec.describe Reek::AST::SexpExtensions::ModuleNode do
   context 'with a simple name' do
     subject do

data/spec/reek/smells/nested_iterators_spec.rb

@@ -173,6 +173,26 @@ RSpec.describe Reek::Smells::NestedIterators do
     end
   end
 
+  context 'when blocks are specified as lambdas' do
+    it 'does not report blocks that are not nested' do
+      source = <<-EOS
+        def foo
+          bar ->(x) { baz x }
+        end
+      EOS
+      expect(source).not_to reek_of(:NestedIterators)
+    end
+
+    it 'reports blocks that are nested' do
+      source = <<-EOS
+        def foo
+          bar ->(x) { baz x, ->(y) { quux y } }
+        end
+      EOS
+      expect(source).to reek_of(:NestedIterators)
+    end
+  end
+
   context 'when the allowed nesting depth is 3' do
     let(:config) do
       { Reek::Smells::NestedIterators::MAX_ALLOWED_NESTING_KEY => 3 }

data/tasks/mutant.rake

@@ -1,5 +1,18 @@
 desc 'Runs mutant'
 task :mutant do
-  system 'RUBY_THREAD_VM_STACK_SIZE=64000 bundle exec mutant --include lib '\
-         "--require reek --use rspec --since master --jobs 4 'Reek*'"
+  command = <<-EOS
+    branch_name=$(git symbolic-ref HEAD 2>/dev/null | cut -d"/" -f 3)
+    if [ "$branch_name" != "master" ]; then
+      RUBY_THREAD_VM_STACK_SIZE=64000\
+      bundle exec mutant\
+        --include lib\
+        --require reek\
+        --use rspec\
+        --since master\
+        --jobs 4 'Reek*'
+    else
+      echo "!!! Not running mutant on master branch !!!"
+    fi
+  EOS
+  system command
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.0.4
+  version: 4.0.5
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-12 00:00:00.000000000 Z
+date: 2016-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb
@@ -173,6 +173,7 @@ files:
 - lib/reek/ast/sexp_extensions/case.rb
 - lib/reek/ast/sexp_extensions/constant.rb
 - lib/reek/ast/sexp_extensions/if.rb
+- lib/reek/ast/sexp_extensions/lambda.rb
 - lib/reek/ast/sexp_extensions/literal.rb
 - lib/reek/ast/sexp_extensions/logical_operators.rb
 - lib/reek/ast/sexp_extensions/methods.rb