reek 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d3d1f1d919181f67b1404d126a1dd1e92b6b36e3
-  data.tar.gz: cd338514426fb1ea540fc73a0192fb7e492edcbc
+  metadata.gz: 8d43b7fe788a2ad7e920eb34098cd2ac8eb9d399
+  data.tar.gz: fbccb8b4b7020ca6e86a823f8da449560d417dd7
 SHA512:
-  metadata.gz: 706c68a4e8ce046d345b4e6f6acdcbe767d47becb217e01b62c10e7029e3490b7e8f2f98c8fadfd52264e68f855da40d1243ed536206ce168fe35ebb4baea9cf
-  data.tar.gz: a94a1759d26ec2cf3da345116ebb55736eff62963b750f414b3387f189ee4b46f7413b872e9c2ccbe24bdeab9b46370cb7175487dadb92af4155a03cfb6a83d3
+  metadata.gz: 1da698aa80dde3b094eb7d1a0d63090438b0fc0f4792f4f460e0949428c9c91397d7caf39ea20773a1cc44541794f66d2d8e57428a9cb0e74a4aead8d17719b5
+  data.tar.gz: 9a5a2b29af8b5e69c31f04910a35f8109cda43195bd18a87bb00df6f674266c9f2bab86c348bf0b3fdbab6ee11d16680d412cec46a4c5fb55624306efa257dad

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 4.0.1 (2016-04-10)
+
+* (thepry) Fix excluded paths for custom config formats.
+
 ## 4.0.0 (2016-03-21)
 
 * (troessner) Fix disabling UnusedPrivateMethod via `exclude` in configuration.

data/lib/reek/cli/application.rb

@@ -13,13 +13,14 @@ module Reek
     # command line.
     #
     class Application
+      include Input
       attr_reader :configuration
 
       def initialize(argv)
         @options = configure_options(argv)
         @status = options.success_exit_code
         @configuration = configure_app_configuration(options.config_file)
-        @command = command_class.new(OptionInterpreter.new(options))
+        @command = command_class.new(OptionInterpreter.new(options), sources: sources)
       end
 
       def execute
@@ -48,6 +49,10 @@ module Reek
       def command_class
         options.generate_todo_list ? Command::TodoListCommand : Command::ReportCommand
       end
+
+      def argv
+        options.argv
+      end
     end
   end
 end

data/lib/reek/cli/command/base_command.rb

@@ -6,21 +6,18 @@ module Reek
       # Base class for all commands
       #
       class BaseCommand
-        def initialize(options)
+        def initialize(options, sources:)
           @options = options
+          @sources = sources
         end
 
         private
 
-        attr_reader :options
+        attr_reader :options, :sources
 
         def smell_names
           @smell_names ||= options.smells_to_detect
         end
-
-        def sources
-          @sources ||= options.sources
-        end
       end
     end
   end

data/lib/reek/cli/input.rb

@@ -34,7 +34,7 @@ module Reek
 
       # :reek:UtilityFunction
       def working_directory_as_source
-        Source::SourceLocator.new(['.']).sources
+        Source::SourceLocator.new(['.'], configuration: configuration).sources
       end
 
       def sources_from_argv

data/lib/reek/cli/option_interpreter.rb

@@ -9,7 +9,6 @@ module Reek
     # Interprets the options set from the command line
     #
     class OptionInterpreter
-      include Input
       extend Forwardable
       def_delegators :options, :smells_to_detect, :success_exit_code, :failure_exit_code
 

data/lib/reek/version.rb

@@ -7,6 +7,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '4.0.0'.freeze
+    STRING = '4.0.1'.freeze
   end
 end

data/spec/reek/cli/command/report_command_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe Reek::CLI::Command::ReportCommand do
     let(:reporter) { double 'reporter' }
     let(:app) { double 'app' }
 
-    let(:command) { described_class.new option_interpreter }
+    let(:command) { described_class.new(option_interpreter, sources: []) }
 
     before do
       allow(option_interpreter).to receive(:reporter).and_return reporter
@@ -20,7 +20,6 @@ RSpec.describe Reek::CLI::Command::ReportCommand do
 
     context 'when no smells are found' do
       before do
-        allow(option_interpreter).to receive(:sources).and_return []
         allow(reporter).to receive(:smells?).and_return false
       end
 
@@ -32,7 +31,6 @@ RSpec.describe Reek::CLI::Command::ReportCommand do
 
     context 'when smells are found' do
       before do
-        allow(option_interpreter).to receive(:sources).and_return []
         allow(reporter).to receive(:smells?).and_return true
       end
 

data/spec/reek/cli/command/todo_list_command_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Reek::CLI::Command::TodoListCommand do
   describe '#execute' do
     let(:option_interpreter) { FactoryGirl.build(:options_interpreter_with_empty_sources) }
     let(:app) { double 'app' }
-    let(:command) { described_class.new option_interpreter }
+    let(:command) { described_class.new(option_interpreter, sources: []) }
 
     before do
       $stdout = StringIO.new
@@ -52,7 +52,7 @@ RSpec.describe Reek::CLI::Command::TodoListCommand do
     end
 
     describe 'groups_for' do
-      let(:command) { described_class.new({}) }
+      let(:command) { described_class.new({}, sources: []) }
 
       it 'returns a proper hash representation of the smells found' do
         smells = [FactoryGirl.build(:smell_warning)]

data/spec/reek/cli/input_spec.rb

@@ -7,10 +7,22 @@ RSpec.describe Reek::CLI::Input do
     include Reek::CLI::Input
 
     def argv; end
+
+    def configuration; end
+  end
+
+  let(:path_excluded_in_configuration) do
+    SAMPLES_PATH.join('source_with_exclude_paths/ignore_me/uncommunicative_method_name.rb')
   end
 
+  let(:configuration) { test_configuration_for(SAMPLES_PATH.join('configuration/with_excluded_paths.reek')) }
+
   subject { DummyClass.new }
 
+  before do
+    allow(subject).to receive(:configuration).and_return(configuration)
+  end
+
   describe '#sources' do
     context 'when no source files given' do
       before do
@@ -38,6 +50,10 @@ RSpec.describe Reek::CLI::Input do
         it 'should use working directory as source' do
           expect(subject.sources).to_not be_empty
         end
+
+        it 'should use configuration for excluded paths' do
+          expect(subject.sources).to_not include(path_excluded_in_configuration)
+        end
       end
     end
 

data/spec/spec_helper.rb

@@ -5,17 +5,13 @@ require_relative '../lib/reek/ast/ast_node_class_map'
 require_relative '../lib/reek/configuration/app_configuration'
 
 Reek::CLI::Silencer.silently do
-  require 'factory_girl'
   begin
     require 'pry-byebug'
   rescue LoadError # rubocop:disable Lint/HandleExceptions
   end
 end
-if Gem.loaded_specs['factory_girl'].version > Gem::Version.create('4.5.0')
-  raise 'Remove the above silencer as well as this check now that ' \
-        '`factory_girl` gem is updated to version greater than 4.5.0!'
-end
 
+require 'factory_girl'
 FactoryGirl.find_definitions
 
 SAMPLES_PATH = Pathname.new("#{__dir__}/samples").relative_path_from(Pathname.pwd)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-21 00:00:00.000000000 Z
+date: 2016-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb