reek 3.7.1 → 3.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0360a27f0d7285b66c630aa23ff08c48273f0ff7
-  data.tar.gz: cf166a5b8541a65c60738afa51aa903c0c673998
+  metadata.gz: f9790efcdbc4208c4183611dd613d3c9e5075583
+  data.tar.gz: 4584bf1720a0ae7b9db6088e2c7e44550ed98fd3
 SHA512:
-  metadata.gz: d52ffb53c36fc67b58993411a6bdeb1f319cadd044736f5cb13e690789dc77c2e0022b7f25261e1ebe4838fe4c11036f47d005472d5af30d6f33f4885651ae37
-  data.tar.gz: 443d185d3acc0d65d3f673e34f1e050e754a87637cc6fae8c63fa1059d9f1150c5936437c0cfe662d8fd9952ca903fa90647036ee35a35fcb07f200909d67f40
+  metadata.gz: 1822f9ebf7c84992bcd366da12b336f5e48f5082d35e44c2c9ac639501237609a0be36b45907f639e5594ea2ba5afaf8dc7940cae8125609ba5e32ba6bc46e5d
+  data.tar.gz: 9dfe34d1d98f9816fb96504ca843f51e2daedc0912f4732fa5b7a07f36e1fde3a83796341ac157cb1866cbd91f26e9f0dd5dab4d40ac7c5c55d96d1a3c3acdcf

data/.rubocop.yml

@@ -7,7 +7,7 @@ AllCops:
 # FIXME: Make the class shorter
 Metrics/ClassLength:
   Exclude:
-    - lib/reek/tree_walker.rb
+    - lib/reek/context_builder.rb
     - lib/reek/cli/options.rb
 
 # FIXME: Lower the method length by fixing the biggest offenders
@@ -59,3 +59,10 @@ Style/Documentation:
     - 'lib/reek/ast/sexp_extensions/send.rb'
     - 'lib/reek/ast/sexp_extensions/super.rb'
     - 'lib/reek/ast/sexp_extensions/variables.rb'
+
+Style/AccessorMethodName:
+  Exclude:
+    - 'lib/reek/context/visibility_tracker.rb'
+
+Style/ParallelAssignment:
+  Enabled: false

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+## 3.8.0 (2015-12-27)
+
+* (troessner) Report unused private instance methods.
+* (troessner) Add Rake task for console.
+
 ## 3.7.1 (2015-11-29)
 
 * (troessner) Reverse merge default directives into directory directives.

data/README.md

@@ -65,7 +65,7 @@ demo.rb -- 8 warnings:
 
 Reek focuses on high-level code smells, so we can't tell you how to fix warnings in
 a generic fashion; this is and will always be completely dependent on your domain
-language and bussiness logic.
+language and business logic.
 
 That said, an example might help you get going. Have a look at this sample of a
 Ruby on Rails model (be aware that this is truncated, not working code):

data/defaults.reek

@@ -106,6 +106,9 @@ UncommunicativeVariableName:
 UnusedParameters:
   enabled: true
   exclude: []
+UnusedPrivateMethod:
+  enabled: true
+  exclude: []
 UtilityFunction:
   enabled: true
   exclude: []

data/docs/Code-Smells.md

@@ -32,3 +32,4 @@ Reek currently includes checks for the following smells:
   * [Uncommunicative Parameter Name](Uncommunicative-Parameter-Name.md)
   * [Uncommunicative Variable Name](Uncommunicative-Variable-Name.md)
 * [Unused Parameters](Unused-Parameters.md)
+* [Unused Private Method](Unused-Private-Method.md)

data/docs/How-reek-works-internally.md

@@ -42,7 +42,8 @@
                                   * adorns the generated AST via a TreeDresser (core/tree_dresser)
                                   * initializes a SmellRepository with all relevant smells (smells/smell_repository)
                                   * initializes a WarningCollector (cli/warning_collector)
-                                  * runs all corresponding smell detectors via a Treewalker (core/tree_walker) for the SmellRepository above
+                                  * builds a tree of Contexts using ContextBuilder
+                                  * runs the smell detectors from the SmellRepository above on each of the contexts
                                   /       |       \
                                  /        |        \
                                 /         |         \
@@ -110,5 +111,5 @@ The overall workflow is like this:
             |
             |
             |
-      A TreeWalker then traverses this now adorned tree again and
+      A ContextBuilder then traverses this now adorned tree again and
       runs all SmellDetectors from the SmellRepository above

data/docs/Unused-Private-Method.md

@@ -0,0 +1,47 @@
+## Introduction
+
+Classes should use their private methods. Otherwise this is dead
+code which is confusing and bad for maintenance.
+
+The `Unused Private Method` detector reports unused private instance
+methods and instance methods only - class methods are ignored.
+
+## Example
+
+Given:
+
+```Ruby
+class Car
+  private
+  def drive; end
+  def start; end
+end
+```
+
+`Reek` would emit the following warning:
+
+```
+2 warnings:
+  [3]:Car has the unused private instance method `drive` (UnusedPrivateMethod)
+  [4]:Car has the unused private instance method `start` (UnusedPrivateMethod)
+```
+
+## Configuration
+
+`Unused Private Method` offers the [Basic Smell Options](Basic-Smell-Options.md).
+
+Private methods that are called via dynamic dispatch
+will trigger a false alarm since detecting something like this is far out of
+scope for `Reek`. In this case you can disable this detector via the `exclude`
+configuration option (which is part of the [Basic Smell Options](Basic-Smell-Options.md))
+for instance like this (an example from `Reek's` own codebase):
+
+```Ruby
+# :reek:UnusedPrivateMethod: { exclude: [ !ruby/regexp /process_/ ] }
+class ContextBuilder
+  def process_begin
+    # ....
+  end
+end
+```
+

data/features/samples.feature

@@ -177,7 +177,7 @@ Feature: Basic smell detection
       UnusedParameters: OptionParser::Completion#convert has unused parameter 'opt' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: OptionParser::Switch::NoArgument#parse has unused parameter 'argv' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: OptionParser::Switch::OptionalArgument#parse has unused parameter 'argv' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-    redcloth.rb -- 101 warnings:
+    redcloth.rb -- 121 warnings:
       Attribute: RedCloth#filter_html is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: RedCloth#filter_styles is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: RedCloth#hard_breaks is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
@@ -269,6 +269,26 @@ Feature: Basic smell detection
       UnusedParameters: RedCloth#textile_fn_ has unused parameter 'cite' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: RedCloth#textile_fn_ has unused parameter 'tag' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: RedCloth#textile_p has unused parameter 'cite' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `block_markdown_atx` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `block_markdown_bq` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `block_markdown_lists` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `block_markdown_rule` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `block_markdown_setext` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `block_textile_lists` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `block_textile_prefix` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `block_textile_table` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `inline_markdown_link` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `inline_markdown_reflink` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `inline_textile_code` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `inline_textile_image` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `inline_textile_link` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `inline_textile_span` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `refs_markdown` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `refs_textile` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `textile_bq` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `textile_fn_` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `textile_p` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      UnusedPrivateMethod: RedCloth has the unused private instance method `textile_popup_help` [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
       UtilityFunction: RedCloth#block_markdown_rule doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#clean_html doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#flush_left doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
@@ -279,5 +299,5 @@ Feature: Basic smell detection
       UtilityFunction: RedCloth#lT doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#no_textile doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#v_align doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
-    265 total warnings
+    285 total warnings
     """

data/features/step_definitions/sample_file_steps.rb

@@ -145,6 +145,9 @@ Given(/^a configuration file disabling UtilityFunction for non-public methods ca
     ---
     UtilityFunction:
       public_methods_only: true
+    # Not necessary for the feature per se but for removing distracting output.
+    UnusedPrivateMethod:
+      enabled: false
   EOS
 end
 

data/lib/reek/ast/node.rb

@@ -12,6 +12,7 @@ module Reek
     #
     class Node < ::Parser::AST::Node
       attr_reader :parent
+      private_attr_reader :comments
 
       def initialize(type, children = [], options = {})
         @comments = options.fetch(:comments, [])
@@ -114,8 +115,6 @@ module Reek
 
       private
 
-      private_attr_reader :comments
-
       def each_sexp
         children.each { |elem| yield elem if elem.is_a? ::Parser::AST::Node }
       end

data/lib/reek/ast/object_refs.rb

@@ -3,25 +3,48 @@ require 'private_attr/everywhere'
 module Reek
   # Represents functionality related to an Abstract Syntax Tree.
   module AST
-    # Responsible for holding one specific object reference.
-    ObjectRef = Struct.new(:name, :line)
     #
-    # Manages and counts the references out of a method to other objects.
+    # ObjectRefs is used in CodeContexts.
+    # It manages and counts the references out of a method to other objects and to `self`.
+    #
+    # E.g. this code:
+    #   def foo(thing)
+    #     bar.call_me
+    #     bar.maybe(thing.wat)
+    #   end
+    #
+    # would make "@refs" below look like this after the TreeWalker has done his job:
+    # {
+    #   :self=>[2, 3], # `bar.call_me` and `bar.maybe` count as refs to `self` in line 2 and 3
+    #   :thing=>[3]    # `thing.wat` in `bar.maybe()` counts as one reference to `thing`
+    # }
     #
     class ObjectRefs
       def initialize
         @refs = Hash.new { |refs, name| refs[name] = [] }
       end
 
+      # Records the references a given method in a CodeContext has including
+      # `self` (see the example at the beginning of this file).
+      #
+      # @param name [Symbol] The name of the object that the method references or `self`.
+      # @param line [Int] The line number where this reference occurs.
+      #
+      # @return [Int|nil] The line number that was added (which might be nil).
+      def record_reference(name: raise, line: nil)
+        refs[name] << line
+      end
+
+      # @return [Hash] The most popular references.
+      # E.g. for
+      #   { foo: [2], self: [2,3], bar: [3,4] }
+      # this would return
+      #   { self: [2,3], bar: [3,4] }
       def most_popular
         max = refs.values.map(&:size).max
         refs.select { |_name, refs| refs.size == max }
       end
 
-      def record_reference_to(name, line: nil)
-        refs[name] << ObjectRef.new(name, line)
-      end
-
       def references_to(name)
         refs[name]
       end

data/lib/reek/code_comment.rb

@@ -1,39 +1,45 @@
 require 'yaml'
 require 'private_attr/everywhere'
 
-# NOTE: Work-around for https://github.com/tenderlove/psych/issues/223
-require 'psych.rb' if Object.const_defined?(:Psych)
-
 module Reek
   #
   # A comment header from an abstract syntax tree; found directly above
   # module, class and method definitions.
   #
   class CodeComment
-    CONFIG_REGEX = /:reek:(\w+)(:\s*\{.*?\})?/
-
-    def initialize(text)
-      @config = Hash.new { |hash, key| hash[key] = {} }
-      @text = text.gsub(CONFIG_REGEX) do
-        @config.merge! add_to_config($1, $2)
-        ''
-      end.gsub(/#/, '').gsub(/\n/, '').strip
-    end
+    CONFIGURATION_REGEX            = /:reek:(\w+)(:\s*\{.*?\})?/
+    SANITIZE_REGEX                 = /(#|\n|\s)+/ # Matches '#', newlines and > 1 whitespaces.
+    DISABLE_DETECTOR_CONFIGURATION = ': { enabled: false }'
+    MINIMUM_CONTENT_LENGTH         = 2
 
     attr_reader :config
+    private_attr_reader :original_comment
+
+    #
+    # @param comment [String] - the original comment as found in the source code
+    #   E.g.:
+    #   "\n        # :reek:Duplication: { enabled: false }\n      "
+    #
+    def initialize(comment)
+      @original_comment  = comment
+      @config            = Hash.new { |hash, key| hash[key] = {} }
+
+      @original_comment.scan(CONFIGURATION_REGEX) do |smell_type, options|
+        @config.merge! YAML.load(smell_type + (options || DISABLE_DETECTOR_CONFIGURATION))
+      end
+    end
 
     def descriptive?
-      text.split(/\s+/).length >= 2
+      sanitized_comment.split(/\s+/).length >= MINIMUM_CONTENT_LENGTH
     end
 
     private
 
-    # :reek:UtilityFunction
-    def add_to_config(smell, options)
-      options ||= ': { enabled: false }'
-      YAML.load(smell + options)
+    def sanitized_comment
+      @sanitized_comment ||= original_comment.
+        gsub(CONFIGURATION_REGEX, '').
+        gsub(SANITIZE_REGEX, ' ').
+        strip
     end
-
-    private_attr_reader :text
   end
 end

data/lib/reek/context/class_context.rb

@@ -0,0 +1,11 @@
+require_relative 'module_context'
+
+module Reek
+  module Context
+    #
+    # A context wrapper for any class found in a syntax tree.
+    #
+    class ClassContext < ModuleContext
+    end
+  end
+end

data/lib/reek/context/code_context.rb

@@ -1,5 +1,10 @@
 require_relative '../code_comment'
 require_relative '../ast/object_refs'
+require_relative 'visibility_tracker'
+require_relative 'statement_counter'
+
+require 'forwardable'
+require 'private_attr/everywhere'
 
 module Reek
   module Context
@@ -12,10 +17,13 @@ module Reek
     # :reek:TooManyMethods: { max_methods: 19 }
     # :reek:TooManyInstanceVariables: { max_instance_variables: 8 }
     class CodeContext
-      attr_reader :exp
-      attr_reader :num_statements
-      attr_reader :children
-      attr_reader :visibility
+      extend Forwardable
+      delegate each_node: :exp
+      delegate %i(name type) => :exp
+      delegate %i(visibility visibility= non_public_visibility?) => :visibility_tracker
+
+      attr_reader :children, :context, :exp, :statement_counter, :visibility_tracker
+      private_attr_reader :refs
 
       # Initializes a new CodeContext.
       #
@@ -30,7 +38,7 @@ module Reek
       #     end
       #   end
       #
-      # The {TreeWalker} object first instantiates a {RootContext}, which has no parent.
+      # The {ContextBuilder} object first instantiates a {RootContext}, which has no parent.
       #
       # Next, it instantiates a {ModuleContext}, with +context+ being the
       # {RootContext} just created, and +exp+ looking like this:
@@ -43,7 +51,7 @@ module Reek
       #      (send nil :puts
       #        (lvar :x))))
       #
-      # Finally, {TreeWalker} will instantiate a {MethodContext}. This time,
+      # Finally, {ContextBuilder} will instantiate a {MethodContext}. This time,
       # +context+ is the {ModuleContext} created above, and +exp+ is:
       #
       #   (def :foo
@@ -52,15 +60,41 @@ module Reek
       #     (send nil :puts
       #       (lvar :x)))
       def initialize(context, exp)
-        @context    = context
-        @exp        = exp
-        @visibility = :public
-        @children   = []
+        @context            = context
+        @exp                = exp
+        @children           = []
+        @visibility_tracker = VisibilityTracker.new
+        @statement_counter  = StatementCounter.new
+        @refs               = AST::ObjectRefs.new
+      end
+
+      # Iterate over each AST node (see `Reek::AST::Node`) of a given type for the current expression.
+      #
+      # @param type [Symbol] the type of the nodes we are looking for, e.g. :defs.
+      # @yield block that is executed for every node.
+      #
+      def local_nodes(type, &blk)
+        each_node(type, [:casgn, :class, :module], &blk)
+      end
+
+      # Iterate over `self` and child contexts.
+      # The main difference (among others) to `each_node` is that we are traversing
+      # `CodeContexts` here, not AST nodes (see `Reek::AST::Node`).
+      #
+      # @yield block that is executed for every node.
+      # @return [Enumerator]
+      #
+      def each(&block)
+        return enum_for(:each) unless block_given?
 
-        @num_statements = 0
-        @refs = AST::ObjectRefs.new
+        yield self
+        children.each do |child|
+          child.each(&block)
+        end
       end
 
+      alias_method :parent, :context
+
       # Register a child context. The child's parent context should be equal to
       # the current context.
       #
@@ -69,14 +103,10 @@ module Reek
       #
       # @param child [CodeContext] the child context to register
       def append_child_context(child)
-        child.visibility = tracked_visibility
+        visibility_tracker.set_child_visibility(child)
         children << child
       end
 
-      def count_statements(num)
-        self.num_statements += num
-      end
-
       # :reek:TooManyStatements: { max_statements: 6 }
       # :reek:FeatureEnvy
       def record_call_to(exp)
@@ -86,28 +116,15 @@ module Reek
         case type
         when :lvar, :lvasgn
           unless exp.object_creation_call?
-            refs.record_reference_to(receiver.name, line: line)
+            refs.record_reference(name: receiver.name, line: line)
           end
         when :self
-          refs.record_reference_to(:self, line: line)
+          refs.record_reference(name: :self, line: line)
         end
       end
 
       def record_use_of_self
-        refs.record_reference_to(:self)
-      end
-
-      def name
-        exp.name
-      end
-
-      def local_nodes(type, &blk)
-        each_node(type, [:casgn, :class, :module], &blk)
-      end
-
-      # See Reek::AST::Node for details.
-      def each_node(type, ignoring, &blk)
-        exp.each_node(type, ignoring, &blk)
+        refs.record_reference(name: :self)
       end
 
       def matches?(candidates)
@@ -124,60 +141,23 @@ module Reek
 
       def config_for(detector_class)
         context_config_for(detector_class).merge(
-          config[detector_class.smell_type] || {})
+          configuration_via_code_commment[detector_class.smell_type] || {})
       end
 
-      # Handle the effects of a visibility modifier.
-      #
-      # @example Setting the current visibility
-      #   track_visibility :public
-      #
-      # @example Modifying the visibility of existing children
-      #   track_visibility :private, [:hide_me, :implementation_detail]
-      #
-      # @param visibility [Symbol]
-      # @param names [Array<Symbol>]
       def track_visibility(visibility, names)
-        if names.any?
-          children.each do |child|
-            child.visibility = visibility if names.include? child.name
-          end
-        else
-          self.tracked_visibility = visibility
-        end
+        visibility_tracker.track_visibility children: children,
+                                            visibility: visibility,
+                                            names: names
       end
 
-      def type
-        exp.type
+      def number_of_statements
+        statement_counter.value
       end
 
-      # Iterate over +self+ and child contexts.
-      def each(&block)
-        yield self
-        children.each do |child|
-          child.each(&block)
-        end
-      end
-
-      def non_public_visibility?
-        visibility != :public
-      end
-
-      protected
-
-      attr_writer :num_statements, :visibility
-
       private
 
-      private_attr_writer :tracked_visibility
-      private_attr_reader :context, :refs
-
-      def tracked_visibility
-        @tracked_visibility ||= :public
-      end
-
-      def config
-        @config ||= CodeComment.new(full_comment).config
+      def configuration_via_code_commment
+        @configuration_via_code_commment ||= CodeComment.new(full_comment).config
       end
 
       def full_comment

data/lib/reek/context/module_context.rb

@@ -1,4 +1,5 @@
 require_relative 'code_context'
+require_relative 'method_context'
 require_relative '../ast/sexp_formatter'
 
 module Reek
@@ -6,7 +7,24 @@ module Reek
     #
     # A context wrapper for any module found in a syntax tree.
     #
+    # :reek:FeatureEnvy
     class ModuleContext < CodeContext
+      def defined_instance_methods(visibility: :public)
+        each.select do |context|
+          context.is_a?(Context::MethodContext) &&
+            context.visibility == visibility
+        end
+      end
+
+      def instance_method_calls
+        each.
+          grep(SendContext).
+          select { |context| context.parent.class == MethodContext }
+      end
+
+      #
+      # @deprecated use `defined_instance_methods` instead
+      #
       def node_instance_methods
         local_nodes(:def)
       end

data/lib/reek/context/send_context.rb

@@ -0,0 +1,17 @@
+require_relative 'code_context'
+
+module Reek
+  module Context
+    #
+    # A context wrapper for method calls found in a syntax tree.
+    #
+    class SendContext < CodeContext
+      attr_reader :name
+
+      def initialize(context, exp, name)
+        @name = name
+        super context, exp
+      end
+    end
+  end
+end

data/lib/reek/context/singleton_method_context.rb

@@ -6,9 +6,6 @@ module Reek
     # A context wrapper for any singleton method definition found in a syntax tree.
     #
     class SingletonMethodContext < MethodContext
-      def envious_receivers
-        {}
-      end
     end
   end
 end

data/lib/reek/context/statement_counter.rb

@@ -0,0 +1,32 @@
+require_relative '../ast/node'
+require 'private_attr/everywhere'
+
+module Reek
+  module Context
+    # Responsible for counting the statements in a `CodeContext`.
+    class StatementCounter
+      attr_reader :value
+      private_attr_writer :value
+
+      def initialize
+        @value = 0
+      end
+
+      def increase_by(sexp)
+        return unless sexp
+        case sexp
+        when Reek::AST::Node
+          self.value = value + 1
+        when Array
+          self.value = value + sexp.length
+        else
+          raise ArgumentError, "Invalid type #{sexp} given"
+        end
+      end
+
+      def decrease_by(number)
+        self.value = value - number
+      end
+    end
+  end
+end