reek 3.0.1 → 3.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d5b829b54c2856a722ff2906a4d038f4ad3601f
-  data.tar.gz: 7ad7e5f417d336194b59f1b85b3a518d6b3c9f8c
+  metadata.gz: 71abe096497ff72ac2b0ff61c0264cde02d49ff3
+  data.tar.gz: 03e5768e1b53aef97a23e47d985daceb3f7316dd
 SHA512:
-  metadata.gz: 78e6b08e5ddf25dd0489860320ecc7b8b6ff6e89333ba2051523f37ac7a6318ba1c8c13449cd7978b47118068f9ca773b72223b935393ac9a2a4e3604acfc43d
-  data.tar.gz: 9aa379ef6f5d621c8916e6c70acff7ad90ffec332458650e9474364b285eb6bd2379385a79d57ce8f59338c4cf91ea0636857e465bf50dc012afcefbc70cb313
+  metadata.gz: 9e8b1c75ccd4d2982825ee6f066a834dc602b8d370179740d2a79645bd5ae1c3974ffb466560dc0e4962393f203efb7e8cb603afb22ebd37913d11eb91348c44
+  data.tar.gz: c12a018c2777291fdcaaf93d3220b8d3abf193542cbe13763017c982473afa1e22767c3595cca3efe8e64c170954165b4a616412daff0822e1a053e0e8ed6fd5

data/CHANGELOG

@@ -1,3 +1,7 @@
+== 3.0.2
+
+* (troessner) Only use ruby source files.
+
 == 3.0.1
 
 * (troessner) Fix reek descending into hidden directories

data/lib/reek/source/source_locator.rb

@@ -31,16 +31,16 @@ module Reek
           Find.find(given_path) do |path|
             pathname = Pathname.new(path)
             if pathname.directory?
-              exclude_path?(pathname) || hidden_directory?(pathname) ? Find.prune : next
+              ignore_path?(pathname) ? Find.prune : next
             else
-              relevant_paths << pathname
+              relevant_paths << pathname if ruby_file?(pathname)
             end
           end
         end
         relevant_paths.flatten.sort
       end
 
-      def exclude_path?(pathname)
+      def path_excluded?(pathname)
         Configuration::AppConfiguration.exclude_paths.include? pathname.to_s
       end
 
@@ -55,6 +55,14 @@ module Reek
       def hidden_directory?(pathname)
         pathname.basename.to_s.start_with? '.'
       end
+
+      def ignore_path?(pathname)
+        path_excluded?(pathname) || hidden_directory?(pathname)
+      end
+
+      def ruby_file?(pathname)
+        pathname.to_s.end_with?('.rb')
+      end
     end
   end
 end

data/lib/reek/version.rb

@@ -3,6 +3,6 @@ module Reek
   # This module holds the Reek version informations
   #
   module Version
-    STRING = '3.0.1'
+    STRING = '3.0.2'
   end
 end

data/spec/reek/source/source_locator_spec.rb

@@ -45,5 +45,27 @@ RSpec.describe Reek::Source::SourceLocator do
         end
       end
     end
+
+    context 'non-ruby files' do
+      let(:path) { 'spec/samples/source_with_non_ruby_files' }
+      let(:expected_files) do
+        ['spec/samples/source_with_non_ruby_files/uncommunicative_parameter_name.rb']
+      end
+      let(:files_that_are_expected_to_be_ignored) do
+        [
+          'spec/samples/source_with_non_ruby_files/gibberish',
+          'spec/samples/source_with_non_ruby_files/python_source.py'
+        ]
+      end
+
+      it 'does only use ruby source files' do
+        sources = described_class.new([path]).sources
+
+        expect(sources.map(&:path)).
+          not_to include(files_that_are_expected_to_be_ignored)
+
+        expect(sources.map(&:path)).to eq expected_files
+      end
+    end
   end
 end

data/spec/samples/source_with_non_ruby_files/gibberish

@@ -0,0 +1 @@
+adfasfsadfasdfsafsad

data/spec/samples/source_with_non_ruby_files/python_source.py

@@ -0,0 +1 @@
+print("Hello, World!")

data/spec/samples/source_with_non_ruby_files/uncommunicative_parameter_name.rb

@@ -0,0 +1,6 @@
+# Klass comment
+class Klass
+  def method(a)
+    a + @x
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.0.2
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -419,6 +419,9 @@ files:
 - spec/samples/source_with_exclude_paths/nested/uncommunicative_parameter_name.rb
 - spec/samples/source_with_hidden_directories/.hidden/uncommunicative_method_name.rb
 - spec/samples/source_with_hidden_directories/uncommunicative_parameter_name.rb
+- spec/samples/source_with_non_ruby_files/gibberish
+- spec/samples/source_with_non_ruby_files/python_source.py
+- spec/samples/source_with_non_ruby_files/uncommunicative_parameter_name.rb
 - spec/samples/three_clean_files/clean_one.rb
 - spec/samples/three_clean_files/clean_three.rb
 - spec/samples/three_clean_files/clean_two.rb