reek 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da371c20978d5a436025bc2ecddc2df4582a9c7e
-  data.tar.gz: 8aa3729d6814cba34e69ff9e1696ce93450221c6
+  metadata.gz: 4d5b829b54c2856a722ff2906a4d038f4ad3601f
+  data.tar.gz: 7ad7e5f417d336194b59f1b85b3a518d6b3c9f8c
 SHA512:
-  metadata.gz: d15340c5aa637820c280d28008579ecc97f9de7a56bf74e47f6f217a9f593d3a1416dfa6757b4beb3900032c505eed91aa8fa21de94374ac1e2d1537706cbabb
-  data.tar.gz: c49a1ae86f1265e493f6e5eff700e2d02c2849358a49db20d87d9c52498138da0ca38fd7bd83cb90d0c16cb7b19789aa43422b052910b145ac611d9421bc6bf8
+  metadata.gz: 78e6b08e5ddf25dd0489860320ecc7b8b6ff6e89333ba2051523f37ac7a6318ba1c8c13449cd7978b47118068f9ca773b72223b935393ac9a2a4e3604acfc43d
+  data.tar.gz: 9aa379ef6f5d621c8916e6c70acff7ad90ffec332458650e9474364b285eb6bd2379385a79d57ce8f59338c4cf91ea0636857e465bf50dc012afcefbc70cb313

data/CHANGELOG

@@ -1,3 +1,7 @@
+== 3.0.1
+
+* (troessner) Fix reek descending into hidden directories
+
 == 3.0.0
 
 * (troessner) Make directories excludable via configuration.

data/lib/reek/source/source_locator.rb

@@ -31,7 +31,7 @@ module Reek
           Find.find(given_path) do |path|
             pathname = Pathname.new(path)
             if pathname.directory?
-              exclude_path?(pathname) ? Find.prune : next
+              exclude_path?(pathname) || hidden_directory?(pathname) ? Find.prune : next
             else
               relevant_paths << pathname
             end
@@ -51,6 +51,10 @@ module Reek
       def print_no_such_file_error(path)
         $stderr.puts "Error: No such file - #{path}"
       end
+
+      def hidden_directory?(pathname)
+        pathname.basename.to_s.start_with? '.'
+      end
     end
   end
 end

data/lib/reek/version.rb

@@ -3,6 +3,6 @@ module Reek
   # This module holds the Reek version informations
   #
   module Version
-    STRING = '3.0.0'
+    STRING = '3.0.1'
   end
 end

data/spec/reek/source/source_locator_spec.rb

@@ -3,6 +3,25 @@ require_relative '../../../lib/reek/source/source_locator'
 
 RSpec.describe Reek::Source::SourceLocator do
   describe '#sources' do
+    context 'applied to hidden directories' do
+      let(:path) { 'spec/samples/source_with_hidden_directories' }
+      let(:expected_files) do
+        ['spec/samples/source_with_hidden_directories/uncommunicative_parameter_name.rb']
+      end
+      let(:files_that_are_expected_to_be_ignored) do
+        ['spec/samples/source_with_hidden_directories/.hidden/uncommunicative_method_name.rb']
+      end
+
+      it 'does not scan hidden directories' do
+        sources = described_class.new([path]).sources
+
+        expect(sources.map(&:path)).
+          not_to include(files_that_are_expected_to_be_ignored)
+
+        expect(sources.map(&:path)).to eq expected_files
+      end
+    end
+
     context 'exclude paths' do
       let(:config) { 'spec/samples/configuration/with_excluded_paths.reek' }
       let(:path) { 'spec/samples/source_with_exclude_paths' }

data/spec/samples/source_with_hidden_directories/.hidden/uncommunicative_method_name.rb

@@ -0,0 +1,5 @@
+# Klass comment.
+class Klass
+  def m
+  end
+end

data/spec/samples/source_with_hidden_directories/uncommunicative_parameter_name.rb

@@ -0,0 +1,6 @@
+# Klass comment
+class Klass
+  def method(a)
+    a + @x
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-30 00:00:00.000000000 Z
+date: 2015-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -417,6 +417,8 @@ files:
 - spec/samples/source_with_exclude_paths/ignore_me/uncommunicative_method_name.rb
 - spec/samples/source_with_exclude_paths/nested/ignore_me_as_well/irresponsible_module.rb
 - spec/samples/source_with_exclude_paths/nested/uncommunicative_parameter_name.rb
+- spec/samples/source_with_hidden_directories/.hidden/uncommunicative_method_name.rb
+- spec/samples/source_with_hidden_directories/uncommunicative_parameter_name.rb
 - spec/samples/three_clean_files/clean_one.rb
 - spec/samples/three_clean_files/clean_three.rb
 - spec/samples/three_clean_files/clean_two.rb