reek 1.6.2 → 1.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 654a7a3741c1426d2a2e40b05fe4f07515f7fe2e
-  data.tar.gz: c6b97971092b5645f2ae4ee55e5a82859371e360
+  metadata.gz: 0dce92707c157b19ecfb605d859d11a9f19255c9
+  data.tar.gz: f744fc0047adc1371b6343c5a99f88874ed74625
 SHA512:
-  metadata.gz: 7272b0e52da60a43de15c0dc72d794554fb01652c054c07be603de16ab52c156fa857e71330b2087528a9fe049bb13366b09e55c60883037e2df199bbdfcf0e5
-  data.tar.gz: 717834c506b575606000461375091233f5d90b5cbd8bc3ccf6bb9b7fc93d4035ad4944d5b4ba570f16a7249cb1b72681d377f44f5e44ae487f4c0627dad97d39
+  metadata.gz: ac473b612774d5942592fb188443313675cfaca2bea8f2776d82cec4d425c0291d49f64fd0c5a037c635ce439a37b1bc431a8af45f79f861fa3cb4e91727b23b
+  data.tar.gz: 4ef741652ffa782237c63a1af81d5dbb1d48ec7d7530e78e9b1c593b9b0a357f42b2b608663b025fd4721ce0787009b0b2c2b20793f96e0a65eeff6db131197f

data/CHANGELOG

@@ -1,3 +1,7 @@
+== 1.6.3
+
+* (mvz) Support ruby 2.2
+
 == 1.6.2
 
 * (mvz) Fix rake task bug when no config file was given explicitly.

data/lib/reek/smells/smell_detector.rb

@@ -14,7 +14,7 @@ module Reek
     # Shared responsibilities of all smell detectors.
     #
     class SmellDetector
-      attr_reader :source, :smell_category, :smell_type
+      attr_reader :source
 
       # The name of the config field that lists the names of code contexts
       # that should not be checked. Add this field to the config for each

data/lib/reek/source/ast_node.rb

@@ -5,8 +5,6 @@ module Reek
     # Base class for AST nodes extended with utility methods. Contains some
     # methods to ease the transition from Sexp to AST::Node.
     class AstNode < Parser::AST::Node
-      attr_reader :comments
-
       def initialize(type, children = [], options = {})
         @comments = options.fetch(:comments, [])
         super

data/lib/reek/version.rb

@@ -1,3 +1,3 @@
 module Reek
-  VERSION = '1.6.2'
+  VERSION = '1.6.3'
 end

data/reek.gemspec

@@ -31,12 +31,12 @@ Gem::Specification.new do |s|
   s.summary = 'Code smell detector for Ruby'
 
   s.add_runtime_dependency('parser', ['~> 2.2.0.pre.7'])
-  s.add_runtime_dependency('unparser', ['= 0.1.16'])
+  s.add_runtime_dependency('unparser', ['~> 0.2.2'])
   s.add_runtime_dependency('rainbow', ['>= 1.99', '< 3.0'])
 
   s.add_development_dependency('bundler', ['~> 1.1'])
   s.add_development_dependency('rake', ['~> 10.0'])
-  s.add_development_dependency('cucumber', ['~> 1.3'])
+  s.add_development_dependency('cucumber', ['~> 1.3', '>= 1.3.18'])
   s.add_development_dependency('rspec', ['~> 3.0'])
   s.add_development_dependency('yard', ['>= 0.8.7', '< 0.9'])
   s.add_development_dependency('factory_girl', ['~> 4.0'])

data/spec/reek/cli/report_spec.rb

@@ -55,8 +55,8 @@ describe Report::TextReport, ' when empty' do
     context 'when output format is yaml' do
       it 'prints empty yaml' do
         yaml_report = report(Report::YamlReport.new(report_options))
-        output = capture_output_stream { yaml_report.show }
-        expect(output).to match(/^--- \[\]\n.*$/)
+        result = capture_output_stream { yaml_report.show }
+        expect(result).to match(/^--- \[\]\n.*$/)
       end
     end
 
@@ -104,8 +104,8 @@ describe Report::TextReport, ' when empty' do
         end
 
         it 'has a footer in color' do
-          output = capture_output_stream { @rpt.show }
-          expect(output).to end_with "\e[32m0 total warnings\n\e[0m"
+          result = capture_output_stream { @rpt.show }
+          expect(result).to end_with "\e[32m0 total warnings\n\e[0m"
         end
       end
 
@@ -123,8 +123,8 @@ describe Report::TextReport, ' when empty' do
         end
 
         it 'has a footer in color' do
-          output = capture_output_stream { @rpt.show }
-          expect(output).to end_with "\e[31m4 total warnings\n\e[0m"
+          result = capture_output_stream { @rpt.show }
+          expect(result).to end_with "\e[31m4 total warnings\n\e[0m"
         end
       end
     end

data/spec/reek/core/code_context_spec.rb

@@ -33,9 +33,9 @@ describe CodeContext do
     end
 
     context 'when there is an outer' do
+      let(:outer) { double('outer') }
       before :each do
         @outer_name = 'another_random sting'
-        outer = double('outer')
         allow(outer).to receive(:full_name).at_least(:once).and_return(@outer_name)
         allow(outer).to receive(:config).and_return({})
         @ctx = CodeContext.new(outer, @exp)
@@ -158,19 +158,19 @@ EOS
   end
 
   describe '#config_for' do
-    let(:exp) { double('exp') }
+    let(:expression) { double('exp') }
     let(:outer) { nil }
-    let(:ctx) { CodeContext.new(outer, exp) }
+    let(:context) { CodeContext.new(outer, expression) }
     let(:sniffer) { double('sniffer') }
 
     before :each do
       allow(sniffer).to receive(:smell_type).and_return('DuplicateMethodCall')
-      allow(exp).to receive(:comments).and_return(
+      allow(expression).to receive(:comments).and_return(
         ':reek:DuplicateMethodCall: { allow_calls: [ puts ] }')
     end
 
-    it 'gets its configuration from the exp comments' do
-      expect(ctx.config_for(sniffer)).to eq('allow_calls' => ['puts'])
+    it 'gets its configuration from the expression comments' do
+      expect(context.config_for(sniffer)).to eq('allow_calls' => ['puts'])
     end
 
     context 'when there is an outer' do
@@ -182,8 +182,8 @@ EOS
       end
 
       it 'merges the outer config with its own configuration' do
-        expect(ctx.config_for(sniffer)).to eq('allow_calls' => ['puts'],
-                                              'max_calls' => 2)
+        expect(context.config_for(sniffer)).to eq('allow_calls' => ['puts'],
+                                                  'max_calls' => 2)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.6.3
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-13 00:00:00.000000000 Z
+date: 2015-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -30,16 +30,16 @@ dependencies:
   name: unparser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.16
+        version: 0.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.16
+        version: 0.2.2
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -95,6 +95,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.18
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -102,6 +105,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.18
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement