reek 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2bd3b362caed94f8eec563376a0542677d215b9c
-  data.tar.gz: 85af0be0c7132c4718b145b114d2013a836a8880
+  metadata.gz: 8c45202c174ceb4196695ec6f2a5b6a823c14d06
+  data.tar.gz: 34ec72fa7a3dc9cb07d40258e178ee8ab066e3b8
 SHA512:
-  metadata.gz: e933370d907c7d45079a56e513c88363b3b6faeb8244651e6ac4a6f3e08242087e705490c8a5d86eee80fb585f5f74a3af7f5d2d49e42e672081b0e9d861f32c
-  data.tar.gz: c0bcc02e84cd9475db5f2c59c1d74c9fc42e983ff79e373f951092224df4df8784fd00b2ce8d43a306d4ebe42e742dba2507e42893aa88a4798a47dc7874d726
+  metadata.gz: b2b8bf4eee7cba82e33ce1f2dbc6768c786829599d64d175d3eb232d82b3d9e6c605111ae0723e9164697ae9718194a4f91078cc4a6e130341b4bac1f178ed60
+  data.tar.gz: 52242fe4f536bb3d2bb2de1777b4cd77232307047392ad308542d0f1f62d4ecf337a8e7f78f892e6de95459accbbf17e7a1a1732fbce3bce924f82bb80e4d81f

data/CHANGELOG

@@ -1,3 +1,6 @@
+* (chastell) Add keyword arguments support after switching to 'parser'
+* (mvz) Handle nil-block in iterators
+
 == 1.5.0
 
 * (mvz) Parse with the parse gem

data/features/samples.feature

@@ -290,3 +290,13 @@ Feature: Basic smell detection
     spec/samples/ruby20_syntax.rb -- 1 warning:
       [1]:SomeClass has no descriptive comment (IrresponsibleModule)
     """
+
+  @ruby21
+  Scenario: Correct smells from a source file with Ruby 2.1 specific syntax
+    When I run reek spec/samples/ruby21_syntax.rb
+    Then the exit status indicates smells
+    And it reports:
+    """
+    spec/samples/ruby21_syntax.rb -- 1 warning:
+      [1]:SomeClass has no descriptive comment (IrresponsibleModule)
+    """

data/lib/reek/smells/nested_iterators.rb

@@ -62,6 +62,7 @@ module Reek
       end
 
       def find_iters(exp, depth)
+        return [] unless exp
         exp.find_nodes([:block]).flat_map do |elem|
           find_iters_for_iter_node(elem, depth)
         end

data/lib/reek/source/sexp_extensions.rb

@@ -40,6 +40,11 @@ module Reek
         include ArgNodeBase
       end
 
+      # Utility methods for :kwarg nodes.
+      module KwargNode
+        include ArgNodeBase
+      end
+
       # Utility methods for :optarg nodes.
       module OptargNode
         include ArgNodeBase

data/lib/reek/version.rb

@@ -1,3 +1,3 @@
 module Reek
-  VERSION = '1.5.0'
+  VERSION = '1.5.1'
 end

data/reek.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
   s.rubyforge_project = 'reek'
   s.rubygems_version = '1.3.6'
-  s.required_ruby_version = '>= 1.9.2'
+  s.required_ruby_version = '>= 1.9.3'
   s.summary = 'Code smell detector for Ruby'
 
   s.add_runtime_dependency('parser', ['~> 2.2.0.pre.7'])

data/spec/reek/smells/nested_iterators_spec.rb

@@ -44,6 +44,15 @@ EOS
     expect(src).not_to smell_of(NestedIterators)
   end
 
+  it 'detects an iterator with an empty block' do
+    src = <<-EOS
+      def foo
+        bar { baz { } }
+      end
+    EOS
+    expect(src).to smell_of(NestedIterators, {})
+  end
+
   it 'should report nested iterators only once per method' do
     src = <<EOS
 def bad(fred)

data/spec/samples/ruby21_syntax.rb

@@ -0,0 +1,5 @@
+class SomeClass
+  def method_with_required_keyword_arguments(foo:)
+    puts foo
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-01 00:00:00.000000000 Z
+date: 2014-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -341,6 +341,7 @@ files:
 - spec/samples/overrides_defaults/config.reek
 - spec/samples/redcloth.rb
 - spec/samples/ruby20_syntax.rb
+- spec/samples/ruby21_syntax.rb
 - spec/samples/three_clean_files/clean_one.rb
 - spec/samples/three_clean_files/clean_three.rb
 - spec/samples/three_clean_files/clean_two.rb
@@ -369,7 +370,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="