reek 1.3.7 → 1.3.8

Sign up to get free protection for your applications and to get access to all the features.
Files changed (7) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +1 -1
  3. data/lib/reek/smells/boolean_parameter.rb +3 -2
  4. data/lib/reek/smells/unused_parameters.rb +3 -2
  5. data/lib/reek/version.rb +1 -1
  6. data/reek.gemspec +2 -2
  7. metadata +18 -6
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: a655ae03def5604c059ac663e271eecc1a18d461
4
- data.tar.gz: 6f6c21e7d712a339e649ad91eabefea90c5a6d13
3
+ metadata.gz: 4e5b741864981fffaab8d15e77e27ade44e67355
4
+ data.tar.gz: 0196170433478c772cd616523401c3c58dd4c40f
5
5
  SHA512:
6
- metadata.gz: 637e3a7af79aee3dd3d7e107d9de35ab2bac39b90f015b58ae8b21cd852a12613a7085d5217eb701ef0b78baa2f517566d21906006eba841dcc77e722ff6d171
7
- data.tar.gz: 1f6f1923e86614fcb73d77e6a36e3c4f977db3bba059b785904042f27fa8fe7fecc5f568128597c432ee5ca42ea7b9c3ce5039b256f13bd87f46228136438d3d
6
+ metadata.gz: 224dfa2013aad084aaff389f7aca99883f0d7153f7086fa6c860dde323753da85aec0809c9b5a47f410cd84c69754aba47d5887a9cb782b9128619ebca198663
7
+ data.tar.gz: 32a0e0f15be5a1deecdd60a61d06f894917d979f24a7e8942c3bd22cba336ced0103fa1f3090b442388d54c2be5c947ac97beb12f4f28ca0a5b106c6f1c9b3ad
data/README.md CHANGED
@@ -7,7 +7,7 @@
7
7
  [![Build Status](https://secure.travis-ci.org/troessner/reek.png?branch=master)](http://travis-ci.org/troessner/reek?branch=master)
8
8
  [![Gem Version](https://badge.fury.io/rb/reek.png)](http://badge.fury.io/rb/reek)
9
9
  [![Dependency Status](https://gemnasium.com/troessner/reek.png)](https://gemnasium.com/troessner/reek)
10
- [![Inline docs](http://inch-pages.github.io/github/troessner/reek.png)](http://inch-pages.github.io/github/troessner/reek)
10
+ [![Inline docs](http://inch-ci.org/github/troessner/reek.png)](http://inch-ci.org/github/troessner/reek)
11
11
 
12
12
 
13
13
  ### Synopsis
data/lib/reek/smells/boolean_parameter.rb CHANGED
@@ -28,9 +28,10 @@ module Reek
28
28
  method_ctx.parameters.default_assignments.select do |param, value|
29
29
  [:true, :false].include?(value[0])
30
30
  end.map do |param, value|
31
+ param_name = param.to_s
31
32
  SmellWarning.new(SMELL_CLASS, method_ctx.full_name, [method_ctx.exp.line],
32
- "has boolean parameter '#{param.to_s}'",
33
- @source, SMELL_SUBCLASS, {PARAMETER_KEY => param.to_s})
33
+ "has boolean parameter '#{param_name}'",
34
+ @source, SMELL_SUBCLASS, {PARAMETER_KEY => param_name})
34
35
  end
35
36
  end
36
37
  end
data/lib/reek/smells/unused_parameters.rb CHANGED
@@ -66,14 +66,15 @@ module Reek
66
66
  end
67
67
 
68
68
  def smell_warning(method_ctx, param)
69
+ param_name = param.to_s
69
70
  SmellWarning.new(
70
71
  SMELL_CLASS,
71
72
  method_ctx.full_name,
72
73
  [ method_ctx.exp.line ],
73
- "has unused parameter '#{param.to_s}'",
74
+ "has unused parameter '#{param_name}'",
74
75
  @source,
75
76
  SMELL_SUBCLASS,
76
- { PARAMETER_KEY => param.to_s }
77
+ { PARAMETER_KEY => param_name }
77
78
  )
78
79
  end
79
80
 
data/lib/reek/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module Reek
2
- VERSION = '1.3.7'
2
+ VERSION = '1.3.8'
3
3
  end
data/reek.gemspec CHANGED
@@ -28,8 +28,8 @@ and reports any code smells it finds.
28
28
 
29
29
  s.add_runtime_dependency(%q<ruby_parser>, ["~> 3.3"])
30
30
  s.add_runtime_dependency(%q<sexp_processor>)
31
- s.add_runtime_dependency(%q<ruby2ruby>, ["~> 2.0.8"])
32
- s.add_runtime_dependency(%q<rainbow>)
31
+ s.add_runtime_dependency(%q<ruby2ruby>, [">= 2.0.8", "< 3.0"])
32
+ s.add_runtime_dependency(%q<rainbow>, [">= 1.99", "< 3.0"])
33
33
 
34
34
  s.add_development_dependency(%q<bundler>, ["~> 1.1"])
35
35
  s.add_development_dependency(%q<rake>)
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: reek
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.3.7
4
+ version: 1.3.8
5
5
  platform: ruby
6
6
  authors:
7
7
  - Kevin Rutherford
@@ -10,7 +10,7 @@ authors:
10
10
  autorequire:
11
11
  bindir: bin
12
12
  cert_chain: []
13
- date: 2014-03-25 00:00:00.000000000 Z
13
+ date: 2014-07-07 00:00:00.000000000 Z
14
14
  dependencies:
15
15
  - !ruby/object:Gem::Dependency
16
16
  name: ruby_parser
@@ -44,30 +44,42 @@ dependencies:
44
44
  name: ruby2ruby
45
45
  requirement: !ruby/object:Gem::Requirement
46
46
  requirements:
47
- - - "~>"
47
+ - - ">="
48
48
  - !ruby/object:Gem::Version
49
49
  version: 2.0.8
50
+ - - "<"
51
+ - !ruby/object:Gem::Version
52
+ version: '3.0'
50
53
  type: :runtime
51
54
  prerelease: false
52
55
  version_requirements: !ruby/object:Gem::Requirement
53
56
  requirements:
54
- - - "~>"
57
+ - - ">="
55
58
  - !ruby/object:Gem::Version
56
59
  version: 2.0.8
60
+ - - "<"
61
+ - !ruby/object:Gem::Version
62
+ version: '3.0'
57
63
  - !ruby/object:Gem::Dependency
58
64
  name: rainbow
59
65
  requirement: !ruby/object:Gem::Requirement
60
66
  requirements:
61
67
  - - ">="
62
68
  - !ruby/object:Gem::Version
63
- version: '0'
69
+ version: '1.99'
70
+ - - "<"
71
+ - !ruby/object:Gem::Version
72
+ version: '3.0'
64
73
  type: :runtime
65
74
  prerelease: false
66
75
  version_requirements: !ruby/object:Gem::Requirement
67
76
  requirements:
68
77
  - - ">="
69
78
  - !ruby/object:Gem::Version
70
- version: '0'
79
+ version: '1.99'
80
+ - - "<"
81
+ - !ruby/object:Gem::Version
82
+ version: '3.0'
71
83
  - !ruby/object:Gem::Dependency
72
84
  name: bundler
73
85
  requirement: !ruby/object:Gem::Requirement