redstream 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 032fbb3b9ee72cf051d9b9dffe996d1efee73b106952d7739bfe75a08190ac2c
-  data.tar.gz: da3131c6117fb981d1709d5825b94bc09f59cd771835cfd0516cfec22765d09a
+  metadata.gz: e25cd9c9c13d7fe93e81207a7608599e37c72a39425b54108c7178b3e97917f3
+  data.tar.gz: 5a5179bf6de8ef24effa908595a32bbcccd9c5c717988ce25a0f38aa128b6cab
 SHA512:
-  metadata.gz: 55bf7e981765709911f69af1c30a8ee00dc1138bc0b6636ef6ec3442c5428138eebfb23553069cae3be520e1d8b5c40594db9c3c6646d18555834761813e4551
-  data.tar.gz: 4dda09649b7f523f57a19dc8e17a8c3c9a9177199c26b8530db45fa634d1bc0e589ddc44eeddb4fc8f67a81a3e03d81f09ac6d432b1bb60d39e943bb27a22f9e
+  metadata.gz: adee0c463fb89d9f112b3bc374c25fcb7fe60819f18952133df3afe789bcbabca5fcc184d144b5dff8db747098b2c8953cb440be474d6dd1df4ed004fd1e6467
+  data.tar.gz: 430b4df8d3095e9375320f9fbfa83aa24615bf2d6b19c2deba663fb69db3806a664dddd83c3f98f5f26b28c8de603f69d8ed926943043be905771d16595dc10e

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # CHANGELOG
 
+## v0.4.4
+* Remove deletion of delay messages after queues messages are sent from `.bulk`
+
 ## v0.4.3
 * Change gemspec to support older redis versions again
 

data/lib/redstream/producer.rb

@@ -52,11 +52,11 @@ module Redstream
     def bulk(records)
       records_array = Array(records)
 
-      delay_message_ids = bulk_delay(records_array)
+      bulk_delay(records_array)
 
       yield
 
-      bulk_queue(records_array, delay_message_ids: delay_message_ids)
+      bulk_queue(records_array)
     end
 
     # @api private
@@ -68,7 +68,7 @@ module Redstream
     # @return The redis message ids
 
     def bulk_delay(records)
-      res = records.each_slice(250).flat_map do |slice|
+      records.each_slice(250) do |slice|
         Redstream.connection_pool.with do |redis|
           redis.pipelined do |pipeline|
             slice.each do |object|
@@ -82,7 +82,7 @@ module Redstream
         redis.wait(@wait, 0) if @wait
       end
 
-      res
+      true
     end
 
     # @api private
@@ -90,15 +90,13 @@ module Redstream
     # Writes messages to a stream in redis for immediate retrieval.
     #
     # @param records [#to_a] The object/objects that will be updated deleted
-    # @param delay_message_ids [#to_a] The delay message ids to delete
 
-    def bulk_queue(records, delay_message_ids: nil)
-      records.each_with_index.each_slice(250) do |slice|
+    def bulk_queue(records)
+      records.each_slice(250) do |slice|
         Redstream.connection_pool.with do |redis|
           redis.pipelined do |pipeline|
-            slice.each do |object, index|
+            slice.each do |object|
               pipeline.xadd(Redstream.stream_key_name(stream_name(object)), { payload: JSON.dump(object.redstream_payload) })
-              pipeline.xdel(Redstream.stream_key_name("#{stream_name(object)}.delay"), delay_message_ids[index]) if delay_message_ids
             end
           end
         end

data/lib/redstream/version.rb

@@ -1,3 +1,3 @@
 module Redstream
-  VERSION = "0.4.3"
+  VERSION = "0.4.4"
 end

data/redstream.gemspec

@@ -14,7 +14,6 @@ Gem::Specification.new do |spec|
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "activerecord"

data/spec/redstream/producer_spec.rb

@@ -78,19 +78,6 @@ RSpec.describe Redstream::Producer do
         { "payload" => JSON.dump(products[1].redstream_payload) }
       ])
     end
-
-    it "deletes the delay messages after the queue messages have been sent" do
-      products = create_list(:product, 2)
-      producer = Redstream::Producer.new
-
-      other_delay_message_id = producer.delay(create(:product))
-
-      producer.bulk(products) do
-        expect(redis.xlen(Redstream.stream_key_name("products.delay"))).to eq(3)
-      end
-
-      expect(redis.xrange(Redstream.stream_key_name("products.delay"), "-", "+").map(&:first)).to eq([other_delay_message_id])
-    end
   end
 
   describe "#bulk_queue" do
@@ -108,18 +95,6 @@ RSpec.describe Redstream::Producer do
         { "payload" => JSON.dump(products[1].redstream_payload) }
       ])
     end
-
-    it "deletes the delay messages after the queue messages have been sent" do
-      products = create_list(:product, 2)
-      producer = Redstream::Producer.new
-
-      delay_message_ids = producer.bulk_delay(products)
-      other_delay_message_id = producer.delay(create(:product))
-
-      producer.bulk_queue(products, delay_message_ids: delay_message_ids)
-
-      expect(redis.xrange(Redstream.stream_key_name("products.delay"), "-", "+").map(&:first)).to eq([other_delay_message_id])
-    end
   end
 
   describe "#bulk_delay" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redstream
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Benjamin Vetter
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-28 00:00:00.000000000 Z
+date: 2022-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -294,12 +294,4 @@ signing_key:
 specification_version: 4
 summary: Using redis streams to keep your primary database in sync with secondary
   datastores
-test_files:
-- spec/redstream/consumer_spec.rb
-- spec/redstream/delayer_spec.rb
-- spec/redstream/lock_spec.rb
-- spec/redstream/model_spec.rb
-- spec/redstream/producer_spec.rb
-- spec/redstream/trimmer_spec.rb
-- spec/redstream_spec.rb
-- spec/spec_helper.rb
+test_files: []