redstream 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48ab0cf09dec323cf89c4bebe065054535f24402182208ee62ab0524e0d45fa3
-  data.tar.gz: 4264929febdbe55dfd240893d8f1327244937a835e2535cdf943342529e926a4
+  metadata.gz: 6be694edcad63b15c2e7a6630047080556a412fc1b52f874e4f793e8f07f80b9
+  data.tar.gz: f140446d6fbebc97533de509ff622fe32b121cd89af2c5f0cc2b856f5e820e02
 SHA512:
-  metadata.gz: 2507c6ebdeb7e4e1c0088af3f7711dce068b614c490222cb69a3634696c8be695e9485750f3c032f1b87d17653135bd59397a09bacc3d3d121f9fbce94251b9a
-  data.tar.gz: 66cf9439eebf813c7bca3426bb466189babec062da87eeb6f0a1a893d497fdf80cafe0bb63764aee7c1a56a07bdfbae9aebce91a2ff1eb2f8b4da4074a6f69af
+  metadata.gz: 2b38daa5a07f1761fa47340c4d479b974b30937479a6a73897ad8d8e47c9d45328ef976d20b8a74a7cb0488d35985864d162b3adbb66133e56195cb016b09ab4
+  data.tar.gz: 0b625e0f6fea967e69ba319115dd9bfd727b68aec369a83a0842bb39805b0389ebef33bae5cf2559314d54724a9fd28d5a517ab8cbdc88f14db1ec5a601c12ee

data/CHANGELOG.md

@@ -1,6 +1,8 @@
 # CHANGELOG
 
-* v0.1.0
+## v0.1.1
+* Fix missing queue message in `after_commit on: :destroy`
 
-- No longer queue/delay in after_save/after_commit if no changes occurred
-- Added Redstream.stream_size
+## v0.1.0
+* No longer queue/delay in `after_save`/`after_commit` if no changes occurred
+* Added `Redstream.stream_size`

data/lib/redstream/model.rb

@@ -32,7 +32,8 @@ module Redstream
         after_save { |object| producer.delay(object) if object.saved_changes.present? }
         after_touch { |object| producer.delay(object) }
         after_destroy { |object| producer.delay(object) }
-        after_commit { |object| producer.queue(object) if object.saved_changes.present? }
+        after_commit(on: [:create, :update]) { |object| producer.queue(object) if object.saved_changes.present? }
+        after_commit(on: :destroy) { |object| producer.queue(object) }
       end
 
       def redstream_name

data/lib/redstream/version.rb

@@ -1,3 +1,3 @@
 module Redstream
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/redstream/model_spec.rb

@@ -2,74 +2,72 @@ require File.expand_path("../spec_helper", __dir__)
 
 RSpec.describe Redstream::Model do
   describe "after_save" do
-    it "adds a delay message after save" do
-      expect(redis.xlen(Redstream.stream_key_name("products.delay"))).to eq(0)
-
-      time = Time.now
+    it "adds a delay message after_save" do
+      expect { create(:product) }.to change { redis.xlen(Redstream.stream_key_name("products.delay")) }
+    end
 
-      product = Timecop.freeze(time) do
-        create(:product)
-      end
+    it "adds the correct payload for the delay message" do
+      product = create(:product)
 
-      expect(redis.xlen(Redstream.stream_key_name("products.delay"))).to eq(1)
       expect(redis.xrange(Redstream.stream_key_name("products.delay"), "-", "+").first[1]).to eq("payload" => JSON.dump(product.redstream_payload))
     end
 
-    it "does not a delay message after save if there are no changes" do
+    it "adds a queue message after_save on commit" do
+      expect { create(:product) }.to change { redis.xlen(Redstream.stream_key_name("products")) }
+    end
+
+    it "does not add a delay message after_save if there are no changes" do
       product = create(:product)
 
       expect { product.save }.not_to change { redis.xlen(Redstream.stream_key_name("products.delay")) }
     end
+
+    it "does not add a queue messages after_save on commit if there are no changes" do
+      product = create(:product)
+
+      expect { product.save }.not_to change { redis.xlen(Redstream.stream_key_name("products")) }
+    end
   end
 
   describe "after_touch" do
     it "adds a delay message after touch" do
-      expect(redis.xlen(Redstream.stream_key_name("products.delay"))).to eq(0)
-
       product = create(:product)
 
-      time = Time.now
+      expect { product.touch }.to change { redis.xlen(Redstream.stream_key_name("products.delay")) }
+    end
 
-      Timecop.freeze(time) do
-        product.touch
-      end
+    it "sets the correct payload for the delay message" do
+      product = create(:product)
+      product.touch
 
-      expect(redis.xlen(Redstream.stream_key_name("products.delay"))).to eq(2)
       expect(redis.xrange(Redstream.stream_key_name("products.delay"), "-", "+").last[1]).to eq("payload" => JSON.dump(product.redstream_payload))
     end
+
+    it "adds a queue message after touch commit" do
+      product = create(:product)
+
+      expect { product.touch }.to change { redis.xlen(Redstream.stream_key_name("products")) }
+    end
   end
 
   describe "after_destroy" do
     it "adds a delay message after destroy" do
-      expect(redis.xlen(Redstream.stream_key_name("products.delay"))).to eq(0)
-
       product = create(:product)
 
-      time = Time.now
-
-      Timecop.freeze(time) do
-        product.touch
-      end
-
-      expect(redis.xlen(Redstream.stream_key_name("products.delay"))).to eq(2)
-      expect(redis.xrange(Redstream.stream_key_name("products.delay"), "-", "+").last[1]).to eq("payload" => JSON.dump(product.redstream_payload))
+      expect { product.destroy }.to change { redis.xlen(Redstream.stream_key_name("products.delay")) }
     end
-  end
-
-  describe "after_commit" do
-    it "adds a queue message after commit" do
-      expect(redis.xlen(Redstream.stream_key_name("products"))).to eq(0)
 
+    it "sets the correct payload for the delay message" do
       product = create(:product)
+      product.destroy
 
-      expect(redis.xlen(Redstream.stream_key_name("products"))).to eq(1)
-      expect(redis.xrange(Redstream.stream_key_name("products"), "-", "+").first[1]).to eq("payload" => JSON.dump(product.redstream_payload))
+      expect(redis.xrange(Redstream.stream_key_name("products.delay"), "-", "+").last[1]).to eq("payload" => JSON.dump(product.redstream_payload))
     end
 
-    it "does not add a queue message after commit if there are no changes" do
+    it "adds a queue messages after destroy on commit" do
       product = create(:product)
 
-      expect { product.save }.not_to change { redis.xlen(Redstream.stream_key_name("products")) }
+      expect { product.destroy }.to change { redis.xlen(Redstream.stream_key_name("products")) }.by(1)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redstream
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Benjamin Vetter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-10 00:00:00.000000000 Z
+date: 2020-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -288,8 +288,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Using redis streams to keep your primary database in sync with secondary