redshift-client 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b658841f49c42bf499c3f22897a4705513570c93
-  data.tar.gz: 1742bf0ceafb98d437226a4bf4a326560e4b7d76
+  metadata.gz: 57e6fbf69de3d525922584318839428a561a0f6b
+  data.tar.gz: f66fd482e6d7f9c6edce75a631797e5fd18164b6
 SHA512:
-  metadata.gz: 5378dd022002853efb3f3941dba78b10ca841a6f20cd5e0c25b2a6833d0185940feb4662ba106c6dea7005966a11ef8fb5cdbbf12c911ad057e3998d48667f5a
-  data.tar.gz: dab2d572ee46543f268a830640c66034c83a81516398979a5dc10ff2875d2dbcfac15ddd9d8e8e089203269aad499e949269ae5711c049a47f34e158061dae1d
+  metadata.gz: 83b406edb33a22f17bd980c97261aea3b6a7e0a4ee28c48c888f4ca2418b04952e986a11b5874b5cf0fe9fb2259755e4e4cd77c4a03d7be281a799b6a1a0236f
+  data.tar.gz: abbe01a0b47e299370ffd150d9fd02c788bfe78a01a1b1ab17769644e80f3c232501a81c0bba784301ca0e190e49e3e3f116736e2432c7dc29c6a99b1a985b77

data/lib/redshift/client/connection_handling.rb

@@ -1,5 +1,6 @@
 require 'pg'
 require 'uri'
+require 'active_support/lazy_load_hooks'
 
 module Redshift
   module Client
@@ -26,7 +27,7 @@ module Redshift
       end
 
       def connection
-        raise ConnectionNotEstablished.new unless established?
+        ActiveSupport.run_load_hooks :redshift_client_connection unless established?
 
         if connected?
           thread[:connection]
@@ -49,6 +50,7 @@ module Redshift
       end
 
       def connect!
+        raise ConnectionNotEstablished.new unless established?
         thread[:connection] = PG.connect(thread[:configurations].to_hash)
       end
 

data/lib/redshift/client/version.rb

@@ -1,5 +1,5 @@
 module Redshift
   module Client
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

data/redshift-client.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_runtime_dependency "pg"
+  spec.add_runtime_dependency "activesupport", ">= 4"
 
   spec.add_development_dependency "bundler", "~> 1.10"
   spec.add_development_dependency "rake", "~> 10.0"

data/spec/redshift/client_spec.rb

@@ -53,6 +53,31 @@ describe Redshift::Client do
     end
   end
 
+  describe "#connection" do
+    context "when already established" do
+      before do
+        Redshift::Client.establish_connection
+      end
+
+      it "returns PG::Connection" do
+        expect(Redshift::Client.connection).to be_instance_of PG::Connection
+      end
+    end
+
+    context "when not yet established" do
+      before do
+        allow(ActiveSupport).to receive :run_load_hooks
+      end
+
+      it "calls ActiveSupport#run_load_hooks and raise error" do
+        Thread.new {
+          expect { Redshift::Client.connection }.to raise_error(Redshift::Client::ConnectionNotEstablished)
+          expect(ActiveSupport).to have_received(:run_load_hooks).with(:redshift_client_connection).once
+        }.join
+      end
+    end
+  end
+
   describe "#established?" do
     context "when already established" do
       before do
@@ -70,7 +95,7 @@ describe Redshift::Client do
 
     context "when not yet established" do
       it "returns false" do
-        Thread.new { expect(Redshift::Client).not_to be_established }
+        Thread.new { expect(Redshift::Client).not_to be_established }.join
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redshift-client
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Dai Akatsuka
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement