redmine_nonproject_modules 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5376c3a5a50a27ab5825bf4c0d6c6cadc2d672047808792d8b7b2d5b47118443
-  data.tar.gz: b173b20f273e8236950d0ac67641e40b23a88395ad35a7157828a6c29dddc296
+  metadata.gz: 814d3dfc718b68bc5fe007744f2a692d11d4b1a9cbd2ee927a87ce50fa2567f8
+  data.tar.gz: 5012e42e690df9bbcea7403a72b116e633e98dabcac7cadd18e3386c9511c3e1
 SHA512:
-  metadata.gz: 3b78a4ccfc86da2be65496081ad35730be443faec2b2da9a299ceb4ae8a31e89ede3f94a8b16098484fc5be448b7835179a386c8d494a2201e31173d92ab1446
-  data.tar.gz: 57bf1adcd605ee92b9d1be876d67c279cee75b90cc49017996c955dd61c81e61a31370958de94db143ac1fdde6b73c2a4152fcc8714aae1edfc90cfb72f1ed47
+  metadata.gz: 9c20081f983fb4fcbe99dced67e283c7448294fd03a6667a867e7bf56e1aa49ec2660ad2449189c056972b069ea858960246fd7b54a6fe9b12a25ac309f6337d
+  data.tar.gz: b896a7c1706015d050b178fa5faaa4d8c1d68cd0fa9a0bfc1bc6e7bbfa7df5867651ba58facb47389b8cae46802659b289fe969cedc5930d554e1c58a71e279b

data/app/controllers/group_merge_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupMergeController < ApplicationController
   require_permission 'group_merge'
   helper GroupMergeHelper
@@ -10,6 +12,7 @@ class GroupMergeController < ApplicationController
   def check
     @group_merge = ::GroupMerge.new(check_parameters)
     return if @group_merge.valid?
+
     build_targets_list
     render :index
   end

data/app/controllers/group_permissions_controller.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 class GroupPermissionsController < ApplicationController
   require_permission 'group_permissions'
-  before_action :set_group, only: [:show, :update]
+  before_action :set_group, only: %i[show update]
 
   def index
     @groups = Group.sorted

data/app/controllers/nonproject_modules_controller.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class NonprojectModulesController < ApplicationController
+  layout 'nonproject_modules'
+
+  def index; end
+end

data/app/helpers/group_merge_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GroupMergeHelper
   def group_merge_elements_sorted(group_merge)
     r = group_merge.to_merge_elements.map do |x|
@@ -8,8 +10,8 @@ module GroupMergeHelper
     r.sort_by { |x| [x[0], x[1]] }
   end
 
-  def group_merge_element_class(x)
-    "GroupMergeHelper_element_#{x[1]}"
+  def group_merge_element_class(element)
+    "GroupMergeHelper_element_#{element[1]}"
   end
 
   def group_merge_type_element_label(element)
@@ -21,11 +23,11 @@ module GroupMergeHelper
     respond_to?(m) ? send(m, element) : element.to_s
   end
 
-  def group_merge_member_element_label(m)
-    "#{t(:label_project)}: #{m.project} (#{m.roles.to_a.join(', ')})"
+  def group_merge_member_element_label(member)
+    "#{t(:label_project)}: #{member.project} (#{member.roles.to_a.join(', ')})"
   end
 
-  def group_merge_group_permission_element_label(gp)
-    gp.permission
+  def group_merge_group_permission_element_label(group_permission)
+    group_permission.permission
   end
 end

data/app/models/group_merge.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'virtus'
 
 class GroupMerge
@@ -39,16 +41,17 @@ class GroupMerge
   end
 
   def associations_to_merge
-    [:users, :memberships, :permissions]
+    %i[users memberships permissions]
   end
 
   private
 
-  def element_on_status(x)
-    return ON_BOTH if target_elements.include?(x) && source_elements.include?(x)
-    return ONLY_ON_TARGET if target_elements.include?(x)
-    return ONLY_ON_SOURCE if source_elements.include?(x)
-    raise "Element is neither on source nor on target: #{x}"
+  def element_on_status(element)
+    return ON_BOTH if target_elements.include?(element) && source_elements.include?(element)
+    return ONLY_ON_TARGET if target_elements.include?(element)
+    return ONLY_ON_SOURCE if source_elements.include?(element)
+
+    raise "Element is neither on source nor on target: #{element}"
   end
 
   def target_elements
@@ -68,8 +71,8 @@ class GroupMerge
   end
 
   def source_new_elements
-    source_elements.select do |x|
-      !target_elements.include?(x)
+    source_elements.reject do |x|
+      target_elements.include?(x)
     end
   end
 

data/app/models/group_permission.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'eac_ruby_utils/simple_cache'
 
 class GroupPermission < ActiveRecord::Base
@@ -27,23 +29,26 @@ class GroupPermission < ActiveRecord::Base
 
     def permission?(permission, user = false)
       return permission_by_hash?(permission, user) if permission.is_a?(Hash)
+
       permission(permission).user_has?(user || User.current)
     end
 
     def permission(key)
       key = key.to_s
       return permissions_hash[key] if permissions_hash.key?(key)
+
       raise "Not found \"#{key}\" in GroupPermission::permissions"
     end
 
     private
 
     def permissions_hash
-      @permissions ||= {}.with_indifferent_access
+      @permissions_hash ||= {}.with_indifferent_access
     end
 
     def permission_by_hash?(hash, user)
-      raise 'Hasy should have :or parameter' unless hash[:or].present?
+      raise 'Hasy should have :or parameter' if hash[:or].blank?
+
       ps = hash[:or].is_a?(Array) ? hash[:or] : [hash[:or]]
       ps.any? { |p| permission?(p, user) }
     end
@@ -53,8 +58,8 @@ class GroupPermission < ActiveRecord::Base
     include ::EacRubyUtils::SimpleCache
 
     class << self
-      def sanitize_key(k)
-        k.to_s.downcase
+      def sanitize_key(key)
+        key.to_s.downcase
       end
     end
 
@@ -75,11 +80,13 @@ class GroupPermission < ActiveRecord::Base
 
     def user_has?(user)
       return true if user.admin
+
       GroupPermission.where(group: user_groups(user), permission: depends_recursive.to_a).any?
     end
 
     def depends_recursive(visited = Set.new)
       return [] if visited.include?(key)
+
       r = Set.new([key])
       visited << key
       depends.each do |d|
@@ -96,6 +103,7 @@ class GroupPermission < ActiveRecord::Base
 
     def user_groups(user)
       return [Group.anonymous] if user.anonymous?
+
       [Group.anonymous, Group.non_member] + user.groups
     end
 

data/app/models/group_permissions_setup.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupPermissionsSetup
   include ActiveModel::Model
 

data/app/views/layouts/_nonproject_modules_menu.html.erb

@@ -0,0 +1,14 @@
+<% any_available = false %>
+<% ::Redmine::Plugin.registered_plugins.keys.each do |plugin_key| %>
+  <% content = render_menu plugin_key %>
+  <% if content %>
+    <% any_available = true %>
+    <div style="margin-bottom: 1.0em">
+      <h4><%= t("menu_#{plugin_key}") %></h4>
+      <%= content %>
+    </div>
+  <% end %>
+<% end %>
+<% unless any_available %>
+  <p><em><%= t(:none_module_available) %></em></p>
+<% end %>

data/app/views/layouts/nonproject_modules.html.erb

@@ -0,0 +1,5 @@
+<% content_for :sidebar do %>
+  <h3><%= t(:label_nonproject_modules) %></h3>
+  <%= render partial: 'layouts/nonproject_modules_menu' %>
+<% end %>
+<%= render :file => "layouts/base" %>

data/app/views/nonproject_modules/index.html.erb

@@ -0,0 +1,7 @@
+<h2><%= t(:label_nonproject_modules) %></h2>
+<% if User.current.anonymous? %>
+  <p>Faça o <%= link_to('login', signin_path) %> para que o acesso aos módulos
+    apareçam à direita.</p>
+<% else %>
+  <p>Navegue pelo menu à direita.</p>
+<% end %>

data/config/initializers/000_dependencies.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Redmine::Plugin.post_register :redmine_nonproject_modules do
   # Source: https://github.com/esquilo-azul/redmine_plugins_helper
   requires_redmine_plugin(:redmine_plugins_helper, version_or_higher: '0.5.2')

data/config/locales/en.yml

@@ -4,7 +4,9 @@ en:
   in_both_group: In both groups.
   label_group_permission: Group permission
   label_group_permission_plural: Groups / Permissions
+  label_nonproject_modules: Non-project
   merge: Merge
+  none_module_available: 'No modules available.'
   group_will_receive_elements: 'The group "%{group}" will receive the following elements:'
   only_in_group: 'Only in "%{group}".'
   permission_group_permissions_description: Read/write access to groups' permissions.

data/config/locales/pt-BR.yml

@@ -5,7 +5,9 @@ pt-BR:
   in_both_group: Em ambos os grupos.
   label_group_permission: Permissão de grupo
   label_group_permission_plural: Grupos / Permissões
+  label_nonproject_modules: Não-projetos
   merge: Mesclar
+  none_module_available: 'Nenhum módulo disponível.'
   group_will_receive_elements: 'O grupo "%{group}" receberá os seguintes elementos:'
   only_in_group: 'Somente em "%{group}".'
   permission_group_permissions_description: Visualização/modificação das

data/config/routes.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 RedmineApp::Application.routes.draw do
-  resources(:group_permissions, only: [:index, :show, :update])
+  resources(:group_permissions, only: %i[index show update])
+  resources(:nonproject_modules, only: [:index])
   get '/group/:id/merge', to: 'group_merge#index', as: :merge_group
   post '/group/:id/merge_check', to: 'group_merge#check', as: :merge_check_group
   post '/group/:id/merge_confirm', to: 'group_merge#confirm', as: :merge_confirm_group

data/init.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'active_scaffold'
 
@@ -24,6 +24,11 @@ Redmine::Plugin.register :redmine_nonproject_modules do
               if: proc { GroupPermission.permission?('group_permissions') }
   end
 
+  Redmine::MenuManager.map :top_menu do |menu|
+    menu.push :nonproject_modules, { controller: 'nonproject_modules', action: 'index', id: nil },
+              caption: :label_nonproject_modules
+  end
+
   ActiveScaffold.delayed_setup = true
 end
 

data/lib/redmine_nonproject_modules/dispatcher_finder.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'eac_ruby_utils/simple_cache'
 
 module RedmineNonprojectModules
   # https://stackoverflow.com/questions/12088025/detect-if-application-was-started-as...
   # https://github.com/newrelic/rpm/blob/master/lib/new_relic/local_environment.rb
   class DispatcherFinder
-    WEBSERVER_DISPATCHERS = %w(webrick passenger).freeze
+    WEBSERVER_DISPATCHERS = %w[webrick passenger].freeze
     DISPATCHERS = WEBSERVER_DISPATCHERS
 
     class << self

data/lib/redmine_nonproject_modules/patches/controller_patch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RedmineNonprojectModules
   module Patches
     module ControllerPatch
@@ -7,14 +9,15 @@ module RedmineNonprojectModules
       end
 
       module ClassMethods
-        def require_permission(permission)
-          before_action { |c| c.before_action_require_permission(permission) }
+        def require_permission(permission, options = {})
+          before_action(options) { |c| c.before_action_require_permission(permission) }
         end
       end
 
       module InstanceMethods
         def before_action_require_permission(permission)
           return true if GroupPermission.permission?(permission)
+
           deny_access
         end
       end

data/lib/redmine_nonproject_modules/patches/group_patch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RedmineNonprojectModules
   module Patches
     module GroupPatch
@@ -12,6 +14,7 @@ module RedmineNonprojectModules
         def add_permission(permission)
           permission = permission.permission if permission.is_a?(::GroupPermission)
           return if permissions.pluck(:permission).include?(permission)
+
           ::GroupPermission.create!(group: self, permission: permission)
         end
       end

data/lib/redmine_nonproject_modules/patches/redmine/menu_manager_patch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RedmineNonprojectModules
   module Patches
     module Redmine
@@ -72,10 +74,11 @@ module RedmineNonprojectModules
           controller_class.const_get('PERMISSIONS')
         end
 
-        def parse_permissions(p)
-          return parse_permissions(p.values) if p.is_a?(Hash)
-          return p.flat_map { |v| parse_permissions(v) } if p.is_a?(Enumerable)
-          [p.to_s]
+        def parse_permissions(permission)
+          return parse_permissions(permission.values) if permission.is_a?(Hash)
+          return permission.flat_map { |v| parse_permissions(v) } if permission.is_a?(Enumerable)
+
+          [permission.to_s]
         end
       end
     end

data/lib/redmine_nonproject_modules/patches/user_patch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RedmineNonprojectModules
   module Patches
     module UserPatch

data/lib/redmine_nonproject_modules/version.rb

@@ -4,5 +4,5 @@ module RedmineNonprojectModules
   AUTHOR = 'Eduardo Henrique Bogoni'
   HOMEPAGE = 'https://github.com/esquilo-azul/redmine_nonproject_modules'
   SUMMARY = 'Support to non-project modules.'
-  VERSION = '0.2.1'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redmine_nonproject_modules
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
-- 0.2.1
+- 0.3.0
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-26 00:00:00.000000000 Z
+date: 2019-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_scaffold
@@ -88,6 +88,7 @@ files:
 - app/assets/stylesheets/redmine_nonproject_modules.css
 - app/controllers/group_merge_controller.rb
 - app/controllers/group_permissions_controller.rb
+- app/controllers/nonproject_modules_controller.rb
 - app/helpers/group_merge_helper.rb
 - app/models/group_merge.rb
 - app/models/group_permission.rb
@@ -98,6 +99,9 @@ files:
 - app/views/group_permissions/_member_context.html.erb
 - app/views/group_permissions/index.html.erb
 - app/views/group_permissions/show.html.erb
+- app/views/layouts/_nonproject_modules_menu.html.erb
+- app/views/layouts/nonproject_modules.html.erb
+- app/views/nonproject_modules/index.html.erb
 - config/initializers/000_dependencies.rb
 - config/locales/en.yml
 - config/locales/pt-BR.yml