redmine_acts_as_taggable_on 0.3.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2bc9e3d024cb678113b306c60f49d40462100594
-  data.tar.gz: 8ecbd8e715db36c5351c67494a51320dfb3440c0
+  metadata.gz: 7a8aebb95ce3366f4a0a5bca2b04eb5c99e92b9f
+  data.tar.gz: 2107a0155fafe2af5f4eec883fad6fb192de8178
 SHA512:
-  metadata.gz: 3d7251ac7ad29c285e6a8e317093a65ea67a62ed3d3bd73508abeca025da19dd8f34962a5360e7b474080b1d1b92c1455e565472f5b5d884da76490c46556d31
-  data.tar.gz: af42f34a2a26b8e627945a39e796cfb5a5eba32d689278763769443706ba97528e596e2d666a65bb9f5aa792890b39db9bd12d0df1f3b3ff7d86a7ca9ec0c6ca
+  metadata.gz: b476996b9db2467b8129b78b5f6eaae42a0a0dbc3f4f3a161c150bc93c8b935f80bc3bd5ff0eeea3b8bbba9756290bf6b541b2e85026af5f5675cb800935dfcc
+  data.tar.gz: f31a1fe060dff5ea5d7c170c204dc172395105ab3612bb9168c217d72fb4f1f7de1087bd6148bd76ae21db3eb6fd56f7cd7e461977350a7f69b7a701b7e8983e

data/.travis.yml

@@ -1,13 +1,23 @@
 language: ruby
-before_install:
-  - gem update --system 1.8.25
-  - gem --version
+install: echo 'explicitly doing nothing'
 script: ./test/run.bash
-rvm: 2.0.0-p0
-env: branches="trunk tags/2.3.1"
+rvm:
+  - 2.0.0-p0
+  - 1.9.3-p392
+  - 1.8.7-p371
+env:
+  - branches="trunk"
+  - branches="tags/2.3.1"
+  - branches="tags/2.2.4"
+  - branches="tags/2.1.5"
+  - branches="tags/2.0.4"
 matrix:
-  include:
-    - rvm: 1.9.3-p392
-      env: branches="trunk tags/2.3.1 tags/2.2.4 tags/2.1.5 tags/2.0.4"
-    - rvm: 1.8.7-p371
-      env: branches="trunk tags/2.3.1 tags/2.2.4 tags/2.1.5 tags/2.0.4"
+  exclude:
+    # these versions are known not to work together, according to
+    # http://www.redmine.org/projects/redmine/wiki/RedmineInstall
+    - rvm: 2.0.0-p0
+      env: branches="tags/2.2.4"
+    - rvm: 2.0.0-p0
+      env: branches="tags/2.1.5"
+    - rvm: 2.0.0-p0
+      env: branches="tags/2.0.4"

data/README.md

@@ -52,7 +52,17 @@ some nasty monkey-patching. On the other hand, data loss is no fun at all.
 
 Add it to your plugin's Gemfile:
 
-    gem 'redmine_acts_as_taggable_on', '~> 0.3.0'
+    gem 'redmine_acts_as_taggable_on', '~> 1.0'
+
+**Note**: Please use the above line _verbatim_. This is to avoid being told by
+Bundler that we aren't allowed to use multiple declarations of the same gem
+with different version requirements.
+
+I've chosen the above requirement to ensure that there are no accidental
+breakages -- the public API (that is, the following paragraph) will remain the
+same throughout version 1.0. If it does need to change, I'll bump the major
+version. This should ensure that Bundler only refuses to bundle when there is
+an actual incompatibility.
 
 Add the migration:
 

data/lib/redmine_acts_as_taggable_on/version.rb

@@ -1,3 +1,3 @@
 module RedmineActsAsTaggableOn
-  VERSION = "0.3.0"
+  VERSION = "1.0.0"
 end

data/test/mk_temp_redmine.bash

@@ -1,31 +1,38 @@
 #!/usr/bin/env bash
 set -e
 
+# if --verbose is given, output logging info to stdout. Otherwise, to /dev/null
+if [ "$1" = "--verbose" ]; then
+  shift
+  mk_temp_redmine_out="/dev/fd/2"
+else
+  mk_temp_redmine_out="/dev/null"
+fi
+
 # makes a new Redmine installation in a temporary directory, using SQLite as
 # the database.
-make_temp_redmine() {
-  local branch="$1"
-  [ -z "$branch" ] && branch="trunk"
+branch="$1"
+[ -z "$branch" ] && branch="trunk"
 
-  # for branches which have slashes in them, like tags/2.3.0
-  local branch_filename="${branch//\//-}"
-  temp_redmine=`mktemp -d /tmp/redmine_acts_as_taggable_on.$branch_filename.XXXXXXX`
-  pushd "$temp_redmine"
+# for branches which have slashes in them, like tags/2.3.0
+branch_filename="${branch//\//-}"
+temp_redmine=`mktemp -d /tmp/redmine_acts_as_taggable_on.$branch_filename.XXXXXXX`
+cd "$temp_redmine"
 
-  svn checkout "http://svn.redmine.org/redmine/$branch" redmine
-  pushd redmine
+svn checkout "http://svn.redmine.org/redmine/$branch" redmine \
+  > "$mk_temp_redmine_out"
+cd redmine
 
-  echo "production:
+echo "production:
   adapter: sqlite3
   database: db/redmine.sqlite3" > config/database.yml
 
-  bundle install \
-    --without="postgresql development test mysql rmagick ldap"
-  rake generate_secret_token db:create db:migrate
+bundle install \
+  --without="development test rmagick ldap mysql postgresql" \
+  --gemfile="$PWD/Gemfile" \
+  --binstubs \
+  > "$mk_temp_redmine_out"
 
-  popd
-  popd
-}
+rake db:create db:migrate > "$mk_temp_redmine_out"
 
-make_temp_redmine "$1" >/dev/null
 echo "$temp_redmine"

data/test/run.bash

@@ -3,18 +3,21 @@ set -e
 
 # Run all the tests on a specific branch of Redmine.
 run_tests_on_branch() {
-  temp_redmine_path="$(test/mk_temp_redmine.bash "$1")"
-  if [ "$?" -ne 0 ]; then
+  local temp_redmine_path="$($redmine_acts_as_taggable_on_path/test/mk_temp_redmine.bash "$1")"
+  if [ "$?" -ne 0 ] || [ -z "$temp_redmine_path" ]; then
     echo "failed to create temporary redmine on $1: cancelling these tests"
     return 1
   fi
 
   export temp_redmine_path
-
-  [ -f test/bats/bin/bats ] || git submodule update
+  cd "$temp_redmine_path/redmine"
 
   local test_status=0
-  test/bats/bin/bats test/test.bats || test_status=1
+  "$redmine_acts_as_taggable_on_path/test/bats/bin/bats" \
+    "$redmine_acts_as_taggable_on_path/test/test.bats" || test_status=1
+
+  # avoid 'error retrieving current directory' during the next test
+  cd /tmp
 
   if [ "$test_status" -eq 1 ]; then
     echo "Some tests failed on $1. You can inspect the tree at $temp_redmine_path"
@@ -22,16 +25,17 @@ run_tests_on_branch() {
     rm -rf "$temp_redmine_path"
   fi
 
-  temp_redmine_path=""
   return $test_status
 }
 
-RAILS_ENV="production"
-export RAILS_ENV
+export RAILS_ENV="production"
+
+# these are needed on Travis CI
+export BUNDLE_GEMFILE=""
+export PATH="./bin:$PATH"
 
 redmine_acts_as_taggable_on_path="$(cd "$(dirname "${BASH_SOURCE[0]}")"/.. && pwd)"
 export redmine_acts_as_taggable_on_path
-pushd "$redmine_acts_as_taggable_on_path" >/dev/null
 
 # branches should be a space-separated string of repo paths to check out.
 # We don't use an array because they're difficult to export.
@@ -48,5 +52,4 @@ for branch in $branches; do
   echo
 done
 
-popd >/dev/null
 exit $test_status

data/test/test.bats

@@ -7,7 +7,6 @@ load test_helpers
 preserved_files=(db/redmine.sqlite3 db/schema.rb)
 
 setup() {
-  pushd "$temp_redmine_path/redmine" >/dev/null
   for file in ${preserved_files[@]}; do
       cp $file $file.bak
   done
@@ -18,7 +17,6 @@ teardown() {
   for file in ${preserved_files[@]}; do
       mv $file.bak $file
   done
-  popd >/dev/null
 }
 
 @test "migrates upwards with solitary proper plugin" {

data/test/test_helpers.bash

@@ -4,12 +4,11 @@
 mk_standard_plugin() {
   local name="redmine_$1"
   mkdir plugins/$name
-  pushd plugins/$name >/dev/null
+  cd plugins/$name
 
   echo "Redmine::Plugin.register(:$name) { name '$name' }" > init.rb
 
-  popd >/dev/null
-
+  cd ../..
   echo "Created a standard redmine plugin: $name"
 }
 
@@ -17,7 +16,7 @@ mk_standard_plugin() {
 mk_proper_plugin() {
   mk_standard_plugin "$1" >/dev/null
   local name="redmine_$1"
-  pushd plugins/$name >/dev/null
+  cd plugins/$name
 
   echo "source 'https://rubygems.org'
 gem 'redmine_acts_as_taggable_on',
@@ -31,10 +30,8 @@ Redmine::Plugin.register(:$name) { requires_acts_as_taggable_on }" \
   echo "class AddTagsAndTaggings < RedmineActsAsTaggableOn::Migration; end" \
     > db/migrate/001_add_tags_and_taggings.rb
 
-  bundle >/dev/null
-
-  popd >/dev/null
-
+  cd ../..
+  bundle --gemfile="$PWD/Gemfile"
   echo "Created a redmine plugin using redmine_acts_as_taggable_on: $name"
 }
 
@@ -43,13 +40,12 @@ Redmine::Plugin.register(:$name) { requires_acts_as_taggable_on }" \
 mk_plugin_missing_declaration() {
   mk_proper_plugin "$1" >/dev/null
   local name="redmine_$1"
-  pushd plugins/$name >/dev/null
+  cd plugins/$name
 
   echo "require 'redmine_acts_as_taggable_on/initialize'
 Redmine::Plugin.register(:$name) { name '$name' }" > init.rb
 
-  popd >/dev/null
-
+  cd ../..
   echo "Created a redmine plugin using redmine_acts_as_taggable_on"
   echo "  (but without the declaration): $name"
 }
@@ -59,13 +55,13 @@ Redmine::Plugin.register(:$name) { name '$name' }" > init.rb
 mk_old_style_plugin() {
   mk_standard_plugin "$1" >/dev/null
   local name="redmine_$1"
-  pushd plugins/$name >/dev/null
+  cd plugins/$name
 
   echo "source 'https://rubygems.org'
 gem 'acts-as-taggable-on'" > Gemfile
-  bundle >/dev/null
-  popd >/dev/null
 
+  cd ../..
+  bundle --gemfile="$PWD/Gemfile"
   echo "Created a plugin using acts-as-taggable-on without the embedded"
   echo "  migration: $name"
 }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redmine_acts_as_taggable_on
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Harry Garrood