redis_ring_client 0.1.0 → 0.1.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    redis_ring_client (0.0.4)
+    redis_ring_client (0.1.0)
       json
       redis
       zookeeper

data/lib/redis_ring/client/ring_meta_data.rb

@@ -42,17 +42,26 @@ module RedisRing
       end
 
       def get_shards_json_string(retries = 0)
-        @zookeeper ||= Zookeeper.new(zookeeper_addr)
+        @zookeeper ||= self.class.zookeeper(zookeeper_addr)
         @watcher = Zookeeper::WatcherCallback.new
         resp = @zookeeper.get(:path => "/cluster_status", :watcher => @watcher, :watcher_context => "/cluster_status")
         return resp[:data]
       rescue ZookeeperExceptions::ZookeeperException::ConnectionClosed
         raise if retries == 4
-        puts "reopening"
         @zookeeper.reopen
         return get_shards_json_string(retries + 1)
       end
 
+      def self.zookeepers
+        @zookeepers ||= {}
+      end
+
+      # it appears that only a very limited number of zookeeper connections can be opened by a single client
+      # so we have to cache/share them between RingMetaData instances
+      def self.zookeeper(address)
+        self.zookeepers[address] ||= Zookeeper.new(address)
+      end
+
     end
 
     class ShardMetaData

data/lib/redis_ring/client/version.rb

@@ -1,5 +1,5 @@
 module RedisRing
   module Client
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/spec/redis_ring/client/ring_proxy_spec.rb

@@ -36,11 +36,8 @@ describe RedisRing::Client::RingProxy do
   end
 
   context "with real RedisRing" do
-    before(:all) do
-      @proxy = RedisRing::Client::RingProxy.new
-    end
-
     before(:each) do
+      @proxy = RedisRing::Client::RingProxy.new
       @proxy.flushdb
     end
 

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Adam Pohorecki