redis 4.5.0 → 4.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1e483240f70aa8a92a7fe1f38968262ea82e84a97e436a9c7c695c032584313
-  data.tar.gz: 1cb164b2d588ef2f2701b91371a12a0d90299a78994f0d614cb14ab0daa36243
+  metadata.gz: 7a7232fef186e6d6a11a90d8dd9aa7c71114f017e0afe9378999a96c9e6b4e05
+  data.tar.gz: 689f176b87909bf61eb60e57d1eb795198162a7e039104c80facf36880964bda
 SHA512:
-  metadata.gz: 72c3e91839061ae26e27cbb08330f752acbba5f440c8549cad4325b2c2f517a907a0db11330ca9ba221255aa7b570efe2050bde9cbb905217794c4754c53dadb
-  data.tar.gz: e92cc58111fb9e1553a3363c56569ef6064c3851263d5eb86147c907878650b697db5c598b2b2046f9c9025cc40ca7eda5ce16f4f21049ac49f09385cf80a92f
+  metadata.gz: 22b11dee92e298b46bb94a707156d3dbf9afb83c8e9e8cbf82cf366d582a7c1b7295d7f09a0fec01965245f4800c2482c0559d646f46ff1c6bba6423ab398ba9
+  data.tar.gz: 9a74ba29c8cb3d7634a44c78e30018a048e19cca66c7fad6a226722183f66546bebb370c92ecdf20522bb35ee72a09b2fda64891ff6d94db1702375bd1ba6b46

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Unreleased
 
+# 4.5.1
+
+* Restore the accidential auth behavior of redis-rb 4.3.0 with a warning. If provided with the `default` user's password, but a wrong username,
+  redis-rb will first try to connect as the provided user, but then will fallback to connect as the `default` user with the provided password.
+  This behavior is deprecated and will be removed in Redis 4.6.0. Fix #1038.
+
 # 4.5.0
 
 * Handle parts of the command using incompatible encodings. See #1037.

data/lib/redis/client.rb

@@ -122,6 +122,16 @@ class Redis
             rescue CommandError => err # Likely on Redis < 6
               if err.message.match?(/ERR wrong number of arguments for \'auth\' command/)
                 call [:auth, password]
+              elsif err.message.match?(/WRONGPASS invalid username-password pair/)
+                begin
+                  call [:auth, password]
+                rescue CommandError
+                  raise err
+                end
+                ::Kernel.warn(
+                  "[redis-rb] The Redis connection was configured with username #{username.inspect}, but" \
+                  " the provided password was for the default user. This will start failing in redis-rb 4.6."
+                )
               else
                 raise
               end

data/lib/redis/connection/ruby.rb

@@ -21,7 +21,7 @@ class Redis
         super(*args)
 
         @timeout = @write_timeout = nil
-        @buffer = "".dup
+        @buffer = "".b
       end
 
       def timeout=(timeout)
@@ -32,30 +32,13 @@ class Redis
         @write_timeout = (timeout if timeout && timeout > 0)
       end
 
-      string_capacity_support = begin
-        String.new(capacity: 0)
-        true # Ruby 2.4+
-      rescue ArgumentError
-        false # Ruby 2.3
-      end
-
-      if string_capacity_support
-        def read(nbytes)
-          result = @buffer.slice!(0, nbytes)
+      def read(nbytes)
+        result = @buffer.slice!(0, nbytes)
 
-          buffer = String.new(capacity: nbytes, encoding: Encoding::ASCII_8BIT)
-          result << _read_from_socket(nbytes - result.bytesize, buffer) while result.bytesize < nbytes
+        buffer = String.new(capacity: nbytes, encoding: Encoding::ASCII_8BIT)
+        result << _read_from_socket(nbytes - result.bytesize, buffer) while result.bytesize < nbytes
 
-          result
-        end
-      else
-        def read(nbytes)
-          result = @buffer.slice!(0, nbytes)
-
-          result << _read_from_socket(nbytes - result.bytesize, "".b) while result.bytesize < nbytes
-
-          result
-        end
+        result
       end
 
       def gets

data/lib/redis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Redis
-  VERSION = '4.5.0'
+  VERSION = '4.5.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redis
 version: !ruby/object:Gem::Version
-  version: 4.5.0
+  version: 4.5.1
 platform: ruby
 authors:
 - Ezra Zygmuntowicz
@@ -16,7 +16,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-10-14 00:00:00.000000000 Z
+date: 2021-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: em-synchrony
@@ -102,9 +102,9 @@ licenses:
 metadata:
   bug_tracker_uri: https://github.com/redis/redis-rb/issues
   changelog_uri: https://github.com/redis/redis-rb/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/redis/4.5.0
+  documentation_uri: https://www.rubydoc.info/gems/redis/4.5.1
   homepage_uri: https://github.com/redis/redis-rb
-  source_code_uri: https://github.com/redis/redis-rb/tree/v4.5.0
+  source_code_uri: https://github.com/redis/redis-rb/tree/v4.5.1
 post_install_message:
 rdoc_options: []
 require_paths: