redis-session-store 0.6.1 → 0.6.4

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 2b6b105a9579a8c097a1234c80dc058309866fe6
+  data.tar.gz: 2c405132ca0f846a51189e8a63d0a02ab3d974b5
+SHA512:
+  metadata.gz: af87b6104ce6ae3e347a22cc6da952c6aae4fd6ca758e563ebd03e2c966e6546270e152770b25820897e91a5f53d6ceae9c31049efb0105752af3d46798ed644
+  data.tar.gz: 5d4075ed6b6d493659b39d7feddc68b1cb9d8066659cba7147f9e47de3c7b4d749df56a6412d7c0f43936591288b9edf0b7d500259d1b5242380afec3e1919a1

data/.rubocop.yml

@@ -12,4 +12,4 @@ FileName:
 # Offense count: 1
 # Configuration parameters: CountComments.
 ClassLength:
-  Max: 103
+  Max: 110

data/CHANGELOG.md

@@ -1,6 +1,23 @@
 redis-session-store history
 ===========================
 
+## v0.6.4 (2014-04-04)
+
+* Reverting `setnx` usage in v0.6.3 so we can change our sessions.
+
+## v0.6.3 (2014-04-01)
+
+* Reverting the `#setnx` change in `0.6.2` as it behaved badly under
+  load, hitting yet another race condition issue and pegging the CPU.
+* Setting session ID with a multi-call `#setnx` and `#expire` instead of
+  `#setex`.
+
+## v0.6.2 (2014-03-31)
+
+* Use `#setnx` instead of `#get` when checking for session ID
+  collisions, which is slightly more paranoid and should help avoid a
+  particularly nasty edge case.
+
 ## v0.6.1 (2014-03-17)
 
 * Fix compatibility with `ActionDispatch::Request::Session::Options`

data/README.md

@@ -3,6 +3,7 @@ Redis Session Store
 
 [![Build Status](https://travis-ci.org/roidrage/redis-session-store.png?branch=master)](https://travis-ci.org/roidrage/redis-session-store)
 [![Code Climate](https://codeclimate.com/github/roidrage/redis-session-store.png)](https://codeclimate.com/github/roidrage/redis-session-store)
+[![Gem Version](https://badge.fury.io/rb/redis-session-store.png)](http://badge.fury.io/rb/redis-session-store)
 
 A simple Redis-based session store for Rails.  But why, you ask,
 when there's [redis-store](http://github.com/jodosha/redis-store/)?
@@ -19,21 +20,13 @@ only suitable for Rails applications. For other frameworks or
 drop-in support for caching, check out
 [redis-store](http://github.com/jodosha/redis-store/)
 
-Rails 2 Compatibility
----------------------
-
-This gem is currently only compatible with Rails 3+.  If you need
-Rails 2 compatibility, be sure to pin to a lower version like so:
-
-``` ruby
-gem 'redis-session-store', '< 0.3'
-```
-
 Installation
 ------------
 
-``` bash
-gem install redis-session-store
+For Rails 3+, adding this to your Gemfile will do the trick.
+
+``` ruby
+gem 'redis-session-store'
 ```
 
 Configuration
@@ -43,7 +36,7 @@ See `lib/redis-session-store.rb` for a list of valid options.
 In your Rails app, throw in an initializer with the following contents:
 
 ``` ruby
-My::Application.config.session_store = :redis_session_store, {
+My::Application.config.session_store :redis_session_store, {
   key: 'your_session_key',
   redis: {
     db: 2,
@@ -62,7 +55,7 @@ collides with an existing session ID, a custom callable handler may be
 provided as `on_sid_collision`:
 
 ``` ruby
-My::Application.config.session_store = :redis_session_store, {
+My::Application.config.session_store :redis_session_store, {
   # ... other options ...
   on_sid_collision: ->(sid) { Rails.logger.warn("SID collision! #{sid}") }
 }
@@ -74,7 +67,7 @@ If you want to handle cases where Redis is unavailable, a custom
 callable handler may be provided as `on_redis_down`:
 
 ``` ruby
-My::Application.config.session_store = :redis_session_store, {
+My::Application.config.session_store :redis_session_store, {
   # ... other options ...
   on_redis_down: ->(e, env, sid) { do_something_will_ya!(e) }
 }
@@ -91,7 +84,7 @@ custom serializer:
 * `CustomClass` - You can just pass the constant name of any class that responds to `.load` and `.dump`
 
 ``` ruby
-My::Application.config.session_store = :redis_session_store, {
+My::Application.config.session_store :redis_session_store, {
   # ... other options ...
   serializer: :hybrid
 }
@@ -107,7 +100,7 @@ custom callable handler may be provided as `on_session_load_error` which
 will be given the error and the session ID.
 
 ``` ruby
-My::Application.config.session_store = :redis_session_store, {
+My::Application.config.session_store :redis_session_store, {
   # ... other options ...
   on_session_load_error: ->(e, sid) { do_something_will_ya!(e) }
 }
@@ -115,6 +108,15 @@ My::Application.config.session_store = :redis_session_store, {
 
 **Note** The session will *always* be destroyed when it cannot be loaded.
 
+Rails 2 Compatibility
+---------------------
+
+This gem is currently only compatible with Rails 3+.  If you need
+Rails 2 compatibility, be sure to pin to a lower version like so:
+
+``` ruby
+gem 'redis-session-store', '< 0.3'
+```
 Contributing, Authors, & License
 --------------------------------
 

data/lib/redis-session-store.rb

@@ -4,7 +4,7 @@ require 'redis'
 # Redis session storage for Rails, and for Rails only. Derived from
 # the MemCacheStore code, simply dropping in Redis instead.
 class RedisSessionStore < ActionDispatch::Session::AbstractStore
-  VERSION = '0.6.1'
+  VERSION = '0.6.4'
 
   # ==== Options
   # * +:key+ - Same as with the other cookie stores, key name
@@ -21,7 +21,7 @@ class RedisSessionStore < ActionDispatch::Session::AbstractStore
   #
   # ==== Examples
   #
-  #     My::Application.config.session_store = :redis_session_store, {
+  #     My::Application.config.session_store :redis_session_store, {
   #       key: 'your_session_key',
   #       redis: {
   #         db: 2,
@@ -108,8 +108,8 @@ class RedisSessionStore < ActionDispatch::Session::AbstractStore
     serializer.load(data)
   end
 
-  def set_session(env, sid, session_data, options = nil)
-    expiry = (options || env[ENV_SESSION_OPTIONS_KEY])[:expire_after]
+  def set_session(env, sid, session_data, options = nil) # rubocop: disable MethodLength, LineLength
+    expiry = (options || env.fetch(ENV_SESSION_OPTIONS_KEY))[:expire_after]
     if expiry
       redis.setex(prefixed(sid), expiry, encode(session_data))
     else

data/spec/redis_session_store_spec.rb

@@ -450,4 +450,30 @@ describe RedisSessionStore do
       end
     end
   end
+
+  describe 'setting the session' do
+    it 'allows changing the session' do
+      env = { 'rack.session.options' => {} }
+      sid = 1234
+      store.stub(:redis).and_return(Redis.new)
+      data1 = { 'foo' => 'bar' }
+      store.send(:set_session, env, sid, data1)
+      data2 = { 'baz' => 'wat' }
+      store.send(:set_session, env, sid, data2)
+      _, session = store.send(:get_session, env, sid)
+      expect(session).to eq(data2)
+    end
+
+    it 'allows changing the session when the session has an expiry' do
+      env = { 'rack.session.options' => { expire_after: 60 } }
+      sid = 1234
+      store.stub(:redis).and_return(Redis.new)
+      data1 = { 'foo' => 'bar' }
+      store.send(:set_session, env, sid, data1)
+      data2 = { 'baz' => 'wat' }
+      store.send(:set_session, env, sid, data2)
+      _, session = store.send(:get_session, env, sid)
+      expect(session).to eq(data2)
+    end
+  end
 end

metadata

@@ -1,110 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: redis-session-store
 version: !ruby/object:Gem::Version
-  version: 0.6.1
-  prerelease: 
+  version: 0.6.4
 platform: ruby
 authors:
 - Mathias Meyer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-17 00:00:00.000000000 Z
+date: 2014-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fakeredis
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: A drop-in replacement for e.g. MemCacheStore to store Rails sessions
@@ -118,11 +105,11 @@ extra_rdoc_files:
 - AUTHORS.md
 - CONTRIBUTING.md
 files:
-- .gitignore
-- .rspec
-- .rubocop.yml
-- .simplecov
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".simplecov"
+- ".travis.yml"
 - AUTHORS.md
 - CHANGELOG.md
 - CONTRIBUTING.md
@@ -138,33 +125,27 @@ files:
 homepage: https://github.com/roidrage/redis-session-store
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 311231876661318648
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 311231876661318648
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A drop-in replacement for e.g. MemCacheStore to store Rails sessions (and
   Rails sessions only) in Redis.
 test_files: []
+has_rdoc: true