redis-cluster-client 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 032431ff16773725b9cb68482bc5df78affdf23e66b6bbd91b6ddbabdd9da921
-  data.tar.gz: dc789f59f6509e35ab23df03a70867b5e8414ee3bb327462fbcd5d63be4c6744
+  metadata.gz: 86d73675660702eb937b5d27925248d16b64fe46306d49da0c2b89ee49b5dc34
+  data.tar.gz: d2472791161a5ba746cc29c504353dc0e8414c093a531ff1017653a5a354d7dd
 SHA512:
-  metadata.gz: 6013ff65d8dc06b776b7b201244d75eaf62993368f5285d823472f78bec2c81639734f23c32793bc1b8d1981905e5794e35e4e353696d70f1d66930434e6104f
-  data.tar.gz: 0e1dc5f17a9706c2fc64bdd03e74ee457f9b9aea81740cdeb5459bd9bbc769b6353047b64ef008b6d34b950fbc7cb8cf57e66c9deb41d33edbacaba78ca2a12e
+  metadata.gz: bd12c8ebbc013d36ead0ee5bb4f8914ad8e5dec4a302e1aa54890ba36abd2358376bc0329e94b859c9e5c5d71d1a07d11a2f9684db655fef375000e792ca5f0c
+  data.tar.gz: d05782f64503cc104ef789683448d967ca6d71355cdc8a1411e8a92ea98f9412ad94a7a411bc0a93ffffb5ff384f6d3fb6e48ef83cc07bf0fe907872045e2567

data/lib/redis_client/cluster/command.rb

@@ -7,15 +7,21 @@ class RedisClient
   class Cluster
     class Command
       class << self
-        def load(nodes)
-          errors = nodes&.map do |node|
+        def load(nodes) # rubocop:disable Metrics/MethodLength
+          errors = []
+          cmd = nil
+          nodes&.each do |node|
+            break unless cmd.nil?
+
             reply = node.call('COMMAND')
             details = parse_command_details(reply)
-            return ::RedisClient::Cluster::Command.new(details)
-          rescue ::RedisClient::ConnectionError, ::RedisClient::CommandError => e
-            e
+            cmd = ::RedisClient::Cluster::Command.new(details)
+          rescue ::RedisClient::Error => e
+            errors << e
           end
 
+          return cmd unless cmd.nil?
+
           raise ::RedisClient::Cluster::InitialSetupError, errors
         end
 

data/lib/redis_client/cluster/errors.rb

@@ -6,8 +6,6 @@ class RedisClient
   class Cluster
     ERR_ARG_NORMALIZATION = ->(arg) { Array[arg].flatten.reject { |e| e.nil? || (e.respond_to?(:empty?) && e.empty?) } }
 
-    # Raised when client connected to redis as cluster mode
-    # and failed to fetch cluster state information by commands.
     class InitialSetupError < ::RedisClient::Error
       def initialize(errors)
         msg = ERR_ARG_NORMALIZATION.call(errors).map(&:message).uniq.join(',')
@@ -15,8 +13,6 @@ class RedisClient
       end
     end
 
-    # Raised when client connected to redis as cluster mode
-    # and some cluster subcommands were called.
     class OrchestrationCommandNotSupported < ::RedisClient::Error
       def initialize(command)
         str = ERR_ARG_NORMALIZATION.call(command).map(&:to_s).join(' ').upcase
@@ -28,7 +24,6 @@ class RedisClient
       end
     end
 
-    # Raised when error occurs on any node of cluster.
     class ErrorCollection < ::RedisClient::Error
       attr_reader :errors
 
@@ -41,11 +36,10 @@ class RedisClient
 
         @errors = errors
         messages = @errors.map { |node_key, error| "#{node_key}: #{error.message}" }
-        super("Command errors were replied on any node: #{messages.join(', ')}")
+        super("Errors occurred on any node: #{messages.join(', ')}")
       end
     end
 
-    # Raised when cluster client can't select node.
     class AmbiguousNodeError < ::RedisClient::Error
       def initialize(command)
         super("Cluster client doesn't know which node the #{command} command should be sent to.")

data/lib/redis_client/cluster/node.rb

@@ -102,7 +102,7 @@ class RedisClient
       end
 
       def each(&block)
-        @clients.values.each(&block)
+        @clients.each_value(&block)
       end
 
       def sample

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redis-cluster-client
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Taishi Kasuga