redis-client 0.18.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0903a6d92200235e71b687f16de1ec058ca88979a42cc14d2a783ba5d5605061'
-  data.tar.gz: 1e772676e34700120320659108e1be493cd4d2067a286056cb8ac87f1c3b51e7
+  metadata.gz: 1dfa2a6fb000223a3150caeffa1f5341e322b436128dc0cdb0b22998586e1a56
+  data.tar.gz: cc8cd32d6036a00710b5d0dc728382c7be48e58fcbc07759d392267cf9a6397b
 SHA512:
-  metadata.gz: 66e2d650fe13befeb44b06514e0523d571dfa749f0f787bf7c95126b16d7e54a6b7cb3aa7ed99375f761a302892c2de50c14ad2c011bd42266f4a441a6c9b24b
-  data.tar.gz: 14b28ce893f07569688acb16a404c2f98bb8cdcd3eaca6d68264a2f1c790cb52c483cd252cc243e8f3f8b4f6e858daf34204d78c7689dcfb2146fc960d45bf3a
+  metadata.gz: 69f9ba83f34836944c0af218f1dd117c76d6f4a09a5aeee001727b19ac01013e1bb3ba308386690a34960282153d4075cd7949fc7b0a25c89840b82eceb5dbdf
+  data.tar.gz: 54d85162e372c33756adf4af7da1f0abe3d0cd4789336d678a1fc4a37afac749c929d7032a58d3e92f3576ed1001c3ec60bd15670762dc2553a69744891a3b06

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Unreleased
 
+# 0.19.0
+
+- Revalidate connection in `RedisClient#connected?`
+- Eagerly fail if `db:` isn't an Integer. #151.
+
 # 0.18.0
 
 - Expose more connection details such as `host`, `db`, etc on `RedisClient`.

data/Gemfile

@@ -6,7 +6,7 @@ source "https://rubygems.org"
 gemspec name: "redis-client"
 
 gem "minitest"
-gem "rake", "~> 13.0"
+gem "rake", "~> 13.1"
 gem "rake-compiler"
 gem "rubocop"
 gem "rubocop-minitest"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    redis-client (0.18.0)
+    redis-client (0.19.0)
       connection_pool
 
 GEM
@@ -18,7 +18,7 @@ GEM
     parser (3.1.2.1)
       ast (~> 2.4.1)
     rainbow (3.1.1)
-    rake (13.0.6)
+    rake (13.1.0)
     rake-compiler (1.2.5)
       rake
     redis (4.6.0)
@@ -53,7 +53,7 @@ DEPENDENCIES
   byebug
   hiredis
   minitest
-  rake (~> 13.0)
+  rake (~> 13.1)
   rake-compiler
   redis (~> 4.6)
   redis-client!

data/lib/redis_client/config.rb

@@ -41,7 +41,12 @@ class RedisClient
       )
         @username = username
         @password = password
-        @db = db || DEFAULT_DB
+        @db = begin
+          Integer(db || DEFAULT_DB)
+        rescue ArgumentError
+          raise ArgumentError, "db: must be an Integer, got: #{db.inspect}"
+        end
+
         @id = id
         @ssl = ssl || false
 

data/lib/redis_client/ruby_connection.rb

@@ -148,6 +148,7 @@ class RedisClient
       )
       true
     rescue SystemCallError, OpenSSL::SSL::SSLError, SocketError => error
+      socket&.close
       raise CannotConnectError, error.message, error.backtrace
     end
 

data/lib/redis_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class RedisClient
-  VERSION = "0.18.0"
+  VERSION = "0.19.0"
 end

data/lib/redis_client.rb

@@ -222,17 +222,18 @@ class RedisClient
 
   def timeout=(timeout)
     super
-    raw_connection.read_timeout = raw_connection.write_timeout = timeout if connected?
+    @raw_connection&.read_timeout = timeout
+    @raw_connection&.write_timeout = timeout
   end
 
   def read_timeout=(timeout)
     super
-    raw_connection.read_timeout = timeout if connected?
+    @raw_connection&.read_timeout = timeout
   end
 
   def write_timeout=(timeout)
     super
-    raw_connection.write_timeout = timeout if connected?
+    @raw_connection&.write_timeout = timeout
   end
 
   def pubsub
@@ -386,7 +387,7 @@ class RedisClient
   end
 
   def connected?
-    @raw_connection&.connected?
+    @raw_connection&.revalidate
   end
 
   def close
@@ -669,6 +670,7 @@ class RedisClient
     elsif retryable
       tries = 0
       connection = nil
+      preferred_error = nil
       begin
         connection = raw_connection
         if block_given?
@@ -677,13 +679,15 @@ class RedisClient
           connection
         end
       rescue ConnectionError, ProtocolError => error
+        preferred_error ||= error
+        preferred_error = error unless error.is_a?(CircuitBreaker::OpenCircuitError)
         close
 
         if !@disable_reconnection && config.retry_connecting?(tries, error)
           tries += 1
           retry
         else
-          raise
+          raise preferred_error
         end
       end
     else

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redis-client
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Jean Boussier
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-26 00:00:00.000000000 Z
+date: 2023-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool