redis-classy 1.1.1 → 1.2.0

data/README.md

@@ -22,6 +22,9 @@ This library contains only 30+ lines of code, yet powerful when you need better
 
 ### What's new:
 
+* v1.2.0: Raise NoMethodError when commands are not found in redis-rb.
+* v1.1.1: Raise exception when Redis::Classy.db is not assigned
+* v1.1.0: Explicitly require all files
 * v1.0.1: Relaxed version dependency on redis-namespace
 * v1.0.0: Play nice with Mongoid
 
@@ -152,6 +155,19 @@ Since the `db` attribute is a class instance variable, you can dynamically assig
 UniqueUser.db = Redis::Namespace.new('UniqueUser', :redis => Redis.new(:host => 'another.host'))
 ```
 
+Unicorn support
+---------------
+
+If you run fork-based app servers such as **Unicorn** or **Passenger**, you need to reconnect to the Redis after forking.
+
+```ruby
+after_fork do
+  Redis::Classy.db.client.reconnect
+end
+```
+
+Note that since Redis Classy assigns a namespaced Redis instance upon the inheritance event of each subclass (`class Something < Redis::Classy`), reconnecting the master (non-namespaced) connection that is referenced from all subclasses should probably be the safest and the most efficient way to survive a forking event.
+
 Reference
 ---------
 

data/lib/redis/classy/version.rb

@@ -1,5 +1,5 @@
 class Redis
   class Classy
-    VERSION = '1.1.1'
+    VERSION = '1.2.0'
   end
 end

data/lib/redis/classy.rb

@@ -4,17 +4,22 @@ class Redis
       attr_accessor :db
 
       def inherited(subclass)
-        subclass.db = Redis::Namespace.new(subclass.name, :redis => Redis::Classy.db) if Redis::Classy.db
+        raise 'Redis::Classy.db is not assigned' unless Redis::Classy.db
+        subclass.db = Redis::Namespace.new(subclass.name, :redis => Redis::Classy.db)
       end
 
-      def method_missing(method_name, *args, &block)
-        db.send(method_name, *args, &block)
+      def delegatables
+        @delegatables ||= Redis::Classy.db.class.instance_methods(false).map(&:to_sym) # ruby1.8 returns strings
       end
 
-      Redis::Namespace::COMMANDS.keys.each do |key|
-        define_method(key) do |*args, &block|
-          raise 'Redis::Classy.db is not assigned' unless db
-          db.send(key, *args, &block)
+      def method_missing(command, *args, &block)
+        return super unless delegatables.include?(command)
+        db.send(command, *args, &block)
+      end
+
+      Redis::Namespace::COMMANDS.keys.each do |command|
+        define_method(command) do |*args, &block|
+          db.send(command, *args, &block)
         end
       end
     end
@@ -25,8 +30,8 @@ class Redis
       @key = key
     end
 
-    def method_missing(method_name, *args, &block)
-      self.class.send(method_name, key, *args, &block)
+    def method_missing(command, *args, &block)
+      self.class.send(command, @key, *args, &block)
     end
   end
 end

data/spec/redis_classy_spec.rb

@@ -11,49 +11,47 @@ module Deep
   end
 end
 
-describe "RedisClassy" do
+describe Redis::Classy do
   before do
     Redis::Classy.flushdb
   end
 
-  after do
-    Redis::Classy.flushdb
-  end
-
   after(:all) do
+    Redis::Classy.flushdb
     Redis::Classy.quit
   end
 
-  it "should prepend class name to the key" do
-    Something.set("foo", "bar")
-    Something.keys.should == ["foo"]
-    Redis::Classy.keys.should include "Something:foo"
+  it 'prepends class name to the key' do
+    Something.set('foo', 'bar')
+    Something.keys.should == ['foo']
+    Redis::Classy.keys.should include 'Something:foo'
 
-    Another.set("foo", "bar")
-    Another.keys.should == ["foo"]
-    Redis::Classy.keys.should include "Another:foo"
+    Another.set('foo', 'bar')
+    Another.keys.should == ['foo']
+    Redis::Classy.keys.should include 'Another:foo'
 
-    Deep::Klass.set("foo", "bar")
-    Deep::Klass.keys.should == ["foo"]
-    Redis::Classy.keys.should include "Deep::Klass:foo"
+    Deep::Klass.set('foo', 'bar')
+    Deep::Klass.keys.should == ['foo']
+    Redis::Classy.keys.should include 'Deep::Klass:foo'
   end
 
-  it "should delegate class methods" do
-    Something.get("foo").should == nil
-    Something.set("foo", "bar")
-    Something.get("foo").should == "bar"
+  it 'delegates to class methods' do
+    Something.get('foo').should == nil
+    Something.set('foo', 'bar')
+    Something.get('foo').should == 'bar'
   end
 
-  it "should delegate instance methods with the key binding" do
-    something = Something.new("foo")
+  it 'delegates instance methods with the key binding' do
+    something = Something.new('foo')
 
     something.get.should == nil
-    something.set("bar")
-    something.get.should == "bar"
+    something.set('bar')
+    something.get.should == 'bar'
+    Something.get('foo').should == 'bar'
   end
 
-  it "should handle multi block" do
-    something = Something.new("foo")
+  it 'handles multi block' do
+    something = Something.new('foo')
 
     Redis::Classy.multi do
       something.sadd 1
@@ -64,7 +62,16 @@ describe "RedisClassy" do
     something.smembers.should == ['1','2','3']
   end
 
-  it "should battle against mongoid" do
+  it 'handles method_missing' do
+    # class method
+    expect { Something.bogus }.to raise_error(NoMethodError)
+
+    # instance method
+    something = Something.new('foo')
+    expect { something.bogus }.to raise_error(NoMethodError)
+  end
+
+  it 'should battle against mongoid' do
     # Emulate notorious Mongoid::Extensions::Object::Conversions
     class Object
       def self.get(value)
@@ -74,7 +81,7 @@ describe "RedisClassy" do
 
     # This would have returned "foo" instead of nil, unless we explicitly defined
     # class methods from Redis::Namespace::COMMANDS
-    Something.get("foo").should == nil
+    Something.get('foo').should == nil
 
     class << Object
       remove_method :get

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redis-classy
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-26 00:00:00.000000000 Z
+date: 2012-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis-namespace
-  requirement: &70184551488360 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,15 @@ dependencies:
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70184551488360
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70184551487720 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70184551487720
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70184551485580 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70184551485580
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70184551502420 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +69,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70184551502420
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Class-style namespace prefixing for Redis
 email:
 - kenn.ejima@gmail.com
@@ -95,10 +115,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 1.8.19
 signing_key: 
 specification_version: 3
 summary: Class-style namespace prefixing for Redis
 test_files:
 - spec/redis_classy_spec.rb
 - spec/spec_helper.rb
+has_rdoc: