redis-activesupport 5.0.4 → 5.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 33df3ef09a75d9ce2b545efe032cd801d2437eea
-  data.tar.gz: 807b5a494112c947faaacd3c47090004e47ffc5a
+  metadata.gz: c3b0c9c08812e36f2dffac848245c0bcc15d7dc7
+  data.tar.gz: 402843532853000850b53950016066539773c629
 SHA512:
-  metadata.gz: 3bdafb650c1a86020859524d0d9f66c3d9d6f2e1b6772525d05a9f6574fbfca702bdc9fbc404c1581ea94b06e9c2c7b309faf0c73f7d6a674197d1688ae2df3e
-  data.tar.gz: 1bd8ea70bc58ebfc4f89c2152590139bc516fea97e796fcdfd6657cacc78c53bc1e74ac522399bc1ebdca3ca783ee991ed9da8d5895285ce252635f06b950a66
+  metadata.gz: a5c72abe5df437b209a58f190decd3b06c23e9d47d31d099344dc12bd4b0925e2ea304402fb11e89bb034dfab3d15e21d896e8c08f5818c12f8bfed9f4da49da
+  data.tar.gz: 4967910fdab2b5042cca028ca56b4cc6435ccb71a32b8566914cf4b85885dbcd0ee02c33e6b3e83028d636fe16e149327058ba8768bcd2c5c7f4d61e60146289

data/.travis.yml

@@ -22,3 +22,6 @@ matrix:
       gemfile: gemfiles/Gemfile.activesupport-5.x
     - rvm: 2.1
       gemfile: gemfiles/Gemfile.activesupport-5.x
+notifications:
+  webhooks: https://www.travisbuddy.com/
+  on_success: never

data/README.md

@@ -1,6 +1,21 @@
 # Redis stores for ActiveSupport
 
-__`redis-activesupport`__ provides a cache for __ActiveSupport__. See the main [redis-store readme](https://github.com/redis-store/redis-store) for general guidelines.
+__`redis-activesupport`__ provides a cache for __ActiveSupport__. 
+
+
+For guidelines on using our underlying cache store, see the main [redis-store readme](https://github.com/redis-store/redis-store).
+
+For information on how to use this library in a Rails app, see the [documentation for redis-rails](https://github.com/redis-store/redis-rails).
+
+If, for some reason, you're using `ActiveSupport::Cache` and not in a Rails app, read on to learn how to install/use this gem by itself!
+
+## A quick note about Rails 5.2
+
+Rails 5.2.0 [includes a Redis cache store out of the
+box](https://github.com/rails/rails/pull/31134), so you don't really
+need this anymore if you're generating a new Rails application. We
+are no longer accepting new features for this gem, only pull requests
+for security and compatibility fixes will be accepted.
 
 ## Installation
 

data/lib/active_support/cache/redis_store.rb

@@ -20,6 +20,9 @@ module ActiveSupport
       #   RedisStore.new
       #     # => host: localhost,   port: 6379,  db: 0
       #
+      #   RedisStore.new client: Redis.new(url: "redis://127.0.0.1:6380/1")
+      #     # => host: localhost,   port: 6379,  db: 0
+      #
       #   RedisStore.new "example.com"
       #     # => host: example.com, port: 6379,  db: 0
       #
@@ -42,8 +45,8 @@ module ActiveSupport
       #     pool: ::ConnectionPool.new(size: 1, timeout: 1) { ::Redis::Store::Factory.create("localhost:6379/0") })
       #     # => supply an existing connection pool (e.g. for use with redis-sentinel or redis-failover)
       def initialize(*addresses)
-        @options = addresses.dup.extract_options!
-        addresses = addresses.map(&:dup)
+        @options = addresses.extract_options!
+        addresses = addresses.compact.map(&:dup)
 
         @data = if @options[:pool]
                   raise "pool must be an instance of ConnectionPool" unless @options[:pool].is_a?(ConnectionPool)
@@ -54,9 +57,11 @@ module ActiveSupport
                   pool_options[:size]    = options[:pool_size] if options[:pool_size]
                   pool_options[:timeout] = options[:pool_timeout] if options[:pool_timeout]
                   @pooled = true
-                  ::ConnectionPool.new(pool_options) { ::Redis::Store::Factory.create(*addresses) }
+                  ::ConnectionPool.new(pool_options) { ::Redis::Store::Factory.create(*addresses, @options) }
+                elsif @options[:client]
+                  @options[:client]
                 else
-                  ::Redis::Store::Factory.create(*addresses)
+                  ::Redis::Store::Factory.create(*addresses, @options)
                 end
 
         super(@options)

data/lib/redis/active_support/version.rb

@@ -1,5 +1,5 @@
 class Redis
   module ActiveSupport
-    VERSION = '5.0.4'
+    VERSION = '5.0.5'
   end
 end

data/test/active_support/cache/redis_store_test.rb

@@ -26,6 +26,13 @@ describe ActiveSupport::Cache::RedisStore do
     end
   end
 
+  it "uses redis client passed as an option" do
+    redis = Redis.new(url: "redis://127.0.0.1:6380/1")
+    store = ActiveSupport::Cache::RedisStore.new(client: redis)
+
+    store.data.must_equal(redis)
+  end
+
   it "connects using an hash of options" do
     address = { host: '127.0.0.1', port: '6380', db: '1' }
     store = ActiveSupport::Cache::RedisStore.new(address.merge(pool_size: 5, pool_timeout: 10))
@@ -91,6 +98,11 @@ describe ActiveSupport::Cache::RedisStore do
     underlying_store.must_be_instance_of(::Redis::Store)
   end
 
+  it "creates a normal store when given nil" do
+    underlying_store = instantiate_store nil
+    underlying_store.must_be_instance_of(::Redis::Store)
+  end
+
   it "creates a normal store when given options only" do
     underlying_store = instantiate_store(:expires_in => 1.second)
     underlying_store.must_be_instance_of(::Redis::Store)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redis-activesupport
 version: !ruby/object:Gem::Version
-  version: 5.0.4
+  version: 5.0.5
 platform: ruby
 authors:
 - Luca Guidi
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-16 00:00:00.000000000 Z
+date: 2018-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis-store
@@ -184,7 +184,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: redis-activesupport
-rubygems_version: 2.6.11
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Redis store for ActiveSupport