reddit_wallpaper 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f59e4c97092153ebdec0864c6219dc5fe13b83fd
-  data.tar.gz: 0478a417e076a5c9f439d5eccb26d7792bae2039
+  metadata.gz: 114bcb054b2e01cae7d3a9edff84d9584ce13dce
+  data.tar.gz: 25c1435e6ff0fc26038981df9591abe01d98e769
 SHA512:
-  metadata.gz: 0cfc5b6d3060a1277ee7a60ba356d3be31aad9b4bf0e7dacc89a17f9c717ee8c3e1d1f0a87c45bad2a888ece041ad7cd2fd7e9b4c89d0d484b13e26f28b1a977
-  data.tar.gz: 16a44d81d5fd0df08bf5adcc7d69b3034e383bf70732042ffcc658c9bbfd74876b6aa8a9bb1d4525d2bfc45fdf60809515c034dcf1a22f946b08e500a64e7e73
+  metadata.gz: d0fb0af3be8b2e4d2349f7a605c807a9fd9c02339609281791bbe0050cc608cd023a79ea0c0cf88f500ff92659612d18f25f31e929c831ab416c0d7b59b7b3c8
+  data.tar.gz: 7d82e5892b7a6a257488c5447328c0ee5bddb6007a004bd9e4b6695b6cfbe89808dacc0f1a1b4f2c067eea32ad06cd1a3b4cb7da3a213c83fe9f487ed708d668

data/lib/reddit_wallpaper.rb

@@ -3,6 +3,10 @@ require 'ruby_reddit_api'
 require 'open_uri_redirections'
 
 class RedditWallpaper
+  def self.reddit
+    @reddit ||= Reddit::Api.new
+  end
+
   def initialize(subreddit, destination_file)
     @subreddit      = subreddit
     @path           = destination_file
@@ -13,10 +17,10 @@ class RedditWallpaper
   attr_reader :path, :subreddit, :downloaded, :not_downloaded
 
   def download_new_image
-    posts = reddit.browse(subreddit)
-    posts.each do |post|
-      if post.url.include?('imgur') && !downloaded.include?(post.url)
-        not_downloaded << post.url
+    posts = RedditWallpaper.reddit.browse(subreddit)
+    posts.map(&:url).each do |url|
+      if download? url
+        not_downloaded << url
       end
     end
 
@@ -25,14 +29,19 @@ class RedditWallpaper
 
   private
 
-  def reddit
-    @reddit ||= Reddit::Api.new
+  # Checks that the post url is either a jpg file or hosted on imgur
+  #
+  def download?(url)
+    url[/(imgur|\.jpe?g\z)/] && !downloaded.include?(url)
   end
 
   def download_image(url)
-    # Append .jpg to ensure we are getting the image file
+    return unless url
+    # Append .jpg to ensure we are getting the image file from imgur
+    url += ".jpg" unless url[/\.jpe?g\z/]
+
     open(path, 'wb') do |file|
-      file << open(url + ".jpg", allow_redirections: :all).read
+      file << open(url, allow_redirections: :all).read
     end
     downloaded << url
   end

data/spec/reddit_wallpaper_spec.rb

@@ -0,0 +1,78 @@
+require 'minitest/autorun'
+
+require_relative '../lib/reddit_wallpaper'
+require_relative 'support/reddit_stub'
+
+describe 'RedditWallpaper' do
+  let(:reddit_wallpaper) { RedditWallpaper.new(subreddit, "/dev/null") }
+  let(:image_url)        { "http://i.imgur.com/Nhg3uHn.jpg" }
+  let(:subreddit)        { "fancy-subreddit" }
+
+  it 'downloads the latest image posts' do
+    post = MiniTest::Mock.new
+    post.expect :url, image_url
+
+    RedditWallpaper.stub :reddit, Support::RedditStub.new([post]) do
+      reddit_wallpaper.download_new_image
+    end
+
+    post.verify
+
+    reddit_wallpaper.downloaded.must_include image_url
+  end
+
+  it 'loads posts from the specified subreddit' do
+    reddit_stub = Support::RedditStub.new
+
+    RedditWallpaper.stub :reddit, reddit_stub do
+      reddit_wallpaper.download_new_image
+    end
+
+    reddit_stub.subreddit.must_equal subreddit
+  end
+
+  it 'does not download non-jpg files' do
+    bad_url = "http://www.google.com"
+
+    post = MiniTest::Mock.new
+    post.expect :url, bad_url
+
+    RedditWallpaper.stub :reddit, Support::RedditStub.new([post]) do
+      reddit_wallpaper.download_new_image
+    end
+
+    post.verify
+
+    reddit_wallpaper.downloaded.wont_include bad_url
+  end
+
+  it 'accepts imgur urls without an extension' do
+    imgur_url = "http://imgur.com/Nhg3uHn"
+
+    post = MiniTest::Mock.new
+    post.expect :url, imgur_url
+
+    RedditWallpaper.stub :reddit, Support::RedditStub.new([post]) do
+      reddit_wallpaper.download_new_image
+    end
+
+    post.verify
+
+    reddit_wallpaper.downloaded.must_include imgur_url + ".jpg"
+  end
+
+  it 'does not mind being redirected' do
+    secure_url = "https://imgur.com/Nhg3uHn"
+
+    post = MiniTest::Mock.new
+    post.expect :url, secure_url
+
+    RedditWallpaper.stub :reddit, Support::RedditStub.new([post]) do
+      reddit_wallpaper.download_new_image
+    end
+
+    post.verify
+
+    reddit_wallpaper.downloaded.must_include secure_url + ".jpg"
+  end
+end

data/spec/support/reddit_stub.rb

@@ -0,0 +1,15 @@
+module Support
+  class RedditStub
+    def initialize(posts = [])
+      @posts = posts
+    end
+
+    attr_reader   :subreddit
+    attr_accessor :posts
+
+    def browse(subreddit)
+      @subreddit = subreddit
+      posts
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reddit_wallpaper
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Emad Elsaid
@@ -39,6 +39,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '5.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '5.3'
 description: Download the latest images from your favorite subreddit and set them
   as your desktop background
 email:
@@ -53,6 +67,8 @@ files:
 - README.md
 - bin/reddit_wallpaper
 - lib/reddit_wallpaper.rb
+- spec/reddit_wallpaper_spec.rb
+- spec/support/reddit_stub.rb
 homepage: https://github.com/jordanbyron/reddit_wallpaper
 licenses:
 - MIT
@@ -77,5 +93,7 @@ rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Auto-changing wallpaper from reddit / imgur images
-test_files: []
+test_files:
+- spec/reddit_wallpaper_spec.rb
+- spec/support/reddit_stub.rb
 has_rdoc: