recurly 2.8.3 → 2.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 5d8d608dad115469f711a1e02417114735591b0b64ce9b7cf2fdb13155ce7f6d
-  data.tar.gz: 5e98dce7f4872d4a6ed38f8d089ccd2908b7f495ff0d6991336300cb8df90ca7
+SHA1:
+  metadata.gz: 484c28b3c176d82de1fb1f2f25df00602ce9701f
+  data.tar.gz: b841ce1d8a13adc2345446df5661b4f8b5f0390e
 SHA512:
-  metadata.gz: ae7ad01aad504251fbd34ea498b203a9d4058fc0e1aa98e80ded7c2a8b1e9b065027d152e68c5bd85cffc879d6e6baa8ec293292cf4edc1f7628890b47c19a93
-  data.tar.gz: b5cbfb94397b2be7f0dbb1be6730985b4d095d7efa5acad1f9896b232e2dc5b519d86614b52ddd37beaa1d6c7c02bb9b6b6f3ff834448b0f28283a6f9bfdcb4e
+  metadata.gz: 6c7fbf56c05a64d0dc90285f56a75de6b086ffe09f9621b27d5248d9f0e2f36f5124e858a575ced4f6743bf1b5b7c7796347390b47266c53ea79c4cae563b7a5
+  data.tar.gz: e561799eb31ca989e9c891132919cb348553a5935b07337a6aeb0664e390e5d98cced23ef150ffd87326c5e63d978edb59ebd917cdfef4d996b11e9caeb7abcb

data/README.md

@@ -14,13 +14,12 @@ Recurly is packaged as a Ruby gem. We recommend you install it with
 [Bundler](http://gembundler.com/) by adding the following line to your Gemfile:
 
 ``` ruby
-gem 'recurly', '~> 2.8.2'
+gem 'recurly', '~> 2.9.0'
 ```
 
 Recurly will automatically use [Nokogiri](http://nokogiri.org/) (for a nice
 speed boost) if it's available and loaded in your app's environment.
 
-
 ## Configuration
 
 If you're using Rails, you can generate an initializer with the following
@@ -90,6 +89,19 @@ Any configuration items you do not include in the above config call will be defa
 configuration items. For example if you do not define default_currency then Recurly.default_currency
 will be used.
 
+## Supported Versions
+
+We are currently supporting versions `2.1.0` and above. `1.9` and `2.0` will still work but are deprecated.
+
+If you are still using one of these rubies, you should know that support for them ended in
+2015 (1.9) and 2016 (2.0) and continuing to use them is a security risk.
+
+- https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/
+- https://www.ruby-lang.org/en/news/2016/02/24/support-plan-of-ruby-2-0-0-and-2-1/
+
+For now, we are still running the tests on 1.9 and 2.0 but without `nokogiri` and only `rexml`. Nokogiri is
+no longer supported on 1.9 or 2.0 and has patched known vulnerabilities since dropping support.
+If you must run one of these rubies (this includes jruby1.7), you must use rexml and not nokogiri.
 
 ## Usage
 

data/lib/recurly/address.rb

@@ -1,6 +1,5 @@
 module Recurly
   class Address < Resource
-
     define_attribute_methods %w(
       address1
       address2
@@ -11,5 +10,12 @@ module Recurly
       phone
       geo_code
     )
+
+    # This ensures every attribute is rendered
+    # when updating. The Address object does not
+    # accept partial updates on the server
+    def xml_keys
+      attributes.keys
+    end
   end
 end

data/lib/recurly/api/net_http_adapter.rb

@@ -43,7 +43,6 @@ module Recurly
             }
             uri += "?#{pairs.join '&'}"
           end
-          self.validate_uri!(uri)
           request = METHODS[method].new uri.request_uri, head
           request.basic_auth(*[Recurly.api_key, nil].flatten[0, 2])
           if options[:body]

data/lib/recurly/api.rb

@@ -15,7 +15,6 @@ module Recurly
     require 'recurly/api/errors'
 
     @@base_uri = "https://api.recurly.com/v2/"
-    @@valid_domains = [".recurly.com"]
 
     RECURLY_API_VERSION = '2.5'
 
@@ -76,13 +75,6 @@ module Recurly
         URI.parse @@base_uri.sub('api', Recurly.subdomain)
       end
 
-      def validate_uri!(uri)
-        domain = @@valid_domains.detect { |d| uri.host.end_with?(d) }
-        unless domain
-          raise ArgumentError, "URI #{uri} is invalid. You may only make requests to a Recurly domain."
-        end
-      end
-
       # @return [String]
       def user_agent
         "Recurly/#{Version}; #{RUBY_DESCRIPTION}"

data/lib/recurly/resource/pager.rb

@@ -44,6 +44,19 @@ module Recurly
       #   if the loaded page content has not changed.
       # @option options [String] :uri The default location the pager will
       #   request.
+      # @option options [String, Symbol] :sort The attribute that will be used to order
+      #   records: <tt>created_at</tt>, <tt>updated_at</tt>. Defaults to <tt>created_at</tt>.
+      # @option options [String, Symbol] :order The order in which records will be
+      #   returned: <tt>asc</tt> for ascending order, <tt>desc</tt> for descending order.
+      #   Defaults to <tt>desc</tt>.
+      # @option options [DateTime, String] :begin_time Operates on the attribute specified by the
+      #   <tt>sort</tt> parameter. Filters records to only include those with datetimes
+      #   greater than or equal to the supplied datetime. Accepts an ISO 8601
+      #   date or date and time.
+      # @option options [DateTime, String] :end_time Operates on the attribute specified by
+      #   the <tt>sort</tt> parameter. Filters records to only include those with
+      #   datetimes less than or equal to the supplied datetime. Accepts an
+      #   ISO 8601 date or date and time.
       # @raise [API::NotModified] If the <tt>:etag</tt> option is set and
       #   matches the server's.
       def initialize resource_class, options = {}

data/lib/recurly/resource.rb

@@ -336,8 +336,9 @@ module Recurly
           raise NotFound, "can't find a record with nil identifier"
         end
 
+        uri = uuid =~ /^http/ ? uuid : member_path(uuid)
         begin
-          from_response API.get(member_path(uuid), {}, options)
+          from_response API.get(uri, {}, options)
         rescue API::NotFound => e
           raise NotFound, e.description
         end
@@ -460,8 +461,8 @@ module Recurly
               # parsing here or else it always serializes. Need
               # a better way of handling changed attributes
               if el.name == 'address' && val.kind_of?(Hash)
-                address = Address.new val
-                address.changed_attributes.clear
+                address = Address.new(val)
+                address.instance_variable_set(:@changed_attributes, {})
                 record[el.name] = address
               else
                 record[el.name] = val
@@ -634,12 +635,9 @@ module Recurly
         return if response.body.to_s.length.zero?
         fresh = self.class.from_response response
       else
-        options = {:etag => (etag unless changed?)}
-        fresh = if @href
-                  self.class.from_response API.get(@href, {}, options)
-                else
-                  self.class.find(to_param, options)
-                end
+        fresh = self.class.find(
+          @href || to_param, :etag => (etag unless changed?)
+        )
       end
       fresh and copy_from fresh
       persist! true

data/lib/recurly/version.rb

@@ -1,8 +1,8 @@
 module Recurly
   module Version
     MAJOR   = 2
-    MINOR   = 8
-    PATCH   = 3
+    MINOR   = 9
+    PATCH   = 0
     PRE     = nil
 
     VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join('.').freeze

data/lib/recurly/xml.rb

@@ -80,7 +80,18 @@ module Recurly
 end
 
 if defined? Nokogiri
-  require 'recurly/xml/nokogiri'
+  if RUBY_VERSION < "2.1.0"
+    raise <<-MSG
+
+      You are attempting to use an insecure version of
+      nokogiri on an insecure version of ruby. Please see
+      the documentation on supported versions for more information:
+      https://github.com/recurly/recurly-client-ruby#supported-versions
+
+    MSG
+  else
+    require 'recurly/xml/nokogiri'
+  end
 else
   require 'recurly/xml/rexml'
 end

data/lib/recurly.rb

@@ -86,8 +86,6 @@ module Recurly
     end
 
     # Assigns a logger to log requests/responses and more.
-    # The logger can only be set if the environment variable
-    # `RECURLY_INSECURE_DEBUG` equals `true`.
     #
     # @return [Logger, nil]
     # @example
@@ -99,22 +97,6 @@ module Recurly
     #   Recurly.logger = nil # Or Recurly.logger = Logger.new nil
     attr_accessor :logger
 
-    def logger=(logger)
-      if ENV['RECURLY_INSECURE_DEBUG'].to_s.downcase == 'true'
-        @logger = logger
-        puts <<-MSG
-        [WARNING] Recurly logger enabled. The logger has the potential to leak
-        PII and should never be used in production environments.
-        MSG
-      else
-        puts <<-MSG
-        [WARNING] Recurly logger has been disabled. If you wish to use it,
-        only do so in a non-production environment and make sure
-        the `RECURLY_INSECURE_DEBUG` environment variable is set to `true`.
-        MSG
-      end
-    end
-
     # Convenience logging method includes a Logger#progname dynamically.
     # @return [true, nil]
     def log level, message

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: recurly
 version: !ruby/object:Gem::Version
-  version: 2.8.3
+  version: 2.9.0
 platform: ruby
 authors:
 - Recurly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-09 00:00:00.000000000 Z
+date: 2017-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.0
-  type: :runtime
+        version: 1.7.1
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.7.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.24.6
+        version: 2.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.24.6
+        version: 2.3.2
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
@@ -238,7 +238,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Recurly API Client