recordselect 3.1.8 → 3.1.9

data/app/assets/javascripts/jquery/record_select.js

@@ -239,8 +239,8 @@ RecordSelect.Abstract = Class.extend({
     var offset = this.obj.offset(), top = this.obj.height() + offset.top;
     this.container.show();
     this.container.css('left', offset.left);
-    if (top + this.container.height() > $(document).height())
-      this.container.css('top', offset.top - this.container.height());
+    if (top + this.container.height() > $(window).height())
+      this.container.css('bottom', $(window).height() - offset.top);
     else this.container.css('top', top);
 
     if (this._use_iframe_mask()) {

data/app/assets/javascripts/jquery/record_select.js~

@@ -239,8 +239,8 @@ RecordSelect.Abstract = Class.extend({
     var offset = this.obj.offset(), top = this.obj.height() + offset.top;
     this.container.show();
     this.container.css('left', offset.left);
-    if (top + this.container.height() > $(document).height())
-      this.container.css('top', offset.top - this.container.height());
+    if (top + this.container.height() > $(window).height())
+      this.container.css('bottom', offset.top);
     else this.container.css('top', top);
 
     if (this._use_iframe_mask()) {
@@ -438,7 +438,6 @@ RecordSelect.Single = RecordSelect.Abstract.extend({
   onselect: function(id, value) {
     this.set(id, value);
     if (this.options.onchange) this.options.onchange.call(this, id, value);
-    var _this = this;
     this.obj.trigger("recordselect:change", [id, value]);
     this.close();
   },

data/app/assets/javascripts/prototype/record_select.js

@@ -105,9 +105,13 @@ Object.extend(RecordSelect.Abstract.prototype, {
    * positions and reveals the recordselect
    */
   show: function() {
-    var offset = Position.cumulativeOffset(this.obj);
+    var offset = Position.cumulativeOffset(this.obj),
+        top = Element.getHeight(this.obj) + offset[1],
+        window_height = document.viewport.getHeight();
     this.container.style.left = offset[0] + 'px';
-    this.container.style.top = (Element.getHeight(this.obj) + offset[1]) + 'px';
+    if (top + Element.getHeight(this.container) > window_height)
+      this.container.style.bottom = (window_height - offset[1]) + 'px';
+    else this.container.style.top = top + 'px';
 
     if (this._use_iframe_mask()) {
       this.container.insertAdjacentHTML('afterEnd', '<iframe src="javascript:false;" class="record-select-mask" />');

data/app/assets/javascripts/prototype/record_select.js~

@@ -61,6 +61,9 @@ Object.extend(RecordSelect.Abstract.prototype, {
     this.url = url;
     this.options = options;
     this.container;
+    if (this.options.onchange && typeof this.options.onchange != 'function') {
+      this.options.onchange = eval(this.options.onchange);
+    }
 
     if (RecordSelect.document_loaded) this.onload();
     else Event.observe(window, 'load', this.onload.bind(this));
@@ -102,9 +105,13 @@ Object.extend(RecordSelect.Abstract.prototype, {
    * positions and reveals the recordselect
    */
   show: function() {
-    var offset = Position.cumulativeOffset(this.obj);
+    var offset = Position.cumulativeOffset(this.obj),
+        top = Element.getHeight(this.obj) + offset[1],
+        window_height = document.viewport.getDimensions().height;
     this.container.style.left = offset[0] + 'px';
-    this.container.style.top = (Element.getHeight(this.obj) + offset[1]) + 'px';
+    if (top + Element.getHeight(this.container) > window_height)
+      this.container.style.bottom = (window_height - offset[1]) + 'px';
+    else this.container.style.top = top + 'px';
 
     if (this._use_iframe_mask()) {
       this.container.insertAdjacentHTML('afterEnd', '<iframe src="javascript:false;" class="record-select-mask" />');
@@ -304,6 +311,7 @@ RecordSelect.Single.prototype = Object.extend(new RecordSelect.Abstract(), {
   onselect: function(id, value) {
     this.set(id, value);
     if (this.options.onchange) this.options.onchange.call(this, id, value);
+    this.obj.fire('recordselect:change', {"id": id, "label": value});
     this.close();
   },
 
@@ -343,17 +351,17 @@ RecordSelect.Autocomplete.prototype = Object.extend(new RecordSelect.Abstract(),
   },
 
   onselect: function(id, value) {
-    this.set(id, value);
+    this.set(value);
     if (this.options.onchange) this.options.onchange.call(this, id, value);
+    this.obj.fire('recordselect:change', {"id": id, "label": value});
     this.close();
   },
 
   /**
    * sets the id/label
    */
-  set: function(id, label) {
+  set: function(label) {
     this.obj.value = label.unescapeHTML();
-    this.hidden_input.value = id;
   }
 });
 

data/lib/record_select/version.rb

@@ -2,7 +2,7 @@ module RecordSelect
   module Version
     MAJOR = 3
     MINOR = 1
-    PATCH = 8
+    PATCH = 9
 
     STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: recordselect
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: 
   segments: 
   - 3
   - 1
-  - 8
-  version: 3.1.8
+  - 9
+  version: 3.1.9
 platform: ruby
 authors: 
 - Sergio Cambra
@@ -17,7 +17,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-01 00:00:00 Z
+date: 2012-02-21 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   version_requirements: &id001 !ruby/object:Gem::Requirement