recommendable 1.1.6 → 1.1.7

data/CHANGELOG.markdown

@@ -1,8 +1,12 @@
 Changelog
 =========
 
-1.1.6 (Current version)
+1.1.7 (Current version)
 -----------------------
+* Fix #50, a method that was forgotten to time during the ignoreable => ignorable typo update
+
+1.1.6
+-----
 * Minor code cleanup for my benefit
 
 1.1.5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    recommendable (1.1.5)
+    recommendable (1.1.6)
       hooks (>= 0.2.1)
       rails (>= 3.0.0)
       redis (>= 2.2.0)
@@ -9,12 +9,12 @@ PATH
 GEM
   remote: http://rubygems.org/
   specs:
-    actionmailer (3.2.7)
-      actionpack (= 3.2.7)
+    actionmailer (3.2.8)
+      actionpack (= 3.2.8)
       mail (~> 2.4.4)
-    actionpack (3.2.7)
-      activemodel (= 3.2.7)
-      activesupport (= 3.2.7)
+    actionpack (3.2.8)
+      activemodel (= 3.2.8)
+      activesupport (= 3.2.8)
       builder (~> 3.0.0)
       erubis (~> 2.7.0)
       journey (~> 1.0.4)
@@ -22,18 +22,18 @@ GEM
       rack-cache (~> 1.2)
       rack-test (~> 0.6.1)
       sprockets (~> 2.1.3)
-    activemodel (3.2.7)
-      activesupport (= 3.2.7)
+    activemodel (3.2.8)
+      activesupport (= 3.2.8)
       builder (~> 3.0.0)
-    activerecord (3.2.7)
-      activemodel (= 3.2.7)
-      activesupport (= 3.2.7)
+    activerecord (3.2.8)
+      activemodel (= 3.2.8)
+      activesupport (= 3.2.8)
       arel (~> 3.0.2)
       tzinfo (~> 0.3.29)
-    activeresource (3.2.7)
-      activemodel (= 3.2.7)
-      activesupport (= 3.2.7)
-    activesupport (3.2.7)
+    activeresource (3.2.8)
+      activemodel (= 3.2.8)
+      activesupport (= 3.2.8)
+    activesupport (3.2.8)
       i18n (~> 0.6)
       multi_json (~> 1.0)
     arel (3.0.2)
@@ -61,17 +61,17 @@ GEM
       rack
     rack-test (0.6.1)
       rack (>= 1.0)
-    rails (3.2.7)
-      actionmailer (= 3.2.7)
-      actionpack (= 3.2.7)
-      activerecord (= 3.2.7)
-      activeresource (= 3.2.7)
-      activesupport (= 3.2.7)
+    rails (3.2.8)
+      actionmailer (= 3.2.8)
+      actionpack (= 3.2.8)
+      activerecord (= 3.2.8)
+      activeresource (= 3.2.8)
+      activesupport (= 3.2.8)
       bundler (~> 1.0)
-      railties (= 3.2.7)
-    railties (3.2.7)
-      actionpack (= 3.2.7)
-      activesupport (= 3.2.7)
+      railties (= 3.2.8)
+    railties (3.2.8)
+      actionpack (= 3.2.8)
+      activesupport (= 3.2.8)
       rack-ssl (~> 1.3.2)
       rake (>= 0.8.7)
       rdoc (~> 3.4)

data/README.markdown

@@ -91,6 +91,12 @@ Users.all.each do |user|
 end
 ```
 
+Why not stars?
+--------------
+I'll let Randall Munroe of [XKCD](http://xkcd.com/) take this one for me:
+
+[![I got lost and wandered into the world's creepiest cemetery, where the headstones just had names and star ratings. Freaked me out. When I got home I tried to leave the cemetery a bad review on Yelp, but as my hand hovered over the 'one star' button I felt this distant chill ...](http://imgs.xkcd.com/comics/star_ratings.png)](http://xkcd.com/1098/)
+
 Contributing to recommendable
 -----------------------------
 

data/lib/recommendable/acts_as_recommendable.rb

@@ -44,7 +44,7 @@ module Recommendable
             items = self.find ids
             return items.first if count == 1
 
-            return items.sort { |x, y| ids.index(x.id) <=> ids.index(y.id) }
+            return items.sort_by { |item| ids.index(item.id) }
           end
 
           private

data/lib/recommendable/acts_as_recommended_to.rb

@@ -374,9 +374,9 @@ module Recommendable
       # @return [ActiveRecord::Relation] an ActiveRecord::Relation of records that self has ignored
       def ignored_for klass
         ids = if klass.sti?
-          ignores.joins(manual_join(klass, 'ignore')).map(&:ignoreable_id)
+          ignores.joins(manual_join(klass, 'ignore')).map(&:ignorable_id)
         else
-          ignores.where(:ignoreable_type => klass.to_s).map(&:ignoreable_id)
+          ignores.where(:ignorable_type => klass.to_s).map(&:ignorable_id)
         end
 
         klass.where('ID IN (?)', ids)
@@ -414,9 +414,7 @@ module Recommendable
         raters = Recommendable.user_class.find rater_ids
         
         # The query loses the ordering, so...
-        return raters.sort do |x, y|
-          rater_ids.index(x.id) <=> rater_ids.index(y.id)
-        end
+        return raters.sort_by { |rater| rater_ids.index(rater.id) }
       end
 
       def liked_in_common_with rater, options = {}

data/lib/recommendable/version.rb

@@ -1,7 +1,7 @@
 module Recommendable
   MAJOR = 1
   MINOR = 1
-  PATCH = 6
+  PATCH = 7
 
   VERSION = [MAJOR, MINOR, PATCH].join '.'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recommendable
 version: !ruby/object:Gem::Version
-  version: 1.1.6
+  version: 1.1.7
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-03 00:00:00.000000000 Z
+date: 2012-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3