rebay 1.1.3 → 1.2.0

data/Gemfile

@@ -6,6 +6,4 @@ end
   
 group :development do
   gem 'rspec'
-  gem 'bundler', '>= 1.0.0'
-  gem 'jeweler', '>= 1.5.2'
 end

data/Gemfile.lock

@@ -1,30 +1,20 @@
 GEM
   remote: http://rubygems.org/
   specs:
-    diff-lcs (1.1.2)
-    git (1.2.5)
-    jeweler (1.5.2)
-      bundler (~> 1.0.0)
-      git (>= 1.2.5)
-      rake
+    diff-lcs (1.1.3)
     json (1.5.1)
-    rake (0.8.7)
-    rspec (2.5.0)
-      rspec-core (~> 2.5.0)
-      rspec-expectations (~> 2.5.0)
-      rspec-mocks (~> 2.5.0)
-    rspec-core (2.5.1)
-    rspec-expectations (2.5.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.5.0)
-    watchr (0.7)
+    rspec (2.12.0)
+      rspec-core (~> 2.12.0)
+      rspec-expectations (~> 2.12.0)
+      rspec-mocks (~> 2.12.0)
+    rspec-core (2.12.2)
+    rspec-expectations (2.12.1)
+      diff-lcs (~> 1.1.3)
+    rspec-mocks (2.12.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (>= 1.0.0)
-  jeweler (>= 1.5.2)
   json
   rspec
-  watchr

data/README.md

@@ -38,7 +38,29 @@ For my own sanity, I transform this response into a more standard ruby hash and
 You can check for success or failure of the request:
 	response.success?
 	response.failure?
-	
+  
+Recent Updates
+--------------
+[yarmiganosca](https://github.com/yarmiganosca)
+
+  Added support for using Ebay Sandbox urls (through a configuration
+  variable).
+
+  Changed the way Finding and Shopping generate their base urls. Instead
+  of a class variable, they now call self.base_url, which reads the
+  sandbox configuration variable and either creates a sandbox url or a
+  production url.
+  
+  Updated the conditions under which the Shopping Api calls raise
+  ArgumentErrors, involved changing the cases of the parameters (they
+  changed in the Ebay Api) and adding support for specifying either a
+  ProductID or a ProductID.type, ProductID.Value pair for searching by
+  ProductIDs other than Ebay ReferenceIDs.
+  
+[peppyheppy](https://github.com/peppyheppy)
+
+  Added support for dynamic siteid in both configuration and by passing in params
+  
 MIT License
 -----------
 Copyright (c) 2010 Chuck Collins

data/VERSION

@@ -1 +1 @@
-1.1.3
+1.2.0

data/lib/rebay/api.rb

@@ -4,25 +4,46 @@ require 'uri'
 
 module Rebay
   class Api
+    # default site is EBAY_US, for other available sites see eBay documentation:
+    # http://developer.ebay.com/DevZone/merchandising/docs/Concepts/SiteIDToGlobalID.html
     EBAY_US = 0
-  
-    def self.app_id= app_id
-      @@app_id = app_id
-    end
-    
-    def self.app_id
-      @@app_id
-    end
+
+    class << self
+      attr_accessor :app_id, :default_site_id, :sandbox
+      
+      def base_url
+        [base_url_prefix,
+         sandbox ? "sandbox" : nil,
+         base_url_suffix].compact.join('.')
+      end
+
+      def base_url_prefix
+        "http://svcs"
+      end
+
+      def base_url_suffix
+        "ebay.com"
+      end
+
+      def sandbox
+        @sandbox ||= false
+      end
       
-    def self.configure
-      yield self if block_given?
+      def default_site_id
+        @default_site_id || EBAY_US
+      end
+      
+      def configure
+        yield self if block_given?
+      end
     end
-    
+
     protected
+    
     def get_json_response(url)
       Rebay::Response.new(JSON.parse(Net::HTTP.get_response(URI.parse(url)).body))
     end
-    
+
     def build_rest_payload(params)
       payload = ''
       unless params.nil?
@@ -33,4 +54,4 @@ module Rebay
       return payload
     end
   end
-end
+end

data/lib/rebay/finding.rb

@@ -1,6 +1,9 @@
 module Rebay
   class Finding < Rebay::Api
-    BASE_URL = 'http://svcs.ebay.com/services/search/FindingService/v1'
+    def self.base_url_suffix
+      "ebay.com/services/search/FindingService/v1"
+    end
+    
     VERSION = '1.0.0'
     
     #http://developer.ebay.com/DevZone/finding/CallRef/findItemsAdvanced.html
@@ -91,9 +94,9 @@ module Rebay
     
     private    
     def build_request_url(service, params=nil)
-      url = "#{BASE_URL}?OPERATION-NAME=#{service}&SERVICE-VERSION=#{VERSION}&SECURITY-APPNAME=#{Rebay::Api.app_id}&RESPONSE-DATA-FORMAT=JSON&REST-PAYLOAD"
+      url = "#{self.class.base_url}?OPERATION-NAME=#{service}&SERVICE-VERSION=#{VERSION}&SECURITY-APPNAME=#{Rebay::Api.app_id}&RESPONSE-DATA-FORMAT=JSON&REST-PAYLOAD"
       url += build_rest_payload(params)
       return url
     end
   end
-end
+end

data/lib/rebay/shopping.rb

@@ -1,95 +1,106 @@
 module Rebay
   class Shopping < Rebay::Api
-    BASE_URL = 'http://open.api.ebay.com/shopping'
-    VERSION = '677'
+    VERSION = '793'
+    
+    class << self
+      def base_url_prefix
+        "http://open.api"
+      end
+    
+      def base_url_suffix
+        "ebay.com/shopping"
+      end
+    end
     
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/FindProducts.html
     def find_products(params)
-      raise ArgumentError unless params[:categoryId] or params[:productId] or params[:queryKeywords]
+      raise ArgumentError unless params[:CategoryID] or params[:ProductID] or params[:QueryKeywords] or
+        (params[:'ProductID.Value'] && params[:'ProductID.type'])
       response = get_json_response(build_request_url('FindProducts', params))
       if response.response.has_key?('Product')
         response.results = response.response['Product']
       end
       return response
     end
-    
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/FindHalfProducts.html
     def find_half_products(params)
-      raise ArgumentError unless params[:productId] or params[:queryKeywords]
+      raise ArgumentError unless params[:ProductID] or params[:QueryKeywords] or
+        (params[:'ProductID.Value'] && params[:'ProductID.type'])
       response = get_json_response(build_request_url('FindHalfProducts', params))
       if response.response.has_key?('Products') && response.response['Products'].has_key?('Product')
         response.results = response.response['Products']['Product']
       end
       return response
     end
-    
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/GetSingleItem.html
     def get_single_item(params)
-      raise ArgumentError unless params[:itemId]
+      raise ArgumentError unless params[:ItemID]
       response = get_json_response(build_request_url('GetSingleItem', params))
       if response.response.has_key?('Item')
         response.results = response.response['Item']
       end
       return response
     end
-    
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/GetItemStatus.html
     def get_item_status(params)
-      raise ArgumentError unless params[:itemId]
+      raise ArgumentError unless params[:ItemID]
       response = get_json_response(build_request_url('GetItemStatus', params))
       if response.response.has_key?('Item')
         response.results = response.response['Item']
       end
       return response
     end
-    
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/GetShippingCosts.html
     def get_shipping_costs(params)
-      raise ArgumentError unless params[:itemId]
+      raise ArgumentError unless params[:ItemID]
       response = get_json_response(build_request_url('GetShippingCosts', params))
       return response
     end
-    
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/GetMultipleItems.html
     def get_multiple_items(params)
-      raise ArgumentError unless params[:itemId]
+      raise ArgumentError unless params[:ItemID]
       response = get_json_response(build_request_url('GetMultipleItems', params))
       if response.response.has_key?('Item')
         response.results = response.response['Item']
       end
       return response
     end
-    
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/GetUserProfile.html
     def get_user_profile(params)
-      raise ArgumentError unless params[:userId]
+      raise ArgumentError unless params[:UserID]
       response = get_json_response(build_request_url('GetUserProfile', params))
       if response.response.has_key?('User')
         response.results = response.response['User']
       end
       return response
     end
-    
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/FindPopularSearches.html
     def find_popular_searches(params)
-      raise ArgumentError unless params[:categoryId]
+      raise ArgumentError unless params[:CategoryID]
       response = get_json_response(build_request_url('FindPopularSearches', params))
       if response.response.has_key?('PopularSearchResult')
         response.results = response.response['PopularSearchResult']
       end
       return response
     end
-    
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/FindPopularItems.html
     def find_popular_items(params={})
-      raise ArgumentError unless params[:categoryId] or params[:queryKeywords]
+      raise ArgumentError unless params[:CategoryID] or params[:QueryKeywords]
       response = get_json_response(build_request_url('FindPopularItems', params))
       if response.response.has_key?('ItemArray') && response.response['ItemArray'].has_key?('Item')
         response.results = response.response['ItemArray']['Item']
       end
       return response
     end
-      
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/FindReviewsandGuides.html
     def find_reviews_and_guides(params={})
       response = get_json_response(build_request_url('FindReviewsAndGuides', params))
@@ -98,28 +109,28 @@ module Rebay
       end
       return response
     end
-   
+
     #http://developer.ebay.com/DevZone/shopping/docs/CallRef/GetCategoryInfo.html
     def get_category_info(params)
-      raise ArgumentError unless params[:categoryId]
+      raise ArgumentError unless params[:CategoryID]
       response = get_json_response(build_request_url('GetCategoryInfo', params))
       if response.response.has_key?('CategoryArray') && response.response['CategoryArray'].has_key?('Category')
         response.results = response.response['CategoryArray']['Category']
       end
       return response
     end
-    
+
     def get_category_info_with_children(params)
       params[:IncludeSelector] = 'ChildCategories'
       response = get_category_info(params)
       return response
-    end 
-    
+    end
+
     private
     def build_request_url(service, params=nil)
-      url = "#{BASE_URL}?callname=#{service}&appid=#{Rebay::Api.app_id}&version=#{VERSION}&responseencoding=JSON&siteid=#{Rebay::Api::EBAY_US}"
-      url += build_rest_payload(params)
+      url = "#{self.class.base_url}?callname=#{service}&appid=#{Rebay::Api.app_id}&version=#{VERSION}&responseencoding=JSON"
+      url += build_rest_payload({siteid: Rebay::Api.default_site_id}.merge(params))
       return url
     end
   end
-end
+end

data/rebay.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "rebay"
-  s.version = "1.1.3"
+  s.version = "1.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Chuck Collins"]
-  s.date = "2012-02-17"
+  s.date = "2013-01-03"
   s.email = "chuck.collins@gmail.com"
   s.extra_rdoc_files = [
     "LICENSE",
@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/ccollins/rebay"
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.11"
+  s.rubygems_version = "1.8.23"
   s.summary = "Client for the RESTful JSON ebay finding and shopping api"
 
   if s.respond_to? :specification_version then
@@ -41,19 +41,13 @@ Gem::Specification.new do |s|
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<rspec>, [">= 0"])
-      s.add_development_dependency(%q<bundler>, [">= 1.0.0"])
-      s.add_development_dependency(%q<jeweler>, [">= 1.5.2"])
       s.add_runtime_dependency(%q<json>, [">= 0"])
     else
       s.add_dependency(%q<rspec>, [">= 0"])
-      s.add_dependency(%q<bundler>, [">= 1.0.0"])
-      s.add_dependency(%q<jeweler>, [">= 1.5.2"])
       s.add_dependency(%q<json>, [">= 0"])
     end
   else
     s.add_dependency(%q<rspec>, [">= 0"])
-    s.add_dependency(%q<bundler>, [">= 1.0.0"])
-    s.add_dependency(%q<jeweler>, [">= 1.5.2"])
     s.add_dependency(%q<json>, [">= 0"])
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rebay
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-17 00:00:00.000000000Z
+date: 2013-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70147704523280 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,40 +21,28 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70147704523280
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: &70147704517520 !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.0.0
-  type: :development
-  prerelease: false
-  version_requirements: *70147704517520
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: jeweler
-  requirement: &70147704513820 !ruby/object:Gem::Requirement
+  name: json
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.5.2
-  type: :development
+        version: '0'
+  type: :runtime
   prerelease: false
-  version_requirements: *70147704513820
-- !ruby/object:Gem::Dependency
-  name: json
-  requirement: &70147704510340 !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: *70147704510340
 description: 
 email: chuck.collins@gmail.com
 executables: []
@@ -97,7 +85,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Client for the RESTful JSON ebay finding and shopping api