rebay 1.1.1 → 1.1.2

data/VERSION

@@ -1 +1 @@
-1.1.1
+1.1.2

data/lib/rebay/finding.rb

@@ -8,6 +8,7 @@ module Rebay
       raise ArgumentError unless params[:keywords] or params[:categoryId]
       response = get_json_response(build_request_url('findItemsAdvanced', params))
       response.trim(:findItemsAdvancedResponse)
+      
       if response.response.has_key?('searchResult') && response.response['searchResult'].has_key?('item')
         response.results = response.response['searchResult']['item']
       end

data/lib/rebay/response.rb

@@ -31,6 +31,16 @@ module Rebay
       end
     end
     
+    def size
+      if @results.nil?
+        return 0
+      elsif @results.class == Array
+        return @results.size
+      else
+        return 1
+      end
+    end
+    
     protected
     def transform_json_response(response)    
       if response.class == Hash

data/rebay.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rebay}
-  s.version = "1.1.1"
+  s.version = "1.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Chuck Collins"]
-  s.date = %q{2010-10-05}
+  s.date = %q{2010-11-06}
   s.email = %q{chuck.collins@gmail.com}
   s.extra_rdoc_files = [
     "LICENSE",

data/spec/finding_spec.rb

@@ -63,7 +63,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_advanced.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_advanced"))
         @finder.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @finder.find_items_advanced({:keywords => 'whatevs'})
         
@@ -71,6 +71,16 @@ module Rebay
         response.each { |r| count = count + 1 }
         count.should eq(2)
       end
+      
+      it "should work with 1 result" do
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_advanced_one_item"))
+        @finder.stub!(:get_json_response).and_return(Rebay::Response.new(json))
+        response = @finder.find_items_advanced({:categoryId => 1})
+        count = 0
+
+        response.each { |r| count = count + 1 }
+        count.should eq(1)
+      end
     end
     
     context "when calling find_items_by_category" do     
@@ -87,7 +97,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_by_category.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_by_category"))
         @finder.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @finder.find_items_by_category({:categoryId => 1})
         
@@ -111,7 +121,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_by_product.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_by_product"))
         @finder.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @finder.find_items_by_product({:productId => 1})
         
@@ -135,7 +145,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_by_keywords.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_by_keywords"))
         @finder.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @finder.find_items_by_keywords({:keywords => 'whatevs'})
         
@@ -191,7 +201,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/get_search_keywords_recommendation.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/get_search_keywords_recommendation"))
         @finder.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @finder.get_search_keywords_recommendation({:keywords => 'whatevs'})
         
@@ -213,7 +223,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/get_version.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/get_version"))
         @finder.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @finder.get_version
         

data/spec/response_spec.rb

@@ -4,14 +4,14 @@ module Rebay
   describe Response do
     context "on creation" do
       it "should transform the happy json" do
-        json_happy = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/get_search_keywords_recommendation_happy.json"))
+        json_happy = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/get_search_keywords_recommendation_happy"))
         response = Response.new(json_happy)
         response.response.should eq({"getSearchKeywordsRecommendationResponse" => {"ack" => "Success", "version" => "1.5.0", 
                                                                                   "timestamp" => "2010-08-13T21:11:02.539Z", "keywords" => "accordion"}})
       end
       
       it "should transform the sad json" do
-        json_sad = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/get_search_keywords_recommendation_sad.json"))
+        json_sad = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/get_search_keywords_recommendation_sad"))
         response = Response.new(json_sad)
         response.response.should eq({"getSearchKeywordsRecommendationResponse" =>
                         {"ack" => "Warning",
@@ -68,7 +68,7 @@ module Rebay
     
     context "using find items advanced json" do
       before(:each) do
-        @json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_advanced.json"))
+        @json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/finding/find_items_advanced"))
         @response = Response.new(@json)
         @response.trim(:findItemsAdvancedResponse)
         @proper = {"ack"=>"Success", "version"=>"1.7.0", "timestamp"=>"2010-09-29T01:53:58.039Z",
@@ -111,6 +111,10 @@ module Rebay
       it "should trim format response correctly" do
         @response.response.should eq(@proper)
       end
+      
+      it "should show correct size" do
+        @response.size.should eq(2)
+      end
     end
   end
 end

data/spec/shopping_spec.rb

@@ -79,7 +79,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/get_category_info.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/get_category_info"))
         @shopper.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @shopper.get_category_info({:categoryId => 1})
         
@@ -103,7 +103,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_products.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_products"))
         @shopper.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @shopper.find_products({:queryKeywords => 'whatevs'})
         
@@ -127,7 +127,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_half_products.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_half_products"))
         @shopper.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @shopper.find_half_products({:queryKeywords => 'whatevs'})
         
@@ -221,7 +221,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_popular_searches.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_popular_searches"))
         @shopper.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @shopper.find_popular_searches({:categoryId => 1})
         
@@ -241,7 +241,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_popular_items.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_popular_items"))
         @shopper.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @shopper.find_popular_items({:categoryId => 1})
         
@@ -261,7 +261,7 @@ module Rebay
       end
       
       it "should iterate over results" do
-        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_reviews_and_guides.json"))
+        json = JSON.parse(File.read(File.dirname(__FILE__) + "/json_responses/shopping/find_reviews_and_guides"))
         @shopper.stub!(:get_json_response).and_return(Rebay::Response.new(json))
         response = @shopper.find_reviews_and_guides
         

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 1
-  - 1
-  version: 1.1.1
+  - 2
+  version: 1.1.2
 platform: ruby
 authors: 
 - Chuck Collins
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-05 00:00:00 -05:00
+date: 2010-11-06 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency