read_ipa 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a2a7646019ea6e7252423c51d1547fcced1825b1
-  data.tar.gz: 7b994e0ad60aa6de7f31af351af733409f563a9c
+  metadata.gz: 1f767230a21f560c346509d7c0676dd68de0324d
+  data.tar.gz: ea8e0a300c27f1d4395d41120f8866d54866a3c8
 SHA512:
-  metadata.gz: 62ec5b5ac54ddf38dae995edb2a224767876d2c0279e1c96a1d7f899f8cc6cc90dae3956ed5285816b2712f67496a0219495f5f11dd79e98bd32f3d032b26691
-  data.tar.gz: 075366d953eaabc281fe3435ab3a7c5d0a3a0c22554a3697d82cab222cff57050ca9c539d99e9eaf1e7d6adb3457358ceccaeca2579c07a799c8947779c3b5fa
+  metadata.gz: 5ccf898d03ad4ebaa7d3f0bf328fde06cc3d28524ca93fb3517108c2a1eadc0bc39ce079bbc578cb9327352850c7d535a38a85c4294d307c6f1dd3f6c02eb507
+  data.tar.gz: 60a232032d4a8fa7c72f5da8cbc7e67af151eb6ed325ad1c9c6dca63fa0df8b4f941cf8a61646739838d8e8baeffa6e353db952274b525c8237aec9d2b2e71f8

data/lib/read_ipa.rb

@@ -58,13 +58,15 @@ module ReadIpa
     end
 
     def get_highest_res_icon(icons_file_names)
-      highest_res_icon = icons_file_names
+      icon_names = icons_file_names
         .map{ |icon_path| find_existing_path(icon_path) }
         .compact
         .uniq(&:name)
+      highest_res_icon = icon_names
         .map{|entry| entry.get_input_stream.read}
         .max_by{|data| read_png(data).width }
 
+      return nil if highest_res_icon.nil?
       begin
         return ApplePng.new(highest_res_icon).data
       rescue NotValidApplePngError
@@ -73,22 +75,17 @@ module ReadIpa
     end
 
     def icon_file
-      if plist["CFBundleIconFiles"]
-        get_highest_res_icon(plist["CFBundleIconFiles"])
-      elsif plist["CFBundleIcons"]
+      icon_files = [plist["CFBundleIconFile"]].compact
+      icon_files += plist["CFBundleIconFiles"] || []
+      if plist["CFBundleIcons"]
         dict = plist["CFBundleIcons"]
         primary_icons = dict["CFBundlePrimaryIcon"]
         return nil unless primary_icons
         icons = primary_icons.to_rb["CFBundleIconFiles"]
         return nil unless icons
-        get_highest_res_icon(icons)
-      elsif plist["CFBundleIconFile"]
-        data = read_file(plist["CFBundleIconFile"])
-        png = ApplePng.new(data)
-        png.data
-      else
-        nil
+        icon_files += icons
       end
+      get_highest_res_icon(icon_files)
     end
 
     def executable_file_name

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: read_ipa
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Marvin Killing