reactrb 0.8.5 → 0.8.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 432c02f2ff9fa554e3a2a1204eeefd0ddc298517
-  data.tar.gz: 5f3cab14f2b427012679be08b6b9be74b83906ae
+  metadata.gz: dd3c6c8b1cf5d2a684020ee3d320fe5ac37c340e
+  data.tar.gz: ac90157aefeb57a7ffecaa3d9f5782ed1d428de7
 SHA512:
-  metadata.gz: cc66ddd5e99becd6dc75cd130905f2b5c4eeff00801a9381244286d22a501500b48be20bae15f3fdd8f1310e94025dd0de4578d734e8ed7a922badad2c1300a0
-  data.tar.gz: f88436fe6d61c23e9cd66db39a2bf76c72cf4c9cbd9e6f9c9f59b8e96b49f921278c64719f70364089174dc175ea3e6597ec28599d626c9b227186adad87fe46
+  metadata.gz: f0d14776cd42b7b2fac9a03da13f9132e27fe544b6f323e8f92ee947f02e253c1a226ef813e73cbdcb56d89446694caa1bca7082b5c88d22c48bae6ab48736a5
+  data.tar.gz: fad34a83a2b6ab81438e8e0db5c37590c07a18bcaa27afeb1e10bfefe4784cffee4ae31f500515e86150b076b9ef82f6227b2a7238c32694af976fd80ac61652

data/CHANGELOG.md

@@ -0,0 +1,29 @@
+# Change Log
+
+All notable changes to this project will be documented in this file starting with v0.8.6.
+This project *tries* to adhere to [Semantic Versioning](http://semver.org/), even before v1.0.
+
+Changes are grouped as follows:
+- **Added** for new features.
+- **Changed** for changes in existing functionality.
+- **Deprecated** for once-stable features removed in upcoming releases.
+- **Removed** for deprecated features removed in this release.
+- **Fixed** for any bug fixes.
+- **Security** to invite users to upgrade in case of vulnerabilities.
+
+<!--
+Whitespace conventions:
+- 4 spaces before ## titles
+- 2 spaces before ### titles
+- 1 spaces before normal text
+ -->
+
+
+
+
+## [0.8.6] - 2016-06-30
+
+
+### Fixed
+
+- Method missing within a component was being reported as `incorrect const name` (#151)

data/lib/react/component/tags.rb

@@ -83,13 +83,20 @@ module React
       private
 
       def find_component(name)
-        scopes = "#{self.class.name}".split('::').inject([Module]) do |nesting, next_const|
+        component = lookup_const(name)
+        if component && !component.method_defined?(:render)
+          raise "#{name} does not appear to be a react component."
+        end
+        component
+      end
+
+      def lookup_const(name)
+        return nil unless name =~ /^[A-Z]/
+        scopes = self.class.name.to_s.split('::').inject([Module]) do |nesting, next_const|
           nesting + [nesting.last.const_get(next_const)]
         end.reverse
-        scope = scopes.detect { |s| s.const_defined?(name) } || return
-        component = scope.const_get(name)
-        return component if component.method_defined?(:render)
-        raise "#{name} does not appear to be a react component."
+        scope = scopes.detect { |s| s.const_defined?(name) }
+        scope.const_get(name) if scope
       end
     end
   end

data/lib/reactive-ruby/version.rb

@@ -1,3 +1,3 @@
 module React
-  VERSION = '0.8.5'
+  VERSION = '0.8.6'
 end

data/spec/react/dsl_spec.rb

@@ -153,6 +153,18 @@ describe 'the React DSL' do
       .to raise_error('Comp does not appear to be a react component.')
   end
 
+  it 'raises a method missing error' do
+    stub_const 'Foo', Class.new(React::Component::Base)
+    Foo.class_eval do
+      backtrace :none
+      render do
+        _undefined_method
+      end
+    end
+    expect { React.render_to_static_markup(React.create_element(Foo)) }
+      .to raise_error(NoMethodError)
+  end
+
   it "will treat the component class name as a first class component name" do
     stub_const 'Mod::Bar', Class.new
     Mod::Bar.class_eval do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reactrb
 version: !ruby/object:Gem::Version
-  version: 0.8.5
+  version: 0.8.6
 platform: ruby
 authors:
 - David Chang
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-29 00:00:00.000000000 Z
+date: 2016-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opal
@@ -232,6 +232,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md