reactor 0.5.3 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2e2420e728e56ddaf2d1dac1b97d68e39be9da53
-  data.tar.gz: 3a6107dd7f630ffb35ffd7b3a9974c3f571e8dee
+  metadata.gz: e0929514c03a52f0651fddbe28552d2cd2753f35
+  data.tar.gz: 920052c285cb492a8fb916fc4fae5b3dd8a6e30d
 SHA512:
-  metadata.gz: db8d01bf51e70978395acf02baf414c6eaf44d720a8328c01c3cfd0d7f5c13836a0998b5d90419b191083be37a9ce0aa5868ccb3b48b1126e76a8cf1939c773f
-  data.tar.gz: a9a78311e709d5361ecff086cc6e3dc1b6f7a57b713c1d1056ef3225401934f875c5e6d4890d1895d48e89cc936b94e49b1324e802ba3e1514c4d4e155d21118
+  metadata.gz: 023ef8cb5805b53006d9d25b95486160c3d4ffa7885f3654f99d9d8f69716c7f4818731839e74a873619ed11d925a7232bd2346ec13e0bd82df7250dbb100079
+  data.tar.gz: 1fa9340e7e9a3d5621058edbfa8df3281e9407dfd11805d58a8b64eca41a72acc240d8e7ed1065f0c76aae5794a5e427969edcfdd6bd0a96b1cffd3c55a37206

data/README.md

@@ -44,12 +44,18 @@ Well, this is evolving, so it's probably best to go read the specs.
 
 #### Subscribable
 
-  *New in 0.3*
-
   You can now bind any block to an event in your models like so
 
     on_event :any_event do |event|
-      MyModel.find(event.target).do_something_about_it!
+      event.target.do_something_about_it!
+    end
+
+  Static subscribers like these are automatically placed into Sidekiq and executed in the background
+
+  It's also possible to run a subscriber block in memory like so
+
+    on_event :any_event, in_memory: true do |event|
+      event.target.do_something_about_it_and_make_the_user_wait!
     end
 
 ## Contributing

data/lib/reactor/event.rb

@@ -13,16 +13,8 @@ class Reactor::Event
 
   def perform(name, data)
     data.merge!(fired_at: Time.current, name: name)
-    Reactor::Subscriber.where(event: name).each do |subscriber|
-      Reactor::Subscriber.delay.fire subscriber.id, data
-    end
-
-    #TODO: support more matching?
-    Reactor::Subscriber.where(event: '*').each do |s|
-      Reactor::Subscriber.delay.fire s.id, data
-    end
-
-    ((Reactor::SUBSCRIBERS[name.to_s]  || []) | (Reactor::SUBSCRIBERS['*'] || [])).each {|s| s.perform_async(data) }
+    fire_database_driven_subscribers(data, name)
+    fire_block_subscribers(data, name)
   end
 
   def method_missing(method, *args)
@@ -91,4 +83,19 @@ class Reactor::Event
   def initialize_polymorphic_association(method)
     data["#{method}_type"].constantize.find(data["#{method}_id"])
   end
+
+  def fire_database_driven_subscribers(data, name)
+    Reactor::Subscriber.where(event: name).each do |subscriber|
+      Reactor::Subscriber.delay.fire subscriber.id, data
+    end
+
+    #TODO: support more matching?
+    Reactor::Subscriber.where(event: '*').each do |s|
+      Reactor::Subscriber.delay.fire s.id, data
+    end
+  end
+
+  def fire_block_subscribers(data, name)
+    ((Reactor::SUBSCRIBERS[name.to_s] || []) | (Reactor::SUBSCRIBERS['*'] || [])).each { |s| s.perform_where_needed(data) }
+  end
 end

data/lib/reactor/models/concerns/subscribable.rb

@@ -2,8 +2,10 @@ module Reactor::Subscribable
   extend ActiveSupport::Concern
 
   module ClassMethods
-    def on_event(event, method = nil, options = {}, &block)
-      (Reactor::SUBSCRIBERS[event.to_s] ||= []).push(StaticSubscriberFactory.create event, method, {source: self}.merge(options), &block)
+    def on_event(*args, &block)
+      options = args.extract_options!
+      event, method = args
+      (Reactor::SUBSCRIBERS[event.to_s] ||= []).push(StaticSubscriberFactory.create(event, method, {source: self}.merge(options), &block))
     end
   end
 
@@ -17,7 +19,7 @@ module Reactor::Subscribable
         class #{new_class}
           include Sidekiq::Worker
 
-          cattr_accessor :method, :delay, :source
+          cattr_accessor :method, :delay, :source, :in_memory
 
           def perform(data)
             event = Reactor::Event.new(data)
@@ -27,6 +29,14 @@ module Reactor::Subscribable
               @@method.call(event)
             end
           end
+
+          def self.perform_where_needed(data)
+            if @@in_memory
+              new.perform(data)
+            else
+              perform_async(data)
+            end
+          end
         end
       }
 
@@ -34,6 +44,7 @@ module Reactor::Subscribable
       new_class.method = method || block
       new_class.delay = options[:delay] || 0
       new_class.source = options[:source]
+      new_class.in_memory = options[:in_memory]
       new_class
     end
   end

data/lib/reactor/version.rb

@@ -1,3 +1,3 @@
 module Reactor
-  VERSION = "0.5.3"
+  VERSION = "0.6.0"
 end

data/spec/models/concerns/subscribable_spec.rb

@@ -13,6 +13,10 @@ class Auction < ActiveRecord::Base
     event.actor.more_puppies! if event.name == 'another_event'
   end
 
+  on_event :cat_delivered, in_memory: true do |event|
+    puppies!
+  end
+
   def self.ring_bell(event)
     pp "ring ring! #{event}"
   end
@@ -49,5 +53,18 @@ describe Reactor::Subscribable do
       Auction.any_instance.should_receive(:more_puppies!)
       Reactor::Event.publish(:another_event, actor: Auction.create)
     end
+
+    describe 'in_memory flag' do
+      it 'doesnt fire perform_async when true' do
+        Auction.should_receive(:puppies!)
+        Reactor::StaticSubscribers::CatDeliveredHandler0.should_not_receive(:perform_async)
+        Reactor::Event.publish(:cat_delivered)
+      end
+
+      it 'fires perform_async when falsey' do
+        Reactor::StaticSubscribers::WildcardHandler0.should_receive(:perform_async)
+        Reactor::Event.publish(:puppy_delivered)
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reactor
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.6.0
 platform: ruby
 authors:
 - winfred
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-23 00:00:00.000000000 Z
+date: 2014-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -135,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Sidekiq/ActiveRecord pubsub lib