reactor 0.18.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1058e9253784011ae11ef0d90a81d6b03b6adda
-  data.tar.gz: 5ac34c6beb094cee626a25f91f2eef3d81c31cbf
+  metadata.gz: 5fb837714e773b0e547099b05ed322b059310f23
+  data.tar.gz: 928b14c3d60d9cae2a318d2fb36fa84e2e6384da
 SHA512:
-  metadata.gz: '0191eb26785cf2a8f269d580539ade48efd533e2add38fb07b1914b1374d35fae5316d74fa8a47cbe41f6c3bccc6935f7f39f6ff1f552ed04dcb13d995b89610'
-  data.tar.gz: c9e3c1bd5384f357375ebcd93760fce39c5f8e4e432bf88a820fdbf219566ac286da2946da41b7be0ef34c277a92a5b45c5168c8a26e363f21bbe1204567433a
+  metadata.gz: 536da1fe846ac55173a110ffd7e25e1bb362e0ca765ab40dac2730f379521b6b62da64b77e8f1768733fa4ca275c872b7da9df2020389bbe729b02685fc7e52a
+  data.tar.gz: faf39d4f13d4a2d173284b0298947b92eb7959fc63d800a397df6db2963c22a4a421bf7c796880d22362f74db3175982412d82e08f8ccd5355873b04230cc266

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    reactor (0.18.0)
+    reactor (0.19.0)
       rails
       sidekiq (> 4.0)
 
@@ -55,24 +55,24 @@ GEM
     coderay (1.1.1)
     concurrent-ruby (1.0.5)
     connection_pool (2.2.1)
+    crass (1.0.3)
     diff-lcs (1.3)
     docile (1.1.5)
-    erubi (1.6.1)
-    globalid (0.4.0)
+    erubi (1.7.0)
+    globalid (0.4.1)
       activesupport (>= 4.2.0)
     i18n (0.8.6)
     json (2.1.0)
-    loofah (2.0.3)
+    loofah (2.1.1)
+      crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
-    mail (2.6.6)
-      mime-types (>= 1.16, < 4)
+    mail (2.7.0)
+      mini_mime (>= 0.1.1)
     method_source (0.8.2)
-    mime-types (3.1)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2016.0521)
+    mini_mime (1.0.0)
     mini_portile2 (2.3.0)
     minitest (5.10.2)
-    nio4r (2.1.0)
+    nio4r (2.2.0)
     nokogiri (1.8.1)
       mini_portile2 (~> 2.3.0)
     pry (0.10.4)
@@ -111,7 +111,7 @@ GEM
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (12.0.0)
-    redis (3.3.3)
+    redis (4.0.1)
     rspec (3.6.0)
       rspec-core (~> 3.6.0)
       rspec-expectations (~> 3.6.0)
@@ -128,11 +128,11 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.6.0)
     rspec-support (3.6.0)
-    sidekiq (5.0.4)
+    sidekiq (5.0.5)
       concurrent-ruby (~> 1.0)
       connection_pool (~> 2.2, >= 2.2.0)
       rack-protection (>= 1.5.0)
-      redis (~> 3.3, >= 3.3.3)
+      redis (>= 3.3.4, < 5)
     simplecov (0.14.1)
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
@@ -155,7 +155,7 @@ GEM
       thread_safe (~> 0.1)
     websocket-driver (0.6.5)
       websocket-extensions (>= 0.1.0)
-    websocket-extensions (0.1.2)
+    websocket-extensions (0.1.3)
 
 PLATFORMS
   ruby

data/README.md

@@ -28,7 +28,8 @@ Or install it yourself as:
 
 ## Usage
 
-Well, this is evolving, so it's probably best to go read the specs.
+Well, this is evolving, so it's probably best to go read the specs as
+well as below.
 
 
 ### Barebones API
@@ -37,7 +38,6 @@ Well, this is evolving, so it's probably best to go read the specs.
 Reactor::Event.publish(:event_name, any: 'data', you: 'want')
 ```
 
-### ActiveModel extensions
 
 #### Publishable
 
@@ -287,6 +287,15 @@ on_event :high_frequency_event, :do_something, deprecated: true
 If no -> you can probably just delete the subscriber. 
 In the worst case scenario, you get some background exceptions for a job you didn't intend to have run anyway. Pick your poison. 
 
+#### Managing Queues
+
+There will likely be more queue theory here later, but for now here are the features.
+
+Everything is done on Sidekiq `default` queue by default.
+
+Subscribers can opt into certain queues with `on_event :whatever, sidekiq_options: { queue: 'whatever' }` argument.
+
+You can also override _all queue choices_ with `ENV['REACTOR_QUEUE']`. You may want to do this if you wish to contain the 'cascade' of events for more expensive or risky operations.
 
 ## Contributing
 

data/lib/reactor/event.rb

@@ -1,7 +1,13 @@
 class Reactor::Event
-  include Reactor::OptionallySubclassable
   include Sidekiq::Worker
 
+  sidekiq_options queue: ENV['REACTOR_QUEUE'] || Sidekiq.default_worker_options['queue']
+
+  CONSOLE_CONFIRMATION_MESSAGE = <<-eos
+    It looks like you are on a production console. Only fire an event if you intend to trigger 
+    all of its subscribers. In order to proceed, you must pass `srsly: true` in the event data.'
+  eos
+
   attr_accessor :__data__
 
   def initialize(data = {})
@@ -32,7 +38,6 @@ class Reactor::Event
 
     if need_to_fire
       data.merge!(fired_at: Time.current, name: name)
-      fire_database_driven_subscribers(data, name)
       fire_block_subscribers(data, name)
     end
   end
@@ -55,6 +60,9 @@ class Reactor::Event
     end
 
     def publish(name, data = {})
+      if defined?(Rails::Console) && ENV['RACK_ENV'] == 'production' && data[:srsly].blank?
+        raise ArgumentError.new(CONSOLE_CONFIRMATION_MESSAGE)
+      end
       message = new(data.merge(event: name, uuid: SecureRandom.uuid))
 
       if message.at
@@ -115,13 +123,6 @@ class Reactor::Event
     __data__["#{method}_type"].constantize.find(__data__["#{method}_id"])
   end
 
-  def fire_database_driven_subscribers(data, name)
-    #TODO: support more matching?
-    Reactor::Subscriber.where(event_name: [name, '*']).pluck(:id).each do |model_id|
-      Reactor::Workers::DatabaseSubscriberWorker.perform_async model_id, data
-    end
-  end
-
   def fire_block_subscribers(data, name)
     ((Reactor::SUBSCRIBERS[name.to_s] || []) | (Reactor::SUBSCRIBERS['*'] || [])).each { |s| s.perform_where_needed(data) }
   end

data/lib/reactor/models.rb

@@ -1,5 +1,3 @@
 # FIXME - these are not properly namespaced. The directories mean nothing
 require "reactor/models/concerns/publishable"
 require "reactor/models/concerns/subscribable"
-require "reactor/models/concerns/optionally_subclassable"
-require "reactor/models/subscriber"

data/lib/reactor/version.rb

@@ -1,3 +1,3 @@
 module Reactor
-  VERSION = "0.18.0"
+  VERSION = "0.19.0"
 end

data/lib/reactor/workers/concerns/configuration.rb

@@ -20,14 +20,19 @@ module Reactor
           if deprecated
             return
           elsif delay > 0
-            perform_in(delay, data)
+            event_queue.perform_in(delay, data)
           elsif async
-            perform_async(data)
+            event_queue.perform_async(data)
           else
             new.perform(data)
           end
           source
         end
+
+        def event_queue
+          queue_override = ENV['REACTOR_QUEUE']
+          queue_override.present? ? set(queue: queue_override) : self
+        end
       end
 
       def configured?

data/lib/reactor/workers.rb

@@ -5,4 +5,3 @@ end
 
 require "reactor/workers/event_worker"
 require "reactor/workers/mailer_worker"
-require "reactor/workers/database_subscriber_worker"

data/lib/reactor.rb

@@ -37,6 +37,3 @@ module Reactor
     Reactor::StaticSubscribers
   end
 end
-
-ActiveRecord::Base.send(:include, Reactor::Publishable)
-ActiveRecord::Base.send(:include, Reactor::Subscribable)

data/spec/event_spec.rb

@@ -8,7 +8,7 @@ module MyModule
   end
 end
 
-class ArbitraryModel < ActiveRecord::Base
+class ArbitraryModel < ApplicationRecord
 
   on_event :barfed, handler_name: :bad do
     raise 'UNEXPECTED!'
@@ -60,39 +60,55 @@ describe Reactor::Event do
       expect(Reactor::Event).to receive(:perform_async).with(event_name, 'actor_id' => '1', 'event' => :user_did_this, 'uuid' => uuid)
       Reactor::Event.publish(:user_did_this, actor_id: '1')
     end
-  end
 
-  describe 'perform' do
-    before do
-      Reactor::Subscriber.create(event_name: :user_did_this)
-      Reactor.enable_test_mode_subscriber(Reactor::Subscriber)
-    end
+    context 'when in a production rails console' do
+      it 'requires a second argument srsly: true' do
+        stub_const('Rails::Console', Class.new)
+        ENV['RACK_ENV'] = 'production'
 
-    after do
-      Reactor::Subscriber.destroy_all
-      Reactor.enable_test_mode_subscriber(Reactor::Subscriber)
+        expect {
+          Reactor::Event.publish(:thing)
+        }.to raise_exception(ArgumentError)
+
+        expect {
+          Reactor::Event.publish(:thing, srsly: true)
+        }.to_not raise_exception
+
+        ENV['RACK_ENV'] = 'development'
+      end
     end
+  end
+
+  describe 'perform' do
+    # before do
+    #   allow(Reactor::Event).
+    # end
+    let(:event_name) { :barfed }
 
     it 'fires all subscribers' do
-      expect_any_instance_of(Reactor::Subscriber).to receive(:fire).with(hash_including(actor_id: model.id.to_s))
+      expect(Reactor::StaticSubscribers::ArbitraryModel::BarfedHandler).
+          to receive(:perform_async).with(hash_including(actor_id: model.id.to_s))
+
       Reactor::Event.perform(event_name, actor_id: model.id.to_s, actor_type: model.class.to_s)
     end
 
     it 'sets a fired_at key in event data' do
-      expect_any_instance_of(Reactor::Subscriber).to receive(:fire).with(hash_including(fired_at: anything))
-      Reactor::Event.perform(event_name, actor_id: model.id.to_s, actor_type: model.class.to_s)
-    end
+      expect(Reactor::StaticSubscribers::ArbitraryModel::BarfedHandler).
+          to receive(:perform_async).with(hash_including(fired_at: anything))
 
-    it 'works with the legacy .process method, too' do
-      expect_any_instance_of(Reactor::Subscriber).to receive(:fire).with(hash_including(actor_id: model.id.to_s))
       Reactor::Event.perform(event_name, actor_id: model.id.to_s, actor_type: model.class.to_s)
     end
 
     describe 'when subscriber throws exception', :sidekiq do
-      let(:barfing_event) { Reactor::Event.perform('barfed', somethin: 'up', actor_id: model.id.to_s, actor_type: model.class.to_s) }
-
       it 'doesnt matter because it runs in a separate worker process' do
-        expect { barfing_event }.to_not raise_exception
+        expect {
+          Reactor::Event.perform(
+              'barfed',
+              somethin: 'up',
+              actor_id: model.id.to_s,
+              actor_type: model.class.to_s
+          )
+        }.to_not raise_exception
       end
     end
   end

data/spec/models/concerns/publishable_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'sidekiq/testing'
 
-class Publisher < ActiveRecord::Base
+class Publisher < ApplicationRecord
   belongs_to :pet
 
   def ring_timeout
@@ -20,21 +20,10 @@ class Publisher < ActiveRecord::Base
   publishes :woof, actor: :pet, target: :self
 end
 
-class TestSubscriber < Reactor::Subscriber
-  @@called = false
-
-  on_fire do
-    @@called = true
-  end
-end
-
 describe Reactor::Publishable do
-  before do
-    TestSubscriber.destroy_all
-    TestSubscriber.class_variable_set(:@@called, false)
-  end
+  before { allow(Reactor::Event).to receive(:perform_at).and_call_original }
 
-  describe 'publish' do
+  describe 'publishes' do
     let(:pet) { Pet.create! }
     let(:publisher) { Publisher.create!(pet: pet, start_at: Time.current + 1.day, we_want_it: false) }
 
@@ -92,7 +81,7 @@ describe Reactor::Publishable do
       before do
         Sidekiq::Testing.fake!
         Sidekiq::Worker.clear_all
-        TestSubscriber.create! event_name: :conditional_event_on_publish
+        # TestSubscriber.create! event_name: :conditional_event_on_publish
         publisher
         job = Reactor::Event.jobs.detect do |job|
           job['class'] == 'Reactor::Event' && job['args'].first == 'conditional_event_on_publish'
@@ -153,7 +142,6 @@ describe Reactor::Publishable do
       before do
         Sidekiq::Testing.fake!
         Sidekiq::Worker.clear_all
-        TestSubscriber.create! event_name: :conditional_event_on_save
         publisher
         job = Reactor::Event.jobs.detect do |job|
           job['class'] == 'Reactor::Event' && job['args'].first == 'conditional_event_on_save'
@@ -203,27 +191,28 @@ describe Reactor::Publishable do
 
 
     it 'supports immediate events (on create) that get fired once' do
-      Reactor.with_subscriber_enabled(Reactor::Subscriber) do
-        TestSubscriber.create! event_name: :bell
-        publisher
-        expect(TestSubscriber.class_variable_get(:@@called)).to be_truthy
-        TestSubscriber.class_variable_set(:@@called, false)
-        publisher.start_at = 1.day.from_now
-        publisher.save
-        expect(TestSubscriber.class_variable_get(:@@called)).to be_falsey
-      end
+      expect(Reactor::Event).to receive(:perform_async).
+        with(:woof, hash_including(actor_type: 'Pet'))
+      expect(Reactor::Event).to receive(:perform_async).
+          with(:bell, hash_including(actor_type: 'Publisher'))
+
+      publisher
+
+      # and dont get fired on update
+      publisher.start_at = 1.day.from_now
+      expect(Reactor::Event).to_not receive(:perform_async).with(:bell)
+      expect(Reactor::Event).to_not receive(:perform_async).with(:woof)
+      publisher.save
+
     end
 
     it 'does publish an event scheduled for the future' do
-      Reactor.enable_test_mode_subscriber Reactor::Subscriber
-      Reactor.enable_test_mode_subscriber Publisher
-      TestSubscriber.create! event_name: :begin
-      Publisher.create!(pet: pet, start_at: Time.current + 1.week)
+      future = Time.now.utc + 1.week
 
-      expect(TestSubscriber.class_variable_get(:@@called)).to be_truthy
+      expect(Reactor::Event).to receive(:perform_at).
+          with(future, :begin, hash_including('additional_info' => 'curtis was here'))
 
-      Reactor.disable_test_mode_subscriber Reactor::Subscriber
-      Reactor.disable_test_mode_subscriber Publisher
+      Publisher.create!(pet: pet, start_at: future)
     end
   end
 end

data/spec/models/concerns/subscribable_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-class Auction < ActiveRecord::Base
+class Auction < ApplicationRecord
   on_event :bid_made do |event|
     event.target.update_column :status, 'first_bid_made'
   end
@@ -68,7 +68,7 @@ class KittenMailer < ActionMailer::Base
 end
 
 Reactor.in_test_mode do
-  class TestModeAuction < ActiveRecord::Base
+  class TestModeAuction < ApplicationRecord
     on_event :test_puppy_delivered, -> (event) { "success" }
   end
 end
@@ -166,6 +166,21 @@ describe Reactor::Subscribable do
       end
     end
 
+    describe 'overriding queue options with ENV variable to isolate cascade between processes' do
+      before { ENV['REACTOR_QUEUE'] = 'bulk' }
+      after { ENV.delete('REACTOR_QUEUE') }
+
+      specify do
+        expect_any_instance_of(Reactor::StaticSubscribers::Auction::WildcardHandler).
+            to receive(:perform)
+
+        expect(Reactor::StaticSubscribers::Auction::WildcardHandler).to receive(:set).
+            with(hash_including(queue: 'bulk')).and_call_original
+
+        Reactor::Event.publish(:puppy_delivered)
+      end
+    end
+
     describe '#perform' do
       around(:each) do |example|
         Reactor.in_test_mode { example.run }

data/spec/spec_helper.rb

@@ -18,6 +18,18 @@ require 'reactor/testing/matchers'
 
 require 'rspec/its'
 
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+  include Reactor::Publishable
+  include Reactor::Subscribable
+end
+
+class Pet < ApplicationRecord
+end
+
+class ArbitraryModel < ApplicationRecord
+end
+
 REDIS_URL = ENV["REDISTOGO_URL"] || ENV["REDIS_URL"] || "redis://localhost:6379/4"
 
 ActionMailer::Base.delivery_method = :test

data/spec/support/active_record.rb

@@ -24,13 +24,6 @@ ActiveRecord::Migration.create_table :publishers do |t|
   t.timestamps null: false
 end
 
-ActiveRecord::Migration.create_table :subscribers do |t|
-  t.string :event_name
-  t.string :type
-
-  t.timestamps null: false
-end
-
 ActiveRecord::Migration.create_table :pets do |t|
   t.integer :awesomeness
   t.string :type
@@ -45,8 +38,3 @@ ActiveRecord::Migration.create_table :arbitrary_models do |t|
   t.timestamps null: false
 end
 
-class Pet < ActiveRecord::Base
-end
-
-class ArbitraryModel < ActiveRecord::Base
-end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reactor
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - winfred
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-08 00:00:00.000000000 Z
+date: 2018-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -218,10 +218,8 @@ files:
 - lib/reactor/errors.rb
 - lib/reactor/event.rb
 - lib/reactor/models.rb
-- lib/reactor/models/concerns/optionally_subclassable.rb
 - lib/reactor/models/concerns/publishable.rb
 - lib/reactor/models/concerns/subscribable.rb
-- lib/reactor/models/subscriber.rb
 - lib/reactor/static_subscribers.rb
 - lib/reactor/subscription.rb
 - lib/reactor/testing.rb
@@ -229,7 +227,6 @@ files:
 - lib/reactor/version.rb
 - lib/reactor/workers.rb
 - lib/reactor/workers/concerns/configuration.rb
-- lib/reactor/workers/database_subscriber_worker.rb
 - lib/reactor/workers/event_worker.rb
 - lib/reactor/workers/mailer_worker.rb
 - reactor.gemspec
@@ -237,13 +234,11 @@ files:
 - spec/event_spec.rb
 - spec/models/concerns/publishable_spec.rb
 - spec/models/concerns/subscribable_spec.rb
-- spec/models/subscriber_spec.rb
 - spec/reactor_spec.rb
 - spec/spec_helper.rb
 - spec/subscription_spec.rb
 - spec/support/active_record.rb
 - spec/support/shared_examples.rb
-- spec/workers/database_subscriber_worker_spec.rb
 - spec/workers/event_worker_spec.rb
 - spec/workers/mailer_worker_spec.rb
 homepage: ''
@@ -275,12 +270,10 @@ test_files:
 - spec/event_spec.rb
 - spec/models/concerns/publishable_spec.rb
 - spec/models/concerns/subscribable_spec.rb
-- spec/models/subscriber_spec.rb
 - spec/reactor_spec.rb
 - spec/spec_helper.rb
 - spec/subscription_spec.rb
 - spec/support/active_record.rb
 - spec/support/shared_examples.rb
-- spec/workers/database_subscriber_worker_spec.rb
 - spec/workers/event_worker_spec.rb
 - spec/workers/mailer_worker_spec.rb

data/lib/reactor/models/concerns/optionally_subclassable.rb

@@ -1,13 +0,0 @@
-module Reactor::OptionallySubclassable
-  extend ActiveSupport::Concern
-
-  module ClassMethods
-    def find_sti_class(type_name)
-      begin
-        ActiveSupport::Dependencies.constantize(type_name)
-      rescue NameError
-        self
-      end
-    end
-  end
-end

data/lib/reactor/models/subscriber.rb

@@ -1,28 +0,0 @@
-module Reactor
-  class Subscriber < ActiveRecord::Base
-    attr_accessor :event
-
-    def event_name=(event)
-      write_attribute :event_name, event.to_s
-    end
-
-    def fire(data)
-      self.event = Reactor::Event.new(data)
-      instance_exec &self.class.on_fire
-      self
-    end
-
-    class << self
-      def on_fire(&block)
-        if block
-          @fire_block = block
-        end
-        @fire_block
-      end
-
-      def fire(subscriber_id, data)
-        Reactor::Subscriber.find(subscriber_id).fire data.with_indifferent_access
-      end
-    end
-  end
-end

data/lib/reactor/workers/database_subscriber_worker.rb

@@ -1,22 +0,0 @@
-module Reactor
-  module Workers
-    class DatabaseSubscriberWorker
-
-      include Sidekiq::Worker
-
-      def perform(model_id, data)
-        return :__perform_aborted__ unless should_perform?
-        Reactor::Subscriber.fire(model_id, data)
-      end
-
-      def should_perform?
-        if Reactor.test_mode?
-          Reactor.test_mode_subscriber_enabled? Reactor::Subscriber
-        else
-          true
-        end
-      end
-
-    end
-  end
-end

data/spec/models/subscriber_spec.rb

@@ -1,41 +0,0 @@
-require 'spec_helper'
-
-class MySubscriber < Reactor::Subscriber
-  attr_accessor :was_called
-
-  on_fire do
-    self.was_called = true
-  end
-end
-
-describe Reactor::Subscriber do
-
-  describe 'fire' do
-    subject { MySubscriber.create(event_name: :you_name_it).fire some: 'random', event: 'data' }
-
-    its(:event) { is_expected.to be_a Reactor::Event }
-    its('event.some') { is_expected.to eq('random') }
-
-    it 'executes block given' do
-      expect(subject.was_called).to be_truthy
-    end
-  end
-
-
-  describe 'matcher' do
-    before do
-      MySubscriber.create!(event_name: '*')
-      Reactor.enable_test_mode_subscriber Reactor::Subscriber
-    end
-
-    after do
-      Reactor.disable_test_mode_subscriber Reactor::Subscriber
-      MySubscriber.destroy_all
-    end
-
-    it 'can be set to star to bind to all events' do
-      expect_any_instance_of(MySubscriber).to receive(:fire).with(hash_including('random' => 'data', 'event' => 'this_event'))
-      Reactor::Event.publish(:this_event, {random: 'data'})
-    end
-  end
-end

data/spec/workers/database_subscriber_worker_spec.rb

@@ -1,67 +0,0 @@
-require 'spec_helper'
-
-class DbSubscriber < Reactor::Subscriber
-  attr_accessor :was_called
-
-  on_fire do
-    self.was_called = true
-  end
-end
-
-describe Reactor::Workers::DatabaseSubscriberWorker do
-  let(:event_name) { :fire_db_subscriber }
-  let(:data) { Hash[unused: :data] }
-  let!(:db_subscriber) { DbSubscriber.create!(event_name: event_name) }
-
-  let(:instance) { described_class.new }
-
-  describe '#perform' do
-
-    subject { instance.perform(db_subscriber.id, data) }
-
-    context 'when should_perform? is false' do
-      before { allow_any_instance_of(DbSubscriber).to receive(:should_perform?).and_return(false) }
-
-      it { is_expected.to eq(:__perform_aborted__) }
-    end
-
-    context 'when should_perform? is true' do
-      before do
-        allow(instance).to receive(:should_perform?).and_return(true)
-      end
-
-      it 'fires subscriber' do
-        expect(Reactor::Subscriber).to receive(:fire).with(db_subscriber.id, data)
-        subject
-      end
-    end
-
-  end
-
-  describe '#should_perform?' do
-    subject { instance.should_perform? }
-
-    context 'in test mode' do
-      context 'when subscriber is not enabled' do
-        it { is_expected.to eq(false) }
-      end
-
-      context 'when subscriber is enabled' do
-        it 'should equal true' do
-          Reactor.with_subscriber_enabled Reactor::Subscriber do
-            expect(subject).to eq(true)
-          end
-        end
-      end
-    end
-
-    context 'outside test mode' do
-      before do
-        allow(Reactor).to receive(:test_mode?).and_return(false)
-      end
-
-      it { is_expected.to eq(true) }
-    end
-  end
-
-end