react_on_rails 9.0.2 → 9.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 99a8b2f4c0cbe8f473d8a2a2f67e1ff446229cf0
-  data.tar.gz: d11ab4fbb2739893e23f6a749b676577451b414e
+  metadata.gz: f41863c0e8b5cfbc03a81dc6d8b4adb4267b6475
+  data.tar.gz: c884cd7c06d50f9abc8d5c084df1912f44dd82ea
 SHA512:
-  metadata.gz: 92169df1b919e864d136428a46770e509344f87bd752a139ef5a06b73e648486e6cae062afb351be2c5ccbea00f4e641a9f3409d42b05a84cee5f7406c224975
-  data.tar.gz: fa4f253bb24f1bf487af56f8b3c1176b6af09aa77b544966577e4e603056c4090fe40ca63928293b3bc48dcab6ac8e4cadb1e751c3500e876f92cbf0400af5c1
+  metadata.gz: 17327f03ceea1acf189be53955b0f84f255aafe2809398f1027242877ceb1f7fc79b9c40ade163aaa49cb695beee4e80054774b2fed9a3a8769ee30e0f83a22d
+  data.tar.gz: 92a3d81eb2440990899f77eaa2d41c20b30adf2faa49b67eb6c8d8eb199848a6d26e85cc2c71c0d21c4c9da451fb5b632a03c60491dab3468924fde37fb37870

data/CHANGELOG.md

@@ -8,12 +8,20 @@ Changes since last non-beta release.
 
 *Please add entries here for your pull requests.*
 
-### [9.0.1]
+### [9.0.3] - 2017-09-20
+#### Improved
+- Improved comments in generated Procfile.dev-server. [PR 940](https://github.com/shakacode/react_on_rails/pull/940) by [justin808](https://github.com/justin808 ) 
+
+### [9.0.2] - 2017-09-10
+#### Fixed
+- Improved post install doc comments for generator. [PR 933](https://github.com/shakacode/react_on_rails/pull/933) by [justin808](https://github.com/justin808 ) 
+
+### [9.0.1] - 2017-09-10
 
 #### Fixed
 - Fixes Rails 3.2 compatability issues. [PR 926](https://github.com/shakacode/react_on_rails/pull/926) by [morozovm](https://github.com/morozovm ) 
 
-### [9.0.0]
+### [9.0.0] - 2017-09-06
 Updated React on Rails to depend on [rails/webpacker](https://github.com/rails/webpacker). [PR 908](https://github.com/shakacode/react_on_rails/pull/908) by [justin808](https://github.com/justin808).
 
 
@@ -101,17 +109,17 @@ gem "webpacker"
     - Set the `hmr` key in your `webpacker.yml` to `true`.
     
     
-### [8.0.7]
+### [8.0.7] - 2017-08-16
 #### Fixed
 - Fixes generator bug by keeping blank line at top in case existing .gitignore does not end in a newline. [#916](https://github.com/shakacode/react_on_rails/pull/916) by [justin808](https://github.com/justin808).
 
-### [8.0.6]
+### [8.0.6] - 2017-07-19
 #### Fixed
 - Fixes server rendering when using a CDN. Server rendering would try to fetch a file with the "asset_host". This change updates the webpacker_lite dependency to 2.1.0 which has a new helper `pack_path`. [#901](https://github.com/shakacode/react_on_rails/pull/901) by [justin808](https://github.com/justin808). Be sure to update webpacker_lite to 2.1.0.
 - The package.json file created by the generator now creates minified javascript production builds by default. This was done by adding the -p flag to webpack on the build:production script. [#895](https://github.com/shakacode/react_on_rails/pull/895) by [serodriguez68 ](https://github.com/serodriguez68)
 - Fixes GitUtils.uncommitted_changes? throwing an error when called in an environment without Git, and allows install generator to be run successfully with `--ignore-warnings` [#878](https://github.com/shakacode/react_on_rails/pull/878) by [jasonblalock](https://github.com/jasonblalock).
 
-## [8.0.5]
+## [8.0.5] - 2017-07-04
 ### fixed
  - Corrects `devBuild` value for webpack production build from webpackConfigLoader. [#877](https://github.com/shakacode/react_on_rails/pull/877) by [chenqingspring](https://github.com/chenqingspring).
  - Remove contentBase deprecation warning message. [#878](https://github.com/shakacode/react_on_rails/pull/878) by [ened ](https://github.com/ened).
@@ -120,11 +128,11 @@ gem "webpacker"
 
 *Note: 8.0.4 skipped.*
 
-## [8.0.3]
+## [8.0.3] - 2017-06-19
 ### Fixed
 - Ruby 2.1 issue due to `<<~` as reported in [issue #870](https://github.com/shakacode/react_on_rails/issues/870). [#867](https://github.com/shakacode/react_on_rails/pull/867) by [justin808](https://github.com/justin808)
 
-## [8.0.2]
+## [8.0.2] - 2017-06-04
 ### Fixed
 - Any failure in webpack to build test files quits tests.
 - Fixed a Ruby 2.4 potential crash which could cause a crash due to pathname change in Ruby 2.4.
@@ -135,11 +143,11 @@ gem "webpacker"
   - Fixed test failures against Ruby 2.4
 - [#862](https://github.com/shakacode/react_on_rails/pull/862) by [justin808](https://github.com/justin808)
 
-## [8.0.1]
+## [8.0.1] - 2017-05-30
 ### Fixed
 - Generator no longer modifies `assets.rb`. [#859](https://github.com/shakacode/react_on_rails/pull/859) by [justin808](https://github.com/justin808)
 
-## [8.0.0]
+## [8.0.0] - 2017-05-29
 - Generators and full support for [webpacker_lite](https://github.com/shakacode/webpacker_lite)
 - No breaking changes to move to 8.0.0 other than the default for this setting changed to nil. If you depended on the default of this setting and are using the asset pipeline (and not webpacker_lite), then add this to your `config/initializers/react_on_rails.rb`:
   ```
@@ -723,7 +731,9 @@ Best done with Object destructing:
 ##### Fixed
 - Fix several generator related issues.
 
-[Unreleased]: https://github.com/shakacode/react_on_rails/compare/9.0.1...master
+[Unreleased]: https://github.com/shakacode/react_on_rails/compare/9.0.3...master
+[9.0.3]: https://github.com/shakacode/react_on_rails/compare/9.0.2...9.0.3
+[9.0.2]: https://github.com/shakacode/react_on_rails/compare/9.0.1...9.0.2
 [9.0.1]: https://github.com/shakacode/react_on_rails/compare/9.0.0...9.0.1
 [9.0.0]: https://github.com/shakacode/react_on_rails/compare/8.0.7...9.0.0
 [8.0.7]: https://github.com/shakacode/react_on_rails/compare/8.0.6...8.0.7

data/CONTRIBUTING.md

@@ -131,7 +131,7 @@ After checking out the repo, making sure you have rvm and nvm setup (setup ruby
 Additionally, our RSpec tests use the poltergeist web driver. You will need to install the phantomjs node module:
 
 ```sh
-yarn global add phantomjs
+yarn global add phantomjs-prebuilt
 ```
 
 Note this *must* be installed globally for the dummy test project rspec runner to see it properly.

data/README.md

@@ -5,7 +5,8 @@
 [rails/webpacker](https://github.com/rails/webpacker) just shipped 3.0. This now enables me to ship version 9.0. See [PR #908](https://github.com/shakacode/react_on_rails/pull/908) for more details.
 # React on Rails v9 is based on Webpacker 3.0!
 
-* See the article [Introducing React on Rails v9 with Webpacker Support](https://blog.shakacode.com/introducing-react-on-rails-v9-with-webpacker-support-f2584c6c8fa4),  for an overview of the integration of React on Rails with Webpacker. 
+* See the article [Introducing React on Rails v9 with Webpacker Support](https://blog.shakacode.com/introducing-react-on-rails-v9-with-webpacker-support-f2584c6c8fa4) for an overview of the integration of React on Rails with Webpacker.
+* [Video of running the v9 installer with Webpacker v3](https://youtu.be/M0WUM_XPaII).
 * See the updated [Tutorial](https://github.com/shakacode/react_on_rails/blob/master/docs/tutorial.md).
 * See the [CHANGELOG.md](https://github.com/shakacode/react_on_rails/blob/master/CHANGELOG.md) for migration instructions.
 
@@ -35,7 +36,7 @@ First be sure to run `rails -v` and check that you are using Rails 5.1.3 or abov
 
 ### Turn on server rendering
 
-*Does not work with hot reloading, yet, per [Webpacker issue #732](https://github.com/rails/webpacker/issues/732)*
+*The rails/wepbacker default setup does not work with hot or live reloading, yet, per [Webpacker issue #842](https://github.com/rails/webpacker/issues/842). If you want the combination of both server rendering and hot reloading during development, you will need to a custom webpack setup as shown [here](https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/webpack.client.rails.hot.config.js)*
 
 1. Edit `app/views/hello_world/index.html.erb` and set `prerender` to `true`.
 2. Refresh the page.

data/docs/additional-reading/hot-reloading-rails-development.md

@@ -45,7 +45,7 @@ We'll use a Webpack Dev server on port 3500 to provide the assets to Rails, rath
    2. Start the rails server, setting an ENV value of REACT_ON_RAILS_ENV to HOT if we're hot loading or else setting this to blank.
 1. Configure the file Rails asset pipeline files:
    1. [app/assets/javascripts/application_static.js](https://github.com/shakacode/react_on_rails/tree/master/spec/dummy/app/assets/javascripts/application_static.js) 
-   1. [app/assets/stylesheets/application_static.css.scss](https://github.com/shakacode/react_on_rails/tree/master/spec/dummy/app/assets/stylesheets/application_static.css.scss)
+   1. [app/assets/stylesheets/application_non_webpack.scss](https://github.com/shakacode/react_on_rails/blob/master/spec/dummy/app/assets/stylesheets/application_non_webpack.scss)
 1. Copy the [client/server-rails-hot.js](https://github.com/shakacode/react_on_rails/tree/master/spec/dummy/client/server-rails-hot.js) to the your client directory.
 1. Copy the scripts in the top level and client level `package.json` files:
    1. Top Level: [package.json](https://github.com/shakacode/react_on_rails/tree/master/spec/dummy/package.json)

data/lib/generators/react_on_rails/dev_tests_generator.rb

@@ -5,18 +5,6 @@ require_relative "generator_helper"
 
 module ReactOnRails
   module Generators
-    # TODO9: Do we need something like this still? How to put in with
-    FALLBACK_OPTION_FOR_NODE_MODULES = <<-TEXT
-    // This fixes an issue with resolving 'react' when using a local symlinked version
-    // of the node_package folder
-    modules: [
-      path.join(__dirname, 'node_modules'),
-      'node_modules',
-    ],
-  },
-  plugins: [
-    TEXT
-
     class DevTestsGenerator < Rails::Generators::Base
       include GeneratorHelper
       Rails::Generators.hide_namespace(namespace)

data/lib/generators/react_on_rails/templates/base/base/Procfile.dev-server

@@ -3,5 +3,10 @@ web: rails s -p 3000
 
 # Next line runs the webpack-dev-server
 # You can edit config/webpacker.yml to set HMR to true to see hot reloading.
-# Note,
+# Note, hot and live reloading don't work with the default generator setup on top of
+# the rails/webpacker Webpack config with server rendering.
+# If you have server rendering enabled, modify the call to bin/webpack-dev-server line
+# so you add `--inline=false` and then CSS is not inlined.
+# Otherwise, you will have an error. If you want HMR and Server Rendering, see
+# the example in the https://github.com/shakacode/react-webpack-rails-tutorial
 client: sh -c 'rm -rf public/packs/* || true && bundle exec rake react_on_rails:locale && bin/webpack-dev-server'

data/lib/react_on_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ReactOnRails
-  VERSION = "9.0.2"
+  VERSION = "9.0.3"
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "9.0.2",
+  "version": "9.0.3",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 9.0.2
+  version: 9.0.3
 platform: ruby
 authors:
 - Justin Gordon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-11 00:00:00.000000000 Z
+date: 2017-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow