react_on_rails 6.4.1 → 6.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 94e59e11d5830cb4add6aa9d4c4dfff86075eda1
-  data.tar.gz: 0aed8a351e8ad6701c91e6b802a9b63d3aa04e3f
+  metadata.gz: cc9ce8dfafb075ba679a34c960037df7c61746ff
+  data.tar.gz: 35d775a65518d91e1b46733758cdf9883c52b6ac
 SHA512:
-  metadata.gz: a50c9626b05fbbb4c10b10941dbff6e3168979fb4d9ef6843552557f041260e95d11ae9e3fd0d7a8983ad37bde8c779b408fc87e506a633d28ab24a7a25fd0e1
-  data.tar.gz: b8226192b451b6701d4f788fcfbf01a6eb9516302112d9156ef046f9a7563f7ae291c84140e921bb4b10fd8f9d0a0e5295caa836164b38b5e85aee17df6ffc3e
+  metadata.gz: 8e6c98e563102e792da954e116ef75e7774c13698c970be417869d667364e0bfa604b4e815eb9e22f9e87540e897da7988bd3823ec98836c98846e763195081e
+  data.tar.gz: d675c0ad865f9edd283ba64344e2912cceac4ec50720c6f00c676a8e1d458ad5363cefa86f1f7adcac9847613215fae47701bb7e090b786cbf4bfa31710b7c97

data/CHANGELOG.md

@@ -6,10 +6,17 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com]
 ## [Unreleased]
 *Please add entries here for your pull requests.*
 
+## [6.4.2] - 2017-1-17
+### Fixed
+- Added OS detection for install generator, system call for Windows and unit-tests for it. [#666](https://github.com/shakacode/react_on_rails/pull/666) by [GeorgeGorbanev](https://github.com/GeorgeGorbanev).
+
+## [6.4.1] - 2017-1-17
+No changes.
+
 ## [6.4.0] - 2017-1-12
 
 ### Possible Breaking Change
-- Since foreman is no longer a dependency of the React on Rails gem, please run `gem install foreman`. If you are using rvm, you may wish to run `rvm @global do gem install foreman` to install foreman for all your gemsets. 
+- Since foreman is no longer a dependency of the React on Rails gem, please run `gem install foreman`. If you are using rvm, you may wish to run `rvm @global do gem install foreman` to install foreman for all your gemsets.
 
 ### Fixed
 - Removed foreman as a dependency. [#678](https://github.com/shakacode/react_on_rails/pull/678) by [x2es](https://github.com/x2es).
@@ -428,7 +435,9 @@ Best done with Object destructing:
 ##### Fixed
 - Fix several generator related issues.
 
-[Unreleased]: https://github.com/shakacode/react_on_rails/compare/6.4.0...master
+[Unreleased]: https://github.com/shakacode/react_on_rails/compare/6.4.2...master
+[6.4.2]: https://github.com/shakacode/react_on_rails/compare/6.4.1...6.4.2
+[6.4.1]: https://github.com/shakacode/react_on_rails/compare/6.4.0...6.4.1
 [6.4.0]: https://github.com/shakacode/react_on_rails/compare/6.3.5...6.4.0
 [6.3.5]: https://github.com/shakacode/react_on_rails/compare/6.3.4...6.3.5
 [6.3.4]: https://github.com/shakacode/react_on_rails/compare/6.3.3...6.3.4

data/README.md

@@ -217,7 +217,7 @@ On production deployments that use asset precompilation, such as Heroku deployme
 If you have used the provided generator, these bundles will automatically be added to your `.gitignore` to prevent extraneous noise from re-generated code in your pull requests. You will want to do this manually if you do not use the provided generator.
 
 ### Rails Context
-When you use a "generator function" to create react components (or renderedHtml on the server) or you used shared redux stores, you get 2 params passed to your function:
+When you use a "generator function" to create react components or you used shared redux stores, you get 2 params passed to your function:
 
 1. Props that you pass in the view helper of either `react_component` or `redux_store`
 2. Rails contextual information, such as the current pathname. You can customize this in your config file.
@@ -318,8 +318,6 @@ If you do want different code to run, you'd setup a separate webpack compilation
 #### Generator Functions
 Why would you create a function that returns a React component? For example, you may want the ability to use the passed-in props to initialize a redux store or setup react-router. Or you may want to return different components depending on what's in the props. ReactOnRails will automatically detect a registered generator function.
 
-Another reason to user a generator function is that sometimes in server rendering, specifically with React Router, you need to return the result of calling ReactDOMServer.renderToString(element). You can do this by returning an object with the following shape: { renderedHtml, redirectLocation, error }.
-
 #### Renderer Functions
 A renderer function is a generator function that accepts three arguments: `(props, railsContext, domNodeId) => { ... }`. Instead of returning a React component, a renderer is responsible for calling `ReactDOM.render` to manually render a React component into the dom. Why would you want to call `ReactDOM.render` yourself? One possible use case is [code splitting](docs/additional-reading/code-splitting.md).
 
@@ -342,7 +340,7 @@ react_component(component_name,
                 html_options: {})
 ```
 
-+ **component_name:** Can be a React component, created using a ES6 class, or `React.createClass`, a generator function that returns a React component (or only on the server side, an object with shape { redirectLocation, error, renderedHtml }), or a renderer function that manually renders a React component to the dom (client side only).
++ **component_name:** Can be a React component, created using a ES6 class, or `React.createClass`, a generator function that returns a React component, or a renderer function that manually renders a React component to the dom (client side only).
 + **options:**
   + **props:** Ruby Hash which contains the properties to pass to the react object, or a JSON string. If you pass a string, we'll escape it for you.
   + **prerender:** enable server-side rendering of component. Set to false when debugging!

data/docs/additional-reading/react-router.md

@@ -46,68 +46,3 @@ For a fleshed out integration of react_on_rails with react-router, check out [Re
 * [react-webpack-rails-tutorial/client/app/bundles/comments/startup/ClientRouterApp.jsx](https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/bundles/comments/startup/ClientRouterApp.jsx)
 
 * [react-webpack-rails-tutorial/client/app/bundles/comments/startup/ServerRouterApp.jsx](https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/bundles/comments/startup/ServerRouterApp.jsx)
-
-
-# Server Rendering Using React Router V4
-
-Your generator function may not return an object with the property `renderedHtml`. Thus, you call 
-renderToString() and return an object with this property.
-
-This example **only applies to server rendering** and should be only used in the server side bundle.
-
-From the [original example in the ReactRouter docs](https://react-router.now.sh/ServerRouter)
- 
-```javascript
-   import React from 'react'
-   import { renderToString } from 'react-dom/server'
-   import { ServerRouter, createServerRenderContext } from 'react-router'
-   
-   const ReactRouterComponent = (props, railsContext) => {
-   
-     // first create a context for <ServerRouter>, it's where we keep the
-     // results of rendering for the second pass if necessary
-     const context = createServerRenderContext()
-     const { location } = railsContext;
-
-     // render the first time
-     let markup = renderToString(
-       <ServerRouter
-         location={location}
-         context={context}
-       >
-         <App/>
-       </ServerRouter>
-     )
-   
-     // get the result
-     const result = context.getResult()
-   
-     // the result will tell you if it redirected, if so, we ignore
-     // the markup and send a proper redirect.
-     if (result.redirect) {
-       return { 
-         redirectLocation: result.redirect.pathname 
-       };
-     } else {
-   
-       // the result will tell you if there were any misses, if so
-       // we can send a 404 and then do a second render pass with
-       // the context to clue the <Miss> components into rendering
-       // this time (on the client they know from componentDidMount)
-       if (result.missed) {
-         // React on Rails does not support the 404 status code for the browser.  
-         // res.writeHead(404)
-         
-         markup = renderToString(
-           <ServerRouter
-             location={location}
-             context={context}
-           >
-             <App/>
-           </ServerRouter>
-         )
-       }
-       return { renderedHtml: markup };
-     }
-  }
-```

data/docs/api/javascript-api.md

@@ -4,9 +4,7 @@ The best source of docs is the main [ReactOnRails.js](../../node_package/src/Rea
 ```js
   /**
    * Main entry point to using the react-on-rails npm package. This is how Rails will be able to
-   * find you components for rendering. Components get called with props, or you may use a
-   * "generator function" to return a React component or an object with the following shape:
-   * { renderedHtml, redirectLocation, error }. 
+   * find you components for rendering.
    * @param components (key is component name, value is component)
    */
   register(components)

data/lib/generators/react_on_rails/install_generator.rb

@@ -64,7 +64,7 @@ module ReactOnRails
       end
 
       def missing_npm?
-        return false unless `which npm`.blank?
+        return false unless ReactOnRails::Utils.running_on_windows? ? `where npm`.blank? : `which npm`.blank?
         error = "npm is required. Please install it before continuing. "
         error << "https://www.npmjs.com/"
         GeneratorMessages.add_error(error)
@@ -72,7 +72,7 @@ module ReactOnRails
       end
 
       def missing_node?
-        return false unless `which node`.blank?
+        return false unless ReactOnRails::Utils.running_on_windows? ? `where node`.blank? : `which node`.blank?
         error = "** nodejs is required. Please install it before continuing. "
         error << "https://nodejs.org/en/"
         GeneratorMessages.add_error(error)

data/lib/react_on_rails/utils.rb

@@ -20,6 +20,10 @@ module ReactOnRails
                 ReactOnRails.configuration.server_bundle_js_file)
     end
 
+    def self.running_on_windows?
+      (/cygwin|mswin|mingw|bccwin|wince|emx/ =~ RUBY_PLATFORM) != nil
+    end
+
     module Required
       def required(arg_name)
         raise ArgumentError, "#{arg_name} is required"

data/lib/react_on_rails/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ReactOnRails
-  VERSION = "6.4.1".freeze
+  VERSION = "6.4.2".freeze
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "6.4.1",
+  "version": "6.4.2",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 6.4.1
+  version: 6.4.2
 platform: ruby
 authors:
 - Justin Gordon