react_on_rails 13.3.2 → 13.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37f8e087fd09c6ea86239307c6c47121d294d73c84065b07ff0756e79ed6b679
-  data.tar.gz: 93fc7de963700c87af99cdb13ba4511c6b305721d1f2c784d4cd840f6084775a
+  metadata.gz: 68dc51cc2eb837fd5ff976cdba5aeaefdec1ca13540e574e8f4e2ec054ec8769
+  data.tar.gz: 80d926e7a845cb55f27763de6050b3b4d3f829323b46362ca6f3e92a1daac3aa
 SHA512:
-  metadata.gz: 2c7fa29cd46918b4605e8d9f5481eec8506536bd096cfbeb90bc284e0b246322a16956d0e218c9d7e905a5638674863df222b781826f47b1eafeb79e11ec03c5
-  data.tar.gz: 481709881b0f9d24fb5047b213325c189185e9869e62f664afb8dbcea6b3a24b510f12ba17e1ffc0b7db4c7e478318c92fc93e8d7188b255b26cc245ac430011
+  metadata.gz: ea748cde016bbdae69f2ffa4047324fdd9d2426413e1baf4e5adf9043e6540f4fbcf0d4ec2237ec4854d79eab257b9022afc91576bb9517cf5e2ae2490f06777
+  data.tar.gz: a5c39c15e12231ad30bb15ef56517092cc50d368cd477d4653a4fad57b4f91c4b33143058718f09129623afd46ef81639b3f8add303b1125e4926641cc0b5c54

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,19 @@
+### Summary
+
+_Remove this paragraph and provide a general description of the code changes in your pull
+request... were there any bugs you had fixed? If so, mention them. If
+these bugs have open GitHub issues, be sure to tag them here as well,
+to keep the conversation linked together._
+
+### Pull Request checklist
+_Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by `~`._
+
+- [ ] Add/update test to cover these changes
+- [ ] Update documentation
+- [ ] Update CHANGELOG file  
+  _Add the CHANGELOG entry at the top of the file._
+
+### Other Information
+
+_Remove this paragraph and mention any other important and relevant information such as benchmarks._
+

data/CHANGELOG.md

@@ -65,7 +65,7 @@ Changes since last non-beta release.
 
 - Fixed the `You are importing hydrateRoot from "react-dom" [...] You should instead import it from "react-dom/client"` warning under React 18 ([#1441](https://github.com/shakacode/react_on_rails/issues/1441)). [PR 1460](https://github.com/shakacode/react_on_rails/pull/1460) by [alexeyr](https://github.com/alexeyr).
 
-  In exchange, you may see a warning like this when building a Webpack bundle under React 16:
+  In exchange, you may see a warning like this when building using any version of React below 18:
   ```
   WARNING in ./node_modules/react-on-rails/node_package/lib/reactHydrateOrRender.js19:25-52
   Module not found: Error: Can't resolve 'react-dom/client' in '/home/runner/work/react_on_rails/react_on_rails/spec/dummy/node_modules/react-on-rails/node_package/lib'

data/Gemfile.development_dependencies

@@ -29,8 +29,8 @@ group :development, :test do
   gem "pry-rails"
   gem "pry-rescue"
   gem "rubocop", "1.14.0", require: false
-  gem "rubocop-performance", "1.16.0", require: false
-  gem "rubocop-rspec", "2.4.0", require: false
+  gem "rubocop-performance", require: false
+  gem "rubocop-rspec", require: false
   gem "scss_lint", require: false
   gem "spring", "~> 4.0"
 end

data/docs/guides/rails-webpacker-react-integration-options.md

@@ -56,6 +56,36 @@ document.addEventListener('DOMContentLoaded', () => {
 
 ----
 
+## Suppress warning related to Can't resolve 'react-dom/client' in React < 18
+
+You may see a warning like this when building a Webpack bundle using any version of React below 18:
+
+```
+Module not found: Error: Can't resolve 'react-dom/client' in ....
+```
+
+It can be safely [suppressed](https://webpack.js.org/configuration/other-options/#ignorewarnings) in your Webpack configuration. The following is an example of this suppression in `config/webpack/commonWebpackConfig.js`:
+
+```js
+const { webpackConfig: baseClientWebpackConfig, merge } = require('shakapacker');
+
+const commonOptions = {
+  resolve: {
+    extensions: ['.css', '.ts', '.tsx'],
+  },
+};
+
+const ignoreWarningsConfig = {
+  ignoreWarnings: [/Module not found: Error: Can't resolve 'react-dom\/client'/],
+};
+
+const commonWebpackConfig = () => merge({}, baseClientWebpackConfig, commonOptions, ignoreWarningsConfig);
+
+module.exports = commonWebpackConfig;
+```
+
+----
+
 ## HMR and React Hot Reloading
 
 Before turning HMR on, consider upgrading to the latest stable gems and packages:

data/lib/generators/react_on_rails/bin/dev

@@ -12,7 +12,7 @@ def run(process)
 rescue Errno::ENOENT
   warn <<~MSG
     ERROR:
-    Please ensure `Procfile.dev` exist in your project!
+    Please ensure `Procfile.dev` exists in your project!
   MSG
   exit!
 end

data/lib/generators/react_on_rails/bin/dev-static

@@ -12,7 +12,7 @@ def run(process)
 rescue Errno::ENOENT
   warn <<~MSG
     ERROR:
-    Please ensure `Procfile.dev-static` exist in your project!
+    Please ensure `Procfile.dev-static` exists in your project!
   MSG
   exit!
 end

data/lib/react_on_rails/helper.rb

@@ -324,8 +324,8 @@ module ReactOnRails
 
       ReactOnRails::WebpackerUtils.raise_nested_entries_disabled unless ReactOnRails::WebpackerUtils.nested_entries?
 
-      ApplicationController.helpers.append_javascript_pack_tag("generated/#{component_name}")
-      ApplicationController.helpers.append_stylesheet_pack_tag("generated/#{component_name}")
+      append_javascript_pack_tag "generated/#{component_name}"
+      append_stylesheet_pack_tag "generated/#{component_name}"
     end
 
     # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity

data/lib/react_on_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ReactOnRails
-  VERSION = "13.3.2"
+  VERSION = "13.3.3"
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "13.3.2",
+  "version": "13.3.3",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 13.3.2
+  version: 13.3.3
 platform: ruby
 authors:
 - Justin Gordon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-02-24 00:00:00.000000000 Z
+date: 2023-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -124,6 +124,7 @@ files:
 - ".github/FUNDING.yml"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/PULL_REQUEST_TEMPLATE.md"
 - ".github/workflows/lint-js-and-ruby.yml"
 - ".github/workflows/main.yml"
 - ".github/workflows/package-js-tests.yml"