react_on_rails 11.0.7 → 11.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 18af285d5940a9611b5c13665d8e4d8e3500f2b8
-  data.tar.gz: 05ae472d3a6d8c99c1a78acd6acde45a9ca5363f
+SHA256:
+  metadata.gz: 5ed7b1fbb2464837b56060e72a7496e347e4da42218d09256e11b2e30c24e43b
+  data.tar.gz: fb7122bd0af170552379b15faeb3bdacd989f8121e7995dd975d9554bd948d93
 SHA512:
-  metadata.gz: 1c96204dd51f27506efe54fd42212bc7a9198ce670f1163035399ba74ca4d4ad53eff275325147d157cdf3e65341186226f4d95d609b5c5fa2bcf0eca6486c6f
-  data.tar.gz: 47872bcdb906c82d937daa97d9c6ad2afa5110293ca8f95db4763086f311e29ce0b32c3d091da72f57aa1a27eebb4287099432b62e4a8b85627bef02f5e4b8c0
+  metadata.gz: 2f2cca7b17bf7c7f53d338a51fa01e28bb131712fdba019e058e481993d178995710ef42e3cc063f8617184695abaf1dc444f6161e5ee8a92ed04f4e042a27ed
+  data.tar.gz: ebf4448a0ad4316ecc89d893f6a52eecbd23ec62b55ea7e4a615ff15c7c20fabe1964e84224fda00328348e832555ce1dd78ae3782ffd9ee7d0514fdca9adb17

data/.travis.yml

@@ -37,9 +37,9 @@ before_install:
 
 install:
   - travis_retry gem install bundler
-  - travis_retry nvm install 9.11.1
+  - travis_retry nvm install 8.11.3
   - node -v
-  - travis_retry npm i -g yarn@0.27.5
+  - travis_retry npm i -g yarn
   - travis_retry yarn global add babel-cli
   - travis_retry bundle install
   - travis_retry yarn

data/CHANGELOG.md

@@ -9,13 +9,28 @@ See [Upgrading React on Rails](./docs/basics/upgrading-react-on-rails.md) for mo
 Changes since last non-beta release.
 
 *Please add entries here for your pull requests that are not yet released.*
+### [11.0.9] - 2018-05-22
+#### Fixed
+- HashWithIndifferent access for props threw if used for props. [PR 1100](https://github.com/shakacode/react_on_rails/pull/1100) by [justin808](https://github.com/justin808).
+- Test helper for detecting stale bundles did not properly handle the case of a server-bundle.js without a hash.[PR 1102](https://github.com/shakacode/react_on_rails/pull/1102) by [justin808](https://github.com/justin808).
+
+### [11.0.8] - 2018-05-22
+#### Fixed
+- Fix test helper determination of stale assets. [PR 1093](https://github.com/shakacode/react_on_rails/pull/1093) by [justin808](https://github.com/justin808).
 
 #### Changed
+- Document how to manually rehydrate XHR-substituted components on client side. [PR 1095](https://github.com/shakacode/react_on_rails/pull/1095) by [hchevalier](https://github.com/hchevalier).
+
+### [11.0.7] - 2018-05-11
+#### Fixed
+- Fix npm publshing. [PR 1090](https://github.com/shakacode/react_on_rails/pull/1090) by [justin808](https://github.com/justin808).
 
 ### [11.0.6] - 2018-05-11
+#### Changed
 - Even more detailed errors for Honeybadger and Sentry when there's a JSON parse error on server rendering. [PR 1086](https://github.com/shakacode/react_on_rails/pull/1086) by [justin808](https://github.com/justin808).
 
 ### [11.0.5] - 2018-05-11
+#### Changed
 - More detailed errors for Honeybadger and Sentry. [PR 1081](https://github.com/shakacode/react_on_rails/pull/1081) by [justin808](https://github.com/justin808).
 
 ### [11.0.4] - 2018-05-3
@@ -761,7 +776,10 @@ Best done with Object destructing:
 ##### Fixed
 - Fix several generator related issues.
 
-[Unreleased]: https://github.com/shakacode/react_on_rails/compare/11.0.6...master
+[Unreleased]: https://github.com/shakacode/react_on_rails/compare/11.0.9...master
+[11.0.8]: https://github.com/shakacode/react_on_rails/compare/11.0.8...11.0.9
+[11.0.8]: https://github.com/shakacode/react_on_rails/compare/11.0.7...11.0.8
+[11.0.7]: https://github.com/shakacode/react_on_rails/compare/11.0.6...11.0.7
 [11.0.6]: https://github.com/shakacode/react_on_rails/compare/11.0.5...11.0.6
 [11.0.5]: https://github.com/shakacode/react_on_rails/compare/11.0.4...11.0.5
 [11.0.4]: https://github.com/shakacode/react_on_rails/compare/11.0.3...11.0.4

data/README.md

@@ -2,19 +2,29 @@
 
 *If this projects helps you, please give us a star!*
 
-## Need Help with Rails + Webpack v4 + React? Want better performance?
+## React on Rails Pro Released!
+React on Rails Pro provides Node server rendering and other performance enhancements for React on Rails. It's live at [egghead.io](https://egghead.io). See the [React on Rails Pro Docs](https://github.com/shakacode/react_on_rails/wiki).
+
 Aloha, I'm Justin Gordon the creator and maintainer of React on Rails. I offer a [React on Rails Pro Support Plan](http://www.shakacode.com/work/shakacode-pro-support.pdf), and I can help you with:
 * Optimizing your webpack setup to Webpack v4 for React on Rails.
 * Upgrading from older React on Rails to newer versions (are using using the new Webpacker setup that avoids the asset pipeline?)
 * Better performance client and server side.
 * Efficiently migrating from Angular to React.
 * Best practices based on 4 years of React on Rails experience.
-* Early access to the React on Rails Pro Gem and Node code, including:
-  * ShakaCode's Node.js rendering server for better performance for server rendering (live at [egghead.io](https://egghead.io/)).
-  * Performance caching helpers, especially for server rendering
+
+From Kyle Maune of Cooper Aerial, May 4, 2018
+
+![image](https://user-images.githubusercontent.com/1118459/40891236-9b0b406e-671d-11e8-80ee-c026dbd1d5a2.png)
+
+From Joel Hooks, Co-Founder, Chief Nerd at [egghead.io](https://egghead.io/), January 30, 2017:
+
+![2017-01-30_11-33-59](https://cloud.githubusercontent.com/assets/1118459/22443635/b3549fb4-e6e3-11e6-8ea2-6f589dc93ed3.png)
 
 Please [email me](mailto:justin@shakacode.com) for a free half-hour project consultation, on anything from React on Rails to any aspect of web development.
 
+For more testimonials, see [Live Projects](PROJECTS.md) and [Kudos](./KUDOS.md).
+
+
 ----
 
 ## React on Rails is based on Webpacker!
@@ -69,15 +79,6 @@ Please [**click to subscribe**](https://app.mailerlite.com/webforms/landing/l1d9
 * See [Projects](PROJECTS.md) using and [KUDOS](./KUDOS.md) for React on Rails. Please submit yours! Please edit either page or [email us](mailto:contact@shakacode.com) and we'll add your info. We also **love stars** as it helps us attract new users and contributors.
 * *See [NEWS.md](NEWS.md) for more notes over time.*
 
-------
-
-# Testimonials
-From Joel Hooks, Co-Founder, Chief Nerd at [egghead.io](https://egghead.io/), January 30, 2017:
-
-![2017-01-30_11-33-59](https://cloud.githubusercontent.com/assets/1118459/22443635/b3549fb4-e6e3-11e6-8ea2-6f589dc93ed3.png)
-
-For more testimonials, see [Live Projects](PROJECTS.md) and [Kudos](./KUDOS.md).
-
 -------
 
 # Articles, Videos, and Podcasts
@@ -540,7 +541,10 @@ All options except `props, id, html_options` will inherit from your `react_on_ra
   + **replay_console:** Default is true. False will disable echoing server-rendering logs to the browser. While this can make troubleshooting server rendering difficult, so long as you have the configuration of `logging_on_server` set to true, you'll still see the errors on the server.
   + **logging_on_server:** Default is true. True will log JS console messages and errors to the server.
   + **raise_on_prerender_error:** Default is false. True will throw an error on the server side rendering. Your controller will have to handle the error.
-  
+
+  Note: client hydration will not trigger for components rendered through XHR. You will have to handle it with javascript.
+  For an example, see [spec/dummy/app/views/pages/xhr_refresh.rb](https://github.com/shakacode/react_on_rails/tree/master/spec/dummy/app/views/pages/xhr_refresh.rb). 
+
 ### react_component_hash
 `react_component_hash` is used to return multiple HTML strings for server rendering, such as for
 adding meta-tags to a page. It is exactly like react_component except for the following:

data/docs/additional-reading/rails-engine-integration.md

@@ -32,3 +32,10 @@ This is necessary because React on Rails attaches itself to the rake assets:prec
 Requiring `react_on_rails` and including the helper will get rid of any issues where react on rails or react_component is undefined.
 
 As far as solving the assets issue, `lib/tasks/assets.rake` in `react_on_rails` would somehow have to know that `react_on_rails` was included in an engine, and decide the path accordingly. This might be impossible, especially in the case of multiple engines using `react_on_rails` in a single application. Another solution would be to detach this rake task from the rails assets:precompile task, and let people use it separately.
+
+# Github Issues
+
+* [Integration with an engine #342](https://github.com/shakacode/react_on_rails/issues/342)
+* [Feature: target destination option for the install generator #459](https://github.com/shakacode/react_on_rails/issues/459)
+* [Integration with Rails 5 Engines #562](https://github.com/shakacode/react_on_rails/issues/562)
+* [Run inside a Rails engine? #257](https://github.com/shakacode/react_on_rails/issues/257)

data/docs/additional-reading/rspec-configuration.md

@@ -37,7 +37,13 @@ The following `config/react_on_rails.rb` settings **must** match your setup:
 
   # Define the files we need to check for webpack compilation when running tests.
   # Generally, the manifest.json is good enough for this check if using webpacker
-  config.webpack_generated_files = %w( hello-world-bundle.js )
+  config.webpack_generated_files = %w( manifest.json )
+  
+  # OR if you're not hashing the server-bundle.js, then you should include your server-bundle.js in the list.
+  # config.webpack_generated_files = %w( server-bundle.js manifest.json )
+  
+  # OR if you're not using webpacker, your setup might look like.
+  # config.webpack_generated_files = %w( client-bundle.js server-bundle.js )
   
   # If you are using the ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
   # with rspec then this controls what yarn command is run

data/docs/basics/configuration.md

@@ -58,8 +58,10 @@ ReactOnRails.configure do |config|
 
   # Define the files we need to check for webpack compilation when running tests.
   # The default is `%w( manifest.json )` as will be sufficient for most webpacker builds.
+  # However, if you are generated a server bundle that is NOT hashed (present in manifest.json),
+  # then include the file in this list like this: 
   #
-  config.webpack_generated_files = %w( manifest.json )
+  config.webpack_generated_files = %w( server-bundle.js manifest.json )
   
   # You can optionally add values to your rails_context. See example below for RenderingExtension
   # config.rendering_extension = RenderingExtension
@@ -75,8 +77,10 @@ ReactOnRails.configure do |config|
   # JavaScript execution instances which should handle any component requested.
   #
   # While you may configure this to be the same as your client bundle file, this file is typically
-  # different.
-  #
+  # different. Note, be sure to include the exact file name with the ".js" if you are not hashing this file.
+  # If you are hashing this file (supposing you are using the same file for client rendering), then
+  # 
+  # you should include a name that matches your bundle name in your webpack config.
   config.server_bundle_js_file = "server-bundle.js"
 
   # If set to true, this forces Rails to reload the server bundle if it is modified

data/docs/basics/upgrading-react-on-rails.md

@@ -25,10 +25,10 @@ Reason for doing this: This enables your webpack bundles to bypass the Rails ass
 #### From version 7 or lower
 
 ##### ...while keeping your `client` directory
-Unfortunately, this requires quite a few steps:
 *   `.gitignore`: add `/public/webpack/*`
 *   `Gemfile`: bump `react_on_rails` and add `webpacker`
-*   layout views: anything bundled by webpack will need to be requested by a `javascript_pack_tag` or `stylesheet_pack_tag`
+*   layout views: anything bundled by webpack will need to be requested by a `javascript_pack_tag` or `stylesheet_pack_tag`. 
+  * Search your codebase for javascript_include_tag. Use the 
 *   `config/initializers/assets.rb`: we no longer need to modify `Rails.application.config.assets.paths` or append anything to `Rails.application.config.assets.precompile`.
 *   `config/initializers/react_on_rails.rb`:
     *   Delete `config.generated_assets_dir`. Webpacker's config now supplies this information

data/lib/react_on_rails/configuration.rb

@@ -3,138 +3,13 @@
 module ReactOnRails
   def self.configure
     yield(configuration)
-    setup_config_values
+    configuration.setup_config_values
   end
 
   DEFAULT_GENERATED_ASSETS_DIR = File.join(%w[public webpack], Rails.env).freeze
   DEFAULT_SERVER_RENDER_TIMEOUT = 20
   DEFAULT_POOL_SIZE = 1
 
-  def self.setup_config_values
-    ensure_webpack_generated_files_exists
-    configure_generated_assets_dirs_deprecation
-    configure_skip_display_none_deprecation
-    ensure_generated_assets_dir_present
-    ensure_server_bundle_js_file_has_no_path
-    check_i18n_directory_exists
-    check_i18n_yml_directory_exists
-    check_server_render_method_is_only_execjs
-    error_if_using_webpacker_and_generated_assets_dir_not_match_public_output_path
-  end
-
-  def self.error_if_using_webpacker_and_generated_assets_dir_not_match_public_output_path
-    return unless ReactOnRails::WebpackerUtils.using_webpacker?
-
-    return if @configuration.generated_assets_dir.blank?
-
-    webpacker_public_output_path = ReactOnRails::WebpackerUtils.webpacker_public_output_path
-
-    if File.expand_path(@configuration.generated_assets_dir) == webpacker_public_output_path.to_s
-      Rails.logger.warn("You specified /config/initializers/react_on_rails.rb generated_assets_dir "\
-        "with Webpacker. Remove this line from your configuration file.")
-    else
-      msg = <<-MSG.strip_heredoc
-        Error configuring /config/initializers/react_on_rails.rb: You are using webpacker
-        and your specified value for generated_assets_dir = #{@configuration.generated_assets_dir}
-        that does not match the value for public_output_path specified in
-        webpacker.yml = #{webpacker_public_output_path}. You should remove the configuration
-        value for "generated_assets_dir" from your config/initializers/react_on_rails.rb file.
-      MSG
-      raise ReactOnRails::Error, msg
-    end
-  end
-
-  def self.check_server_render_method_is_only_execjs
-    return if @configuration.server_render_method.blank? ||
-              @configuration.server_render_method == "ExecJS"
-
-    msg = <<-MSG.strip_heredoc
-      Error configuring /config/initializers/react_on_rails.rb: invalid value for `config.server_render_method`.
-      If you wish to use a server render method other than ExecJS, contact justin@shakacode.com
-      for details.
-    MSG
-    raise ReactOnRails::Error, msg
-  end
-
-  def self.check_i18n_directory_exists
-    return if @configuration.i18n_dir.nil?
-    return if Dir.exist?(@configuration.i18n_dir)
-
-    msg = <<-MSG.strip_heredoc
-      Error configuring /config/initializers/react_on_rails.rb: invalid value for `config.i18n_dir`.
-      Directory does not exist: #{@configuration.i18n_dir}. Set to value to nil or comment it
-      out if not using the React on Rails i18n feature.
-    MSG
-    raise ReactOnRails::Error, msg
-  end
-
-  def self.check_i18n_yml_directory_exists
-    return if @configuration.i18n_yml_dir.nil?
-    return if Dir.exist?(@configuration.i18n_yml_dir)
-
-    msg = <<-MSG.strip_heredoc
-      Error configuring /config/initializers/react_on_rails.rb: invalid value for `config.i18n_yml_dir`.
-      Directory does not exist: #{@configuration.i18n_yml_dir}. Set to value to nil or comment it
-      out if not using this i18n with React on Rails, or if you want to use all translation files.
-    MSG
-    raise ReactOnRails::Error, msg
-  end
-
-  def self.ensure_generated_assets_dir_present
-    return if @configuration.generated_assets_dir.present? || ReactOnRails::WebpackerUtils.using_webpacker?
-
-    @configuration.generated_assets_dir = DEFAULT_GENERATED_ASSETS_DIR
-    Rails.logger.warn "ReactOnRails: Set generated_assets_dir to default: #{DEFAULT_GENERATED_ASSETS_DIR}"
-  end
-
-  def self.configure_generated_assets_dirs_deprecation
-    return if @configuration.generated_assets_dirs.blank?
-
-    if ReactOnRails::WebpackerUtils.using_webpacker?
-      webpacker_public_output_path = ReactOnRails::WebpackerUtils.webpacker_public_output_path
-      Rails.logger.warn "Error configuring config/initializers/react_on_rails. Define neither the "\
-        "generated_assets_dirs no the generated_assets_dir when using Webpacker. This is defined by "\
-        "public_output_path specified in webpacker.yml = #{webpacker_public_output_path}."
-      return
-    end
-
-    Rails.logger.warn "[DEPRECATION] ReactOnRails: Use config.generated_assets_dir rather than "\
-        "generated_assets_dirs"
-    if @configuration.generated_assets_dir.blank?
-      @configuration.generated_assets_dir = @configuration.generated_assets_dirs
-    else
-      Rails.logger.warn "[DEPRECATION] ReactOnRails. You have both generated_assets_dirs and "\
-          "generated_assets_dir defined. Define ONLY generated_assets_dir if NOT using Webpacker"\
-          " and define neither if using Webpacker"
-    end
-  end
-
-  def self.ensure_webpack_generated_files_exists
-    return unless @configuration.webpack_generated_files.empty?
-
-    files = ["hello-world-bundle.js"]
-    files << @configuration.server_bundle_js_file if @configuration.server_bundle_js_file.present?
-
-    @configuration.webpack_generated_files = files
-  end
-
-  def self.ensure_server_bundle_js_file_has_no_path
-    return unless @configuration.server_bundle_js_file.include?(File::SEPARATOR)
-
-    assets_dir = ReactOnRails::Utils.generated_assets_full_path
-    @configuration.server_bundle_js_file = File.basename(@configuration.server_bundle_js_file)
-
-    Rails.logger_warn do
-      "[DEPRECATION] ReactOnRails: remove path from server_bundle_js_file in configuration. "\
-      "All generated files must go in #{assets_dir}. Using file basename #{@configuration.server_bundle_js_file}"
-    end
-  end
-
-  def self.configure_skip_display_none_deprecation
-    return if @configuration.skip_display_none.nil?
-    Rails.logger.warn "[DEPRECATION] ReactOnRails: remove skip_display_none from configuration."
-  end
-
   def self.configuration
     @configuration ||= Configuration.new(
       node_modules_location: nil,
@@ -214,5 +89,133 @@ module ReactOnRails
       self.server_render_method = server_render_method
       self.symlink_non_digested_assets_regex = symlink_non_digested_assets_regex
     end
+
+    # on ReactOnRails
+    def setup_config_values
+      ensure_webpack_generated_files_exists
+      configure_generated_assets_dirs_deprecation
+      configure_skip_display_none_deprecation
+      ensure_generated_assets_dir_present
+      ensure_server_bundle_js_file_has_no_path
+      check_i18n_directory_exists
+      check_i18n_yml_directory_exists
+      check_server_render_method_is_only_execjs
+      error_if_using_webpacker_and_generated_assets_dir_not_match_public_output_path
+    end
+
+    private
+
+    def error_if_using_webpacker_and_generated_assets_dir_not_match_public_output_path
+      return unless ReactOnRails::WebpackerUtils.using_webpacker?
+
+      return if generated_assets_dir.blank?
+
+      webpacker_public_output_path = ReactOnRails::WebpackerUtils.webpacker_public_output_path
+
+      if File.expand_path(generated_assets_dir) == webpacker_public_output_path.to_s
+        Rails.logger.warn("You specified /config/initializers/react_on_rails.rb generated_assets_dir "\
+        "with Webpacker. Remove this line from your configuration file.")
+      else
+        msg = <<-MSG.strip_heredoc
+        Error configuring /config/initializers/react_on_rails.rb: You are using webpacker
+        and your specified value for generated_assets_dir = #{generated_assets_dir}
+        that does not match the value for public_output_path specified in
+        webpacker.yml = #{webpacker_public_output_path}. You should remove the configuration
+        value for "generated_assets_dir" from your config/initializers/react_on_rails.rb file.
+        MSG
+        raise ReactOnRails::Error, msg
+      end
+    end
+
+    def check_server_render_method_is_only_execjs
+      return if server_render_method.blank? ||
+                server_render_method == "ExecJS"
+
+      msg = <<-MSG.strip_heredoc
+      Error configuring /config/initializers/react_on_rails.rb: invalid value for `config.server_render_method`.
+      If you wish to use a server render method other than ExecJS, contact justin@shakacode.com
+      for details.
+      MSG
+      raise ReactOnRails::Error, msg
+    end
+
+    def check_i18n_directory_exists
+      return if i18n_dir.nil?
+      return if Dir.exist?(i18n_dir)
+
+      msg = <<-MSG.strip_heredoc
+      Error configuring /config/initializers/react_on_rails.rb: invalid value for `config.i18n_dir`.
+      Directory does not exist: #{i18n_dir}. Set to value to nil or comment it
+      out if not using the React on Rails i18n feature.
+      MSG
+      raise ReactOnRails::Error, msg
+    end
+
+    def check_i18n_yml_directory_exists
+      return if i18n_yml_dir.nil?
+      return if Dir.exist?(i18n_yml_dir)
+
+      msg = <<-MSG.strip_heredoc
+      Error configuring /config/initializers/react_on_rails.rb: invalid value for `config.i18n_yml_dir`.
+      Directory does not exist: #{i18n_yml_dir}. Set to value to nil or comment it
+      out if not using this i18n with React on Rails, or if you want to use all translation files.
+      MSG
+      raise ReactOnRails::Error, msg
+    end
+
+    def ensure_generated_assets_dir_present
+      return if generated_assets_dir.present? || ReactOnRails::WebpackerUtils.using_webpacker?
+
+      self.generated_assets_dir = DEFAULT_GENERATED_ASSETS_DIR
+      Rails.logger.warn "ReactOnRails: Set generated_assets_dir to default: #{DEFAULT_GENERATED_ASSETS_DIR}"
+    end
+
+    def configure_generated_assets_dirs_deprecation
+      return if generated_assets_dirs.blank?
+
+      if ReactOnRails::WebpackerUtils.using_webpacker?
+        webpacker_public_output_path = ReactOnRails::WebpackerUtils.webpacker_public_output_path
+        Rails.logger.warn "Error configuring config/initializers/react_on_rails. Define neither the "\
+        "generated_assets_dirs no the generated_assets_dir when using Webpacker. This is defined by "\
+        "public_output_path specified in webpacker.yml = #{webpacker_public_output_path}."
+        return
+      end
+
+      Rails.logger.warn "[DEPRECATION] ReactOnRails: Use config.generated_assets_dir rather than "\
+        "generated_assets_dirs"
+      if generated_assets_dir.blank?
+        self.generated_assets_dir = generated_assets_dirs
+      else
+        Rails.logger.warn "[DEPRECATION] ReactOnRails. You have both generated_assets_dirs and "\
+          "generated_assets_dir defined. Define ONLY generated_assets_dir if NOT using Webpacker"\
+          " and define neither if using Webpacker"
+      end
+    end
+
+    def ensure_webpack_generated_files_exists
+      return unless webpack_generated_files.empty?
+
+      files = ["hello-world-bundle.js"]
+      files << server_bundle_js_file if server_bundle_js_file.present?
+
+      self.webpack_generated_files = files
+    end
+
+    def ensure_server_bundle_js_file_has_no_path
+      return unless server_bundle_js_file.include?(File::SEPARATOR)
+
+      assets_dir = ReactOnRails::Utils.generated_assets_full_path
+      self.server_bundle_js_file = File.basename(server_bundle_js_file)
+
+      Rails.logger_warn do
+        "[DEPRECATION] ReactOnRails: remove path from server_bundle_js_file in configuration. "\
+      "All generated files must go in #{assets_dir}. Using file basename #{server_bundle_js_file}"
+      end
+    end
+
+    def configure_skip_display_none_deprecation
+      return if skip_display_none.nil?
+      Rails.logger.warn "[DEPRECATION] ReactOnRails: remove skip_display_none from configuration."
+    end
   end
 end

data/lib/react_on_rails/prerender_error.rb

@@ -3,6 +3,8 @@
 # rubocop:disable: Layout/IndentHeredoc
 module ReactOnRails
   class PrerenderError < ::ReactOnRails::Error
+    # TODO: Consider remove providing original `err` as already have access to `self.cause`
+    # http://blog.honeybadger.io/nested-errors-in-ruby-with-exception-cause/
     attr_reader :component_name, :err, :props, :js_code, :console_messages
 
     # err might be nil if JS caught the error

data/lib/react_on_rails/react_on_rails_helper.rb

@@ -264,7 +264,7 @@ module ReactOnRails
 
     def json_safe_and_pretty(hash_or_string)
       return "{}" if hash_or_string.nil?
-      unless hash_or_string.class.in?([Hash, String])
+      unless hash_or_string.is_a?(String) || hash_or_string.is_a?(Hash)
         raise ReactOnRails::Error, "#{__method__} only accepts String or Hash as argument "\
             "(#{hash_or_string.class} given)."
       end

data/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb

@@ -53,7 +53,11 @@ module ReactOnRails
       def all_compiled_assets
         @all_compiled_assets ||= begin
           webpack_generated_files = @webpack_generated_files.map do |bundle_name|
-            ReactOnRails::Utils.bundle_js_file_path(bundle_name)
+            if bundle_name == ReactOnRails.configuration.server_bundle_js_file
+              ReactOnRails::Utils.server_bundle_js_file_path
+            else
+              ReactOnRails::Utils.bundle_js_file_path(bundle_name)
+            end
           end
 
           if webpack_generated_files.present?

data/lib/react_on_rails/utils.rb

@@ -76,8 +76,10 @@ exitstatus: #{status.exitstatus}#{stdout_msg}#{stderr_msg}
                               begin
                                 bundle_js_file_path(bundle_name)
                               rescue Webpacker::Manifest::MissingEntryError
-                                File.join(ReactOnRails::WebpackerUtils.webpacker_public_output_path,
-                                          bundle_name)
+                                File.expand_path(
+                                  File.join(ReactOnRails::WebpackerUtils.webpacker_public_output_path,
+                                            bundle_name)
+                                )
                               end
                             else
                               bundle_js_file_path(bundle_name)

data/lib/react_on_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ReactOnRails
-  VERSION = "11.0.7".freeze
+  VERSION = "11.0.8".freeze
 end

data/lib/react_on_rails/version_syntax_converter.rb

@@ -2,19 +2,21 @@
 
 require_relative "version"
 
-class VersionSyntaxConverter
-  def rubygem_to_npm(rubygem_version = ReactOnRails::VERSION)
-    regex_match = rubygem_version.match(/(\d+\.\d+\.\d+)[.\-]?(.+)?/)
-    return "#{regex_match[1]}-#{regex_match[2]}" if regex_match[2]
+module ReactOnRails
+  class VersionSyntaxConverter
+    def rubygem_to_npm(rubygem_version = ReactOnRails::VERSION)
+      regex_match = rubygem_version.match(/(\d+\.\d+\.\d+)[.\-]?(.+)?/)
+      return "#{regex_match[1]}-#{regex_match[2]}" if regex_match[2]
 
-    regex_match[1].to_s
-  end
+      regex_match[1].to_s
+    end
 
-  def npm_to_rubygem(npm_version)
-    match = npm_version
-            .tr("-", ".")
-            .strip
-            .match(/(\d.*)/)
-    match.present? ? match[0] : nil
+    def npm_to_rubygem(npm_version)
+      match = npm_version
+              .tr("-", ".")
+              .strip
+              .match(/(\d.*)/)
+      match.present? ? match[0] : nil
+    end
   end
 end

data/lib/react_on_rails/webpacker_utils.rb

@@ -8,12 +8,12 @@ module ReactOnRails
       # Note Webpacker 3.4.3 manifest lookup is inside of the public_output_path
       # [2] (pry) ReactOnRails::WebpackerUtils: 0> Webpacker.manifest.lookup("app-bundle.js")
       # "/webpack/development/app-bundle-c1d2b6ab73dffa7d9c0e.js"
+      # Next line will throw if the file or manifest does not exist
       hashed_bundle_name = Webpacker.manifest.lookup!(bundle_name)
 
       if Webpacker.dev_server.running?
         "#{Webpacker.dev_server.protocol}://#{Webpacker.dev_server.host_with_port}#{hashed_bundle_name}"
       else
-        # Next line will throw if the file or manifest does not exist
         File.expand_path(File.join("public", hashed_bundle_name)).to_s
       end
     end
@@ -23,7 +23,7 @@ module ReactOnRails
     end
 
     def self.webpacker_public_output_path
-      # Webpacker has the full absolute path of webpacker output files in a pathname
+      # Webpacker has the full absolute path of webpacker output files in a Pathname
       Webpacker.config.public_output_path.to_s
     end
 

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "11.0.7",
+  "version": "11.0.8",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {

data/rakelib/release.rake

@@ -41,7 +41,7 @@ task :release, %i[gem_version dry_run tools_install] do |_t, args|
   npm_version = if gem_version.strip.empty?
                   ""
                 else
-                  VersionSyntaxConverter.new.rubygem_to_npm(gem_version)
+                  ReactOnRails::VersionSyntaxConverter.new.rubygem_to_npm(gem_version)
                 end
 
   # Having the examples prevents publishing

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 11.0.7
+  version: 11.0.8
 platform: ruby
 authors:
 - Justin Gordon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-16 00:00:00.000000000 Z
+date: 2018-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -498,7 +498,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Rails with react server rendering with webpack.