react_on_rails 10.1.3 → 10.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: fb302b8350ede38683a4c47aa93ba4d370190d0e051fc03646fab235b7bfc8de
-  data.tar.gz: 5bb9691c1a9814d9e17e7d99ca75a471bdb43fd1e53373d2f315f2d15c94d81f
+SHA1:
+  metadata.gz: cf2961b3168fa3053ed43d36eda3e644c37ec679
+  data.tar.gz: 4e6aa1237e92667735efeb47092b58466e93b040
 SHA512:
-  metadata.gz: 3a294a9d796137ea9bb5dde298dc80c29b925989103bc65f7114993353bbc6f0dfa55cdb4cc51ae0d656e518d917ecae1d95af41996d328c6c72986f7877dc5c
-  data.tar.gz: 8b3d11cc0172eb5d1a721c8c9e130c51085a7cf2f7fd0ffeacd56a3dea0a4875414e8e2026845c42ee73aeacf0da2633e0c5acaa810716ad96d6b9dbd6558702
+  metadata.gz: 9d1ed494bfb5f01d3cfec7946459070145543104b483ee35612d683031e4027e89d8d47e64811a40a29d321d22985c4da5a7741375198a53dc0c3cd3be8308b9
+  data.tar.gz: 9cd73592f960f72e22d0318daa3c87d8f22d07513d0121997467140f854b43da062e1f03da10fdadec8c6b503d997421ad6d0bae2e8a83819f7ffb75ad707995

data/CHANGELOG.md

@@ -6,6 +6,15 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com]
 ## [Unreleased]
 Changes since last non-beta release.
 
+### [10.1.4] - 2018-04-11
+
+#### Fixed
+- Changed i18n parsing to convert ruby i18n argument syntax into FormatJS argument syntax. [PR 1046](https://github.com/shakacode/react_on_rails/pull/1046) by [sepehr500](https://github.com/sepehr500).
+
+- Fixed an issue where the spec compiler check would fail if the project path contained spaces. [PR 1045](https://github.com/shakacode/react_on_rails/pull/1045) by [andrewmarkle](https://github.com/andrewmarkle).
+
+- Updated the default `build_production_command` that caused production assets to be built with development settings. [PR 1053](https://github.com/shakacode/react_on_rails/pull/1053) by [Roman Kushnir](https://github.com/RKushnir).
+
 *Please add entries here for your pull requests that are not yet released.*
 
 ### [10.1.3] - 2018-02-28
@@ -691,7 +700,8 @@ Best done with Object destructing:
 ##### Fixed
 - Fix several generator related issues.
 
-[Unreleased]: https://github.com/shakacode/react_on_rails/compare/10.1.3...master
+[Unreleased]: https://github.com/shakacode/react_on_rails/compare/10.1.4...master
+[10.1.4]: https://github.com/shakacode/react_on_rails/compare/10.1.3...10.1.4
 [10.1.3]: https://github.com/shakacode/react_on_rails/compare/10.1.2...10.1.3
 [10.1.2]: https://github.com/shakacode/react_on_rails/compare/10.1.1...10.1.2
 [10.1.1]: https://github.com/shakacode/react_on_rails/compare/10.1.0...10.1.1

data/PROJECTS.md

@@ -1,9 +1,16 @@
 # Projects using React on Rails
 
+[Click here](https://publicwww.com/websites/%22react-on-rails%22++-undeveloped.com/) for a search for public sites using React on Rails. 
+
+Public Sites Using React on Rails:
+
+March 27, 2018: 2126<br>
+April 11, 2018: 2138
+
 *Please support the project by [emailing Justin Gordon](mailto:justin@shakacode.com) of any projects, yours or others, that use React on Rails. You can confirm a project uses React on Rails as the source will contain **`js-react-on-rails`**.*
 
 ## Commercial Products Live
-* **[Friends and Guests](https://www.friendsandguests.com/)**, the signature product of [ShakaCode](http://www.shakacode.com), which is a "Network Connecting Hosts and Guests".
+* **[Hawaii Chee](https://www.hawaiichee.com/)**, the signature product of [ShakaCode](http://www.shakacode.com), which is a vacation rental site focusing on Hawaii.
 * **[KissKissBankBank](https://www.kisskissbankbank.com/)**, large French crowdfunding platform.
 * **[HVMN](https://hvmn.com)**: Web ecommerce site for "biohacking" products.
 * **[GuavaPass](https://guavapass.com/)**: Coaching client of [ShakaCode](http://www.shakacode.com) and React on Rails fan!

data/README.md

@@ -2,9 +2,11 @@
 
 *If this projects helps you, please give us a star!*
 
-[The ShakaCode team has availability to help your project](http://www.shakacode.com/work). If your team might need my help, please [email me](mailto:justin@shakacode.com) for a free half-hour project consultation, on anything from React on Rails to any aspect of web or mobile application development for both consumer and enterprise products.
+# [The ShakaCode team has availability to help your project as of 2018-03-27](http://www.shakacode.com/services).
 
-# React on Rails v10 is based on Webpacker 3.0!
+If your team might need my help, please [email me](mailto:justin@shakacode.com) for a free half-hour project consultation, on anything from React on Rails to any aspect of web or mobile application development for both consumer and enterprise products.
+
+## React on Rails v10 is based on Webpacker 3.0!
 
 * See the article [Introducing React on Rails v9 with Webpacker Support](https://blog.shakacode.com/introducing-react-on-rails-v9-with-webpacker-support-f2584c6c8fa4) for an overview of the integration of React on Rails with Webpacker.
 * [Video of running the v9 installer with Webpacker v3](https://youtu.be/M0WUM_XPaII).
@@ -31,9 +33,10 @@ First be sure to run `rails -v` and check that you are using Rails 5.1.3 or abov
 
 1. New Rails app: `rails new my-app --webpack=react`. `cd` into the directory.
 2. Add gem version: `gem 'react_on_rails', '10.0.2' # prefer exact gem version to match npm version`
-3. Run the generator: `rails generate react_on_rails:install`
-4. Start the app: `rails s`
-5. Visit http://localhost:3000/hello_world
+3. `bundle install`
+4. Run the generator: `rails generate react_on_rails:install`
+5. Start the app: `rails s`
+6. Visit http://localhost:3000/hello_world
 
 ### Turn on server rendering
 
@@ -133,7 +136,7 @@ For more testimonials, see [Live Projects](PROJECTS.md) and [Kudos](./KUDOS.md).
 
 **Project Objective**: To provide an opinionated and optimal framework for integrating Ruby on Rails with React via the [**Webpacker**](https://github.com/rails/webpacker) gem.
 
-React on Rails integrates Facebook's [React](https://github.com/facebook/react) front-end framework with Rails. React v0.14.x and greater is supported, with server rendering. [Redux](https://github.com/reactjs/redux) and [React-Router](https://github.com/reactjs/react-redux) are supported as well, also with server rendering, using **execJS**.
+React on Rails integrates Facebook's [React](https://github.com/facebook/react) front-end framework with Rails. React v0.14.x and greater is supported, with server rendering. [Redux](https://github.com/reactjs/redux) and [React-Router](https://github.com/reactjs/react-router) are supported as well, also with server rendering, using **execJS**.
 
 ## Table of Contents
 

data/app/helpers/react_on_rails_helper.rb

@@ -305,9 +305,9 @@ module ReactOnRailsHelper
     # IMPORTANT: Ensure that we mark string as html_safe to avoid escaping.
     # rubocop:disable Layout/IndentHeredoc
     <<-HTML.html_safe
+#{rendered_output}
 #{component_specification_tag}
-    #{rendered_output}
-    #{console_script}
+#{console_script}
     HTML
     # rubocop:enable Layout/IndentHeredoc
   end

data/docs/additional-reading/elastic-beanstalk.md

@@ -3,41 +3,61 @@
 In order to deploy a React on Rails app to elastic beanstalk, you must install yarn on each instance.
 If yarn is not installed, asset compilation will fail on the elastic beanstalk instance.
 
-You can install yarn by adding a `yarn.config` file to your `.ebextensions` folder which contains these commands.
+You can install `yarn` by adding a `0x_install_yarn.config` file to your `.ebextensions` folder which contains these commands.
 
 ```
-commands:
-
-  01_node_get:
-    cwd: /tmp
-    command: 'sudo curl --silent --location https://rpm.nodesource.com/setup_6.x | sudo bash -'
-
-  02_node_install:
-    cwd: /tmp
-    command: 'sudo yum -y install nodejs'
-
-  03_yarn_get:
-    cwd: /tmp
-    # don't run the command if yarn is already installed (file /usr/bin/yarn exists)
-    test: '[ ! -f /usr/bin/yarn ] && echo "yarn not installed"'
-    command: 'sudo wget https://dl.yarnpkg.com/rpm/yarn.repo -O /etc/yum.repos.d/yarn.repo'
-
-  04_yarn_install:
-    cwd: /tmp
-    test: '[ ! -f /usr/bin/yarn ] && echo "yarn not installed"'
-    command: 'sudo yum -y install yarn'
-    
-  05_mkdir_webapp_dir:
-    command: mkdir /home/webapp
-    ignoreErrors: true
-    
-  06_chown_webapp_dir:
-    command: chown webapp:webapp /home/webapp
-    ignoreErrors: true
-    
-  07_chmod_webapp_dir:
-    command: chmod 700 /home/webapp
-    ignoreErrors: true
+files:
+  "/opt/elasticbeanstalk/hooks/appdeploy/pre/09_yarn.sh" :
+    mode: "000755"
+    owner: root
+    group: root
+    content: |
+      #!/usr/bin/env bash
+      set -xe
+
+      EB_SCRIPT_DIR=$(/opt/elasticbeanstalk/bin/get-config container -k script_dir)
+      EB_APP_STAGING_DIR=$(/opt/elasticbeanstalk/bin/get-config container -k app_staging_dir)
+      EB_APP_USER=$(/opt/elasticbeanstalk/bin/get-config container -k app_user)
+      EB_SUPPORT_DIR=$(/opt/elasticbeanstalk/bin/get-config container -k support_dir)
+
+      . $EB_SUPPORT_DIR/envvars
+      . $EB_SCRIPT_DIR/use-app-ruby.sh
+
+      # Install nodejs
+      echo "install nodejs"
+      curl --silent --location https://rpm.nodesource.com/setup_6.x | sudo bash -
+      yum -y install nodejs
+      echo "install yarn"
+      # install yarn
+      wget https://dl.yarnpkg.com/rpm/yarn.repo -O /etc/yum.repos.d/yarn.repo;
+      yum -y install yarn;
+
+      # yarn install
+      cd $EB_APP_STAGING_DIR
+      yarn
+
+      # mkdir /home/webapp
+      mkdir -p /home/webapp
+      chown webapp:webapp /home/webapp
+      chmod 700 /home/webapp
+```
+
+This script installs `yarn` and all `node.js` dependencies before the rails do `assets:precompile`. Also, it creates `/home/webapp` directory allowing the precompile task to create temp files. 
+
+Your app can be deployed to elastic beanstalk successfully. However, the react app javascript files are under `public/packs`. If you are using nginx, you need to let it know the location of `https://yourhost/packs`. 
 
+In your `proxy.conf` setting, please add the following code.
+
+```
+...
+server{
+  ...
+  location /packs {
+    root /var/app/current/public;
+  }
+  ...
+}
+...
 ```
 
+You can find an example code here: https://github.com/imgarylai/react_on_rails_with_aws_ebs.

data/lib/generators/react_on_rails/templates/base/base/config/initializers/react_on_rails.rb

@@ -5,7 +5,7 @@
 ReactOnRails.configure do |config|
   # This configures the script to run to build the production assets by webpack. Set this to nil
   # if you don't want react_on_rails building this file for you.
-  config.build_production_command = "RAILS_ENV=production bin/webpack"
+  config.build_production_command = "RAILS_ENV=production NODE_ENV=production bin/webpack"
 
   ################################################################################
   ################################################################################

data/lib/react_on_rails/locales_to_js.rb

@@ -108,7 +108,7 @@ module ReactOnRails
         if v.is_a? Hash
           flatten(v).map { |hk, hv| h["#{k}.#{hk}".to_sym] = hv }
         else
-          h[k] = v
+          h[k] = v.gsub("%{", "{")
         end
       end
     end

data/lib/react_on_rails/utils.rb

@@ -146,7 +146,7 @@ exitstatus: #{status.exitstatus}#{stdout_msg}#{stderr_msg}
     end
 
     def self.prepend_cd_node_modules_directory(cmd)
-      "cd #{ReactOnRails.configuration.node_modules_location} && #{cmd}"
+      "cd \"#{ReactOnRails.configuration.node_modules_location}\" && #{cmd}"
     end
 
     def self.source_path

data/lib/react_on_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ReactOnRails
-  VERSION = "10.1.3".freeze
+  VERSION = "10.1.4".freeze
 end

data/lib/react_on_rails/version_checker.rb

@@ -82,9 +82,7 @@ module ReactOnRails
       def major_minor_patch
         return if relative_path?
         match = raw.match(MAJOR_MINOR_PATCH_VERSION_REGEX)
-        unless match
-          raise "Cannot parse version number '#{raw}' (wildcard versions are not supported)"
-        end
+        raise "Cannot parse version number '#{raw}' (wildcard versions are not supported)" unless match
         [match[1], match[2], match[3]]
       end
 

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "10.1.3",
+  "version": "10.1.4",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {

data/react_on_rails.gemspec

@@ -47,5 +47,11 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rails", "~> 5.1.2"
   s.add_development_dependency "rake", "~> 10.0"
   s.add_development_dependency "rspec"
+  
+  s.post_install_message = <<~MSG
+    Email contact@shakacode.com for access to our slack room and information about our "pro support plan"
+    which supports better performance, via caching helpers and our node rendering server.
+
+  MSG
 end
 # rubocop:enable Metrics/BlockLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 10.1.3
+  version: 10.1.4
 platform: ruby
 authors:
 - Justin Gordon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-01 00:00:00.000000000 Z
+date: 2018-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -459,7 +459,10 @@ homepage: https://github.com/shakacode/react_on_rails
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: |+
+  Email contact@shakacode.com for access to our slack room and information about our "pro support plan"
+  which supports better performance, via caching helpers and our node rendering server.
+
 rdoc_options: []
 require_paths:
 - lib
@@ -475,7 +478,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.2
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Rails with react server rendering with webpack.