react-manifest-rails 0.2.23 → 0.2.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 907e5e7bb8b3e6a8554009c4e8a87a39379d8bd09c4455fd9c02b082a014c18b
-  data.tar.gz: 11d4e6ca8833973107937eee1b82881f620f3b2e74442ab0883521ea5803d58b
+  metadata.gz: 786d53e91fe8a65339def86bc62a94179762364cf13d1abcc8427ea9585f0c38
+  data.tar.gz: 90c58cd92bc06eb2911deaf829aca60ed8533e6dc58e535759e9f6d60eefdcd2
 SHA512:
-  metadata.gz: 950abc3b34f1ffe0e8eb6fcd4ae7798469b60746531d0bb0171de0975881cb2572f35182e07785255fcf932ce14ccaac369a1238e2d5e2fe3b8689d323861d06
-  data.tar.gz: dc6fcbfb087a8aa9f95ff109147ee0345b2aa32fc1a0281118ffb60d12313735d659ecb55200832eb940bf6def8675ab711e64208fcc0ec17514e71e0ea57f42
+  metadata.gz: 30c7f0633646f06cfc497a617c76dbbb50f74e84104fd590f3054bff5c228a42e08aa6683dfdc96702656a52cec57533917b2438d4bb39ede667ef6c0686f219
+  data.tar.gz: 0ea044f3d55bb64be2ce9a725cc90cf9b33da8f343fde043707c098995ce6e88840e609947867203efe739623ce5dba3a32e4d444dfb9b3f8b252b56b991adbb

data/CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.24] - 2026-04-22
+
+### Fixed
+- Controller manifests now inline files from bundles listed in `always_include` (for example `ux_main`), so runtime symbol availability no longer depends on cross-bundle script execution order in production.
+- Scanner analysis no longer emits warnings for ux/app file naming convention mismatches, reducing noise for apps that intentionally use custom filename patterns.
+
+### Changed
+- Updated `Gemfile.lock` to keep lockfile state aligned with the released codebase.
+
 ## [0.2.23] - 2026-04-21
 
 ### Fixed

data/lib/react_manifest/generator.rb

@@ -43,11 +43,11 @@ module ReactManifest
     def run!
       classification = @classifier.classify
       scan_result = Scanner.new(@config).scan(classification)
-      controller_context = build_controller_context(classification.controller_dirs, classification.shared_dirs, scan_result)
+      controller_context = build_controller_context(classification.controller_dirs, classification.shared_dirs,
+                                                    scan_result)
 
       # Phase 1: build all content in memory — no I/O.
-      manifests = []
-      classification.controller_dirs.each { |ctrl| manifests << build_controller(ctrl, controller_context) }
+      manifests = classification.controller_dirs.map { |ctrl| build_controller(ctrl, controller_context) }
 
       migrate_legacy_manifests!
 
@@ -62,12 +62,11 @@ module ReactManifest
 
     # ------------------------------------------------------------------ shared
 
-
-
     # --------------------------------------------------------------- controller
 
     def build_controller(ctrl, controller_context)
       lines = header_lines
+      always_include_reqs = controller_context[:always_include_requires].fetch(ctrl[:bundle_name], [])
       dep_requires = controller_dependency_requires(ctrl[:bundle_name], controller_context)
       lib_reqs = controller_context[:shared_lib_requires]
       shared_reqs = controller_context[:shared_requires].fetch(ctrl[:bundle_name], Set.new).to_a.sort
@@ -75,7 +74,7 @@ module ReactManifest
 
       files = js_files_in(ctrl[:path])
       own_requires = files.map { |f| relative_require_path(f) }
-      all_requires = (dep_requires + lib_reqs + shared_reqs + ext_reqs + own_requires).uniq
+      all_requires = (always_include_reqs + dep_requires + lib_reqs + shared_reqs + ext_reqs + own_requires).uniq
 
       if all_requires.empty?
         lines << "// (no JSX files found in #{ctrl[:name]}/)"
@@ -86,6 +85,7 @@ module ReactManifest
       { filename: "#{ctrl[:bundle_name]}.js", content: "#{lines.join("\n")}\n" }
     end
 
+    # rubocop:disable Metrics/AbcSize
     def build_controller_context(controller_dirs, shared_dirs, scan_result)
       bundle_files = {}
       symbol_to_bundle = {}
@@ -103,10 +103,8 @@ module ReactManifest
         end
         shared_requires[ctrl[:bundle_name]] = expand_shared_requires(shared_requires[ctrl[:bundle_name]],
                                                                      shared_dependency_map)
-      end
 
-      # Index controller-defined symbols for cross-app detection
-      controller_dirs.each do |ctrl|
+        # Index controller-defined symbols for cross-app detection
         bundle_name = ctrl[:bundle_name]
         files = js_files_in(ctrl[:path])
         bundle_files[bundle_name] = files
@@ -152,14 +150,18 @@ module ReactManifest
         end
       end
 
+      always_include_requires = build_always_include_requires(bundle_files, dependencies)
+
       {
         bundle_files: bundle_files,
         dependencies: dependencies,
+        always_include_requires: always_include_requires,
         shared_lib_requires: shared_lib_requires,
         shared_requires: shared_requires,
         external_requires: external_requires
       }
     end
+    # rubocop:enable Metrics/AbcSize
 
     def controller_dependency_requires(bundle_name, controller_context)
       deps = transitive_dependencies(bundle_name, controller_context[:dependencies])
@@ -189,6 +191,32 @@ module ReactManifest
       ordered
     end
 
+    def build_always_include_requires(bundle_files, dependencies)
+      bundles = @config.always_include.map(&:to_s).reject(&:empty?).uniq
+      return Hash.new { |h, k| h[k] = [] } if bundles.empty?
+
+      requires_by_bundle = Hash.new { |h, k| h[k] = [] }
+
+      bundle_files.each_key do |bundle_name|
+        requires = Set.new
+
+        bundles.each do |always_bundle|
+          next if always_bundle == bundle_name
+
+          transitive = [always_bundle] + transitive_dependencies(always_bundle, dependencies)
+          transitive.each do |dep_bundle|
+            bundle_files.fetch(dep_bundle, []).each do |abs_path|
+              requires << relative_require_path(abs_path)
+            end
+          end
+        end
+
+        requires_by_bundle[bundle_name] = requires.to_a.sort
+      end
+
+      requires_by_bundle
+    end
+
     # --------------------------------------------------------------- write
 
     def write_manifest(filename, content)

data/lib/react_manifest/scanner.rb

@@ -23,7 +23,7 @@ module ReactManifest
       /function\s+([A-Z][A-Za-z0-9_]*)\s*\(/,         # function FooBar(
       /class\s+([A-Z][A-Za-z0-9_]*)\s*(?:extends|\{)/, # class FooBar
       /(?:const|let|var)\s+(use[A-Z][A-Za-z0-9_]*)\s*=/, # const useFoo = (hooks)
-      /function\s+(use[A-Z][A-Za-z0-9_]*)\s*\(/,     # function useFoo(
+      /function\s+(use[A-Z][A-Za-z0-9_]*)\s*\(/, # function useFoo(
 
       # ES module style (export default / named exports)
       /^export\s+default\s+(?:function|class)\s+([A-Z][A-Za-z0-9_]*)/,
@@ -130,7 +130,6 @@ module ReactManifest
         warnings.add("Controller dir '#{ctrl[:name]}' has no JS/JSX files") if files.empty? && @config.verbose?
 
         files.each do |file_path|
-          validate_naming(file_path, ctrl[:name], warnings)
           content = read_controller_file(file_path, warnings)
           next unless content
 
@@ -191,15 +190,6 @@ module ReactManifest
       rel.sub(/\.js\.jsx$/, "").sub(/\.jsx$/, "").sub(/\.js$/, "")
     end
 
-    def validate_naming(file_path, ctrl_name, warnings)
-      basename = File.basename(file_path, ".*").sub(/\.js$/, "")
-      # Expected: <controller>_index, <controller>_show, <controller>_form, etc.
-      return if basename.start_with?("#{ctrl_name}_") || basename == ctrl_name
-
-      warnings.add("File '#{File.basename(file_path)}' in '#{ctrl_name}' does not follow " \
-                  "'#{ctrl_name}_<action>.js.jsx' naming convention")
-    end
-
     def detect_shared_violations(shared_file_paths, controller_symbol_index, warnings)
       violations = []
       shared_file_paths.each do |file_path, relative|
@@ -222,8 +212,8 @@ module ReactManifest
             violations << { shared_file: relative, symbol: sym,
                             controller: info[:controller], app_file: info[:file] }
             warnings.add("Shared file '#{relative}' uses app-dir symbol '#{sym}' " \
-                        "(from ux/app/#{info[:controller]}). " \
-                        "Move '#{sym}' to a shared dir or the shared file will be incomplete.")
+                         "(from ux/app/#{info[:controller]}). " \
+                         "Move '#{sym}' to a shared dir or the shared file will be incomplete.")
           end
         end
       end
@@ -252,8 +242,8 @@ module ReactManifest
             violations << { external_file: relative, symbol: sym,
                             controller: info[:controller], app_file: info[:file] }
             warnings.add("External file '#{relative}' uses app-dir symbol '#{sym}' " \
-                        "(from ux/app/#{info[:controller]}). " \
-                        "Move '#{sym}' into a shared ux dir to avoid duplicate runtime declarations.")
+                         "(from ux/app/#{info[:controller]}). " \
+                         "Move '#{sym}' into a shared ux dir to avoid duplicate runtime declarations.")
           end
         end
       end
@@ -268,9 +258,7 @@ module ReactManifest
       end
 
       fanout.each do |file, count|
-        if count > 3
-          warnings.add("High fan-out: '#{file}' is used by #{count} controllers")
-        end
+        warnings.add("High fan-out: '#{file}' is used by #{count} controllers") if count > 3
       end
     end
 

data/lib/react_manifest/version.rb

@@ -1,3 +1,3 @@
 module ReactManifest
-  VERSION = "0.2.23".freeze
+  VERSION = "0.2.24".freeze
 end

data/lib/react_manifest/view_helpers.rb

@@ -75,7 +75,7 @@ module ReactManifest
       if respond_to?(:request, true) && request
         request.env["react_manifest.emitted_bundles"] ||= []
       else
-        @_react_manifest_emitted_bundles ||= []
+        @emitted_bundles ||= []
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react-manifest-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.23
+  version: 0.2.24
 platform: ruby
 authors:
 - Oliver Noonan