react-manifest-rails 0.2.21 → 0.2.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a68f022a75a440c68e741e931c5453e6c96c126380356757825a984de94e2143
-  data.tar.gz: 52d20e65e685a1b82d833ee650677c91a6fc5faa9e7b32c1075d85a2e6f53fa7
+  metadata.gz: c87f68d7ed8248c19732ce3b946a1207ed85907a92bd39ab5a2eda665f5b001e
+  data.tar.gz: 7ee42c73f25048a31d8ca713d0cdfc23b344eb99ec68d1f72c58b5cfda3b635d
 SHA512:
-  metadata.gz: bfd3abb4dde7e8d661df2623b42345a6f5a191f6b119ce25d8913ab094261ea76592ea435709a9fd80d320703673deb073b4df2a8de90a2fb76d6cf43532272b
-  data.tar.gz: cef2fd10f820ebf0a1583772fa7236e34f5c5d2744e076f682111d374cf220c265b2625d02a6f88d0274baaaa8e215eb55cfec353e528d85ac82327ef466dc6f
+  metadata.gz: d71e1c8b255678a3b1a72df766134b80dadd8bf7553d4380e240d3a8b526dff5e6f6ef848574b93c86f6778feef896cc04b945a0f020d03d0bccf034acfe7d74
+  data.tar.gz: 874538d0cd06e8b8a121d9343a3846649b6612cd3ad4bb8c0c28a7c1589c1e05bf2f48b80ae0fe6a8af478d07a3d4309d9a5bc692536f4cdebeeed90b89ca74c

data/README.md

@@ -235,6 +235,18 @@ If you see errors like `UserSignInForm is not defined` (often from `eval` inside
 
 Using `defer: true` can cause `react_component` inline scripts to run before your `ux_*.js` bundles are executed.
 
+### `Identifier '<Name>' has already been declared`
+
+This usually means the same component/function is being loaded from two separate bundles.
+
+Common cause: a file outside `ux/` (for example `app/assets/javascripts/components/navbar/*` loaded by `application.js`) references a symbol defined in `ux/app/<controller>/...`, while that controller bundle is also loaded via `react_bundle_tag`.
+
+Recommended fix:
+- Move globally reused symbols out of `ux/app/*` into a shared dir (`ux/components`, `ux/hooks`, `ux/lib`) so they are emitted once via `ux_shared.js`.
+- Keep controller-specific symbols in `ux/app/*` and avoid importing/using them from non-ux global assets.
+
+If you use `external_roots`, `react_manifest:analyze` and generation warnings will now flag this pattern explicitly.
+
 ## Compatibility
 
 - Ruby: 3.2+

data/lib/react_manifest/generator.rb

@@ -132,6 +132,8 @@ module ReactManifest
             next
           end
 
+          warn_on_external_controller_references(file_path, symbol_to_bundle)
+
           extract_defined_symbols(file_path).each do |sym|
             external_symbol_to_require[sym] ||= req_path
           end
@@ -372,6 +374,17 @@ module ReactManifest
       path.to_s.sub(/\.js\.jsx$/, "").sub(/\.jsx$/, "").sub(/\.js$/, "")
     end
 
+    def warn_on_external_controller_references(file_path, symbol_to_bundle)
+      extract_used_component_symbols(file_path).each do |sym|
+        dep_bundle = symbol_to_bundle[sym]
+        next unless dep_bundle
+
+        warn "[ReactManifest] External file '#{relative_require_path(file_path)}' references " \
+             "controller-only symbol '#{sym}' (#{dep_bundle}). " \
+             "Move '#{sym}' to a shared ux dir to avoid duplicate runtime declarations."
+      end
+    end
+
     def auto_generated?(path)
       # Avoid TOCTOU: don't check existence separately — just attempt the read
       # and treat a missing/unreadable file as not auto-generated.

data/lib/react_manifest/scanner.rb

@@ -57,7 +57,8 @@ module ReactManifest
       Object Array String Number Boolean Symbol Map Set WeakMap
     ].freeze
 
-    Result = Struct.new(:symbol_index, :controller_usages, :warnings, :shared_violations, keyword_init: true)
+    Result = Struct.new(:symbol_index, :controller_usages, :warnings, :shared_violations,
+                        :external_violations, keyword_init: true)
 
     def initialize(config = ReactManifest.configuration)
       @config = config
@@ -67,6 +68,7 @@ module ReactManifest
     def scan(classification)
       warnings      = []
       symbol_index  = {}
+      external_file_paths = {} # file_path => relative_require_path for external_roots files
 
       # Phase 1a: index symbols from shared dirs
       shared_file_paths = {} # file_path => relative_require_path for all shared files
@@ -90,7 +92,8 @@ module ReactManifest
         abs_root = abs_external_root(root_path)
         js_files_in(abs_root).each do |file_path|
           relative = relative_require_path(file_path)
-          symbols  = extract_definitions(file_path)
+          external_file_paths[file_path] = relative
+          symbols = extract_definitions(file_path)
           symbols.each do |sym|
             symbol_index[sym] ||= relative
           end
@@ -119,6 +122,7 @@ module ReactManifest
 
       # Phase 1e: detect shared files that use app-dir (controller) symbols
       shared_violations = detect_shared_violations(shared_file_paths, controller_symbol_index, warnings)
+      external_violations = detect_external_root_violations(external_file_paths, controller_symbol_index, warnings)
 
       # Phase 2: scan controller dirs for usage
       controller_usages = {}
@@ -147,7 +151,8 @@ module ReactManifest
         symbol_index: symbol_index,
         controller_usages: controller_usages,
         warnings: warnings,
-        shared_violations: shared_violations
+        shared_violations: shared_violations,
+        external_violations: external_violations
       )
     end
     # rubocop:enable Metrics/MethodLength,Metrics/AbcSize,Metrics/PerceivedComplexity
@@ -229,6 +234,36 @@ module ReactManifest
       violations
     end
 
+    def detect_external_root_violations(external_file_paths, controller_symbol_index, warnings)
+      violations = []
+      external_file_paths.each do |file_path, relative|
+        content = begin
+          File.read(file_path, encoding: "utf-8")
+        rescue Errno::ENOENT, Errno::EACCES, Encoding::InvalidByteSequenceError
+          next
+        end
+
+        local_syms = Set.new
+        DEFINITION_PATTERNS.each { |p| content.scan(p) { |m| local_syms << m[0] } }
+
+        [PASCAL_TOKEN_PATTERN, HOOK_TOKEN_PATTERN].each do |pattern|
+          content.scan(pattern) do |match|
+            sym = match[0]
+            next if local_syms.include?(sym)
+            next unless controller_symbol_index.key?(sym)
+
+            info = controller_symbol_index[sym]
+            violations << { external_file: relative, symbol: sym,
+                            controller: info[:controller], app_file: info[:file] }
+            warnings << "External file '#{relative}' uses app-dir symbol '#{sym}' " \
+                        "(from ux/app/#{info[:controller]}). " \
+                        "Move '#{sym}' into a shared ux dir to avoid duplicate runtime declarations."
+          end
+        end
+      end
+      violations
+    end
+
     # Count how many controllers use each shared file
     def emit_fanout_warnings(controller_usages, warnings)
       fanout = Hash.new(0)

data/lib/react_manifest/version.rb

@@ -1,3 +1,3 @@
 module ReactManifest
-  VERSION = "0.2.21".freeze
+  VERSION = "0.2.22".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react-manifest-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.21
+  version: 0.2.22
 platform: ruby
 authors:
 - Oliver Noonan