re2 2.4.0-x86_64-darwin → 2.4.1-x86_64-darwin

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: edf1c7e3653b56292efc8e46bb85ab926a458dee95c9a9557f45ae027bef8634
-  data.tar.gz: 5c768b4d45614caa2caa3e301e4cf672fc97d65986f93bda22677455678d6510
+  metadata.gz: bf33390b57a9ac1f50def820182c027a4a4d2a79cf6d120d9a835d701c2df96f
+  data.tar.gz: ad0f77f22597ef72d8b593dad32d5c0316d6873a4e77a914db0807c457509fe5
 SHA512:
-  metadata.gz: feae473be7b1d2bba5241c9f1e2865853a0a72de488e2cec72a46d60dad1e804e9c2051c5147a561f353a061d4e937cf11f4a3d9cd9fbe0f91377c64375d163e
-  data.tar.gz: 22a6791f535fd6a32dcd94f1d2b8f01532e2396395b3a566836811c6d28c93b091729081f4b374d0a0d783b7e115911d2d1efb3be933beefeaaababf83ed70ae
+  metadata.gz: 40431501e5e3c37b900034d07ed01a0aca8f2098502bd3b8c72cb0ef0d7fe146f0d25d36e2416ef404c8c473f0ad2bcf646bfd9bb587de863b9c9254d11e5b1d
+  data.tar.gz: a1ea0a37ea7229945421f0a93e235c9fba3ee998e21fa06e6327bc9b1498d62334782e598dfbd765da01e5411846343cf543bab8a42b5ce450df94ab13a6488a

data/README.md

@@ -5,7 +5,7 @@ Ruby bindings to [RE2][], a "fast, safe, thread-friendly alternative to
 backtracking regular expression engines like those used in PCRE, Perl, and
 Python".
 
-**Current version:** 2.4.0  
+**Current version:** 2.4.1  
 **Supported Ruby versions:** 2.6, 2.7, 3.0, 3.1, 3.2  
 **Bundled RE2 version:** libre2.11 (2023-11-01)  
 **Supported RE2 versions:** libre2.0 (< 2020-03-02), libre2.1 (2020-03-02), libre2.6 (2020-03-03), libre2.7 (2020-05-01), libre2.8 (2020-07-06), libre2.9 (2020-11-01), libre2.10 (2022-12-01), libre2.11 (2023-07-01)

data/ext/re2/re2.cc

@@ -130,33 +130,33 @@ static void parse_re2_options(RE2::Options* re2_options, const VALUE options) {
 #define re2_compact_callback(x)
 #endif
 
-static void re2_matchdata_mark(void *data) {
-  re2_matchdata *self = (re2_matchdata *)data;
-  rb_gc_mark_movable(self->regexp);
-  rb_gc_mark_movable(self->text);
+static void re2_matchdata_mark(void *ptr) {
+  re2_matchdata *m = reinterpret_cast<re2_matchdata *>(ptr);
+  rb_gc_mark_movable(m->regexp);
+  rb_gc_mark_movable(m->text);
 }
 
 #ifdef HAVE_RB_GC_MARK_MOVABLE
-static void re2_matchdata_update_references(void *data) {
-  re2_matchdata *self = (re2_matchdata *)data;
-  self->regexp = rb_gc_location(self->regexp);
-  self->text = rb_gc_location(self->text);
+static void re2_matchdata_compact(void *ptr) {
+  re2_matchdata *m = reinterpret_cast<re2_matchdata *>(ptr);
+  m->regexp = rb_gc_location(m->regexp);
+  m->text = rb_gc_location(m->text);
 }
 #endif
 
-static void re2_matchdata_free(void *data) {
-  re2_matchdata *self = (re2_matchdata *)data;
-  if (self->matches) {
-    delete[] self->matches;
+static void re2_matchdata_free(void *ptr) {
+  re2_matchdata *m = reinterpret_cast<re2_matchdata *>(ptr);
+  if (m->matches) {
+    delete[] m->matches;
   }
-  xfree(self);
+  xfree(m);
 }
 
-static size_t re2_matchdata_memsize(const void *data) {
-  const re2_matchdata *self = (const re2_matchdata *)data;
-  size_t size = sizeof(re2_matchdata);
-  if (self->matches) {
-    size += sizeof(self->matches) * self->number_of_matches;
+static size_t re2_matchdata_memsize(const void *ptr) {
+  const re2_matchdata *m = reinterpret_cast<const re2_matchdata *>(ptr);
+  size_t size = sizeof(*m);
+  if (m->matches) {
+    size += sizeof(*m->matches) * m->number_of_matches;
   }
 
   return size;
@@ -168,40 +168,40 @@ static const rb_data_type_t re2_matchdata_data_type = {
     .dmark = re2_matchdata_mark,
     .dfree = re2_matchdata_free,
     .dsize = re2_matchdata_memsize,
-    re2_compact_callback(re2_matchdata_update_references)
+    re2_compact_callback(re2_matchdata_compact)
   },
   // IMPORTANT: WB_PROTECTED objects must only use the RB_OBJ_WRITE()
   // macro to update VALUE references, as to trigger write barriers.
   .flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED
 };
 
-static void re2_scanner_mark(void *data) {
-  re2_scanner *self = (re2_scanner *)data;
-  rb_gc_mark_movable(self->regexp);
-  rb_gc_mark_movable(self->text);
+static void re2_scanner_mark(void *ptr) {
+  re2_scanner *s = reinterpret_cast<re2_scanner *>(ptr);
+  rb_gc_mark_movable(s->regexp);
+  rb_gc_mark_movable(s->text);
 }
 
 #ifdef HAVE_RB_GC_MARK_MOVABLE
-static void re2_scanner_update_references(void *data) {
-  re2_scanner *self = (re2_scanner *)data;
-  self->regexp = rb_gc_location(self->regexp);
-  self->text = rb_gc_location(self->text);
+static void re2_scanner_compact(void *ptr) {
+  re2_scanner *s = reinterpret_cast<re2_scanner *>(ptr);
+  s->regexp = rb_gc_location(s->regexp);
+  s->text = rb_gc_location(s->text);
 }
 #endif
 
-static void re2_scanner_free(void *data) {
-  re2_scanner *self = (re2_scanner *)data;
-  if (self->input) {
-    delete self->input;
+static void re2_scanner_free(void *ptr) {
+  re2_scanner *s = reinterpret_cast<re2_scanner *>(ptr);
+  if (s->input) {
+    delete s->input;
   }
-  xfree(self);
+  xfree(s);
 }
 
-static size_t re2_scanner_memsize(const void *data) {
-  const re2_scanner *self = (const re2_scanner *)data;
-  size_t size = sizeof(re2_scanner);
-  if (self->input) {
-    size += sizeof(self->input);
+static size_t re2_scanner_memsize(const void *ptr) {
+  const re2_scanner *s = reinterpret_cast<const re2_scanner *>(ptr);
+  size_t size = sizeof(*s);
+  if (s->input) {
+    size += sizeof(s->input);
   }
 
   return size;
@@ -213,26 +213,26 @@ static const rb_data_type_t re2_scanner_data_type = {
     .dmark = re2_scanner_mark,
     .dfree = re2_scanner_free,
     .dsize = re2_scanner_memsize,
-    re2_compact_callback(re2_scanner_update_references)
+    re2_compact_callback(re2_scanner_compact)
   },
   // IMPORTANT: WB_PROTECTED objects must only use the RB_OBJ_WRITE()
   // macro to update VALUE references, as to trigger write barriers.
   .flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED
 };
 
-static void re2_regexp_free(void *data) {
-  re2_pattern *self = (re2_pattern *)data;
-  if (self->pattern) {
-    delete self->pattern;
+static void re2_regexp_free(void *ptr) {
+  re2_pattern *p = reinterpret_cast<re2_pattern *>(ptr);
+  if (p->pattern) {
+    delete p->pattern;
   }
-  xfree(self);
+  xfree(p);
 }
 
-static size_t re2_regexp_memsize(const void *data) {
-  const re2_pattern *self = (const re2_pattern *)data;
-  size_t size = sizeof(re2_pattern);
-  if (self->pattern) {
-    size += sizeof(self->pattern);
+static size_t re2_regexp_memsize(const void *ptr) {
+  const re2_pattern *p = reinterpret_cast<const re2_pattern *>(ptr);
+  size_t size = sizeof(*p);
+  if (p->pattern) {
+    size += sizeof(p->pattern);
   }
 
   return size;
@@ -1579,19 +1579,19 @@ static VALUE re2_QuoteMeta(VALUE, VALUE unquoted) {
   return rb_str_new(quoted_string.data(), quoted_string.size());
 }
 
-static void re2_set_free(void *data) {
-  re2_set *self = (re2_set *)data;
-  if (self->set) {
-    delete self->set;
+static void re2_set_free(void *ptr) {
+  re2_set *s = reinterpret_cast<re2_set *>(ptr);
+  if (s->set) {
+    delete s->set;
   }
-  xfree(self);
+  xfree(s);
 }
 
-static size_t re2_set_memsize(const void *data) {
-  const re2_set *self = (const re2_set *)data;
-  size_t size = sizeof(re2_set);
-  if (self->set) {
-    size += sizeof(self->set);
+static size_t re2_set_memsize(const void *ptr) {
+  const re2_set *s = reinterpret_cast<const re2_set *>(ptr);
+  size_t size = sizeof(*s);
+  if (s->set) {
+    size += sizeof(s->set);
   }
 
   return size;
@@ -1877,12 +1877,14 @@ extern "C" void Init_re2(void) {
   re2_eSetUnsupportedError = rb_define_class_under(re2_cSet, "UnsupportedError",
       rb_const_get(rb_cObject, rb_intern("StandardError")));
 
-  rb_define_alloc_func(re2_cRegexp, (VALUE (*)(VALUE))re2_regexp_allocate);
+  rb_define_alloc_func(re2_cRegexp,
+      reinterpret_cast<VALUE (*)(VALUE)>(re2_regexp_allocate));
   rb_define_alloc_func(re2_cMatchData,
-      (VALUE (*)(VALUE))re2_matchdata_allocate);
+      reinterpret_cast<VALUE (*)(VALUE)>(re2_matchdata_allocate));
   rb_define_alloc_func(re2_cScanner,
-      (VALUE (*)(VALUE))re2_scanner_allocate);
-  rb_define_alloc_func(re2_cSet, (VALUE (*)(VALUE))re2_set_allocate);
+      reinterpret_cast<VALUE (*)(VALUE)>(re2_scanner_allocate));
+  rb_define_alloc_func(re2_cSet,
+      reinterpret_cast<VALUE (*)(VALUE)>(re2_set_allocate));
 
   rb_define_method(re2_cMatchData, "string",
       RUBY_METHOD_FUNC(re2_matchdata_string), 0);

data/lib/re2/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RE2
-  VERSION = "2.4.0"
+  VERSION = "2.4.1"
 end

data/spec/re2/match_data_spec.rb

@@ -1,5 +1,14 @@
 # encoding: utf-8
+require 'objspace'
+
 RSpec.describe RE2::MatchData do
+  it "reports a larger consuming memory size when it has more matches" do
+    matches1 = RE2::Regexp.new('w(o)').match('woo')
+    matches2 = RE2::Regexp.new('w(o)(o)').match('woo')
+
+    expect(ObjectSpace.memsize_of(matches1)).to be < ObjectSpace.memsize_of(matches2)
+  end
+
   describe "#to_a" do
     it "is populated with the match and capturing groups" do
       a = RE2::Regexp.new('w(o)(o)').match('woo').to_a

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: re2
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: x86_64-darwin
 authors:
 - Paul Mucur
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-11-11 00:00:00.000000000 Z
+date: 2023-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake-compiler