rdkit_chem 2025.09.3.2 → 2025.09.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb84e9eb9b23425a697da1935d2a58fde15b5b184f9b0f0605340577f9296f16
-  data.tar.gz: 3ba3ea75e71cf6f86d82008d297a6409494a09e152b7049077245eb641626eaf
+  metadata.gz: 72f1c22f156a06620110c1359f9539c406aa65e0192798ea9b5494883d807fdf
+  data.tar.gz: 4d0afc7baa75eb3af77519c140550336fe07d70e0981a32219aa9a0fa21bc98f
 SHA512:
-  metadata.gz: f2001ea207f0a2e4484595d27ce3fe5f74d2e0acbf3b58caf204169a09b928542fccabf544a424653175af1e272b73378eaac81db962b26b8ff1ece82219bd43
-  data.tar.gz: 5c859291de10e2a2355068b3d57619d7e56e3c248c607b3df413d46f4e9fd29437bfc5cc1914fbb70e2daa319da2889b790b2a205c6087a2ebdaf1faffcb6cdd
+  metadata.gz: 8d5b69b87e14806643044e1a414a326630517579bb7761e2d3740284dd6662620d6d598b4c7d4d5b2f7a6dc9a185069a347e8e4c38773f65ea651fa5d96f30cb
+  data.tar.gz: 959e83ad9e231ea1491b229a56919bccf3a7fec0cafc98a9651e3ecd8c7b5e78da0aaac171fef8fa299f17b52be2a8ea40fa2452b63a052a52445f835ba93f3e

data/Code/RubyWrappers/MolOps.i

@@ -45,9 +45,10 @@
 %newobject RDKit::MolOps::adjustQueryProperties;
 
 %ignore RDKit::MolOps::detectChemistryProblems;
-// Ignore all native sanitizeMol overloads - we provide a custom wrapper below
-%ignore RDKit::MolOps::sanitizeMol;
 %include <GraphMol/MolOps.h>
+// Ignore only the 3-arg overload that uses reference parameters (incompatible with SWIG)
+// This keeps the 1-arg sanitizeMol(RWMol &) available from the header
+%ignore RDKit::MolOps::sanitizeMol(RWMol &,unsigned int &,unsigned int &);
 %template(BoolPair) std::pair<bool, bool>;
 
 %inline %{

data/Code/RubyWrappers/ROMol.i

@@ -189,9 +189,12 @@ unsigned int getDefaultPickleProperties();
     return res;
   }
 
-  /* Used in the addConformer modifications described above */
-  unsigned int RDKit::ROMol::addConf(RDKit::Conformer * ownedConf, bool assignId=false) {
-    return self->addConformer(ownedConf, assignId);
+  /* Create a copy of the conformer before adding it to the molecule.
+     This avoids the double-free issue since Ruby owns the original and C++ owns the copy.
+     The original DISOWN approach doesn't work with shared_ptr wrappers. */
+  unsigned int RDKit::ROMol::addConf(RDKit::Conformer *conf, bool assignId=false) {
+    RDKit::Conformer *confCopy = new RDKit::Conformer(*conf);
+    return self->addConformer(confCopy, assignId);
   }
 
   std::string MolToSmiles(bool doIsomericSmiles=true, bool doKekule=false, int rootedAtAtom=-1, bool canonical=true,

data/lib/rdkit_chem/version.rb

@@ -1,4 +1,4 @@
 module RDKitChem
-  VERSION = '2025.09.3'.freeze
-  GEMVERSION = VERSION + '.2'
+  VERSION = "2025.09.3".freeze
+  GEMVERSION = VERSION + ".3"
 end

data/test/test_rdkit_chem.rb

@@ -44,4 +44,41 @@ class RDKitTest < Test::Unit::TestCase
     assert_not_nil(rw_mol)
     assert_equal(28, rw_mol.get_num_atoms)  # C27H46O has 28 heavy atoms (27 C + 1 O)
   end
+
+  def test_conformer_ownership
+    # Test that conformer ownership is properly transferred to the molecule.
+    # This verifies the DISOWN directive works - without it, Ruby GC and C++
+    # destructor both try to free the Conformer, causing a double-free segfault.
+    smiles = 'CCO'  # ethanol
+    rw_mol = RDKitChem::RWMol.mol_from_smiles(smiles)
+
+    # Create a conformer with 3D coordinates
+    conf = RDKitChem::Conformer.new(rw_mol.get_num_atoms)
+    conf.set_atom_pos(0, RDKitChem::Point3D.new(0.0, 0.0, 0.0))
+    conf.set_atom_pos(1, RDKitChem::Point3D.new(1.5, 0.0, 0.0))
+    conf.set_atom_pos(2, RDKitChem::Point3D.new(2.0, 1.0, 0.0))
+
+    # Add conformer to molecule (ownership transfers to C++)
+    conf_id = rw_mol.addConf(conf, true)
+    assert(conf_id >= 0, "Conformer should be added successfully")
+
+    # Verify conformer was added
+    assert_equal(1, rw_mol.get_num_conformers)
+
+    # Access the conformer through the molecule
+    retrieved_conf = rw_mol.get_conformer(conf_id)
+    assert_not_nil(retrieved_conf)
+
+    # Verify coordinates
+    pos = retrieved_conf.get_atom_pos(0)
+    assert_in_delta(0.0, pos.x, 0.001)
+    assert_in_delta(0.0, pos.y, 0.001)
+    assert_in_delta(0.0, pos.z, 0.001)
+
+    # Force garbage collection to ensure no double-free occurs
+    GC.start
+
+    # The molecule should still be valid after GC
+    assert_equal(3, rw_mol.get_num_atoms)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rdkit_chem
 version: !ruby/object:Gem::Version
-  version: 2025.09.3.2
+  version: 2025.09.3.3
 platform: ruby
 authors:
 - An Nguyen