rdkafka 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67acc1069396798fdb93129b30145d277af826c3
-  data.tar.gz: 664621fc32610b18703d393c34e72d64d7f34527
+  metadata.gz: 01adede5b7a59df41ef9b5fb023300acd4040fbe
+  data.tar.gz: c38a35bb30662ded72241c358723e31468a6aa07
 SHA512:
-  metadata.gz: 471c14981fe5ba4c4b2a14d724236d498d483cb02b4f93c75217be5455e0c14c2bef319b5186ffd2b74504dfe5175c9727776d28493d4f9b0da2a335572b90b6
-  data.tar.gz: ee82ae7f498c4fbcb553df0368f9a3bcb9df1045b7b413e1cab6aff70a5f93fb57e309f5abb096cc8886b9393cda88dc444f6eed9ed828714bd6bb12933a0e5f
+  metadata.gz: 1bb19505024ea43457df9d902d0accb09fb9f2c5efa9dfc16c2d831024b5cc3b0390177cd605ce5816c11332d4b77a78b697099cd91715acfc37c220e1f3d396
+  data.tar.gz: cba5c1abc24f563f6958dffdb0402e00c58790ffb36ca4dffe2d8f8b7d19883afe59a05f3f37920ec47d4c05d68c5a695fd5602826f45d12c738702e184987b3

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.3.3
+* Fix bug that prevent display of `RdkafkaError` message
+
 # 0.3.2
 * `add_topic` now supports using a partition count
 * Add way to make errors clearer with an extra message

data/lib/rdkafka/error.rb

@@ -3,13 +3,13 @@ module Rdkafka
   class RdkafkaError < RuntimeError
     # The underlying raw error response
     # @return [Integer]
-    attr_reader :rdkafka_response, :message
+    attr_reader :rdkafka_response, :message_prefix
 
     # @private
-    def initialize(response, message=nil)
+    def initialize(response, message_prefix=nil)
       raise TypeError.new("Response has to be an integer") unless response.is_a? Integer
       @rdkafka_response = response
-      @message = message
+      @message_prefix = message_prefix
     end
 
     # This error's code, for example `:partition_eof`, `:msg_size_too_large`.
@@ -26,12 +26,12 @@ module Rdkafka
     # Human readable representation of this error.
     # @return [String]
     def to_s
-      message_part = if message
-                       "#{message} - "
+      message_prefix_part = if message_prefix
+                       "#{message_prefix} - "
                      else
                        ''
                      end
-      "#{message_part}#{Rdkafka::Bindings.rd_kafka_err2str(@rdkafka_response)} (#{code})"
+      "#{message_prefix_part}#{Rdkafka::Bindings.rd_kafka_err2str(@rdkafka_response)} (#{code})"
     end
 
     # Whether this error indicates the partition is EOF.

data/lib/rdkafka/version.rb

@@ -1,4 +1,4 @@
 module Rdkafka
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
   LIBRDKAFKA_VERSION = "0.11.1"
 end

data/spec/rdkafka/error_spec.rb

@@ -7,8 +7,8 @@ describe Rdkafka::RdkafkaError do
     }.to raise_error TypeError
   end
 
-  it "should create an error with a message" do
-    expect(Rdkafka::RdkafkaError.new(10, "message").message).to eq "message"
+  it "should create an error with a message prefix" do
+    expect(Rdkafka::RdkafkaError.new(10, "message prefix").message_prefix).to eq "message prefix"
   end
 
   describe "#code" do
@@ -34,11 +34,25 @@ describe Rdkafka::RdkafkaError do
       expect(Rdkafka::RdkafkaError.new(10).to_s).to eq "Broker: Message size too large (msg_size_too_large)"
     end
 
-    it "should show the message if present" do
+    it "should add the message prefix if present" do
       expect(Rdkafka::RdkafkaError.new(10, "Error explanation").to_s).to eq "Error explanation - Broker: Message size too large (msg_size_too_large)"
     end
   end
 
+  describe "#message" do
+    it "should handle an invalid response" do
+      expect(Rdkafka::RdkafkaError.new(933975).message).to eq "Err-933975? (err_933975?)"
+    end
+
+    it "should return error messages from rdkafka" do
+      expect(Rdkafka::RdkafkaError.new(10).message).to eq "Broker: Message size too large (msg_size_too_large)"
+    end
+
+    it "should add the message prefix if present" do
+      expect(Rdkafka::RdkafkaError.new(10, "Error explanation").message).to eq "Error explanation - Broker: Message size too large (msg_size_too_large)"
+    end
+  end
+
   describe "#is_partition_eof?" do
     it "should be false when not partition eof" do
       expect(Rdkafka::RdkafkaError.new(933975).is_partition_eof?).to be false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rdkafka
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Thijs Cadier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-25 00:00:00.000000000 Z
+date: 2017-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi